Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 567 bytes |
| addr_list.c | -rw-r--r-- | 8.5 KB |
| afs.h | -rw-r--r-- | 6.8 KB |
| afs_cm.h | -rw-r--r-- | 1006 bytes |
| afs_fs.h | -rw-r--r-- | 2.7 KB |
| afs_vl.h | -rw-r--r-- | 5.1 KB |
| callback.c | -rw-r--r-- | 5.9 KB |
| cell.c | -rw-r--r-- | 23.4 KB |
| cmservice.c | -rw-r--r-- | 15.7 KB |
| dir.c | -rw-r--r-- | 52.8 KB |
| dir_edit.c | -rw-r--r-- | 12.9 KB |
| dir_silly.c | -rw-r--r-- | 7.4 KB |
| dynroot.c | -rw-r--r-- | 8.7 KB |
| file.c | -rw-r--r-- | 14.4 KB |
| flock.c | -rw-r--r-- | 23.5 KB |
| fs_operation.c | -rw-r--r-- | 5.8 KB |
| fs_probe.c | -rw-r--r-- | 11.9 KB |
| fsclient.c | -rw-r--r-- | 47.8 KB |
| inode.c | -rw-r--r-- | 24.8 KB |
| internal.h | -rw-r--r-- | 59.4 KB |
| main.c | -rw-r--r-- | 6.0 KB |
| misc.c | -rw-r--r-- | 4.7 KB |
| mntpt.c | -rw-r--r-- | 5.1 KB |
| proc.c | -rw-r--r-- | 16.3 KB |
| protocol_afs.h | -rw-r--r-- | 654 bytes |
| protocol_uae.h | -rw-r--r-- | 6.8 KB |
| protocol_yfs.h | -rw-r--r-- | 4.9 KB |
| rotate.c | -rw-r--r-- | 13.2 KB |
| rxrpc.c | -rw-r--r-- | 22.9 KB |
| security.c | -rw-r--r-- | 11.6 KB |
| server.c | -rw-r--r-- | 18.0 KB |
| server_list.c | -rw-r--r-- | 2.9 KB |
| super.c | -rw-r--r-- | 17.8 KB |
| vl_alias.c | -rw-r--r-- | 9.2 KB |
| vl_list.c | -rw-r--r-- | 8.1 KB |
| vl_probe.c | -rw-r--r-- | 7.4 KB |
| vl_rotate.c | -rw-r--r-- | 8.5 KB |
| vlclient.c | -rw-r--r-- | 18.4 KB |
| volume.c | -rw-r--r-- | 10.5 KB |
| write.c | -rw-r--r-- | 25.3 KB |
| xattr.c | -rw-r--r-- | 8.4 KB |
| xdr_fs.h | -rw-r--r-- | 2.7 KB |
| yfsclient.c | -rw-r--r-- | 47.4 KB |
Computing file changes ...
