Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.2 KB |
| Makefile | -rw-r--r-- | 213 bytes |
| autofs_i.h | -rw-r--r-- | 7.5 KB |
| dev-ioctl.c | -rw-r--r-- | 17.5 KB |
| expire.c | -rw-r--r-- | 14.4 KB |
| init.c | -rw-r--r-- | 940 bytes |
| inode.c | -rw-r--r-- | 8.7 KB |
| root.c | -rw-r--r-- | 23.8 KB |
| symlink.c | -rw-r--r-- | 629 bytes |
| waitq.c | -rw-r--r-- | 12.5 KB |
Computing file changes ...
