Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 1.9 KB |
| Makefile | -rw-r--r-- | 335 bytes |
| bio.c | -rw-r--r-- | 5.6 KB |
| crypto.c | -rw-r--r-- | 12.7 KB |
| fname.c | -rw-r--r-- | 19.8 KB |
| fscrypt_private.h | -rw-r--r-- | 18.7 KB |
| hkdf.c | -rw-r--r-- | 5.4 KB |
| hooks.c | -rw-r--r-- | 13.2 KB |
| inline_crypt.c | -rw-r--r-- | 15.8 KB |
| keyring.c | -rw-r--r-- | 34.3 KB |
| keysetup.c | -rw-r--r-- | 23.2 KB |
| keysetup_v1.c | -rw-r--r-- | 9.3 KB |
| policy.c | -rw-r--r-- | 25.4 KB |
Computing file changes ...
