Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| .kunitconfig | -rw-r--r-- | 90 bytes |
| Kconfig | -rw-r--r-- | 5.0 KB |
| Makefile | -rw-r--r-- | 338 bytes |
| cache.c | -rw-r--r-- | 9.4 KB |
| dir.c | -rw-r--r-- | 35.0 KB |
| fat.h | -rw-r--r-- | 15.7 KB |
| fat_test.c | -rw-r--r-- | 4.8 KB |
| fatent.c | -rw-r--r-- | 20.6 KB |
| file.c | -rw-r--r-- | 14.5 KB |
| inode.c | -rw-r--r-- | 51.0 KB |
| misc.c | -rw-r--r-- | 10.0 KB |
| namei_msdos.c | -rw-r--r-- | 16.9 KB |
| namei_vfat.c | -rw-r--r-- | 25.3 KB |
| nfs.c | -rw-r--r-- | 7.4 KB |
Computing file changes ...
