Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 551 bytes |
| Makefile | -rw-r--r-- | 365 bytes |
| attributes.c | -rw-r--r-- | 8.7 KB |
| bfind.c | -rw-r--r-- | 6.1 KB |
| bitmap.c | -rw-r--r-- | 5.0 KB |
| bnode.c | -rw-r--r-- | 15.3 KB |
| brec.c | -rw-r--r-- | 13.6 KB |
| btree.c | -rw-r--r-- | 12.2 KB |
| catalog.c | -rw-r--r-- | 14.1 KB |
| dir.c | -rw-r--r-- | 14.1 KB |
| extents.c | -rw-r--r-- | 15.5 KB |
| hfsplus_fs.h | -rw-r--r-- | 16.9 KB |
| hfsplus_raw.h | -rw-r--r-- | 9.6 KB |
| inode.c | -rw-r--r-- | 18.8 KB |
| ioctl.c | -rw-r--r-- | 1.8 KB |
| options.c | -rw-r--r-- | 5.3 KB |
| part_tbl.c | -rw-r--r-- | 4.2 KB |
| super.c | -rw-r--r-- | 17.8 KB |
| tables.c | -rw-r--r-- | 119.1 KB |
| unicode.c | -rw-r--r-- | 10.5 KB |
| wrapper.c | -rw-r--r-- | 6.9 KB |
| xattr.c | -rw-r--r-- | 23.3 KB |
| xattr.h | -rw-r--r-- | 1.2 KB |
| xattr_security.c | -rw-r--r-- | 2.0 KB |
| xattr_trusted.c | -rw-r--r-- | 1.0 KB |
| xattr_user.c | -rw-r--r-- | 1003 bytes |
Computing file changes ...
