Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 27.2 KB |
| Makefile | -rw-r--r-- | 2.4 KB |
| mac-celtic.c | -rw-r--r-- | 30.5 KB |
| mac-centeuro.c | -rw-r--r-- | 26.4 KB |
| mac-croatian.c | -rw-r--r-- | 30.5 KB |
| mac-cyrillic.c | -rw-r--r-- | 24.3 KB |
| mac-gaelic.c | -rw-r--r-- | 28.4 KB |
| mac-greek.c | -rw-r--r-- | 24.3 KB |
| mac-iceland.c | -rw-r--r-- | 30.5 KB |
| mac-inuit.c | -rw-r--r-- | 26.4 KB |
| mac-roman.c | -rw-r--r-- | 32.6 KB |
| mac-romanian.c | -rw-r--r-- | 30.5 KB |
| mac-turkish.c | -rw-r--r-- | 30.5 KB |
| nls_ascii.c | -rw-r--r-- | 5.7 KB |
| nls_base.c | -rw-r--r-- | 15.6 KB |
| nls_cp1250.c | -rw-r--r-- | 15.0 KB |
| nls_cp1251.c | -rw-r--r-- | 12.4 KB |
| nls_cp1255.c | -rw-r--r-- | 17.0 KB |
| nls_cp437.c | -rw-r--r-- | 17.1 KB |
| nls_cp737.c | -rw-r--r-- | 15.1 KB |
| nls_cp775.c | -rw-r--r-- | 13.2 KB |
| nls_cp850.c | -rw-r--r-- | 13.1 KB |
| nls_cp852.c | -rw-r--r-- | 14.5 KB |
| nls_cp855.c | -rw-r--r-- | 12.1 KB |
| nls_cp857.c | -rw-r--r-- | 12.4 KB |
| nls_cp860.c | -rw-r--r-- | 15.8 KB |
| nls_cp861.c | -rw-r--r-- | 17.1 KB |
| nls_cp862.c | -rw-r--r-- | 19.0 KB |
| nls_cp863.c | -rw-r--r-- | 16.8 KB |
| nls_cp864.c | -rw-r--r-- | 18.6 KB |
| nls_cp865.c | -rw-r--r-- | 17.1 KB |
| nls_cp866.c | -rw-r--r-- | 12.3 KB |
| nls_cp869.c | -rw-r--r-- | 13.1 KB |
| nls_cp874.c | -rw-r--r-- | 10.7 KB |
| nls_cp932.c | -rw-r--r-- | 479.7 KB |
| nls_cp936.c | -rw-r--r-- | 681.9 KB |
| nls_cp949.c | -rw-r--r-- | 854.7 KB |
| nls_cp950.c | -rw-r--r-- | 579.9 KB |
| nls_euc-jp.c | -rw-r--r-- | 23.8 KB |
| nls_iso8859-1.c | -rw-r--r-- | 10.0 KB |
| nls_iso8859-13.c | -rw-r--r-- | 11.5 KB |
| nls_iso8859-14.c | -rw-r--r-- | 14.5 KB |
| nls_iso8859-15.c | -rw-r--r-- | 12.6 KB |
| nls_iso8859-2.c | -rw-r--r-- | 12.8 KB |
| nls_iso8859-3.c | -rw-r--r-- | 12.8 KB |
| nls_iso8859-4.c | -rw-r--r-- | 12.8 KB |
| nls_iso8859-5.c | -rw-r--r-- | 10.6 KB |
| nls_iso8859-6.c | -rw-r--r-- | 10.2 KB |
| nls_iso8859-7.c | -rw-r--r-- | 13.2 KB |
| nls_iso8859-9.c | -rw-r--r-- | 10.8 KB |
| nls_koi8-r.c | -rw-r--r-- | 13.5 KB |
| nls_koi8-ru.c | -rw-r--r-- | 1.6 KB |
| nls_koi8-u.c | -rw-r--r-- | 13.9 KB |
| nls_utf8.c | -rw-r--r-- | 1.2 KB |
Computing file changes ...
