Revision ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 authored by Jakub Kicinski on 29 June 2022, 18:19:10 UTC, committed by Jakub Kicinski on 30 June 2022, 18:34:10 UTC
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 9c5de24
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 4.1 KB |
| Makefile | -rw-r--r-- | 913 bytes |
| array.c | -rw-r--r-- | 22.1 KB |
| base.c | -rw-r--r-- | 92.4 KB |
| bootconfig.c | -rw-r--r-- | 2.0 KB |
| cmdline.c | -rw-r--r-- | 415 bytes |
| consoles.c | -rw-r--r-- | 1.9 KB |
| cpuinfo.c | -rw-r--r-- | 670 bytes |
| devices.c | -rw-r--r-- | 1.2 KB |
| fd.c | -rw-r--r-- | 8.1 KB |
| fd.h | -rw-r--r-- | 583 bytes |
| generic.c | -rw-r--r-- | 19.0 KB |
| inode.c | -rw-r--r-- | 17.0 KB |
| internal.h | -rw-r--r-- | 9.0 KB |
| interrupts.c | -rw-r--r-- | 841 bytes |
| kcore.c | -rw-r--r-- | 16.4 KB |
| kmsg.c | -rw-r--r-- | 1.5 KB |
| loadavg.c | -rw-r--r-- | 879 bytes |
| meminfo.c | -rw-r--r-- | 5.4 KB |
| namespaces.c | -rw-r--r-- | 4.2 KB |
| nommu.c | -rw-r--r-- | 2.6 KB |
| page.c | -rw-r--r-- | 8.0 KB |
| proc_net.c | -rw-r--r-- | 10.1 KB |
| proc_sysctl.c | -rw-r--r-- | 47.9 KB |
| proc_tty.c | -rw-r--r-- | 4.5 KB |
| root.c | -rw-r--r-- | 8.7 KB |
| self.c | -rw-r--r-- | 1.7 KB |
| softirqs.c | -rw-r--r-- | 741 bytes |
| stat.c | -rw-r--r-- | 6.2 KB |
| task_mmu.c | -rw-r--r-- | 48.2 KB |
| task_nommu.c | -rw-r--r-- | 6.6 KB |
| thread_self.c | -rw-r--r-- | 1.9 KB |
| uptime.c | -rw-r--r-- | 1.0 KB |
| util.c | -rw-r--r-- | 383 bytes |
| version.c | -rw-r--r-- | 515 bytes |
| vmcore.c | -rw-r--r-- | 41.0 KB |
Computing file changes ...
