6d1bfe4 | Benjamin Wang | 16 February 2023, 01:39:00 UTC | bump version to 3.4.24 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 16 February 2023, 01:39:00 UTC |
9c81b86 | Benjamin Wang | 10 February 2023, 12:18:53 UTC | test: enhance the test case TestV3WatchProgressOnMemberRestart Signed-off-by: Benjamin Wang <wachao@vmware.com> | 10 February 2023, 13:03:53 UTC |
ed529ab | Benjamin Wang | 10 February 2023, 01:59:31 UTC | clientv3: correct the nextRev on receving progress notification response Signed-off-by: Benjamin Wang <wachao@vmware.com> | 10 February 2023, 08:47:56 UTC |
d32dceb | James Blair | 09 February 2023, 10:34:58 UTC | Fix regression in timestamp resolution Historic capnslog timestamps are in microsecond resolution. We need to match that when we migrate to the zap logger. Signed-off-by: James Blair <mail@jamesblair.net> | 09 February 2023, 20:35:24 UTC |
fb7a897 | Marek Siarkowicz | 09 February 2023, 08:10:19 UTC | Merge pull request #15265 from ahrtr/3.4_walSync_failpoint_20230209 [3.4] etctserver: add failpoints walBeforeSync and walAfterSync | 09 February 2023, 08:10:19 UTC |
109873d | Benjamin Wang | 08 February 2023, 23:06:46 UTC | etctserver: add failpoints walBeforeSync and walAfterSync Signed-off-by: Benjamin Wang <wachao@vmware.com> | 08 February 2023, 23:06:46 UTC |
b4e3ed7 | Benjamin Wang | 30 January 2023, 22:37:27 UTC | bump bbolt to v1.3.7 for release-3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 01 February 2023, 19:47:21 UTC |
2f81586 | Wilson Wang | 24 May 2021, 22:15:23 UTC | server: set multiple concurrentReadTx instances share one txReadBuffer. (cherry picked from commit 9c82e8c72b96eec1e7667a0e139a07b944c33b75) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 30 January 2023, 03:43:19 UTC |
c5347cb | kidsan | 20 January 2023, 15:12:06 UTC | netutil: consistently format ipv6 addresses This formats ipv6 addresses to ensure they can be compared safely Signed-off-by: kidsan <8798449+Kidsan@users.noreply.github.com> | 26 January 2023, 22:49:26 UTC |
d2fc8db | Iavael | 20 January 2023, 20:55:44 UTC | docker: remove nsswitch.conf Signed-off-by: Iavael <905853+iavael@users.noreply.github.com> | 24 January 2023, 18:45:52 UTC |
e4b1542 | Benjamin Wang | 19 January 2023, 22:23:32 UTC | Merge pull request #15137 from fuweid/backport-11990-to-3.4 [3.4] mvcc: push down RangeOptions.limit argv into index tree to reduce memory overhead | 19 January 2023, 22:23:32 UTC |
931cf9a | Wei Fu | 18 January 2023, 02:12:50 UTC | mvcc: update ut for Revisions/CountRevisions It is kind of backport from etcd-io#14124. Signed-off-by: Wei Fu <fuweid89@gmail.com> | 18 January 2023, 02:18:57 UTC |
1246c52 | Marek Siarkowicz | 31 May 2021, 15:25:57 UTC | etcdserver: Fix invalid count returned on Range with Limit (cherry picked from commit 182aef6e6b28d2f62cd7281f38c12899d8006a15) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 18 January 2023, 02:02:10 UTC |
d48f7ad | tangcong | 08 June 2020, 06:09:33 UTC | mvcc: push down RangeOptions.limit argv into index tree (cherry picked from commit 26c930f27d46776da5fedae69267ba0b69c31185) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 18 January 2023, 02:01:20 UTC |
a1d1af5 | Benjamin Wang | 18 January 2023, 00:48:29 UTC | Merge pull request #15099 from fuweid/backport-11771-11743-pr-to-3.4 [3.4] mvcc: reduce count-only range overhead | 18 January 2023, 00:48:29 UTC |
4be8c0e | Piotr Tabor | 17 January 2023, 08:15:02 UTC | Merge pull request #15097 from ahrtr/3.4_promote_non_exist_id_20230113 [3.4] etcdserver: return membership.ErrIDNotFound when the memberID not found | 17 January 2023, 08:15:02 UTC |
00b3151 | Benjamin Wang | 13 January 2023, 07:17:19 UTC | etcdserver: return membership.ErrIDNotFound when the memberID not found Backport https://github.com/etcd-io/etcd/pull/15095 to 3.4. When promoting a learner, we need to wait until the leader's applied ID catches up to the commitId. Afterwards, check whether the learner ID exist or not, and return `membership.ErrIDNotFound` directly in the API if the member ID not found, to avoid the request being unnecessarily delivered to raft. Signed-off-by: Benjamin Wang <wachao@vmware.com> | 16 January 2023, 22:27:31 UTC |
10c080d | Wei Fu | 16 January 2023, 07:12:50 UTC | mvcc: Add ut for Revisions/CountRevisions It is kind of backport from #14124. Signed-off-by: Wei Fu <fuweid89@gmail.com> | 16 January 2023, 07:15:34 UTC |
2070f55 | tangcong | 09 April 2020, 16:09:46 UTC | e2e: add getCountOnlyTest testcase (cherry picked from commit 3594ab94cfefa7488993ac14e7b410ee63b25d3d) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 13 January 2023, 08:33:56 UTC |
00a005c | tangcong | 09 April 2020, 15:50:17 UTC | mvcc: reduce count-only range overhead (cherry picked from commit 730f3f1d783fc1159a4c2e258713e5b1fe3ec5b4) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 13 January 2023, 08:32:35 UTC |
841f3bd | mlmhl | 02 April 2020, 02:57:13 UTC | etcdctl: support query count only of specified prefix (cherry picked from commit aa7b056a7706a55054e94380382cbc1948a3edcc) Signed-off-by: Wei Fu <fuweid89@gmail.com> | 13 January 2023, 08:31:23 UTC |
a577940 | Benjamin Wang | 13 January 2023, 02:39:28 UTC | Merge pull request #15088 from fuweid/3.4-fix-flaky-testcase [3.4] grpc-gateway: update version to v1.11.0 | 13 January 2023, 02:39:28 UTC |
c320f75 | Wei Fu | 12 January 2023, 08:32:39 UTC | grpc-gateway: update version to v1.11.0 The issue is caused by hand-crafted protobuf message. The runtime.errorBody defines two protobuf fields with same number. We need to upgrade the version to fix it. Otherwise, the client side won't receive any errors from server side because of panic. ``` mismatching field: runtime.errorBody.error, want runtime.errorBody.message ``` It can fix the cases PASSES="build grpcproxy" CPU=4 RACE=true ./test -run TestV3CurlLeaseRevokeNoTLS The original error is like: ``` v3_curl_lease_test.go:109: testV3CurlLeaseRevoke: prefix (/v3) endpoint (/kv/lease/revoke): error (read /dev/ptmx: input/output error (expected "etcdserver: requested lease not found", got ["curl: (52) Empty reply from server\r\n"])), wanted etcdserver: requested lease not found v3_curl_lease_test.go:109: testV3CurlLeaseRevoke: prefix (/v3beta) endpoint (/kv/lease/revoke): error (read /dev/ptmx: input/output error (expected "etcdserver: requested lease not found", got ["curl: (52) Empty reply from server\r\n"])), wanted etcdserver: requested lease not found ``` The `Empty reply from server` is caused by panic and server recover it but it doesn't have chance to reply to client. Signed-off-by: Wei Fu <fuweid89@gmail.com> | 12 January 2023, 09:06:00 UTC |
46511ab | Benjamin Wang | 23 December 2022, 23:13:34 UTC | Merge pull request #15042 from ahrtr/update_nsswitch_3.4 [3.4] Update nsswitch.conf for 3.4 | 23 December 2022, 23:13:34 UTC |
58c2f5f | Benjamin Wang | 23 December 2022, 12:31:45 UTC | update nsswitch.conf for 3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 23 December 2022, 12:31:45 UTC |
283e447 | Benjamin Wang | 23 December 2022, 11:27:41 UTC | Merge pull request #15038 from ahrtr/remove_busybox_3.4_20221223 3.4: remove the dependency on busybox | 23 December 2022, 11:27:41 UTC |
8aace73 | Benjamin Wang | 23 December 2022, 10:43:44 UTC | 3.4: remove the dependency on busybox Signed-off-by: Benjamin Wang <wachao@vmware.com> | 23 December 2022, 10:43:44 UTC |
c8b7831 | Benjamin Wang | 21 December 2022, 06:11:16 UTC | bump version to 3.4.23 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 21 December 2022, 06:11:16 UTC |
8119eb3 | Benjamin Wang | 19 December 2022, 11:33:56 UTC | Merge pull request #15019 from ahrtr/deps_3.4_20221219 [3.4] Security: address HIGH Vulnerabilities | 19 December 2022, 11:33:56 UTC |
5413ce4 | Benjamin Wang | 19 December 2022, 09:46:06 UTC | bump go version to 1.17.3 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 10:34:04 UTC |
86479c5 | Benjamin Wang | 19 December 2022, 09:43:43 UTC | deps: bump golang.org/x/net to v0.4.0 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 09:43:43 UTC |
68a5543 | Benjamin Wang | 19 December 2022, 08:34:06 UTC | deps: bump golang.org/x/net to 0.0.0-20220906165146-f3363e06e74c to address CVE CVE-2021-44716 and CVE-2022-27664 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 08:34:06 UTC |
40566d9 | Benjamin Wang | 19 December 2022, 08:32:23 UTC | deps: bump github.com/prometheus/client_golang to 1.11.1 to address CVE CVE-2022-21698 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 08:32:23 UTC |
fcb048d | Benjamin Wang | 19 December 2022, 08:30:53 UTC | deps: bump github.com/gogo/protobuf to 1.3.2 to address CVE CVE-2021-3121 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 08:30:53 UTC |
f318a39 | Benjamin Wang | 19 December 2022, 08:23:30 UTC | Merge pull request #15017 from ahrtr/use_distroless_3.4_20221219 [3.4] Security: use distroless base image to address critical Vulnerabilities | 19 December 2022, 08:23:30 UTC |
c1bec6b | Benjamin Wang | 19 December 2022, 00:04:42 UTC | security: use distroless base image to address critical Vulnerabilities Command: trivy image --severity CRITICAL gcr.io/etcd-development/etcd:v3.4.22 -f json -o 3.4.22_image_critical.json Signed-off-by: Benjamin Wang <wachao@vmware.com> | 19 December 2022, 00:04:47 UTC |
9d37e76 | Benjamin Wang | 17 December 2022, 10:09:47 UTC | Merge pull request #15011 from MukulKolpe/specify_branch_release-3.4 fix: specify the branch name of release-3.4 in the workflow | 17 December 2022, 10:09:47 UTC |
fb07cf8 | Mukul Kolpe | 17 December 2022, 09:03:46 UTC | fix: specify the branch name of release-3.4 in the workflow Signed-off-by: Mukul Kolpe <mukulkolpe45@gmail.com> | 17 December 2022, 09:10:24 UTC |
e03c62d | Benjamin Wang | 16 December 2022, 05:59:40 UTC | Merge pull request #15007 from ArkaSaha30/trivy-release-3-4 Add trivy nightly scan for `release-3.4` | 16 December 2022, 05:59:40 UTC |
7450bcf | ArkaSaha30 | 16 December 2022, 05:36:58 UTC | Add trivy nightly scan for release-3.4 Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com> | 16 December 2022, 05:36:58 UTC |
5937118 | Benjamin Wang | 06 December 2022, 11:25:12 UTC | Merge pull request #14900 from ahrtr/fix_readyonly_txn_panic_3.4_20221206 [3.4] etcdserver: fix nil pointer panic for readonly txn | 06 December 2022, 11:25:12 UTC |
acca4fa | Benjamin Wang | 06 December 2022, 10:09:44 UTC | etcdserver: fix nil pointer panic for readonly txn Backporting https://github.com/etcd-io/etcd/pull/14895 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 06 December 2022, 10:09:47 UTC |
c619e27 | Benjamin Wang | 25 November 2022, 09:01:02 UTC | Merge pull request #14853 from ahrtr/remove_memberid_alarm_3.4_20221125 [3.4] etcdserver: intentionally set the memberID as 0 in corruption alarm | 25 November 2022, 09:01:02 UTC |
2f4f732 | Benjamin Wang | 25 November 2022, 07:58:23 UTC | etcdserver: intentionally set the memberID as 0 in corruption alarm Signed-off-by: Benjamin Wang <wachao@vmware.com> | 25 November 2022, 07:58:23 UTC |
f4bf538 | Benjamin Wang | 17 November 2022, 10:08:11 UTC | Merge pull request #14792 from ahrtr/auth_3.4_20221117 [3.4] clientv3: do not refresh token when users use CommonName based authentication | 17 November 2022, 10:08:11 UTC |
90585e0 | Benjamin Wang | 17 November 2022, 00:47:51 UTC | test: add test case to cover the CommonName based authentication Signed-off-by: Benjamin Wang <wachao@vmware.com> | 17 November 2022, 01:12:13 UTC |
8b4405b | Benjamin Wang | 17 November 2022, 00:34:59 UTC | test: add certificate with root CommonName Signed-off-by: Benjamin Wang <wachao@vmware.com> | 17 November 2022, 00:34:59 UTC |
8ca42a7 | Benjamin Wang | 17 November 2022, 00:32:35 UTC | clientv3: do not refresh token when using TLS CommonName based authentication When users use the TLS CommonName based authentication, the authTokenBundle is always nil. But it's possible for the clients to get `rpctypes.ErrAuthOldRevision` response when the clients concurrently modify auth data (e.g, addUser, deleteUser etc.). In this case, there is no need to refresh the token; instead the clients just need to retry the operations (e.g. Put, Delete etc). Signed-off-by: Benjamin Wang <wachao@vmware.com> | 17 November 2022, 00:32:35 UTC |
1f05498 | Benjamin Wang | 02 November 2022, 00:08:33 UTC | Bump version to 3.4.22 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 02 November 2022, 00:08:33 UTC |
c9cf4db | Benjamin Wang | 01 November 2022, 23:56:50 UTC | Merge pull request #14675 from cenkalti/release-3.4 server: add more context to panic message | 01 November 2022, 23:56:50 UTC |
7a4a3ad | Cenk Alti | 01 November 2022, 22:59:11 UTC | server: add more context to panic message Signed-off-by: Cenk Alti <cenkalti@gmail.com> | 01 November 2022, 22:59:17 UTC |
7c1499d | Benjamin Wang | 29 October 2022, 05:11:36 UTC | Merge pull request #14649 from mitake/test-authrecover-3.4 [3.4] server: add a unit test case for authStore.Reocver() with empty rangePermCache | 29 October 2022, 05:11:36 UTC |
b7a2331 | Hitoshi Mitake | 29 October 2022, 04:55:06 UTC | etcdserver: call refreshRangePermCache on Recover() in AuthStore Signed-off-by: Oleg Guba <oleg@dropbox.com> Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com> | 29 October 2022, 04:55:06 UTC |
0b3ff06 | Hitoshi Mitake | 29 October 2022, 03:31:52 UTC | server: add a unit test case for authStore.Reocver() with empty rangePermCache Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com> | 29 October 2022, 04:27:53 UTC |
ce1630f | Benjamin Wang | 27 October 2022, 06:21:22 UTC | Merge pull request #14601 from dusk125/release-3.4 Backport #14500 to 3.4 | 27 October 2022, 06:21:22 UTC |
9254f8f | Allen Ray | 19 October 2022, 20:02:03 UTC | Release-3.4: server/etcdmain: add configurable cipher list to gRPC proxy listener Signed-off-by: Allen Ray <alray@redhat.com> | 19 October 2022, 20:02:13 UTC |
b058374 | Benjamin Wang | 16 October 2022, 21:25:50 UTC | Merge pull request #14594 from ZoeShaw101/fix-watch-test-issue-3.4 Backport #14591 to 3.4. | 16 October 2022, 21:25:50 UTC |
dcebdf7 | 王霄霄 | 16 October 2022, 11:05:20 UTC | Backport #14591 to 3.4. Signed-off-by: 王霄霄 1141195807@qq.com Signed-off-by: 王霄霄 <1141195807@qq.com> | 16 October 2022, 13:18:53 UTC |
5b764d8 | Benjamin Wang | 12 October 2022, 23:23:02 UTC | Merge pull request #14581 from tomari/tomari/watch-backoff-for-3.4 [3.4] client/v3: Add backoff before retry when watch stream returns unavailable | 12 October 2022, 23:23:02 UTC |
7b7fbbf | Hisanobu Tomari | 07 October 2022, 21:57:30 UTC | client/v3: Add backoff before retry when watch stream returns unavailable The client retries connection without backoff when the server is gone after the watch stream is established. This results in high CPU usage in the client process. This change introduces backoff when the stream is failed and unavailable. Signed-off-by: Hisanobu Tomari <posco.grubb@gmail.com> | 12 October 2022, 20:26:31 UTC |
429fcb9 | Sahdev Zala | 12 October 2022, 15:34:33 UTC | Merge pull request #14579 from ahrtr/wal_log_3.4 [3.4] etcdserver: added more debug log for the purgeFile goroutine | 12 October 2022, 15:34:33 UTC |
1d7639f | Benjamin Wang | 12 October 2022, 11:35:06 UTC | etcdserver: added more debug log for the purgeFile goroutine Signed-off-by: Benjamin Wang <wachao@vmware.com> | 12 October 2022, 11:39:20 UTC |
5b3ac7d | Benjamin Wang | 12 October 2022, 09:58:26 UTC | Merge pull request #14577 from pchan/acp3.4 Cherry pick of #13224 | 12 October 2022, 09:58:26 UTC |
5381daf | Sergey Kacheev | 26 September 2021, 06:50:10 UTC | netutil: make a `raw` URL comparison part of the urlsEqual function Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com> | 12 October 2022, 09:37:46 UTC |
90e7e25 | Sergey Kacheev | 31 July 2021, 17:20:50 UTC | Apply suggestions from code review Co-authored-by: Lili Cosic <cosiclili@gmail.com> Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com> | 12 October 2022, 09:37:46 UTC |
abb019a | Sergey Kacheev | 18 July 2021, 18:31:21 UTC | netutil: add url comparison without resolver to URLStringsEqual If one of the nodes in the cluster has lost a dns record, restarting the second node will break it. This PR makes an attempt to add a comparison without using a resolver, which allows to protect cluster from dns errors and does not break the current logic of comparing urls in the URLStringsEqual function. You can read more in the issue #7798 Fixes #7798 Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com> | 12 October 2022, 09:37:46 UTC |
57a27de | Hitoshi Mitake | 10 October 2022, 13:48:53 UTC | Merge pull request #14562 from kafuu-chino/3.4-backport-14296 *: avoid closing a watch with ID 0 incorrectly | 10 October 2022, 13:48:53 UTC |
ed10ca1 | Kafuu Chino | 02 August 2022, 10:55:41 UTC | *: avoid closing a watch with ID 0 incorrectly Signed-off-by: Kafuu Chino <KafuuChinoQ@gmail.com> add test 1 1 1 | 10 October 2022, 11:54:58 UTC |
de11726 | Benjamin Wang | 04 October 2022, 21:50:43 UTC | Merge pull request #14548 from mitake/3.4-backport-14322 Backport PR 14322 to release-3.4 | 04 October 2022, 21:50:43 UTC |
9136517 | Hitoshi Mitake | 09 September 2022, 15:49:37 UTC | tests: a test case for watch with auth token expiration Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com> | 04 October 2022, 13:55:36 UTC |
0c6e466 | Hitoshi Mitake | 31 July 2022, 14:42:38 UTC | *: handle auth invalid token and old revision errors in watch Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com> | 04 October 2022, 13:49:06 UTC |
d0a732f | Marek Siarkowicz | 28 September 2022, 07:30:10 UTC | Merge pull request #14530 from ahrtr/memberid_alarm etcdserver: fix memberID equals to zero in corruption alarm | 28 September 2022, 07:30:10 UTC |
29911e9 | Benjamin Wang | 28 September 2022, 03:01:26 UTC | etcdserver: fix memberID equals to zero in corruption alarm Signed-off-by: Benjamin Wang <wachao@vmware.com> | 28 September 2022, 03:01:26 UTC |
85b640c | Benjamin Wang | 15 September 2022, 00:46:22 UTC | Bump version to 3.4.21 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 15 September 2022, 00:46:22 UTC |
1a05326 | Marek Siarkowicz | 09 September 2022, 07:57:24 UTC | Merge pull request #14442 from ahrtr/fix_TestV3AuthRestartMember [release-3.4] Fix the flaky test TestV3AuthRestartMember | 09 September 2022, 07:57:24 UTC |
b8bea91 | Benjamin Wang | 09 September 2022, 01:37:25 UTC | fix the flaky test TestV3AuthRestartMember Signed-off-by: Benjamin Wang <wachao@vmware.com> | 09 September 2022, 01:37:25 UTC |
6730ed8 | Benjamin Wang | 09 September 2022, 01:34:32 UTC | Merge pull request #14410 from vivekpatani/release-3.4 [release-3.4] server,test: refresh cache on each NewAuthStore | 09 September 2022, 01:34:32 UTC |
a55a9f5 | Benjamin Wang | 09 September 2022, 01:26:40 UTC | Merge pull request #14441 from tjungblu/bz_1918413_3.4_upstream [release-3.4] etcdctl: fix move-leader for multiple endpoints | 09 September 2022, 01:26:40 UTC |
86bc0a2 | Thomas Jungblut | 08 September 2022, 11:00:20 UTC | etcdctl: fix move-leader for multiple endpoints Due to a duplicate call of clientConfigFromCmd, the move-leader command would fail with "conflicting environment variable is shadowed by corresponding command-line flag". Also in scenarios where no command-line flag was supplied. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com> | 08 September 2022, 13:51:19 UTC |
dd743ee | Benjamin Wang | 08 September 2022, 09:00:20 UTC | Merge pull request #14439 from vsvastey/usr/vsvastey/open-with-max-index-test-fix-3.4 [release-3.4] testing: fix TestOpenWithMaxIndex cleanup | 08 September 2022, 09:00:20 UTC |
1ed5dfc | Vladimir Sokolov | 03 September 2022, 22:41:16 UTC | testing: fix TestOpenWithMaxIndex cleanup A WAL object was closed by defer, however the WAL was rewritten afterwards, so defer closed already closed WAL but not the new one. It caused a data race between writing file and cleaning up a temporary test directory, which led to a non-deterministic bug. Fixes #14332 Signed-off-by: Vladimir Sokolov <vsvastey@gmail.com> | 08 September 2022, 07:49:47 UTC |
b2b7b9d | Benjamin Wang | 05 September 2022, 19:29:45 UTC | Merge pull request #14423 from serathius/one_member_data_loss_raft_3_4 [release-3.4] fix the potential data loss for clusters with only one member | 05 September 2022, 19:29:45 UTC |
119e4dd | Benjamin Wang | 30 August 2022, 02:24:51 UTC | fix the potential data loss for clusters with only one member For a cluster with only one member, the raft always send identical unstable entries and committed entries to etcdserver, and etcd responds to the client once it finishes (actually partially) the applying workflow. When the client receives the response, it doesn't mean etcd has already successfully saved the data, including BoltDB and WAL, because: 1. etcd commits the boltDB transaction periodically instead of on each request; 2. etcd saves WAL entries in parallel with applying the committed entries. Accordingly, it may run into a situation of data loss when the etcd crashes immediately after responding to the client and before the boltDB and WAL successfully save the data to disk. Note that this issue can only happen for clusters with only one member. For clusters with multiple members, it isn't an issue, because etcd will not commit & apply the data before it being replicated to majority members. When the client receives the response, it means the data must have been applied. It further means the data must have been committed. Note: for clusters with multiple members, the raft will never send identical unstable entries and committed entries to etcdserver. Signed-off-by: Benjamin Wang <wachao@vmware.com> | 05 September 2022, 12:15:47 UTC |
9d5ae56 | Benjamin Wang | 05 September 2022, 06:53:08 UTC | Merge pull request #14420 from vsvastey/usr/vsvastey/nil-logger etcdserver: nil-logger issue fix for version 3.4 | 05 September 2022, 06:53:08 UTC |
38342e8 | Vladimir Sokolov | 03 September 2022, 01:24:03 UTC | etcdserver: nil-logger issue fix for version 3.4 In v3.5 it is assumed that the logger should not be nil, however it is still a case in v3.4. The PR targeted to v3.5 was backported to 3.4 and that's why it's possible to get panic on nil logger in 3.4. This commit fixed this issue. Fixes #14402 Signed-off-by: Vladimir Sokolov <vsvastey@gmail.com> | 03 September 2022, 01:34:03 UTC |
c0ef7d5 | vivekpatani | 31 August 2022, 20:07:11 UTC | server,test: refresh cache on each NewAuthStore - permissions were incorrectly loaded on restarts. - #14355 - Backport of https://github.com/etcd-io/etcd/pull/14358 Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com> | 31 August 2022, 20:08:11 UTC |
1e26823 | Benjamin Wang | 05 August 2022, 21:27:01 UTC | Bump version to 3.4.20 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 05 August 2022, 21:27:01 UTC |
ee36615 | Sahdev Zala | 01 August 2022, 12:39:19 UTC | Merge pull request #14290 from ahrtr/3.4_no_prevkv_for_create [3.4] Do not get previous K/V for create event | 01 August 2022, 12:39:19 UTC |
095bbfc | Benjamin Wang | 01 August 2022, 07:11:49 UTC | lock down the version of shadow to v0.1.11 The latest vesion v0.1.12 was just released On Jul 27, 2022, and it is causing issue (see below) on the govet check, ``` govet_shadow' started at Sun Jul 31 23:23:27 PDT 2022 go get: upgraded golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2 => v0.0.0-20220722155237-a158d28d115b go get: upgraded golang.org/x/sys v0.0.0-20211019181941-9d821ace8654 => v0.0.0-20220722155257-8c9f86f7a55f go get: upgraded golang.org/x/tools v0.0.0-20190524140312-2c0ae7006135 => v0.1.12 /root/go/pkg/mod/github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0/client_metrics.go:7:2: missing go.sum entry for module providing package golang.org/x/net/context (imported by go.etcd.io/etcd/etcdserver/etcdserverpb); to add: go get go.etcd.io/etcd/etcdserver/etcdserverpb /root/go/pkg/mod/google.golang.org/grpc@v1.26.0/internal/transport/controlbuf.go:28:2: missing go.sum entry for module providing package golang.org/x/net/http2 (imported by go.etcd.io/etcd/embed); to add: go get go.etcd.io/etcd/embed /root/go/pkg/mod/google.golang.org/grpc@v1.26.0/internal/transport/controlbuf.go:29:2: missing go.sum entry for module providing package golang.org/x/net/http2/hpack (imported by github.com/soheilhy/cmux); to add: go get github.com/soheilhy/cmux@v0.1.4 /root/go/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:36:2: missing go.sum entry for module providing package golang.org/x/net/trace (imported by go.etcd.io/etcd/embed); to add: go get go.etcd.io/etcd/embed ``` It isn't good to always to use the latest version. Instead, we should lock down the version, and v0.1.11 was confirmed to be working. Signed-off-by: Benjamin Wang <wachao@vmware.com> | 01 August 2022, 07:11:49 UTC |
cc1b0e6 | Benjamin Wang | 01 August 2022, 05:11:46 UTC | do not get previous K/V for create event Signed-off-by: Benjamin Wang <wachao@vmware.com> | 01 August 2022, 05:11:46 UTC |
314dcbf | Benjamin Wang | 26 July 2022, 20:59:38 UTC | Merge pull request #14274 from lavacat/release-3.4-fix-TestRoundRobinBalancedResolvableFailoverFromServerFail [3.4] clientv3/balancer: fixed flaky TestRoundRobinBalancedResolvableFailoverFromServerFail | 26 July 2022, 20:59:38 UTC |
6f483a6 | Bogdan Kanivets | 25 July 2022, 16:17:58 UTC | clientv3/balancer: fixed flaky TestRoundRobinBalancedResolvableFailoverFromServerFail - ignore "transport is closing" error during connections warmup after stopping one peer. Signed-off-by: Bogdan Kanivets <bkanivets@apple.com> | 26 July 2022, 15:06:59 UTC |
ce539a9 | Benjamin Wang | 26 July 2022, 15:01:34 UTC | Merge pull request #14279 from SimFG/mvcc-race [3.4] clientv3/mvcc: fixed DATA RACE | 26 July 2022, 15:01:34 UTC |
04e5e55 | SimFG | 26 July 2022, 13:38:23 UTC | [3.4] clientv3/mvcc: fixed DATA RACE between mvcc.(*store).setupMetricsReporter and mvcc.(*store).restore Signed-off-by: SimFG <1142838399@qq.com> | 26 July 2022, 13:38:23 UTC |
2c778ee | Benjamin Wang | 25 July 2022, 08:53:06 UTC | Merge pull request #14269 from ahrtr/3.4_resend_readindex [3.4] etcdserver: resend ReadIndex request on empty apply request | 25 July 2022, 08:53:06 UTC |
f53db9b | Benjamin Wang | 25 July 2022, 01:21:31 UTC | etcdserver: resend ReadIndex request on empty apply request Backport https://github.com/etcd-io/etcd/pull/12795 to 3.4 Signed-off-by: Benjamin Wang <wachao@vmware.com> | 25 July 2022, 01:21:31 UTC |
e2b36f8 | Benjamin Wang | 22 July 2022, 08:56:17 UTC | Merge pull request #14253 from serathius/checkpoints-fix-3.4 [3.4] Checkpoints fix 3.4 | 22 July 2022, 08:56:17 UTC |
de2e8cc | Benjamin Wang | 22 July 2022, 08:46:32 UTC | Merge pull request #14258 from ahrtr/3.4_postphone_read_index [3.4] raft: postpone MsgReadIndex until first commit in the term | 22 July 2022, 08:46:32 UTC |
783e99c | Marek Siarkowicz | 21 July 2022, 16:28:40 UTC | Fix lease checkpointing tests by forcing a snapshot Signed-off-by: Marek Siarkowicz <siarkowicz@google.com> | 22 July 2022, 08:28:44 UTC |
8f4735d | Marek Siarkowicz | 01 December 2021, 14:24:25 UTC | server: Require either cluster version v3.6 or --experimental-enable-lease-checkpoint-persist to persist lease remainingTTL To avoid inconsistant behavior during cluster upgrade we are feature gating persistance behind cluster version. This should ensure that all cluster members are upgraded to v3.6 before changing behavior. To allow backporting this fix to v3.5 we are also introducing flag --experimental-enable-lease-checkpoint-persist that will allow for smooth upgrade in v3.5 clusters with this feature enabled. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com> | 22 July 2022, 08:28:29 UTC |