c28ac9f | Joachim | 27 March 2023, 17:26:36 UTC | Revert "Make the "OOMing pods under VPA" test more robust." | 27 March 2023, 17:26:36 UTC |
27cab2e | Kubernetes Prow Robot | 27 March 2023, 14:28:28 UTC | Merge pull request #5550 from DataDog/lt-overrides-and-instancetyperequirements AWS: only look for InstanceRequirements when needed | 27 March 2023, 14:28:28 UTC |
28a1abf | Kubernetes Prow Robot | 27 March 2023, 13:26:30 UTC | Merge pull request #5558 from ionos-cloud/add-vpa-to-chart chart: Add option to install VPA | 27 March 2023, 13:26:30 UTC |
52f6c67 | Kubernetes Prow Robot | 27 March 2023, 10:49:55 UTC | Merge pull request #5621 from kgolab/master Make the "OOMing pods under VPA" test more robust. | 27 March 2023, 10:49:55 UTC |
2042098 | Karol Golab | 24 March 2023, 13:19:07 UTC | Make the "OOMing pods under VPA" test more robust. | 27 March 2023, 09:52:28 UTC |
39e4d59 | Kubernetes Prow Robot | 27 March 2023, 08:35:57 UTC | Merge pull request #5495 from mwielgus/controller-impl Balancer controller implementation | 27 March 2023, 08:35:57 UTC |
dcf8f82 | Kubernetes Prow Robot | 24 March 2023, 15:14:32 UTC | Merge pull request #5551 from askoriy/memory-volumes-evictable Consider pods with emptydir volume in memory be evictable | 24 March 2023, 15:14:32 UTC |
0f51c06 | Marcin Wielgus | 10 February 2023, 10:57:06 UTC | Balancer controller impl | 24 March 2023, 12:46:42 UTC |
d91bee9 | Kubernetes Prow Robot | 24 March 2023, 12:32:33 UTC | Merge pull request #5613 from hezhizhen/chore Fix typo & replace deprecated functions & replace literals with constants | 24 March 2023, 12:32:33 UTC |
f953f5c | Zhizhen He | 24 March 2023, 10:07:52 UTC | Fix typo & replace deprecated functions & replace literals with constants | 24 March 2023, 10:07:52 UTC |
b8ba233 | Kubernetes Prow Robot | 24 March 2023, 09:56:31 UTC | Merge pull request #5507 from vadasambar/feature/5387/allow-scale-down-with-custom-controller-pods-2 feat: check only controller ref to decide if a pod is replicated | 24 March 2023, 09:56:31 UTC |
44771ef | Kubernetes Prow Robot | 23 March 2023, 16:56:33 UTC | Merge pull request #5609 from Shubham82/add-link-mirror_pod Improvement: Added the Link for Mirror pods. | 23 March 2023, 16:56:33 UTC |
1ea7fb0 | shubham82 | 23 March 2023, 04:34:07 UTC | link DaemonSet and Mirror Pods to k8s docs. | 23 March 2023, 04:34:07 UTC |
543fb03 | Kubernetes Prow Robot | 22 March 2023, 13:06:36 UTC | Merge pull request #5610 from jayantjain93/fallback-machine-family GCE: Fallback f1 and g1 machine families to n1 | 22 March 2023, 13:06:36 UTC |
9f8916d | Jayant Jain | 22 March 2023, 12:03:49 UTC | Fallback f1 and g1 machine families to n1 | 22 March 2023, 12:15:04 UTC |
ff6fe58 | vadasambar | 13 January 2023, 05:10:07 UTC | feat: check only controller ref to decide if a pod is replicated Signed-off-by: vadasambar <surajrbanakar@gmail.com> (cherry picked from commit 144a64a4026fbb96d5c6f58991cc7fd601d64bcd) fix: set `replicated` to true if controller ref is set to `true` - forgot to add this in the last commit Signed-off-by: vadasambar <surajrbanakar@gmail.com> (cherry picked from commit f8f458295d2e21fd9248ec8377dd0b6c3d0ff3c3) fix: remove `checkReferences` - not needed anymore Signed-off-by: vadasambar <surajrbanakar@gmail.com> (cherry picked from commit 5df6e31f8beb4a9c0867d4e69578d8fefc87e1e4) test(drain): add test for custom controller pod Signed-off-by: vadasambar <surajrbanakar@gmail.com> feat: add flag to allow scale down on custom controller pods - set to `false` by default - `false` will be set to `true` by default in the future - right now, we want to ensure backwards compatibility and make the feature available if the flag is explicitly set to `true` - TODO: this code might need some unit tests. Look into adding unit tests. Signed-off-by: vadasambar <surajrbanakar@gmail.com> fix: remove `at` symbol in prefix of `vadasambar` - to keep it consistent with previous such mentions in the code Signed-off-by: vadasambar <surajrbanakar@gmail.com> test(utils): run all drain tests twice - once for `allowScaleDownOnCustomControllerOwnedPods=false` - and once for `allowScaleDownOnCustomControllerOwnedPods=true` Signed-off-by: vadasambar <surajrbanakar@gmail.com> docs(utils): add description for `testOpts` struct Signed-off-by: vadasambar <surajrbanakar@gmail.com> docs: update FAQ with info about `allow-scale-down-on-custom-controller-owned-pods` flag Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: rename `allow-scale-down-on-custom-controller-owned-pods` -> `skip-nodes-with-custom-controller-pods` Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: rename `allowScaleDownOnCustomControllerOwnedPods` -> `skipNodesWithCustomControllerPods` Signed-off-by: vadasambar <surajrbanakar@gmail.com> test(utils/drain): fix failing tests - refactor code to add cusom controller pod test Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: fix long code comments - clean-up print statements Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: move `expectFatal` right above where it is used - makes the code easier to read Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: fix code comment wording Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: address PR comments - abstract legacy code to check for replicated pods into a separate function so that it's easier to remove in the future - fix param info in the FAQ.md - simplify tests and remove the global variable used in the tests - rename `--skip-nodes-with-custom-controller-pods` -> `--scale-down-nodes-with-custom-controller-pods` Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: rename flag `--scale-down-nodes-with-custom-controller-pods` -> `--skip-nodes-with-custom-controller-pods` - refactor tests Signed-off-by: vadasambar <surajrbanakar@gmail.com> docs: update flag info Signed-off-by: vadasambar <surajrbanakar@gmail.com> fix: forgot to change flag name on a line in the code Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: use `ControllerRef()` directly instead of `controllerRef` - we don't need an extra variable Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: create tests consolidated test cases - from looping over and tweaking shared test cases - so that we don't have to duplicate shared test cases Signed-off-by: vadasambar <surajrbanakar@gmail.com> refactor: append test flag to shared test description - so that the failed test is easy to identify - shallow copy tests and add comments so that others do the same Signed-off-by: vadasambar <surajrbanakar@gmail.com> | 22 March 2023, 05:21:07 UTC |
b849ddf | shubham82 | 22 March 2023, 03:51:31 UTC | Improvement: Added the Link for Mirror pods. | 22 March 2023, 03:51:31 UTC |
241643d | Kubernetes Prow Robot | 21 March 2023, 15:38:12 UTC | Merge pull request #5597 from kisieland/scale-up-changes-v2 Put ScaleUp logic behind an interface | 21 March 2023, 15:38:12 UTC |
b31b006 | Kubernetes Prow Robot | 21 March 2023, 15:19:08 UTC | Merge pull request #5553 from mboersma/capi-err-checks [cluster-api] Handle ignored errors | 21 March 2023, 15:19:08 UTC |
5b6c50e | Daniel Gutowski | 17 March 2023, 13:24:23 UTC | Apply code reivew remarks: * Rename scaleup.Manager to scaleup.Orchestrator * Remove factory and add Initialize function * Rename the wrpapper package to orchestrator * Rename NewOrchestrator func to just New | 20 March 2023, 17:16:53 UTC |
137bcf1 | Kubernetes Prow Robot | 20 March 2023, 14:31:19 UTC | Merge pull request #5582 from hetznercloud/fix-version fix(ca/hetzner): specify application name & version | 20 March 2023, 14:31:19 UTC |
785444a | Kubernetes Prow Robot | 17 March 2023, 23:31:15 UTC | Merge pull request #5603 from gandhipr/prachigandhi/cloud-based-uri-skuClient baseURI for skuClient based on cloud | 17 March 2023, 23:31:15 UTC |
49dca4d | Prachi Gandhi | 01 March 2023, 03:10:30 UTC | baseURI for skuClient based on cloud | 17 March 2023, 17:36:05 UTC |
57bd2bc | Kubernetes Prow Robot | 16 March 2023, 11:03:17 UTC | Merge pull request #5600 from voelzmo/fix/controller-gen-download-version Fix controller-gen version in automatic download | 16 March 2023, 11:03:17 UTC |
01972d2 | Kubernetes Prow Robot | 16 March 2023, 10:51:15 UTC | Merge pull request #5586 from XavierDuthil/ovhcloud/add-support-for-nodepool-templating ovhcloud: Add support for nodepool templating | 16 March 2023, 10:51:15 UTC |
2c26427 | Kubernetes Prow Robot | 16 March 2023, 10:49:16 UTC | Merge pull request #5583 from XavierDuthil/ovhcloud/fallback-to-canadian-api-on-500 ovhcloud: For any call to api.ovh.com returning a 500 error, retry call on ca.api.ovh.com | 16 March 2023, 10:49:16 UTC |
606ca3b | Kubernetes Prow Robot | 16 March 2023, 10:47:16 UTC | Merge pull request #5584 from XavierDuthil/ovhcloud/fix-multiple-scale-down ovhcloud: Fix deletion of multiple nodes at the same time | 16 March 2023, 10:47:16 UTC |
205eeca | Kubernetes Prow Robot | 16 March 2023, 10:45:17 UTC | Merge pull request #5585 from XavierDuthil/ovhcloud/fix-crash-concurrent-map-access ovhcloud: Fix panic on concurrent map read/write | 16 March 2023, 10:45:17 UTC |
3ac07e7 | Kubernetes Prow Robot | 16 March 2023, 10:31:17 UTC | Merge pull request #5593 from zendesk/grosser/doc docs: fix faq around expendable-pods-priority-cutoff | 16 March 2023, 10:31:17 UTC |
7bb1f0f | Kubernetes Prow Robot | 16 March 2023, 10:27:18 UTC | Merge pull request #5589 from MaciekPytel/patch_release_schedule Introduce a regular patch release schedule for CA | 16 March 2023, 10:27:18 UTC |
9cd44fd | Daniel Gutowski | 15 March 2023, 09:48:32 UTC | ScaleUp wrapper tests refactor * Add field names to struct literals * Slice iteration/population standardized * Add boilerplate and fix comment lint errors | 15 March 2023, 14:10:17 UTC |
7fee123 | Marco Voelz | 15 March 2023, 13:22:42 UTC | Fix controller-gen version in automatic download | 15 March 2023, 13:22:42 UTC |
4805251 | Daniel Gutowski | 15 March 2023, 09:28:52 UTC | ScaleUpManager refactoring * Make the structures public, as well as some helper functions * manager.go to scaleup.go file rename * Minor code simplifications * Minor comment fixes/style consolidations | 15 March 2023, 11:59:19 UTC |
3d796de | Daniel Gutowski | 14 March 2023, 10:01:33 UTC | ScaleUpManager refactors * Introduced ExecuteScaleUp function, which runs chosen expansion options. * Lowered intendation of ScaleUp function, by reverting bestOption check. * Unified error and Autoscaling error variable names to 'err' and 'aErr'. | 14 March 2023, 10:22:09 UTC |
88cdd7a | Daniel Gutowski | 13 March 2023, 15:25:50 UTC | ScaleUp logic refactors * Simplify the ScaleUp* functions parameter list * Introduce the ScaleUpManagerFactory to allow greater expandability * Simplify helper functions in scale up wrapper * Make the SkippedReasons public and move those to a dedicated file | 14 March 2023, 10:22:05 UTC |
675ca31 | Daniel Gutowski | 13 March 2023, 13:38:12 UTC | Add ScaleUpManager interface * Add ScaleUpManager interface, which is copy of existing stand-alone functions * Add a wrapper which contains the current scale up logic code | 14 March 2023, 10:22:00 UTC |
2be8f8e | Daniel Gutowski | 13 March 2023, 12:40:16 UTC | Create core/scaleup package. * Move resource manager to a dedicated package * Move pod equivalence groups to dedicated package | 14 March 2023, 10:21:55 UTC |
1931ea6 | Kubernetes Prow Robot | 14 March 2023, 10:04:17 UTC | Merge pull request #5557 from kisieland/gce-autopilot-client Simplify the GCE client FetchMigInstances function. | 14 March 2023, 10:04:17 UTC |
acdeb92 | Michael Grosser | 14 March 2023, 00:19:17 UTC | docs: fix faq around expendable-pods-priority-cutoff | 14 March 2023, 00:19:17 UTC |
ee08e5b | Daniel Gutowski | 02 March 2023, 13:49:56 UTC | Update the FetchMigInstances GCE call. This will result in call not failing due to the malformed instance url. Change-Id: I46cbaabbb6e2adabe32abe12b46d22429a414aa3 | 13 March 2023, 12:25:28 UTC |
5889a98 | Daniel Gutowski | 02 March 2023, 12:51:26 UTC | Simplify the GCE client FetchMigInstances function. Also export the GetErrorInfo function which maps GCE response to correct error class. Change-Id: I96522d16e3c64093620efb954edb4c9bce9b1ed3 | 13 March 2023, 11:01:38 UTC |
63b334f | Kubernetes Prow Robot | 10 March 2023, 16:32:41 UTC | Merge pull request #5581 from gjtempleton/CA-Document-Snapshotter-Flag CA - Document Debugging Snapshotter flag | 10 March 2023, 16:32:41 UTC |
35f9d55 | Maciek Pytel | 10 March 2023, 15:14:34 UTC | Introduce a regular patch release schedule for CA | 10 March 2023, 15:14:34 UTC |
52f4de5 | Xavier Duthil | 11 January 2023, 17:35:49 UTC | fix(sdk): For any call to api.ovh.com returning a 500 vendor, retry call on ca.api.ovh.com Should cover the cases where a canadian tenant is freshly created and agora sync has not yet been done on EU API. This is a temporary fix until the issue is correctly handled Signed-off-by: Xavier Duthil <xavier.duthil@ovhcloud.com> | 10 March 2023, 14:19:40 UTC |
ecf74e2 | Xavier Duthil | 09 March 2023, 10:51:19 UTC | fix(ovhcloud): Add support for nodepool templating Should fix the autoscaler being unable to scale up an empty nodepool with specific template, because the template was not processed when setting up the upscale simulation (with the following error: "node(s) didn't match Pod's node affinity/selector") Signed-off-by: Xavier Duthil <xavier.duthil@ovhcloud.com> | 10 March 2023, 13:35:01 UTC |
3f7514c | Xavier Duthil | 07 March 2023, 13:19:38 UTC | fix(ovhcloud): Fix panic on concurrent read/write on manager cache Signed-off-by: Xavier Duthil <xavier.duthil@ovhcloud.com> | 10 March 2023, 13:13:55 UTC |
0907390 | Xavier Duthil | 10 March 2023, 13:07:56 UTC | fix(ovhcloud): Add mutex on NodeGroup.DeleteNodes to prevent outdated scale down payloads Signed-off-by: Xavier Duthil <xavier.duthil@ovhcloud.com> | 10 March 2023, 13:10:40 UTC |
c0219b2 | Kubernetes Prow Robot | 10 March 2023, 10:22:40 UTC | Merge pull request #5536 from kushagra98/update-vendor-K8s-1.26 Update vendor k8s 1.26 | 10 March 2023, 10:22:40 UTC |
0ac54e6 | Julian Tölle | 09 March 2023, 15:15:48 UTC | fix(ca/hetzner): specify application name & version This helps Hetzner Cloud find any misbehaving API clients. | 09 March 2023, 15:15:48 UTC |
9c7f989 | Guy Templeton | 09 March 2023, 12:45:30 UTC | CA - Document Debugging Snapshotter flag | 09 March 2023, 12:45:30 UTC |
b1b7f39 | Kubernetes Prow Robot | 09 March 2023, 12:28:02 UTC | Merge pull request #5578 from yaroslava-serdiuk/empty-sorting Add empty nodes sorting for scale down candidates | 09 March 2023, 12:28:02 UTC |
8f62427 | Kubernetes Prow Robot | 09 March 2023, 12:14:01 UTC | Merge pull request #5574 from arrikto/feature-eks-readme docs(README): Update information about EKS PrivateLink | 09 March 2023, 12:14:01 UTC |
29e2554 | Mario Valderrama | 09 March 2023, 11:11:33 UTC | Make updateMode configurable and update docs | 09 March 2023, 11:22:08 UTC |
3feca5c | Mario Valderrama | 02 March 2023, 13:46:42 UTC | chart: Add option to install VPA | 09 March 2023, 11:22:04 UTC |
2a6bfe6 | Kubernetes Prow Robot | 09 March 2023, 10:26:02 UTC | Merge pull request #5575 from voelzmo/enh/cleanup-recommender Cleanup recommender model/container.go | 09 March 2023, 10:26:02 UTC |
a553eb8 | Kubernetes Prow Robot | 08 March 2023, 22:36:09 UTC | Merge pull request #5529 from mmcclean-aws/master Added support for AWS inf2 instance types | 08 March 2023, 22:36:09 UTC |
fdfd4e6 | Matt McClean | 08 March 2023, 19:55:40 UTC | Removed whitespace Co-authored-by: Guy Templeton <guyjtempleton@googlemail.com> | 08 March 2023, 19:55:40 UTC |
205293a | Kubernetes Prow Robot | 08 March 2023, 15:55:11 UTC | Merge pull request #5537 from arrikto/feature-disable-unready-scaledown cluster-autoscaler: Add option to disable scale down of unready nodes | 08 March 2023, 15:55:11 UTC |
cea9d1a | Yaroslava Serdiuk | 08 March 2023, 11:03:45 UTC | Add empty nodes sorting for scale down candidates | 08 March 2023, 15:43:22 UTC |
562b977 | Kubernetes Prow Robot | 08 March 2023, 09:35:12 UTC | Merge pull request #5463 from m99coder/patch-1 Re-sort on root level, add `hostNetwork` parameter | 08 March 2023, 09:35:12 UTC |
4f053f3 | Marco Voelz | 07 March 2023, 13:09:08 UTC | Switch to built-in Duration.truncate method | 07 March 2023, 13:09:08 UTC |
e226af3 | Marco Voelz | 07 March 2023, 13:08:43 UTC | Remove unused OOM Bump constants | 07 March 2023, 13:08:43 UTC |
d20fe43 | Grigoris Thanasoulas | 07 March 2023, 12:48:05 UTC | docs(README): Update information about EKS PrivateLink Since EKS API now supports PrivateLink, update the AWS README with the current state. Signed-off-by: Grigoris Thanasoulas <gregth@arrikto.com> | 07 March 2023, 12:49:30 UTC |
af27896 | Kubernetes Prow Robot | 07 March 2023, 11:38:17 UTC | Merge pull request #5572 from qiutongs/master Cluster Autoscaler: GCE: add pricing info for C3 | 07 March 2023, 11:38:17 UTC |
0064842 | Marco Lehmann | 07 March 2023, 09:11:02 UTC | add `hostNetwork` parameter | 07 March 2023, 09:11:02 UTC |
64e725b | Qiutong Song | 07 March 2023, 06:25:15 UTC | Cluster Autoscaler: GCE: add pricing info for C3 | 07 March 2023, 06:25:15 UTC |
40d8eef | Kubernetes Prow Robot | 07 March 2023, 03:10:17 UTC | Merge pull request #5545 from jbartosik/addon-resizer-kep Create enhancements directory for Addon Resizer | 07 March 2023, 03:10:17 UTC |
eec71a6 | Kubernetes Prow Robot | 07 March 2023, 02:58:17 UTC | Merge pull request #5549 from mboersma/fix-gpu-import cluster-autoscaler: add missing import to kubermark_other.go | 07 March 2023, 02:58:17 UTC |
436c618 | Matt McClean | 06 March 2023, 22:51:39 UTC | rolled back VPA files | 06 March 2023, 22:51:39 UTC |
759d49e | Matt McClean | 06 March 2023, 22:47:46 UTC | Merge remote-tracking branch 'upstream/master' Merged | 06 March 2023, 22:47:46 UTC |
cc3283c | Kubernetes Prow Robot | 06 March 2023, 22:26:18 UTC | Merge pull request #4478 from damienleger/container_security_context [CA] [AWS examples] Add container securityContext | 06 March 2023, 22:26:18 UTC |
553ccf7 | Kubernetes Prow Robot | 06 March 2023, 21:18:17 UTC | Merge pull request #5561 from peaaceChoi/remove-deepcopynode-err Delete unused err returns | 06 March 2023, 21:18:17 UTC |
b8ec430 | Kubernetes Prow Robot | 06 March 2023, 21:16:18 UTC | Merge pull request #5559 from ionos-cloud/update-ionos-cloud-docs Update Ionos Cloud README and deploy example | 06 March 2023, 21:16:18 UTC |
6cf8c32 | Grigoris Thanasoulas | 05 February 2023, 16:33:58 UTC | cluster-autoscaler: Add option to disable scale down of unready nodes Add flag '--scale-down-unready-enabled' to enable or disable scale-down of unready nodes. Default value set to true for backwards compatibility (i.e., allow scale-down of unready nodes). Signed-off-by: Grigoris Thanasoulas <gregth@arrikto.com> | 06 March 2023, 13:51:10 UTC |
4f31778 | Kubernetes Prow Robot | 06 March 2023, 10:22:58 UTC | Merge pull request #5562 from yaroslava-serdiuk/deletions-in-progress Use snapshot of NodeDeletionTracker for ActuationStatus | 06 March 2023, 10:22:58 UTC |
dec8136 | Yaroslava Serdiuk | 03 March 2023, 15:20:31 UTC | Add Snapshot() method to the NodeDeletionTracker | 03 March 2023, 16:31:40 UTC |
82e8804 | peaaceChoi | 03 March 2023, 06:26:38 UTC | Fix continue condition | 03 March 2023, 06:26:38 UTC |
4608362 | peaaceChoi | 03 March 2023, 04:53:50 UTC | Delete unused return param | 03 March 2023, 04:53:50 UTC |
e551e1f | Kubernetes Prow Robot | 02 March 2023, 15:58:55 UTC | Merge pull request #5556 from x13n/fast-sd Limit the rate of adding new uneeded nodes | 02 March 2023, 15:58:55 UTC |
5e59ae7 | Daniel Kłobuszewski | 02 March 2023, 10:04:27 UTC | Limit the rate of adding new uneeded nodes This is an optimization to avoid spending too much time in scale down simulation. The main idea is that it doesn't make sense to add new unneeded nodes at a rate that is higher than the rate at which we can delete them afterwards. | 02 March 2023, 14:57:37 UTC |
5cf8529 | Mario Valderrama | 30 January 2023, 19:43:44 UTC | Update Ionos Cloud README and deploy example | 02 March 2023, 12:58:16 UTC |
e1d9861 | Kubernetes Prow Robot | 01 March 2023, 20:31:20 UTC | Merge pull request #5552 from yaroslava-serdiuk/scalability Fix RemovalSimulation for parallel scale down | 01 March 2023, 20:31:20 UTC |
849bb5f | Yaroslava Serdiuk | 01 March 2023, 17:01:14 UTC | Add limit for removable nodes count | 01 March 2023, 17:30:44 UTC |
a35d6d2 | Yaroslava Serdiuk | 28 February 2023, 16:09:48 UTC | Fix RemovalSimulation for parallel scale down | 01 March 2023, 17:30:30 UTC |
e83711b | Kubernetes Prow Robot | 01 March 2023, 13:31:17 UTC | Merge pull request #5539 from pbetkier/patch-1 Fix multiple recommenders example: deployment name | 01 March 2023, 13:31:17 UTC |
6040d29 | Matt Boersma | 28 February 2023, 20:56:29 UTC | [cluster-api] Handle ignored errors | 28 February 2023, 20:56:29 UTC |
98410d8 | Benjamin Pineau | 28 February 2023, 15:13:41 UTC | AWS: only look for InstanceRequirements when needed In order to support optional InstanceRequirements specifications for ASGs using LaunchTemplates and not directly embedding InstanceRequirements specs, the cluster-autoscaler's AWS cloudprovider was recently improved to look for posssible requirements (specifying eg. CPU and memory capacities) by retrieving LaunchTemplates and their versions when building NodeInfos templates, like so: ``` GetNodeInfoFromTemplate() TemplateNodeInfo() buildNodeFromTemplate() updateCapacityWithRequirementsOverrides() getInstanceRequirementsFromMixedInstancesPolicy() // when ASG doesn't specify an instanceRequirementsOverrides, // we might still find one in its LaunchTemplate, so awsService.getLaunchTemplateData() DescribeLaunchTemplateVersions() ``` Those LT/versions lookups can't be fetched in batch, and aren't cached, so we're hitting AWS API at O(n) proportionally to the number of ASGs having LTs at every loop, which is a change compared to cluster-autoscaler 1.24. On clusters having many LTs attached, that can cause a slowdown or trigger throttling from AWS. But retrieving InstanceRequirements should only be needed when the LT overrides don't specify an InstanceType, as both are mutually exclusive: "If you specify InstanceRequirements, you can't specify InstanceType." (https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LaunchTemplateOverrides.html). That mutual exclusion is already leveraged by `getInstanceTypesForAsgs`: we don't look for InstanceRequirements when we have a mixed instance policy specifying instance types overrides: https://github.com/kubernetes/autoscaler/blob/cluster-autoscaler-1.26.1/cluster-autoscaler/cloudprovider/aws/aws_wrapper.go#L683-L686 This change reduces the overhead for ASGs with LaunchTemplates not using InstanceRequirements. As a follow-up, we should also cache resource retrieved by getInstanceRequirementsFromMixedInstancesPolicy to mitigate the API call pressure when using InstanceRequirements from LT. | 28 February 2023, 18:32:47 UTC |
946189f | Oleksandr Skoryi | 16 February 2023, 11:16:35 UTC | Consider pods with emptydir volume in memory be evictable | 28 February 2023, 18:18:59 UTC |
401e994 | Matt Boersma | 28 February 2023, 17:24:46 UTC | cluster-autoscaler: add missing import to kubermark_other.go | 28 February 2023, 17:24:46 UTC |
edf8779 | Kubernetes Prow Robot | 28 February 2023, 15:25:17 UTC | Merge pull request #5472 from DataDog/scaledown-nodedeletion-metric-fix Fix scaledown:nodedeletion metric calculation | 28 February 2023, 15:25:17 UTC |
f44fb9f | Kubernetes Prow Robot | 28 February 2023, 13:47:17 UTC | Merge pull request #5512 from Shubham82/add_RBAC_permissions_cherryservers Added RBAC Permission to cherryservers. | 28 February 2023, 13:47:17 UTC |
b4504e3 | Joachim Bartosik | 28 February 2023, 10:14:03 UTC | Create enhancements directory for Addon Resizer | 28 February 2023, 10:14:03 UTC |
6526f55 | Piotr Betkier | 28 February 2023, 07:45:05 UTC | Fix multiple recommenders example: deployment name Seems like the example in `/vertical-pod-autoscaler/deploy/recommender-deployment-low.yaml` copied `Deployment` name from `recommender-deployment-high.yaml`. | 28 February 2023, 07:45:05 UTC |
be2da34 | Kushagra | 27 February 2023, 16:31:31 UTC | add script to upgrade vpa vendor | 27 February 2023, 16:31:31 UTC |
5bbf9ec | Kushagra | 27 February 2023, 16:30:27 UTC | fix tests due to vendor upgrade | 27 February 2023, 16:30:27 UTC |
346f553 | Kushagra | 27 February 2023, 16:29:13 UTC | upgrade vpa and vpa-e2e vendor to 1.26 | 27 February 2023, 16:29:13 UTC |
c8d6127 | Kubernetes Prow Robot | 27 February 2023, 10:36:20 UTC | Merge pull request #5521 from qianlei90/fix-delete-panic fix(*): refresh node instance cache when nodegroup not found in deleteCreatedNodesWithErrors | 27 February 2023, 10:36:20 UTC |
e8ba4bf | Kubernetes Prow Robot | 24 February 2023, 13:31:34 UTC | Merge pull request #5497 from BigDarkClown/pdb Track PDBRemainingDisruptions in AutoscalingContext | 24 February 2023, 13:31:34 UTC |
43b459b | Bartłomiej Wróblewski | 09 February 2023, 16:43:12 UTC | Track PDBRemainingDisruptions in AutoscalingContext | 24 February 2023, 12:43:29 UTC |
bdf2dbe | Bartłomiej Wróblewski | 23 February 2023, 13:20:12 UTC | Move PDBRemainingDisruptions to interface and rename it | 24 February 2023, 12:41:56 UTC |