67b897a | sdong | 31 October 2019, 22:06:10 UTC | An odd fix for GCC 7 | 02 November 2019, 19:48:48 UTC |
394b94c | sdong | 31 October 2019, 21:42:34 UTC | Disable warning as error | 31 October 2019, 21:54:22 UTC |
74936bf | sdong | 31 October 2019, 21:17:26 UTC | Add some include<functional> | 31 October 2019, 21:54:22 UTC |
3e09e81 | sdong | 31 October 2019, 21:10:18 UTC | [FB Internal] Point to the latest tool chain. | 31 October 2019, 21:54:22 UTC |
585b9ee | sdong | 17 July 2017, 22:39:37 UTC | [FB Only] use gcc-5 | 18 July 2017, 04:01:59 UTC |
22796e6 | sdong | 12 October 2016, 22:47:53 UTC | fb internal: Should also use GCC 4.8.1 for CentOS 7 | 12 October 2016, 22:49:09 UTC |
edd6100 | Yueh-Hsuan Chiang | 22 December 2014, 18:10:31 UTC | Fixed a possible bug in DoCompactionWork Summary: There are two statuses in DoCompactionWork could be hidden. This path fix this bug. This seems to be a bug since CompactionFilterV2 is introduced: https://github.com/facebook/rocksdb/blame/3.6.fb/db/db_impl.cc#L3294 Test Plan: make Reviewers: nkg-, igor, sdong Reviewed By: igor, sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28989 | 22 December 2014, 18:11:05 UTC |
b11a617 | Lei Jin | 29 October 2014, 22:38:34 UTC | dummy var to suppress compiler warning/error Summary: Revmoed this in D25641, causing compiler complain. put it back Test Plan: make release Reviewers: igor, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27891 | 30 October 2014, 06:45:16 UTC |
f96bb67 | Yueh-Hsuan Chiang | 30 October 2014, 06:43:58 UTC | Merge branch '3.6.fb' of github.com:facebook/rocksdb into fix36-dyopt | 30 October 2014, 06:43:58 UTC |
0b18f64 | Yueh-Hsuan Chiang | 30 October 2014, 05:43:19 UTC | [3.6.fb] dynamic disable_auto_compactions Summary: Pulling diff from https://reviews.facebook.net/D24747 Test Plan: export ROCKSDB_TESTS=Dynamic ./db_test Reviewers: ljin, igor, sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27981 | 30 October 2014, 05:48:44 UTC |
6ef136a | Yueh-Hsuan Chiang | 30 October 2014, 05:25:46 UTC | [3.6.fb] use fallocate(FALLOC_FL_PUNCH_HOLE) to release unused blocks at the end of file Summary: ftruncate does not always free preallocated unused space at the end of file. In some cases, we pin too much disk space than it should This is a fix previously reviewed in on https://reviews.facebook.net/D25641 Test Plan: env_test Reviewers: igor, ljin, sdong Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D27975 | 30 October 2014, 05:29:47 UTC |
ca41f99 | Yueh-Hsuan Chiang | 29 October 2014, 17:43:01 UTC | [3.6.fb] Fix corruption bug in compaction and Mac compilation error Summary: Bring compaction and VersionEdit fix https://reviews.facebook.net/D25581 into 3.6.fb. Test Plan: ./db_test ./version_edit_test Reviewers: igor, ljin, sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27801 | 29 October 2014, 17:52:58 UTC |
f92646c | Igor Canadi | 15 October 2014, 17:57:43 UTC | Move logging outside of mutex | 15 October 2014, 17:57:43 UTC |
1d52589 | Igor Canadi | 07 October 2014, 18:59:30 UTC | Update HISTORY for 3.6 | 07 October 2014, 18:59:30 UTC |
88edfd9 | Tomislav Novak | 23 September 2014, 22:52:28 UTC | SkipListRep::LookaheadIterator Summary: This diff introduces the `lookahead` argument to `SkipListFactory()`. This is an optimization for the tailing use case which includes many seeks. E.g. consider the following operations on a skip list iterator: Seek(x), Next(), Next(), Seek(x+2), Next(), Seek(x+3), Next(), Next(), ... If `lookahead` is positive, `SkipListRep` will return an iterator which also keeps track of the previously visited node. Seek() then first does a linear search starting from that node (up to `lookahead` steps). As in the tailing example above, this may require fewer than ~log(n) comparisons as with regular skip list search. Test Plan: Added a new benchmark (`fillseekseq`) which simulates the usage pattern. It first writes N records (with consecutive keys), then measures how much time it takes to read them by calling `Seek()` and `Next()`. $ time ./db_bench -num 10000000 -benchmarks fillseekseq -prefix_size 1 \ -key_size 8 -write_buffer_size $[1024*1024*1024] -value_size 50 \ -seekseq_next 2 -skip_list_lookahead=0 [...] DB path: [/dev/shm/rocksdbtest/dbbench] fillseekseq : 0.389 micros/op 2569047 ops/sec; real 0m21.806s user 0m12.106s sys 0m9.672s $ time ./db_bench [...] -skip_list_lookahead=2 [...] DB path: [/dev/shm/rocksdbtest/dbbench] fillseekseq : 0.153 micros/op 6540684 ops/sec; real 0m19.469s user 0m10.192s sys 0m9.252s Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb, march, lovro Differential Revision: https://reviews.facebook.net/D23997 | 07 October 2014, 18:48:23 UTC |
6a44330 | Igor Canadi | 07 October 2014, 18:47:23 UTC | Merge pull request #342 from fyrz/java_makefile_fix RocksJava Makefile includes incorrect paths to version.h | 07 October 2014, 18:47:23 UTC |
4f27240 | fyrz | 07 October 2014, 18:43:04 UTC | RocksJava Makefile includes incorrect paths to version.h | 07 October 2014, 18:43:04 UTC |
f78b832 | Igor Canadi | 07 October 2014, 17:40:57 UTC | Log RocksDB version Summary: This will be much easier than reviewing git sha's we currently have in our LOGs Test Plan: none Reviewers: sdong, yhchiang, ljin Reviewed By: ljin Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D24591 | 07 October 2014, 17:40:57 UTC |
25f6a85 | Lei Jin | 07 October 2014, 17:40:45 UTC | add db_test for changing memtable size Summary: The test only covers changing write_buffer_size. Other changable parameters such bloom bits/probes are not obvious how to test. Suggestions are welcome Test Plan: db_test Reviewers: sdong, yhchiang, igor Reviewed By: igor Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D24429 | 07 October 2014, 17:40:45 UTC |
daab6dc | ankgup87 | 07 October 2014, 16:53:20 UTC | Merge pull request #318 from criccomini/master Build RocksDB JNI cross-platform fat jar | 07 October 2014, 16:53:20 UTC |
63eade4 | Igor Canadi | 07 October 2014, 16:47:16 UTC | Fix error introduced by merge | 07 October 2014, 16:50:29 UTC |
ba88297 | Igor Canadi | 07 October 2014, 16:48:21 UTC | Merge pull request #340 from nbougalis/nullderef Avoid dereferencing a null field | 07 October 2014, 16:48:21 UTC |
6bcff9d | Igor Canadi | 07 October 2014, 16:44:08 UTC | Merge pull request #341 from fyrz/arc-lint Removed code which prevents `arc lint` from working properly. | 07 October 2014, 16:44:08 UTC |
d616995 | fyrz | 07 October 2014, 15:40:19 UTC | Removed code which prevents `arc lint` from working properly. | 07 October 2014, 15:40:19 UTC |
b87db07 | Nik Bougalis | 04 October 2014, 21:38:37 UTC | Avoid dereferencing a null field | 07 October 2014, 08:40:29 UTC |
1a1b953 | Igor Canadi | 07 October 2014, 06:07:07 UTC | Merge pull request #270 from tdfischer/check-with-unity Build unity build on make check | 07 October 2014, 06:07:07 UTC |
e107b6b | ankgup87 | 06 October 2014, 17:38:13 UTC | Merge pull request #337 from fyrz/cross-platform-jdb_bench Cross platform fix for Java benchmark shell script. | 06 October 2014, 17:38:13 UTC |
70e401a | Igor Canadi | 06 October 2014, 16:09:37 UTC | Merge pull request #338 from fyrz/rm_obs_code_write_batch_with_index_test Replaced obsolete comparator with builtin variant. | 06 October 2014, 16:09:37 UTC |
1e5a528 | Chris Riccomini | 06 October 2014, 15:24:51 UTC | update release readme | 06 October 2014, 15:24:51 UTC |
d44871e | Chris Riccomini | 06 October 2014, 15:23:31 UTC | fix java doc directory in git ignore | 06 October 2014, 15:23:31 UTC |
2a4d6e7 | Chris Riccomini | 06 October 2014, 15:22:55 UTC | merge master to resolve merge conflicts | 06 October 2014, 15:22:55 UTC |
6b2c1d9 | Chris Riccomini | 06 October 2014, 15:20:56 UTC | make publish jni jars depend on release jni jars | 06 October 2014, 15:20:56 UTC |
1c7c764 | fyrz | 05 October 2014, 19:51:09 UTC | Replaced obsolete comparator with builtin variant. | 05 October 2014, 19:51:09 UTC |
22c64be | fyrz | 05 October 2014, 08:46:55 UTC | Cross platform fix for Java benchmark shell script. | 05 October 2014, 08:46:55 UTC |
8182859 | Igor Canadi | 04 October 2014, 18:58:07 UTC | Merge pull request #335 from fyrz/version-script-cross-platform Cross-platform fix version.sh | 04 October 2014, 18:58:07 UTC |
69d4c51 | fyrz | 04 October 2014, 09:17:06 UTC | Cross-platform fix version.sh version.sh now works also on linux properly. | 04 October 2014, 09:17:06 UTC |
fcd13a7 | ankgup87 | 03 October 2014, 21:47:30 UTC | Merge pull request #334 from fyrz/JavaDoc-Cleanup JavaDoc fixes & enhancements RocksJava | 03 October 2014, 21:47:30 UTC |
bfb0246 | ankgup87 | 03 October 2014, 21:46:41 UTC | Merge pull request #331 from fyrz/findbug_issues Fixed Findbugs issues in RocksJava | 03 October 2014, 21:46:41 UTC |
05204bb | fyrz | 03 October 2014, 19:43:47 UTC | Lint changes | 03 October 2014, 19:43:47 UTC |
da8ff9f | fyrz | 02 October 2014, 19:31:19 UTC | Fixed Findbugs issues - BackupableDB missing call to super.finalize(major) - WriteBatchTest inefficient String usage(minor) - RocksDB local dead variable store(medium) | 03 October 2014, 10:20:40 UTC |
a5757ff | fyrz | 03 October 2014, 09:50:40 UTC | Listing of changes - JavaDoc readability of RocksObject JavaDoc - JavaDoc improvements BlockBasedTableConfig, GenericRateLimiterConfig, RocksDB - JavaDoc improvements MemTableConfig - JavaDoc improvements RocksObject - JavaDoc improvements GenericRateLimiterConfig - JavaDoc improvements ReadOptions - JavaDoc improvements RateLimiterConfig - JavaDoc improvements RestoreOptions - JavaDoc improvements RestoreBackupableDB - JavaDoc improvements BlockBasedTableConfig - JavaDoc improvements Options - JavaDoc improvements BackupableDB and BackupableDBOptions | 03 October 2014, 09:59:54 UTC |
df3373f | Yueh-Hsuan Chiang | 03 October 2014, 09:14:43 UTC | [Java] Fix compile error on DbBenchmark.java Summary: Fix compile error on DbBenchmark.java Test Plan: make rocksdbjava make jdb_bench | 03 October 2014, 09:14:43 UTC |
4eb5a40 | Yueh-Hsuan Chiang | 03 October 2014, 09:10:00 UTC | [Java] Fixed link error on library loading on Mac. Summary: Fixed link error on library loading on Mac. Test Plan: make rocksdbjava make jtest | 03 October 2014, 09:10:51 UTC |
56dfd36 | Yueh-Hsuan Chiang | 03 October 2014, 07:25:27 UTC | Fix a check in database shutdown or Column family drop during flush. Summary: Fix a check in database shutdown or Column family drop during flush. Special thanks to Maurice Barnum who spots the problem :) Test Plan: db_test Reviewers: ljin, igor, sdong Reviewed By: sdong Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D24273 | 03 October 2014, 07:25:27 UTC |
0e516a7 | Yueh-Hsuan Chiang | 03 October 2014, 07:10:58 UTC | Fix lint errors in java/rocksjni/options.cc Summary: Fix lint errors in java/rocksjni/options.cc Test Plan: make rocksdbjava | 03 October 2014, 07:10:58 UTC |
8ea232b | sdong | 02 October 2014, 19:00:09 UTC | Add number of records dropped in compaction summary Summary: Add two stats to compaction summary: 1. Total input records from previous level 2. Total number of records dropped after compaction Test Plan: See outputs of printing when runnning locally Reviewers: ljin, igor, MarkCallaghan Reviewed By: MarkCallaghan Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D24411 | 03 October 2014, 00:54:25 UTC |
f4086a8 | sdong | 03 October 2014, 00:02:30 UTC | perf_context.get_from_output_files_time is set for MultiGet() and ReadOnly DB too. Summary: perf_context.get_from_output_files_time is now only set writable DB's DB::Get(). Extend it to MultiGet() and read only DB. Test Plan: make all check Fix perf_context_test and extend it to cover MultiGet(), as long as read-only DB. Run it and watch the results Reviewers: ljin, yhchiang, igor Reviewed By: igor Subscribers: rven, leveldb Differential Revision: https://reviews.facebook.net/D24207 | 03 October 2014, 00:02:50 UTC |
e869fc6 | Chris Riccomini | 02 October 2014, 22:46:49 UTC | remove proper javadoc directory | 02 October 2014, 22:46:49 UTC |
c127353 | Igor Canadi | 02 October 2014, 22:14:40 UTC | Merge pull request #333 from nbougalis/cleanups Don't return (or dereference) dangling pointer | 02 October 2014, 22:14:40 UTC |
99744e0 | Chris Riccomini | 02 October 2014, 21:59:20 UTC | bump version to 3.6 | 02 October 2014, 21:59:20 UTC |
45d526e | Chris Riccomini | 02 October 2014, 21:57:18 UTC | singular javadoc directory | 02 October 2014, 21:57:18 UTC |
378f321 | Chris Riccomini | 02 October 2014, 21:52:10 UTC | merge master to resolve merge conflicts | 02 October 2014, 21:52:10 UTC |
a1d3f0d | Chris Riccomini | 02 October 2014, 21:49:46 UTC | don't fail if javadocs diretory doesn't exist | 02 October 2014, 21:49:46 UTC |
c832f16 | Chris Riccomini | 02 October 2014, 21:42:49 UTC | add not about updating pom version and rename pom to be unversioned | 02 October 2014, 21:42:49 UTC |
a213971 | Nik Bougalis | 01 October 2014, 00:32:37 UTC | Don't return (or dereference) dangling pointer | 02 October 2014, 21:33:16 UTC |
2a1add6 | Chris Riccomini | 02 October 2014, 21:31:14 UTC | use proper major/minor/micro version rather than hard coding 3.5.0 | 02 October 2014, 21:31:14 UTC |
2d72f78 | Chris Riccomini | 02 October 2014, 21:26:52 UTC | update release docs in java | 02 October 2014, 21:26:52 UTC |
8322cf0 | Chris Riccomini | 02 October 2014, 21:13:09 UTC | use javadoc instead of javadocs | 02 October 2014, 21:13:09 UTC |
079a612 | Igor Canadi | 02 October 2014, 21:03:49 UTC | Fix build_tools/version.sh | 02 October 2014, 21:03:49 UTC |
2e80124 | Chris Riccomini | 02 October 2014, 20:57:54 UTC | add javadoc and sources targets for sonatype | 02 October 2014, 20:57:54 UTC |
df08a2d | Chris Riccomini | 02 October 2014, 20:47:07 UTC | add single rocksdbjni pom | 02 October 2014, 20:47:07 UTC |
deefcf4 | Chris Riccomini | 02 October 2014, 20:46:43 UTC | make fat jar unclassified to satisfy sonatype | 02 October 2014, 20:46:43 UTC |
fd2545c | Chris Riccomini | 02 October 2014, 20:29:47 UTC | add maven publication target and instructions | 02 October 2014, 20:29:47 UTC |
1e9af10 | ankgup87 | 02 October 2014, 20:11:30 UTC | Merge pull request #330 from fyrz/setFilterPolicyForBBTConfig BlockBasedTableConfig Filter policy support RocksJava | 02 October 2014, 20:11:30 UTC |
0173541 | fyrz | 02 October 2014, 11:33:18 UTC | FilterTest | 02 October 2014, 19:17:48 UTC |
d410b39 | fyrz | 02 October 2014, 11:21:20 UTC | BlockBasedTableConfig Filter policy support RocksJava As proposed by yhchiang the filter can now be set in Java for a BlockBasedTableConfig instance. | 02 October 2014, 19:17:48 UTC |
0908ddc | Igor Canadi | 02 October 2014, 18:59:22 UTC | Don't keep managing two rocksdb version Summary: Before this diff, there are two places with rocksdb versions. After the diff: 1. we only have one source of truth for rocksdb version 2. we have a script that we can use to get the version that we can use in other compilations (java, go, etc). Test Plan: make Reviewers: yhchiang, sdong, ljin Reviewed By: ljin Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D24333 | 02 October 2014, 18:59:22 UTC |
d0916f4 | Chris Riccomini | 02 October 2014, 18:07:45 UTC | add major minor micro version to java jars | 02 October 2014, 18:07:45 UTC |
d698721 | Igor Canadi | 02 October 2014, 17:59:52 UTC | Merge pull request #327 from dalgaaf/wip-da-SCA-20141001 Fix some issues from SCA | 02 October 2014, 17:59:52 UTC |
25888ae | Yueh-Hsuan Chiang | 02 October 2014, 08:10:01 UTC | Merge pull request #329 from fyrz/master resolution for java build problem introduced by 5ec53f3edf62bec1b690ce12... | 02 October 2014, 08:10:01 UTC |
89833e5 | Yueh-Hsuan Chiang | 02 October 2014, 08:05:59 UTC | Fixed signed-unsigned comparison warning in db_test.cc Summary: Fixed signed-unsigned comparison warning in db_test.cc db/db_test.cc:8606:3: note: in instantiation of function template specialization 'rocksdb::test::Tester::IsEq<int, unsigned long>' requested here ASSERT_EQ(2, metadata.size()); ^ Test Plan: make db_test | 02 October 2014, 08:05:59 UTC |
fcac705 | Yueh-Hsuan Chiang | 02 October 2014, 08:01:29 UTC | Fixed compile warning on Mac caused by unused variables. Summary: Fixed compile warning caused by unused variables. ./db/compaction_picker.h:118:7: error: private field 'max_grandparent_overlap_factor_' is not used [-Werror,-Wunused-private-field] int max_grandparent_overlap_factor_; ^ ./db/compaction_picker.h:119:7: error: private field 'expanded_compaction_factor_' is not used [-Werror,-Wunused-private-field] int expanded_compaction_factor_; ^ 2 errors generated. Test Plan: make db_test | 02 October 2014, 08:03:08 UTC |
b3343fd | fyrz | 02 October 2014, 07:25:07 UTC | resolution for java build problem introduced by 5ec53f3edf62bec1b690ce12fb21a6c52203f3c8 | 02 October 2014, 07:25:07 UTC |
187b299 | Tomislav Novak | 22 September 2014, 22:20:03 UTC | ForwardIterator: update prev_key_ only if prefix hasn't changed Summary: Since ForwardIterator is on a level below DBIter, the latter may call Next() on it (e.g. in order to skip deletion markers). Since this also updates `prev_key_`, it may prevent the Seek() optimization. For example, assume that there's only one SST file and it contains the following entries: 0101, 0201 (`ValueType::kTypeDeletion`, i.e. a tombstone record), 0201 (`kTypeValue`), 0202. Memtable is empty. `Seek(0102)` will result in `prev_key_` being set to `0201` instead of `0102`, since `DBIter::Seek()` will call `ForwardIterator::Next()` to skip record 0201. Therefore, when `Seek(0102)` is called again, `NeedToSeekImmutable()` will return true. This fix relies on `prefix_extractor_` to detect prefix changes. `prev_key_` is only set to `current_->key()` as long as they have the same prefix. I also made a small change to `NeedToSeekImmutable()` so it no longer returns true when the db is empty (i.e. there's nothing but a memtable). Test Plan: $ TEST_TMPDIR=/dev/shm/rocksdbtest ROCKSDB_TESTS=TailingIterator ./db_test Reviewers: sdong, igor, ljin Reviewed By: ljin Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D23823 | 02 October 2014, 00:10:48 UTC |
5ec53f3 | Lei Jin | 01 October 2014, 23:19:16 UTC | make compaction related options changeable Summary: make compaction related options changeable. Most of changes are tedious, following the same convention: grabs MutableCFOptions at the beginning of compaction under mutex, then pass it throughout the job and register it in SuperVersion at the end. Test Plan: make all check Reviewers: igor, yhchiang, sdong Reviewed By: sdong Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D23349 | 01 October 2014, 23:19:16 UTC |
d122e7b | Igor Canadi | 01 October 2014, 18:15:42 UTC | Update INSTALL.md | 01 October 2014, 18:15:42 UTC |
9d6f380 | Danny Al-Gaaf | 01 October 2014, 09:57:01 UTC | backupable_db_test.cc: pass const string param by reference Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 09:57:01 UTC |
8ff0b40 | Danny Al-Gaaf | 01 October 2014, 09:55:43 UTC | document_db_test.cc: pass const string param by reference Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 09:55:43 UTC |
177caca | Danny Al-Gaaf | 01 October 2014, 09:53:00 UTC | ttl/ttl_test.cc: pass const string param by reference Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 09:53:00 UTC |
4a17188 | Danny Al-Gaaf | 01 October 2014, 09:09:22 UTC | db/version_set.cc: remove unnecessary checks Fix for: [db/version_set.cc:1219]: (style) Unsigned variable 'last_file' can't be negative so it is unnecessary to test it. [db/version_set.cc:1234]: (style) Unsigned variable 'first_file' can't be negative so it is unnecessary to test it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 09:09:22 UTC |
bf3bfd0 | Danny Al-Gaaf | 01 October 2014, 08:53:37 UTC | util/cache_test.cc: use static_cast over C-Style cast Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:53:37 UTC |
86e29f0 | Danny Al-Gaaf | 01 October 2014, 08:37:31 UTC | document_db.cc: remove unused variable Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:09 UTC |
28a6e31 | Danny Al-Gaaf | 01 October 2014, 08:36:51 UTC | table/block_based_table_builder.cc: remove unused variable Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:09 UTC |
0911534 | Danny Al-Gaaf | 01 October 2014, 08:35:56 UTC | db/db_test.cc: remove unused variable Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:09 UTC |
6b6cedb | Danny Al-Gaaf | 01 October 2014, 05:27:39 UTC | table/format.cc: reduce scope of some variables Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:08 UTC |
5565204 | Danny Al-Gaaf | 01 October 2014, 05:24:20 UTC | table/cuckoo_table_reader.cc: pass func parameter by reference Fix for: [table/cuckoo_table_reader.cc:196]: (performance) Function parameter 'target' should be passed by reference. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:08 UTC |
5abd8ad | Danny Al-Gaaf | 01 October 2014, 05:17:07 UTC | db/deletefile_test.cc: remove unused variable Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:08 UTC |
d6483af | Danny Al-Gaaf | 01 October 2014, 05:12:12 UTC | db/db_test.cc: reduce scope of some variables Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:08 UTC |
44cca0c | Danny Al-Gaaf | 01 October 2014, 05:09:06 UTC | db/db_iter.cc: remove unused variable Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 01 October 2014, 08:49:08 UTC |
986dad0 | Igor Canadi | 30 September 2014, 21:45:00 UTC | Merge pull request #324 from dalgaaf/wip-da-SCA-20140930 Various SCA fixes | 30 September 2014, 21:45:00 UTC |
3a0d498 | Chris Riccomini | 30 September 2014, 21:40:04 UTC | rebase master | 30 September 2014, 21:40:04 UTC |
8ee75dc | Danny Al-Gaaf | 29 September 2014, 21:55:21 UTC | db/memtable.cc: remove unused variable merge_result Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:33 UTC |
0fd8bbc | Danny Al-Gaaf | 29 September 2014, 21:45:23 UTC | db/db_impl.cc: reduce scope of prefix_initialized Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:33 UTC |
676ff7b | Danny Al-Gaaf | 29 September 2014, 21:31:47 UTC | compaction_picker.cc: remove check for >=0 for unsigned Fix for: [db/compaction_picker.cc:923]: (style) Unsigned variable 'start_index' can't be negative so it is unnecessary to test it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:33 UTC |
e55aea5 | Danny Al-Gaaf | 29 September 2014, 21:27:35 UTC | document_db.cc: fix assert Check for lhs and not twice for rhs. Fix for: [utilities/document/document_db.cc:36] -> [utilities/document/document_db.cc:36]: (style) Same expression on both sides of '&&'. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |
d517c83 | Danny Al-Gaaf | 29 September 2014, 21:23:09 UTC | in_table_factory.cc: use correct format specifier Use %zu instead of %zd since size_t and uint32_t are unsigned. Fix for: [table/plain_table_factory.cc:55]: (warning) %zd in format string (no. 1) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. [table/plain_table_factory.cc:58]: (warning) %zd in format string (no. 1) requires 'ssize_t' but the argument type is 'size_t {aka unsigned long}'. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |
b140375 | Danny Al-Gaaf | 29 September 2014, 21:13:01 UTC | ttl/ttl_test.cc: prefer prefix ++operator for non-primitive types Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |
43c789c | Danny Al-Gaaf | 29 September 2014, 21:11:00 UTC | spatialdb/spatial_db.cc: use !empty() instead of 'size() > 0' Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |
0de452e | Danny Al-Gaaf | 29 September 2014, 21:09:28 UTC | document_db.cc: pass const parameter by reference Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |
4cc8643 | Danny Al-Gaaf | 29 September 2014, 21:05:12 UTC | util/ldb_cmd.cc: prefer prefix ++operator for non-primitive types Prefer prefix ++operator for non-primitive types like iterators for performance reasons. Prefix ++/-- operators avoid creating a temporary copy. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> | 30 September 2014, 21:30:32 UTC |