| 8d87467 | Yueh-Hsuan Chiang | 07 November 2014, 01:07:52 UTC | Make PartialCompactionFailure Test more robust again. Summary: Make PartialCompactionFailure Test more robust again by blocking background compaction until we simulate the file creation error. Test Plan: export ROCKSDB_TESTS=PartialCompactionFailure ./db_test Reviewers: sdong, igor, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28431 | 07 November 2014, 01:07:52 UTC |
| 64d302d | Lei Jin | 07 November 2014, 00:07:07 UTC | make DropWritesFlush deterministic Summary: TEST_WaitForFlush should wait until it sees error when parameter is set to true so we don't need to loop and timeout Test Plan: ROCKSDB_TESTS=DropWritesFlush ./db_test Reviewers: sdong, igor Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28419 | 07 November 2014, 00:07:07 UTC |
| cd5c092 | Igor Canadi | 06 November 2014, 22:42:04 UTC | Merge pull request #387 from fyrz/RocksJava-WShadow-Fix [RocksJava] -WShadow improvements | 06 November 2014, 22:42:04 UTC |
| c4bf07c | fyrz | 06 November 2014, 22:12:36 UTC | [RocksJava] -WShadow improvements Minor corrections to resolve -WShadow build problems with RocksJava code. | 06 November 2014, 22:14:48 UTC |
| e526b71 | Yueh-Hsuan Chiang | 06 November 2014, 21:53:02 UTC | Make PartialCompactionFailure Test more robust. Summary: Make PartialCompactionFailure Test more robust. Test Plan: export ROCKSDB_TESTS=PartialCompactionFailure ./db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28425 | 06 November 2014, 21:53:02 UTC |
| 0c2be0d | Igor Canadi | 06 November 2014, 21:29:17 UTC | Turn on -Wshadow for travis | 06 November 2014, 21:29:17 UTC |
| 5fd33d2 | Igor Canadi | 06 November 2014, 20:01:02 UTC | Turn off -Wshadow Summary: So glibc is not -Wshadow-safe, so we need to turn it off :( error: ‘int sigaction(int, const sigaction*, sigaction*)’ hides constructor for ‘struct sigaction’ The rest of the changes in this diff is that we include .h files under rocksdb namespace, which is a no-no. Test Plan: compiles now Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28413 | 06 November 2014, 20:01:02 UTC |
| 9f20395 | Igor Canadi | 06 November 2014, 19:14:28 UTC | Turn -Wshadow back on Summary: It turns out that -Wshadow has different rules for gcc than clang. Previous commit fixed clang. This commits fixes the rest of the warnings for gcc. Test Plan: compiles Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28131 | 06 November 2014, 19:14:28 UTC |
| c02338a | Lei Jin | 06 November 2014, 19:02:30 UTC | update HISOTRY.md for new release Summary: as title Test Plan: n/a | 06 November 2014, 19:02:30 UTC |
| 367a3f9 | sdong | 06 November 2014, 18:14:47 UTC | Improve DBTest.GroupCommitTest: artificially slowdown log writing to trigger group commit Summary: In order to avoid random failure of DBTest.GroupCommitTest, artificially sleep 100 microseconds in each log writing. Test Plan: Run the test in a machine where valgrind version of the test always fails multiple times and see it always succeed. Reviewers: igor, yhchiang, rven, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28401 | 06 November 2014, 18:48:06 UTC |
| b52b144 | Igor Canadi | 06 November 2014, 18:46:20 UTC | Merge pull request #386 from EugenePig/java8 suppress JDK8 errors for #385 | 06 November 2014, 18:46:20 UTC |
| ac95ae1 | sdong | 06 November 2014, 02:07:22 UTC | Make sure WAL is synced for DB::Write() if write batch is empty Summary: This patch makes it a contract that if an empty write batch is passed to DB::Write() and WriteOptions.sync = true, fsync is called to WAL. Test Plan: A new unit test Reviewers: ljin, rven, yhchiang, igor Reviewed By: igor Subscribers: dhruba, MarkCallaghan, leveldb Differential Revision: https://reviews.facebook.net/D28365 | 06 November 2014, 17:48:19 UTC |
| 59d5497 | Eugene Su | 06 November 2014, 08:25:53 UTC | suppress JDK8 errors for #385 | 06 November 2014, 08:25:53 UTC |
| ea18b94 | Shi Feng | 29 October 2014, 21:24:34 UTC | Add db_bench option --report_file_operations Summary: Add db_bench option --report_file_operations Test Plan: ./db_bench --report_file_operations Observe outputs on # of file operations Reviewers: ljin, MarkCallaghan, sdong Reviewed By: sdong Subscribers: yhchiang, rven, igor, dhruba Differential Revision: https://reviews.facebook.net/D27945 | 06 November 2014, 02:40:18 UTC |
| 2ea1219 | sdong | 01 November 2014, 01:36:07 UTC | Fix RecordIn and RecordDrop stats Summary: 1. fix possible overflow of the two stats by using uint64_t 2. use a similar source of data to calculate RecordDrop. Previous one is not correct. Test Plan: See outputs of db_bench settings, and the results look reasonable Reviewers: MarkCallaghan, ljin, igor Reviewed By: igor Subscribers: rven, leveldb, yhchiang, dhruba Differential Revision: https://reviews.facebook.net/D28155 | 05 November 2014, 19:03:34 UTC |
| e4211d1 | Yueh-Hsuan Chiang | 05 November 2014, 08:12:20 UTC | Apply InfoLogLevel to the logs in util/env_hdfs.cc Summary: Apply InfoLogLevel to the logs in util/env_hdfs.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28011 | 05 November 2014, 08:12:20 UTC |
| 29a9161 | Lei Jin | 05 November 2014, 00:23:45 UTC | Note dynamic options in options.h Summary: as title Test Plan: n/a Reviewers: igor, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28287 | 05 November 2014, 00:23:45 UTC |
| fd24ae9 | Lei Jin | 05 November 2014, 00:23:05 UTC | SetOptions() to return status and also add it to StackableDB Summary: as title Test Plan: ./db_test Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28269 | 05 November 2014, 00:23:05 UTC |
| b126775 | Lei Jin | 04 November 2014, 23:58:14 UTC | fix the asan check Summary: as title Test Plan: ran it Reviewers: yhchiang, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28311 | 04 November 2014, 23:58:14 UTC |
| 83bf091 | sdong | 04 November 2014, 22:39:09 UTC | Bump verison number to 3.7 Summary: As tittle Test Plan: N/A Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28299 | 04 November 2014, 22:52:02 UTC |
| da5daa0 | sdong | 04 November 2014, 19:33:57 UTC | Replace some ASSERT_TRUE() asserts in DBTest.DynamicMemtableOptions and DynamicCompactionOptions with more specific ones Summary: Replace some ASSERT_TRUE() to ASSERT_GT() and ASSERT_LT() so that in case the assert is triggered, the value is printed out. Test Plan: Run the two tests Reviewers: ljin, rven, yhchiang, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28293 | 04 November 2014, 19:45:03 UTC |
| b0cda4a | sdong | 04 November 2014, 19:07:36 UTC | DBTest.DynamicMemtableOptions to use single background compaction Summary: Now DBTest.DynamicMemtableOptions sets background compaction to be 4, without actually increasing thread pool size (even before the feature of automatic increasing it). To make sure the behavior stays the same after the automatic thread pool increasing, set it back to 1. Hopefully it can fix the occasional failure of the test. Test Plan: Run the test Reviewers: igor, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28281 | 04 November 2014, 19:14:12 UTC |
| 8810850 | Yueh-Hsuan Chiang | 04 November 2014, 19:07:11 UTC | Apply InfoLogLevel to the logs in db/compaction_job.cc Summary: Apply InfoLogLevel to the logs in db/compaction_job.cc Test Plan: db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: leveldb, MarkCallaghan, dhruba Differential Revision: https://reviews.facebook.net/D28275 | 04 November 2014, 19:07:11 UTC |
| 71783f6 | Yueh-Hsuan Chiang | 04 November 2014, 19:05:19 UTC | Merge pull request #377 from fyrz/RocksJava-KeyMayExist [RocksJava] KeyMayExist w/o ColumnFamilies | 04 November 2014, 19:05:19 UTC |
| 614bbcb | Yueh-Hsuan Chiang | 04 November 2014, 18:51:59 UTC | Merge pull request #374 from fyrz/RocksJava-DBOptions-Extension-3.6 [RocksJava] DBOptions extension 3.6 | 04 November 2014, 18:51:59 UTC |
| d8e1196 | Yueh-Hsuan Chiang | 04 November 2014, 18:34:33 UTC | Apply InfoLogLevel to the logs in db/version_set.cc Summary: Apply InfoLogLevel to the logs in db/version_set.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27879 | 04 November 2014, 18:34:33 UTC |
| 2a019f1 | Yueh-Hsuan Chiang | 04 November 2014, 18:34:18 UTC | Apply InfoLogLevel to the logs in db/wal_manager.cc Summary: Apply InfoLogLevel to the logs in db/wal_manager.cc Test Plan: db_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28239 | 04 November 2014, 18:34:18 UTC |
| 469d474 | Yueh-Hsuan Chiang | 04 November 2014, 18:28:08 UTC | Apply InfoLogLevel to the logs in db/db_impl.cc Summary: Apply InfoLogLevel to the logs in db/db_impl.cc Test Plan: db_test db_bench Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: leveldb, MarkCallaghan, dhruba Differential Revision: https://reviews.facebook.net/D28233 | 04 November 2014, 18:28:08 UTC |
| ac6afaf | sdong | 04 November 2014, 01:45:55 UTC | Enforce naming convention of getters in version_set.h Summary: Enforce the accessier naming convention in functions in version_set.h Test Plan: make all check Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28143 | 04 November 2014, 17:59:05 UTC |
| 09899f0 | sdong | 03 November 2014, 22:11:33 UTC | DB::Open() to automatically increase thread pool size if it is smaller than max number of parallel compactions or flushes Summary: With the patch, thread pool size will be automatically increased if DB's options ask for more parallelism of compactions or flushes. Too many users have been confused by the API. Change it to make it harder for users to make mistakes Test Plan: Add two unit tests to cover the function. Reviewers: yhchiang, rven, igor, MarkCallaghan, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27555 | 04 November 2014, 01:22:34 UTC |
| 636e57b | Igor Canadi | 03 November 2014, 22:53:00 UTC | Fix coverage script | 03 November 2014, 22:53:00 UTC |
| 30ca375 | Igor Canadi | 03 November 2014, 22:00:45 UTC | Revamp our build tools Summary: This diff is revamping our build tools: 1) Use third-party2 instead of third-party 2) consolidate clang and gcc scripts together, lots of duplication there 3) remove hdfs libs, we never compile rocksdb with them clang compilation doesn't work yet. It doesn't work in master either. I plan to fix it soon, but I just spent 2 hours trying to make it work and failed. I'll ask experts. Test Plan: compiles with gcc Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28047 | 03 November 2014, 22:00:45 UTC |
| 051c67f | Igor Canadi | 03 November 2014, 19:27:50 UTC | Merge pull request #378 from baotiao/master add make clean in examples makefile | 03 November 2014, 19:27:50 UTC |
| d0e7e49 | Igor Canadi | 03 November 2014, 19:27:13 UTC | Merge pull request #379 from fyrz/RocksJavaBuildFix [RocksJava] Build fix after options refactoring | 03 November 2014, 19:27:13 UTC |
| 94e31ac | fyrz | 28 October 2014, 21:38:08 UTC | [RocksJava] Extend Options with DBOptions implementation [RocksJava] Included DBOptionsTest and refactored OptionsTest Summary: Options refactoring - Split Part2 Test Plan: make rocksdbjava make jtest Reviewers: yhchiang, ankgup87 Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28017 | 02 November 2014, 23:13:57 UTC |
| b060d30 | fyrz | 02 November 2014, 22:48:40 UTC | [RocksJava] Build fix after options refactoring | 02 November 2014, 22:48:40 UTC |
| 9fd65e5 | baotiao | 02 November 2014, 20:42:28 UTC | add make clean in examples makefile | 02 November 2014, 20:42:28 UTC |
| 8e79ce6 | Igor Canadi | 01 November 2014, 02:22:49 UTC | Revert "Fix lint errors and coding style of ldb related codes." This reverts commit bc9f36fd5e5f0eae69a5a1b7269bb2623cc0eb1f. | 01 November 2014, 02:22:49 UTC |
| 45a612f | Igor Canadi | 01 November 2014, 02:22:42 UTC | Revert "Fix incorrect fixing of lint errors in ldb_cmd.cc" This reverts commit 8ddddd62d0bf7ac74cf64a024452587a007b6096. | 01 November 2014, 02:22:42 UTC |
| 27129c7 | fyrz | 01 November 2014, 00:02:12 UTC | [RocksJava] KeyMayExist w/o ColumnFamilies | 01 November 2014, 00:02:12 UTC |
| 86905e3 | sdong | 31 October 2014, 18:54:05 UTC | Move VersionBuilder logic to a separate .cc file Summary: Move all the logic of VersionBuilder to a separate .cc file Test Plan: make all check Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28083 | 31 October 2014, 23:34:38 UTC |
| 74eb4fb | Igor Canadi | 31 October 2014, 23:31:25 UTC | CompactionJob Summary: Long awaited CompactionJob class! Move most compaction-related things from DBImpl to CompactionJob, making CompactionJob easier to test and understand. Currently this is just replicating exactly the same functionality with as little as change as possible. As future work, we should: 1. Add CompactionJob tests (I think I'll do that tomorrow) 2. Reduce CompactionJob's state that it inherits from DBImpl 3. Figure out how to do yielding to flush better. Currently I implemented a callback as we agreed yesterday, but I don't think it's a good long term solution. This reduces db_impl.cc from 5000+ LOC to 3400! Test Plan: make check, will add CompactionJob-specific tests, probably also move some tests from db_test to compaction_job_test Reviewers: rven, yhchiang, sdong, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27957 | 31 October 2014, 23:31:25 UTC |
| 8ddddd6 | Yueh-Hsuan Chiang | 31 October 2014, 23:15:15 UTC | Fix incorrect fixing of lint errors in ldb_cmd.cc Summary: Fix incorrect fixing of lint errors in ldb_cmd.cc Test Plan: reduce_levels_test Reviewers: igor, sdong, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28137 | 31 October 2014, 23:15:15 UTC |
| 46c14c6 | Igor Canadi | 31 October 2014, 22:41:25 UTC | Fix #258. benchmarkharness -- make bm_min_usec uint | 31 October 2014, 22:41:56 UTC |
| 72cb7cf | Lei Jin | 31 October 2014, 22:16:31 UTC | Add fsync / corrupt simulation to env_mem Summary: as title Test Plan: env_mem_test Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28077 | 31 October 2014, 22:16:31 UTC |
| 0e526eb | Lei Jin | 31 October 2014, 22:08:10 UTC | introduce TestMemEnv and use it in db_test Summary: TestMemEnv simulates all Env APIs using in-memory data structures. We can use it to speed up db_test run, which is now reduced ~7mins when it is enabled. We can also add features to simulate power/disk failures in the next step TestMemEnv is derived from helper/mem_env mem_env can not be used for rocksdb since some of its APIs do not give the same results as env_posix. And its file read/write is not thread safe Test Plan: make all -j32 ./db_test ./env_mem_test Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28035 | 31 October 2014, 22:08:10 UTC |
| 8db24f4 | Lei Jin | 31 October 2014, 22:07:27 UTC | exclude mock test file from MOCK_SOURCES Summary: as title Test Plan: build with mock_env_test.cc Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28107 | 31 October 2014, 22:07:27 UTC |
| 5594d44 | Lei Jin | 31 October 2014, 22:04:39 UTC | unfriend DBImpl and InternalStats from VersionStorageInfo Summary: as title Test Plan: make release Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28053 | 31 October 2014, 22:04:39 UTC |
| 82e3ae5 | Lei Jin | 31 October 2014, 22:04:01 UTC | fix c_test Summary: as title Test Plan: ./c_test Reviewers: igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28119 | 31 October 2014, 22:04:01 UTC |
| bc9f36f | Yueh-Hsuan Chiang | 31 October 2014, 22:01:39 UTC | Fix lint errors and coding style of ldb related codes. Summary: Fix lint errors and coding style of ldb related codes. Test Plan: ./ldb Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28125 | 31 October 2014, 22:01:39 UTC |
| c645250 | sdong | 31 October 2014, 20:51:16 UTC | CompactionStats to support larger value of RecordIn and RecordDrop Summary: now we use %8d for RecordIn and %10d for RecordDrop, which is far too small for some use cases. Extend both of them to %12d. Test Plan: run one test in db_test and see the LOG file. Reviewers: igor, MarkCallaghan, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28041 | 31 October 2014, 20:51:48 UTC |
| f7e6c85 | sdong | 31 October 2014, 19:16:35 UTC | Fix BaseReferencedVersionBuilder's destructor order Summary: BaseReferencedVersionBuilder now unreference version before destructing VersionBuilder, which is wrong. Fix it. Test Plan: make all check valgrind test to tests that used to fail Reviewers: igor, yhchiang, rven, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D28101 | 31 October 2014, 20:42:18 UTC |
| c76dcb4 | Lei Jin | 31 October 2014, 20:28:07 UTC | fix Summary: Test Plan: Reviewers: CC: Task ID: # Blame Rev: | 31 October 2014, 20:30:08 UTC |
| b452ded | Lei Jin | 31 October 2014, 19:23:00 UTC | fix Summary: Test Plan: Reviewers: CC: Task ID: # Blame Rev: | 31 October 2014, 19:23:00 UTC |
| 29d83cc | Lei Jin | 31 October 2014, 19:20:39 UTC | temporarily remove -Wshadow | 31 October 2014, 19:20:39 UTC |
| c1a924b | Jonah Cohen | 31 October 2014, 19:08:43 UTC | Move convenience.h to /include Summary: Move header file so it can be referenced externally. Test Plan: Rebuild. Reviewers: ljin Reviewed By: ljin Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28095 | 31 October 2014, 19:08:43 UTC |
| 7e01d12 | Venkatesh Radhakrishnan | 31 October 2014, 19:02:14 UTC | Add support for in place update for db_stress Summary: Added two flags which operate as follows: in_place_update: enable in_place_update for default column family set_in_place_one_in: toggles the value of the option inplace_update_support with a probability of 1/N Test Plan: Run db_stress with the two flags above set. Specifically tried in_place_update set to true and set_in_place_one_in set to 10,000. Reviewers: ljin, igor, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D28029 | 31 October 2014, 19:02:14 UTC |
| 9f7fc3a | Igor Canadi | 31 October 2014, 18:59:54 UTC | Turn on -Wshadow Summary: ...and fix all the errors :) Jim suggested turning on -Wshadow because it helped him fix number of critical bugs in fbcode. I think it's a good idea to be -Wshadow clean. Test Plan: compiles Reviewers: yhchiang, rven, sdong, ljin Reviewed By: ljin Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27711 | 31 October 2014, 18:59:54 UTC |
| 98849a3 | Yueh-Hsuan Chiang | 31 October 2014, 18:41:15 UTC | Apply InfoLogLevel to the logs in table/block_based_table_reader.cc Summary: Apply InfoLogLevel to the logs in table/block_based_table_reader.cc Also, add missing checks for the returned status in BlockBasedTable::Open Test Plan: make Reviewers: sdong, ljin, igor Reviewed By: igor Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D28005 | 31 October 2014, 18:41:15 UTC |
| 4d2ba38 | sdong | 31 October 2014, 15:48:19 UTC | Make VersionBuilder unit testable Summary: Rename Version::Builder to VersionBuilder and expose its definition to a header. Make VerisonBuilder not reference Version or ColumnFamilyData, only working with VersionStorageInfo. Add version_builder_test which has a simple test. Test Plan: make all check Reviewers: rven, yhchiang, igor, ljin Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27969 | 31 October 2014, 17:44:06 UTC |
| 2b1f23d | Yueh-Hsuan Chiang | 30 October 2014, 23:54:34 UTC | Apply InfoLogLevel to the logs in db/db_iter.cc Summary: Apply InfoLogLevel to the logs in db/db_iter.cc Test Plan: make Reviewers: igor, ljin, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27861 | 30 October 2014, 23:54:34 UTC |
| ccaf1aa | Yueh-Hsuan Chiang | 30 October 2014, 23:49:40 UTC | Merge pull request #372 from fyrz/RocksJava-CF-Merge-Hardening [RocksJava] Merge with ColumnFamilies & Hardening CFHandle | 30 October 2014, 23:49:40 UTC |
| a29118f | Yueh-Hsuan Chiang | 30 October 2014, 23:46:41 UTC | Merge pull request #355 from fyrz/RocksJava-Options-Refactoring-3.6 [RocksJava] Options Refactoring 3.6 | 30 October 2014, 23:46:41 UTC |
| 85b04ca | fyrz | 30 October 2014, 23:41:04 UTC | [RocksJava] Review comments - reformatted MergeTest | 30 October 2014, 23:41:04 UTC |
| df7abb4 | fyrz | 30 October 2014, 23:04:16 UTC | [RocksJava] Integrated code review comments - Added TODO comments for disabled methods | 30 October 2014, 23:06:52 UTC |
| 171be0e | fyrz | 29 October 2014, 17:40:44 UTC | Merge with ColumnFamilies & Hardening CFHandle Summary: ColumnFamilyHandles face the same problem as RocksIterator previously so used methods were also applied for ColumnFamilyHandles. Another problem with CF was that Options passed to CFs were always filled with default values. To enable Merge, all parts of the database must share the same merge functionality which is not possible using default values. So from now on every CF will inherit from db options. Changes to RocksDB: - merge can now take also a cfhandle Changes to MergeTest: - Corrected formatting - Included also GC tests - Extended tests to cover CF related parts - Corrected paths to cleanup properly within the test process - Reduced verbosity of the test Test Plan: make rocksdbjava make jtest Subscribers: dhruba Differential Revision: https://reviews.facebook.net/D27999 | 30 October 2014, 21:32:04 UTC |
| 39464a9 | fyrz | 28 October 2014, 21:38:08 UTC | [RocksJava] Options Refactoring 3.6 Summary: Options extends now two interfaces DBOptionsInterface and ColumnFamilyOptionsInterface. There are also further improvements to the Options bindings: Optimize methods were ported to Java. (OptimizeForPointLookup, OptimizeLevelCompaction, OptimizeUniversalCompaction). To align BuiltinComparator with every other Enum it was moved to a separate file. Test Plan: make rocksdbjava make jtest | 30 October 2014, 21:26:39 UTC |
| 0f7f3b8 | Yueh-Hsuan Chiang | 30 October 2014, 20:36:18 UTC | Check InfoLogLevel earlier in Log functions. Summary: Check InfoLogLevel earlier in Log functions. Test Plan: auto_roll_logger_test Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27993 | 30 October 2014, 20:36:18 UTC |
| 73605d9 | Yueh-Hsuan Chiang | 30 October 2014, 20:34:44 UTC | Apply InfoLogLevel to the logs in util/db_info_dumper.cc Summary: * Rename util/db_info_dummper.cc to util/db_info_dumper.cc * Apply InfoLogLevel to the logs in util/db_info_dumper.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27915 | 30 October 2014, 20:34:44 UTC |
| fda592d | Yueh-Hsuan Chiang | 30 October 2014, 20:17:53 UTC | Merge pull request #356 from fyrz/RocksJava-TableOptions-3.6 [RocksJava] BlockBasedTableConfig & PlainTableConfig enhancements | 30 October 2014, 20:17:53 UTC |
| c73d13b | fyrz | 28 October 2014, 17:37:53 UTC | [RocksJava] Integrate review comments from yhchiang | 30 October 2014, 19:54:35 UTC |
| b011e20 | fyrz | 26 October 2014, 19:47:54 UTC | Integrated review comments by ankgup87 - Added tests - Minor code-style changes | 30 October 2014, 19:54:35 UTC |
| 2c1bd88 | fyrz | 20 October 2014, 20:42:32 UTC | BlockBasedTableConfig & PlainTableConfig enhancements Summary: BlockBasedTableConfig - ported Checksum - ported IndexType PlainTableConfig - added missing options - added EncodingType Test Plan: make rocksdbjava make jtest Differential Revision: https://reviews.facebook.net/D26595 | 30 October 2014, 19:54:35 UTC |
| e770d61 | Igor Canadi | 30 October 2014, 18:01:41 UTC | Merge pull request #371 from dlezama/master Fix build break because of unsigned/signed mismatch | 30 October 2014, 18:01:41 UTC |
| 41af0f5 | Damian Lezama | 30 October 2014, 17:36:13 UTC | Fix build break because of unsigned/signed mismatch | 30 October 2014, 17:36:13 UTC |
| c5db7f2 | sdong | 30 October 2014, 04:03:45 UTC | Fix CompactionPickerTest.Level1Trigger2 Summary: CompactionPickerTest.Level1Trigger2 now depends on the STL implementation to be correct. Fix it. Test Plan: Run the test Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27963 | 30 October 2014, 17:00:09 UTC |
| 37e9b63 | Yueh-Hsuan Chiang | 30 October 2014, 00:57:00 UTC | Apply InfoLogLevel to the logs in utilities/ttl/db_ttl_impl.h Summary: Apply InfoLogLevel to the logs in utilities/ttl/db_ttl_impl.h Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27885 | 30 October 2014, 00:57:00 UTC |
| 217cc21 | Yueh-Hsuan Chiang | 30 October 2014, 00:55:19 UTC | Apply InfoLogLevel to the logs in table/meta_blocks.cc Summary: Apply InfoLogLevel to the logs in table/meta_blocks.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27903 | 30 October 2014, 00:55:19 UTC |
| 6359054 | Igor Canadi | 30 October 2014, 00:43:37 UTC | WalManager Summary: Decoupling code that deals with archived log files outside of DBImpl. That will make this code easier to reason about and test. It will also make the code easier to improve, because an improver doesn't have to understand DBImpl code in entirety. Test Plan: added test Reviewers: ljin, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27873 | 30 October 2014, 00:43:37 UTC |
| fd95745 | Yueh-Hsuan Chiang | 30 October 2014, 00:42:38 UTC | Fix compile error in table/plain_table_index.cc Summary: Fix compile error in table/plain_table_index.cc Test Plan: make | 30 October 2014, 00:42:38 UTC |
| c3dd0f7 | sdong | 29 October 2014, 23:17:28 UTC | comparator_db_test to cover more irregular comparators Summary: comparator_db_test now adds verification for three more comparators: (1) one that store double as string (2) one that cast uint64 to string (3) one that concatenate two strings, prefixing their sizes. (4) one that order by hash of the string Test Plan: Run ./comparator_db_test Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27927 | 30 October 2014, 00:34:24 UTC |
| 6afafa3 | Yueh-Hsuan Chiang | 30 October 2014, 00:10:21 UTC | Apply InfoLogLevel to the logs in utilities/merge_operators/uint64add.cc Summary: Apply InfoLogLevel to the logs and add missing copy-right information to utilities/merge_operators/uint64add.cc. Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27897 | 30 October 2014, 00:10:21 UTC |
| e7ad69b | Yueh-Hsuan Chiang | 30 October 2014, 00:08:40 UTC | Apply InfoLogLevel to the logs in table/plain_table_index.cc Summary: Apply InfoLogLevel to the logs in table/plain_table_index.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27909 | 30 October 2014, 00:08:40 UTC |
| bbd9c53 | Yueh-Hsuan Chiang | 30 October 2014, 00:08:20 UTC | Apply InfoLogLevel to the logs in table/block_based_table_builder.cc Summary: Apply InfoLogLevel to the logs in table/block_based_table_builder.cc Test Plan: make Reviewers: igor, ljin, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27921 | 30 October 2014, 00:08:20 UTC |
| 065766b | Lei Jin | 30 October 2014, 00:02:21 UTC | DynamicCompactionOptions: relax the check bound a little Summary: Increase the level size so that impact of a single file is smaller. Also relax the bound Test Plan: ran locally Reviewers: sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27939 | 30 October 2014, 00:02:21 UTC |
| 5c82a88 | sdong | 29 October 2014, 23:45:07 UTC | Add a test in compaction_picker_test to test the max score Summary: Add a new unit test in compaction_picker_test to make sure level-based compaction to pick up the level with the largest score. Test Plan: Run the new test Reviewers: ljin, yhchiang, rven, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27933 | 29 October 2014, 23:58:18 UTC |
| 86de200 | sdong | 29 October 2014, 20:49:45 UTC | Add ComparatorDBTest to test non-default comparators Summary: Add some helper functions to make sure DB works well for non-default comparators. Add a test for SimpleSuffixReverseComparator. Test Plan: Run the new test Reviewers: ljin, rven, yhchiang, igor Reviewed By: igor Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27831 | 29 October 2014, 22:42:36 UTC |
| 17be187 | Lei Jin | 29 October 2014, 22:38:34 UTC | dummy var to suppress compiler warning/error Summary: Revmoed this in D25641, causing compiler complain. put it back Test Plan: make release Reviewers: igor, yhchiang, rven, sdong Reviewed By: sdong Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27891 | 29 October 2014, 22:38:34 UTC |
| c2999f5 | Igor Canadi | 29 October 2014, 22:29:33 UTC | Revert "tmp" This reverts commit 9ab0132360fbf68eb0561f7525e726d4d3a4c0f7. | 29 October 2014, 22:29:33 UTC |
| 76d1c28 | sdong | 27 October 2014, 22:49:46 UTC | Make CompactionPicker more easily tested Summary: Make compaction picker easier to test. The basic idea is to separate a minimum subcomponent of Version to VersionStorageInfo, which just responsible to LSM tree. A stub VersionStorageInfo can then be easily created and passed into compaction picker so that we can check the outputs. It now passes most tests. Still two things need to be done: (1) deal with the FIFO compaction's file size. (2) write an example test to make sure the interface can do the job. Add a compaction_picker_test to make sure compaction picker codes can be easily unit tested. Test Plan: Pass all unit tests and compaction_picker_test Reviewers: yhchiang, rven, igor, ljin Reviewed By: ljin Subscribers: leveldb, dhruba Differential Revision: https://reviews.facebook.net/D27639 | 29 October 2014, 22:16:53 UTC |
| 01e6f85 | Yueh-Hsuan Chiang | 29 October 2014, 22:13:31 UTC | Apply InfoLogLevel to the logs in db/transaction_log_impl.h Summary: Apply InfoLogLevel to the logs in db/transaction_log_impl.h Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27867 | 29 October 2014, 22:13:31 UTC |
| 082e49b | Yueh-Hsuan Chiang | 29 October 2014, 22:12:50 UTC | Apply InfoLogLevel to the logs in db/repair.cc Summary: Apply InfoLogLevel to the logs in db/repair.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27855 | 29 October 2014, 22:12:50 UTC |
| c4b4680 | Yueh-Hsuan Chiang | 29 October 2014, 22:12:10 UTC | Apply InfoLogLevel to the logs in db/flush_job.cc Summary: Apply InfoLogLevel to the logs in db/flush_job.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27849 | 29 October 2014, 22:12:10 UTC |
| 34d436b | Yueh-Hsuan Chiang | 29 October 2014, 22:11:32 UTC | Apply InfoLogLevel to the logs in db/column_family.cc Summary: Apply InfoLogLevel to the logs in db/column_family.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27843 | 29 October 2014, 22:11:32 UTC |
| cda9943 | Yueh-Hsuan Chiang | 29 October 2014, 22:11:12 UTC | Apply InfoLogLevel to the logs in db/compaction_picker.cc Summary: Apply InfoLogLevel to the logs in db/compaction_picker.cc Test Plan: make Reviewers: ljin, sdong, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27837 | 29 October 2014, 22:11:12 UTC |
| 7b3a618 | Yueh-Hsuan Chiang | 29 October 2014, 21:06:14 UTC | Apply InfoLogLevel to the logs in db/db_filesnapshot.cc Summary: Apply InfoLogLevel to the logs in db/db_filesnapshot.cc Test Plan: make Reviewers: ljin, sdong, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27813 | 29 October 2014, 21:06:14 UTC |
| 2d4fe04 | Lei Jin | 29 October 2014, 20:38:06 UTC | remove dead code Summary: as title Test Plan: make db_test | 29 October 2014, 20:38:06 UTC |
| 9ab0132 | Lei Jin | 28 October 2014, 22:31:38 UTC | tmp Summary: Test Plan: Reviewers: CC: Task ID: # Blame Rev: | 29 October 2014, 20:36:47 UTC |
| 76d5453 | Lei Jin | 29 October 2014, 20:36:18 UTC | minor - remove default value for ChangeFilterOptions() and ChangeCompactionOptions() Summary: So now all open() in db_test should get options from callsite. And destroy() always uses the last used options saved on open() I will start to integrate env_mem in the next diff Test Plan: make all check -j32 Reviewers: sdong, yhchiang, rven, igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D27819 | 29 October 2014, 20:36:18 UTC |
| 44f0ff3 | Lei Jin | 29 October 2014, 19:24:49 UTC | use fallocate(FALLOC_FL_PUNCH_HOLE) to release unused blocks at the end of file Summary: ftruncate does not always free preallocated unused space at the end of file. In some cases, we pin too much disk space than it should Test Plan: env_test Reviewers: sdong, rven, yhchiang, igor Reviewed By: igor Subscribers: nkg-, dhruba, leveldb Differential Revision: https://reviews.facebook.net/D25641 | 29 October 2014, 19:24:49 UTC |
