Skip to main content

Browse the archive

swh:1:snp:8b6cd603c373c7896fad0be11acd58f0eca899c6
sort by:
Revision Author Date Message Commit Date
569942c Rune Lillesveen 06 September 2024, 22:43:45 UTC Fixed preferred color-scheme changes based on embedder color-scheme When the preferred color-scheme changes as a result of propagating the preferred scheme set by the embedder without changing the preferred color-scheme setting, media queries were not updated. Call Document::ColorSchemeChanged() to ensure media queries are also updated. Fixes NTP invalidation issue. Bug: 364340032 Change-Id: Ie6f2dbdd76f7370414b9a56709fd2bd66be4f589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5841771 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352336} 06 September 2024, 23:50:50 UTC
3af2d6a Nathan Memmott 06 September 2024, 22:43:38 UTC FSA: Add cleanup to GetDirectory tests These tests are leaving behind files in the root of the Bucket File System. This causes flakiness in other WPTs that expect a clean directory. This CL adds a cleanup function to remove the files they create. Bug: 363601806 Change-Id: Icaae990a0e231a3569aead79a763f48bcd1caba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5842591 Commit-Queue: Nathan Memmott <memmott@chromium.org> Reviewed-by: Christine Hollingsworth <christinesm@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352335} 06 September 2024, 23:50:48 UTC
0f9156c Nate Chapin 06 September 2024, 21:51:28 UTC Ensure TreeWalker operations return Node in its own context, not the receiver's Normally, when Nodes are accessible across frames, we apply the extended attribute [CheckSecurity=ReturnValue] in the IDL. The generated bindings then perform the necessary security checks and wrap the Node in its own context, not the receiver context. TreeWalker is different. The root node is already known to be accessible (otherwise it couldn't be passed to the constructor), and therefore any Node returned by TreeWalker must be accessible, since TreeWalker doesn't walk across frame boundaries. However, the TreeWalker and the Node are not required to be from the same context (I don't know why, it's an old API, this seems like the kind of design flaw we would catch in a modern API). So TreeWalker is in a weird middle ground: it doesn't need security checks, but it does need to wrap any Nodes it returns in the Node's context, not the TreeWalker's context. This CL adds a new extended attribute, [NodeWrapInOwnContext], for TreeWalker (and related APIs, NodeIterator and NodeFilter). When the extended attribute is present, the Node will be wrapped for use in V8 with the Node's v8::Context, not the TreeWalker's v8::Context. Fixed: 324929076 Change-Id: I1359483a9b89f7fcc4d1d522a203e357f2136734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5331177 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352303} 06 September 2024, 22:56:46 UTC
3f8fb00 longsonr 06 September 2024, 11:58:52 UTC Make SVG text position react to CSS zoom Differential Revision: https://phabricator.services.mozilla.com/D221292 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917192 gecko-commit: b896bc387c3a2345340c5dfca7e94de64cb97dde gecko-reviewers: emilio 06 September 2024, 22:11:47 UTC
c14dd61 Olli Pettay 06 September 2024, 10:23:53 UTC trusted coalesced events themselves shouldn't have coalesced events Differential Revision: https://phabricator.services.mozilla.com/D221191 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916657 gecko-commit: 94c97b3688bca06ff27c20ab03c9bbce030f9ac7 gecko-reviewers: masayuki 06 September 2024, 21:54:14 UTC
6096a2d Mason Freed 06 September 2024, 21:12:52 UTC Add testing of switching `appearance` on customizable-<select> picker This new test exercises the `appearance` property on the picker of <select> with `appearance:base-select`. In particular, it tries to change the picker `appearance` while the picker is open. The desired behavior is that doing this closes the picker, and does not re-open it, to avoid both hysteresis and oscillation. This currently hits a few CHECKs in different areas of the codebase, so I can't really evaluate whether all of the test is accurate. Once the crashers are fixed, we can see. Bug: 364924715, 364924718 Change-Id: Ief448bdb0cf9d3d37032ff7bbc257fcea00a1ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840689 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352262} 06 September 2024, 21:30:28 UTC
03bb79a Maks Orlovich 06 September 2024, 21:12:44 UTC FLEDGE: Basic WPT test for a B&A auction. Bug: 361027509 Change-Id: I28445fa803e5d064ec40b6be625857410a6b3b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5802392 Reviewed-by: Russ Hamilton <behamilton@google.com> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352260} 06 September 2024, 21:30:24 UTC
10774e0 Maks Orlovich 06 September 2024, 20:04:16 UTC FLEDGE: WPT test getInterestGroupAdAuctionData more thoroughly. Unlike previous tests that just checked for emptiness/non-emptiness, this fully decrypts/decodes/decompresses the message, and checks for presence of required information. For now, this relies on the VirtualTestSuite configuring a known keyset; we will also need to add some sort of test-only API to do so programmatically to do make it work without one. Bug: 361027509 Change-Id: I81f7d221c4e85a2ac0263925ea5d7c71455b4e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5793398 Reviewed-by: Russ Hamilton <behamilton@google.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352219} 06 September 2024, 20:19:07 UTC
432c4b0 Jean-Philippe Gravel 06 September 2024, 19:24:38 UTC Moved param initialization into finalize() in the Canvas WPT generator Before this CL, the variant grid's params was initialized the first time the grid's `params` property was used. This implicit initialization was confusing because it meant we had to first use `params` at the exact right time. Using it too soon was a bug (before the variant's `expected_img` param is configured for instance). This CL moves the grid's param creation into the `finalize()` method, removing this confusion. Bug: 364549423 Change-Id: I00bee16fe9f2d8ab13f5b05b49b511ffa642e746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836568 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1352203} 06 September 2024, 19:43:50 UTC
45a9cf6 Sam Sneddon 05 September 2024, 23:32:08 UTC Add workflow for Safari Technology Preview This duplicates most of safari_stable.yml, which shows that we really do need to refactor most of this into a reusable workflow, but the short-term win of continuing to have results for Safari outweighs purity here. 06 September 2024, 16:37:45 UTC
22c7c60 Sam Sneddon 17 July 2024, 16:59:35 UTC Add an initial GitHub Actions config to run Safari stable We'll likely want to refactor this into a reusable workflow, especially for Safari Technology Preview, but potentially for any other browsers we want to run on GitHub Actions. However, land this without this refactoring, as the important thing is to land this (and migrate away from Azure Pipelines) in the short term due to impending capacity constraints. This will likely fail in the wpt_fyi_notify.yml workflow until https://github.com/web-platform-tests/wpt.fyi/commit/594077b9c49e026214df4ad5670983260fd98082 is deployed to wpt.fyi. 06 September 2024, 16:37:45 UTC
764274f dependabot[bot] 05 September 2024, 22:50:53 UTC Bump taskcluster from 66.0.0 to 68.0.4 in /tools Bumps [taskcluster](https://github.com/taskcluster/taskcluster) from 66.0.0 to 68.0.4. - [Release notes](https://github.com/taskcluster/taskcluster/releases) - [Changelog](https://github.com/taskcluster/taskcluster/blob/main/CHANGELOG.md) - [Commits](https://github.com/taskcluster/taskcluster/compare/v66.0.0...v68.0.4) --- updated-dependencies: - dependency-name: taskcluster dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> 06 September 2024, 15:33:06 UTC
a63eb83 dependabot[bot] 05 September 2024, 22:50:55 UTC Bump types-requests from 2.32.0.20240602 to 2.32.0.20240905 in /tools Bumps [types-requests](https://github.com/python/typeshed) from 2.32.0.20240602 to 2.32.0.20240905. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> 06 September 2024, 15:32:22 UTC
b20bd4e Ben 06 September 2024, 15:21:23 UTC Additional innerText tests * Additional innerText tests for <p> elements. Check that a <p> generates 2 surrounding line breaks even when set to display:block or display:inline-block * Test that <object> content is ignored in innerText * Test how <details>/<summary> innerText is handled 06 September 2024, 15:21:23 UTC
4a48b52 github-actions[bot] 06 September 2024, 14:19:59 UTC Sync interfaces/ with @webref/idl 3.53.1 (#48011) Co-authored-by: wpt-pr-bot <wpt-pr-bot@users.noreply.github.com> 06 September 2024, 14:19:59 UTC
a75813a David Baron 06 September 2024, 13:36:23 UTC Allow :active-view-transition pseudo-classes after ::part(). Based on the discussion in https://github.com/w3c/csswg-drafts/issues/10806 and also in https://github.com/w3c/csswg-drafts/issues/10787, I think the conclusion from #10806 applies to pseudo-classes as well, and I should reverse my earlier decision to disallow the :active-view-transition pseudo-classes after ::part(), even though today it is not possible for them to match. This makes that change behind the CSSPartAllowsMoreSelectorsAfter flag (status:experimental), which also contains other related changes. This matches WebKit's current implementation of those pseudo-classes. Bug: 40623497 Change-Id: I591fe30bb9e6c3a0953df318919f60dd6962d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839421 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351997} 06 September 2024, 14:14:22 UTC
1f2b488 selya 06 September 2024, 13:09:01 UTC Add test for subresources directed from x-site to same-site Bug: 364911868 Change-Id: I3b4a9c92e43a1fdfb44fb973be8a6221e2652971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836574 Commit-Queue: Aaron Selya <selya@google.com> Reviewed-by: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351987} 06 September 2024, 13:36:18 UTC
d3e7484 selya 06 September 2024, 12:56:58 UTC Add external wpt covering partitioned cookies in top-level redirect Bug: 364902366 Change-Id: Ibbfea822fb879368ad63d581d700dbb46e22133b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839548 Reviewed-by: Steven Bingler <bingler@chromium.org> Commit-Queue: Aaron Selya <selya@google.com> Cr-Commit-Position: refs/heads/main@{#1351984} 06 September 2024, 13:08:55 UTC
ff8ec78 Ting-Yu Lin 06 September 2024, 01:08:30 UTC Part 3 - Add WPTs for table intrinsic size. `table-intrinsic-size-001.html` and `table-intrinsic-size-002.html` test `inline-size` and `max-inline-size` on the table elements, respectively. They currently pass on Nightly, but will fail if the special logic in IntrinsicForAxis() is removed. Since we lacked test coverage for this scenario, I added these tests. `table-intrinsic-size-003.html` and `table-intrinsic-size-004.html` tests the intrinsic size when table has orthogonal writing mode. They fail due to bug 1310551. Differential Revision: https://phabricator.services.mozilla.com/D221237 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917056 gecko-commit: 45b1d3abcc094f2317b53a25b5062ec25332e422 gecko-reviewers: layout-reviewers, emilio 06 September 2024, 09:54:48 UTC
0143fe2 Kagami Sascha Rosylight 06 September 2024, 00:06:12 UTC Update the signal abort algorithm Differential Revision: https://phabricator.services.mozilla.com/D220836 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1903676 gecko-commit: e577f2498b11c1a728eb1009897b1249560b5f02 gecko-reviewers: smaug 06 September 2024, 09:51:32 UTC
1e7a015 Alexandra Borovova 05 September 2024, 14:27:55 UTC [wdspec] Add test for order of "browsingContext.navigationStarted" and "network.beforeRequestSent" events. Differential Revision: https://phabricator.services.mozilla.com/D221131 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916427 gecko-commit: 8d1a7a57dd38682d9555873f83cf9d8f7d786d53 gecko-reviewers: webdriver-reviewers, jdescottes 06 September 2024, 09:42:34 UTC
67d7f3f Shweta Bindal 06 September 2024, 06:12:42 UTC [Editing] Reset |input_type| to |kNone| before character input There is an edge case where |last_typing_command| that is reused for inserting a character does not reset its |input_type| to none. The actual |input_type| will be determined later in |GetInputType()| based on the |command_type|. The changed helpers are: |TypingCommand::InsertParagraphSeparator| |TypingCommand::InsertParagraphSeparatorInQuotedContent| |TypingCommand::InsertLineBreak| |TypingCommand::DeleteKeyPressed| |TypingCommand::DeleteSelection| Bug: 41478041 Change-Id: I7ba178968e95cdba9c6c3c6e2dc5123996cedd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5796102 Commit-Queue: Shweta Bindal <shwetabindal@microsoft.com> Reviewed-by: Siye Liu <siliu@microsoft.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351871} 06 September 2024, 06:34:45 UTC
704c5a8 lisa0314 06 September 2024, 02:06:29 UTC webnn: add IDL and mojo definition of quantizeLinear and dequantizeLinear This CL also implements validation tests in WPT and corresponding `opSupportLimits`. https://github.com/webmachinelearning/webnn/issues/375#issuecomment-2292466613 Bug: 362087883 Change-Id: I09d9ad38c10f3e21de621b9e60ccde8229a7ed25 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5811265 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Lisha Guo <lisha.guo@intel.com> Reviewed-by: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#1351828} 06 September 2024, 02:45:56 UTC
1998d1e Rahul Singh 05 September 2024, 18:08:01 UTC IDB WPTs: Extend IDBCursor update() index WPTs to run on workers This set of IndexedDB WPTs currently only run in a window environment. This change combines them into a single file and extends them to also run in dedicated, shared, and service worker environments. Bug: 41455766 Change-Id: I8b2e05a7fe62be9819bd8f61e5c0cb67a447dc7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836522 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1351557} 06 September 2024, 02:45:53 UTC
9358dc6 Hiroyuki Ikezoe 05 September 2024, 04:47:13 UTC Set the initial visible area with MobileViewportManager. On mobile environments, specifically web contents without meta viewport tags get rendered on 980px width device (i.e. desktop mode), thus using the document viewer size directly for the pres context's visible area would result a resize event. Using MobileViewportManager avoids the resize event. Differential Revision: https://phabricator.services.mozilla.com/D220976 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: cca9937c0323ea91455a7bd6d72a311c89a4c475 gecko-reviewers: emilio, botond 06 September 2024, 00:14:16 UTC
b8f0754 Hiroyuki Ikezoe 05 September 2024, 04:47:12 UTC Add meta viewport to make the tests work as intended on mobile. On our CI for Android, the device screen width is 800, without meta viewport Gecko tries to render such documents in 980px width canvas, thus the document gets scaled by 0.816326531 (= 800 / 980), with this scale the tests in this change will not work as intended with the next commit. There will be two failure cases; 1) the content is not scrollable because of the scale abspos-contributes-to-static-parent-bounds.html is one of this category 2) fractional scroll position difference (or some such) because of our scroll position rounding / pixel alignment issues Differential Revision: https://phabricator.services.mozilla.com/D220975 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: 3f775b657457e8dcaabe3156b67e6af5fb3282c1 gecko-reviewers: emilio 06 September 2024, 00:14:16 UTC
34246e8 Hiroyuki Ikezoe 05 September 2024, 04:47:11 UTC Add meta viewport to make the test consistent with the fix for bug 1768527. Similar to the previous commit, we will track this unexpected pass in bug 1916568. Differential Revision: https://phabricator.services.mozilla.com/D220974 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: de576a4406e0ed63262d5e5b3e29e1624ccfbaee gecko-reviewers: emilio 06 September 2024, 00:14:16 UTC
247ae23 Hiroyuki Ikezoe 05 September 2024, 04:47:10 UTC Add meta viewport to make the test consistent with the fix for bug 1768527. I have totally no idea why some test cases in table-rows-with-zero-columns.html pass with the meta viewport, we will track it in bug 1916567. Differential Revision: https://phabricator.services.mozilla.com/D220973 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: a504b7a18e2c44c50059ccf7a4d76c4cc360dee0 gecko-reviewers: emilio 06 September 2024, 00:14:16 UTC
3b88206 Hiroyuki Ikezoe 05 September 2024, 04:47:09 UTC Add meta viewport to make the tests work as same as desktops. Differential Revision: https://phabricator.services.mozilla.com/D220972 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: b76812613c498be260a3960273b456cf5545f3df gecko-reviewers: emilio 06 September 2024, 00:14:16 UTC
02ae482 Hiroyuki Ikezoe 05 September 2024, 04:47:08 UTC Add meta viewport to make the tests work as intended on mobile. Differential Revision: https://phabricator.services.mozilla.com/D220971 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1768527 gecko-commit: 1b45563a111411682d21e672019f70a8e28c12f0 gecko-reviewers: masayuki 06 September 2024, 00:14:16 UTC
5a9069b longsonr 05 September 2024, 07:31:58 UTC zoom polygons and polylines Differential Revision: https://phabricator.services.mozilla.com/D221079 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916111 gecko-commit: 74045e7e11c7e5e114b741140ccde451de763691 gecko-reviewers: emilio 06 September 2024, 00:06:54 UTC
e31406c Jean-Philippe Gravel 05 September 2024, 23:03:41 UTC Simplify directory creation in canvas WPT generator Bug: 364549423 Change-Id: I42ddc8b332752eb66ca7efa35b100bc41c672b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840027 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351760} 05 September 2024, 23:29:57 UTC
91ed316 Morten Stenshorne 05 September 2024, 21:57:45 UTC Add some basic pagination tests. Testing various basic things, such as several break-before:page / combined with break-after:avoid, and also that the implementation actually supports multiple pages, and doesn't just output the first or last page. break-after: page at the same break opportunity, break-before:page Change-Id: Iae645a98d602f7914c04c58e7ae647ca0c490f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5831010 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351698} 05 September 2024, 22:35:06 UTC
e19fa52 fantasai 05 September 2024, 21:22:49 UTC [css-text-decor] Add test for omitted text-emphasis-position values 05 September 2024, 21:36:26 UTC
9eafafc Andreu Botella 05 September 2024, 21:03:30 UTC [line-clamp] Change the computed value of `display: -webkit-box` when used with `line-clamp` The legacy `-webkit-line-clamp` CSS property requires the properties `display: -webkit-box` (or `-webkit-inline-box`) and `-webkit-box-orient: vertical` to work. These keywords of the `display` property are legacy versions of `flex` (and `inline-flex`), but in modern implementations of `-webkit-line-clamp` (including the LayoutNG one) they instead create a BFC when all three properties are present. In Chromium's implementation this was done by creating a `LayoutBlockFlow` rather than a `LayoutFlexibleBox` when creating a layout object for the element. However, Gecko instead set the computed value of `display` to `flow-root` (or `inline-block`). In https://github.com/w3c/csswg-drafts/issues/10435 the CSSWG resolved to go with Gecko's behavior on this. This patch implements this computed style adjustment. For web compatibility, it must still be the case that `-webkit-line-clamp` will not do anything if the specified value of `display` is not `-webkit-box` (or `-webkit-inline-box`). Therefore, this patch needs to add a computed style extra field `IsSpecifiedDisplayWebkitBox` to track this state. This behavior is implemented behind an enabled-by-default runtime flag so it can be easily rolled back if web compatibility issues are found. Bug: 40336192, 346759535, 362756798 Change-Id: Id5737af8d01f8cd450a379cbd088951a2a14058b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836688 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1351678} 05 September 2024, 21:34:14 UTC
0cb5593 Weizhong Xia 05 September 2024, 18:20:50 UTC Add an empyt pytest.ini file for webdriver tests pytest will look for pytest.ini file to determine the value for rootdir. With this file added, pytest will always set rootdir to webdriver/tests. Webdriver tests currently fail on the Android WPT builder[1]. The reason is that rootdir is set to some subdirectory of webdriver/tests, e.g. /tmp/wpt/webdriver/tests/classic/navigate_to, and that caused fixtures inside the support directory can not be found. [1] https://ci.chromium.org/ui/p/chromium/builders/ci/android-chrome-pie-x86-wpt-fyi-rel Bug: 364109563 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I7adf0ef64cb591f60c21259701ba58ee736f4997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838000 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351242} 05 September 2024, 21:03:24 UTC
a4301e8 Joey Arhar 05 September 2024, 19:04:29 UTC Set focus when base-select popover is closed When base-select's popover is closed, we should focus the invoker button. Without this, keyboard navigation is broken. Fixed: 40263709, 40286771 Change-Id: Ic40090a8617d7f67212f35ebc0b021f4f65b3377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5825735 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351591} 05 September 2024, 19:39:53 UTC
562e2b6 David Grogan 05 September 2024, 18:49:37 UTC [flexbox] Update tests for 'new' column flexbox intrinsic sizing These tests are not included in interop2024 scoring. So even though other engines will start to fail these tests after this patch, no interop2024 scores will suffer. Bug: 40425575 Change-Id: I06953a5be2ab14de86eccf31145041e84918e36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840308 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351580} 05 September 2024, 19:39:50 UTC
661e368 Jean-Philippe Gravel 05 September 2024, 18:20:59 UTC Fix invalid path concatenations in Canvas WPT generator Paths were concatenated with hard-coded forward slashes, which is not valid on Windows. Bug: 364549423 Change-Id: I0129e360ee3066c8957c49090f1546cce27e9903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839987 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351567} 05 September 2024, 19:39:47 UTC
64330f3 Jocelyn Tran 05 September 2024, 18:25:11 UTC Remove ex-generic selector in wai-aria/roles/contextual-roles.html (#47966) 05 September 2024, 18:25:11 UTC
0fd88b0 Jean-Philippe Gravel 05 September 2024, 17:56:15 UTC Move colr-glyph-composition test to manual folder This test was recently added in commit: https://github.com/web-platform-tests/wpt/commit/0bf584aaaa3140965d30aa2cfb2d93a39c10d524 It's a manually written test, but it was placed in a folder containing only generated files. This CL moves the test to the "manual" folder. Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1902253 Change-Id: I4832667711b3fe62e3d290c03a9d49a6742fb391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836235 Reviewed-by: Andres Ricardo Perez <andresrperez@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351535} 05 September 2024, 18:07:55 UTC
a7a7cde Olga Gerchikov 05 September 2024, 17:43:39 UTC Speculative attempt to unflake one-custom-property-animation.https.html - Deleted custom-property-animation-on-main-thread.https.html which is identical to one-custom-property-animation.https.html. - Restructured one-custom-property-animation.https.html, added logging. Bug: 40215935 Change-Id: I25cca07c92d018a68c65ebae5213e9fdc75cfc1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5827942 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351530} 05 September 2024, 18:07:51 UTC
0745979 David Grogan 05 September 2024, 17:09:24 UTC [layout] Support justify-self:safe for blocks Change-Id: Iae1ab849b7a81734b1e650eb649821cde184101b Bug: 355683658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5809577 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351501} 05 September 2024, 17:43:35 UTC
67a07c1 David Baron 05 September 2024, 16:19:42 UTC Add tests to test the distinction between legacy name aliases and legacy shorthands. This is a followup to the discussion in https://github.com/w3c/csswg-drafts/issues/8014 and tests the concepts in https://drafts.csswg.org/css-cascade-5/#aliasing partly using the rules in https://drafts.csswg.org/css-variables/#substitution-in-shorthands . Bug: 40834250 Change-Id: Ic8c2044a091ec609bb447c739052888a4ec6e603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5838006 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#1351453} 05 September 2024, 16:33:29 UTC
5237b49 Oriol Brufau 04 September 2024, 10:56:37 UTC Treat `align-self: normal` as `stretch` on flex items According to https://drafts.csswg.org/css-align/#align-flex It was being treated as `auto` instead. Signed-off-by: Oriol Brufau <obrufau@igalia.com> 05 September 2024, 12:23:54 UTC
5768389 Ari Chivukula 05 September 2024, 11:33:10 UTC [Partitioned Popins] Sec-Popin-Context Request Header This CL implements the HTTP Request Header Sec-Popin-Context which is sent on top-level navigations/redirects within a popin. Explainer: https://explainers-by-googlers.github.io/partitioned-popins/ I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/ Bug: 340606651 Change-Id: I25ad7dd85197b549da5bf1e6d117edc7db6ffc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836978 Commit-Queue: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351341} 05 September 2024, 11:59:15 UTC
23a2954 Steinar H. Gunderson 05 September 2024, 10:57:22 UTC Fix error recovery after invalid var() in unparsed declarations. If hitting an invalid var() while in a block, we would go into error recovery mode and eat tokens until we are back at the top level. However, since we did “break”, we did not reach the “continue” statement that would jump over the otherwise-used logic of incrementing the block level counter. Fundamentally, this comes from the issue that in C++, break and continue in the same context can refer to entirely different loop constructs (in this case, a switch and a for loop). Fixed: 364443009 Change-Id: I54356afa37afffe590e04810cda0c14ac386487c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839697 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351326} 05 September 2024, 11:33:03 UTC
d93d2f2 Garima Chadha 05 September 2024, 10:10:06 UTC IDB WPTs: Extend Keygenerator tests to workers The update modifies keygenerator related WPTs to run not only in window environments but also on dedicated, service, and shared workers. Bug: 41455766 Change-Id: If5f6f80d5e74a6ecc57f80a9844dc5e81dcd16bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5822974 Commit-Queue: Garima Chadha <garimachadha@microsoft.com> Auto-Submit: Garima Chadha <garimachadha@microsoft.com> Reviewed-by: Abhishek Shanthkumar <abhishek.shanthkumar@microsoft.com> Reviewed-by: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1351307} 05 September 2024, 10:33:34 UTC
d7ae7c1 wpt-pr-bot 12 August 2024, 01:01:38 UTC Automated regeneration of WPT certificates 05 September 2024, 10:31:50 UTC
5bbb9af Sean Feng 04 September 2024, 16:10:10 UTC Cancel the loading=lazy iframe when it's load via a different way Differential Revision: https://phabricator.services.mozilla.com/D218143 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1882670 gecko-commit: 40f19af2bb8a71854d19ffd4a9a3606713c6ef81 gecko-reviewers: emilio, webdriver-reviewers 05 September 2024, 07:48:25 UTC
9428df8 rubberyuzu 05 September 2024, 06:35:38 UTC [bfcache] Unblock broadcastchannel on dedicated worker This CL... (1) changes the reporting name of broadcastchannel eviction to match the spec (2) support dedicated worker (pages with broadcastchannel on dedicated worker can enter bfcache). The messages sent to broadcastchannel in dedicated worker while in bfcache are queued and delivered upon bfcache restore. This was already done thanks to dedicated worker's freezing mechanism. Bug:327075943 Change-Id: Iea7fdd4024f54dd6306334437ba80030feb9a0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526694 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351244} 05 September 2024, 07:34:09 UTC
833120c Emilio Cobos Álvarez 04 September 2024, 22:22:51 UTC Track color-scheme dependencies for non-inherited rule cache. Differential Revision: https://phabricator.services.mozilla.com/D220134 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914735 gecko-commit: c30c633bc68b4e4b8251bf2d8dff8dfcae911a3b gecko-reviewers: firefox-style-system-reviewers, boris 05 September 2024, 07:33:30 UTC
d575dc7 Ming-Ying Chung 05 September 2024, 02:07:05 UTC Update FetchLaterAPI to not use "deferred-fetch" for now The [discussion][1] is not yet finalized, but we want to extend OT for other partners. [1]: https://github.com/WICG/pending-beacon/issues/87#issuecomment-2315624105 Bug: 40276121 Change-Id: I6f163add73707be7b9c2b34d58dce22542621293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5833346 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Ming-Ying Chung <mych@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351171} 05 September 2024, 02:41:12 UTC
3bbea9e Kevin Babbitt 05 September 2024, 00:41:22 UTC Refactor UnresolvedColorMix to support unresolved relative colors Split off UnresolvedColorFunction as a base class of UnresolvedColorMix and implement a new derived class UnresolvedRelativeColor to represent unresolved relative colors. Exercise the new class in a WPT by checking that we can serialize an unresolved relative color out to computedStyleMap. Bug: 325309578 Change-Id: Ie28ec93ac6b2f36735d619ef3a56290618b692ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5785061 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351129} 05 September 2024, 00:53:46 UTC
b68ac84 Bryan Bernhart 04 September 2024, 21:35:04 UTC WebNN: rename IDL to use MLTensor Strictly replaces uses of MLBuffer* related IDL types to use MLTensor*. This will be one of multiple CLs to split up WebNN's renaming of MLTensor to MLBuffer to avoid merge conflicts. Bug: 361372446 Change-Id: I34dff70eb77d2096e23d202ed1fd2cf459363b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837821 Reviewed-by: Austin Sullivan <asully@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com> Cr-Commit-Position: refs/heads/main@{#1351057} 04 September 2024, 23:30:20 UTC
0277003 Sahir Vellani 04 September 2024, 20:46:22 UTC Set overflow: hidden for scroll snap test body The test is flaky on Linux because the rightmost box in the line occasionally exceeds the width of the viewport. This may be due to calculations related to viewport width with scrollbars. Turning the scrollbars off may help reduce flakiness. This is a speculative fix. Bug: 363881422 Change-Id: I207a6f614ecb90c5cb11ae29dbd8e32943deaf8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836267 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1351033} 04 September 2024, 21:25:21 UTC
3fed65b Alvin Ji 04 September 2024, 20:09:24 UTC bluetooth: Use WebBluetoothCompanyPtr as HashMap key to avoid hash collisions This CL switches the key type in a Bluetooth manufacturer data HashMap from uint16_t to WebBluetoothCompanyPtr. This prevents collisions with reserved hash values in WTF::HashMap, enabling the use of the full uint16_t range for manufacturer UUIDs. Bug: 356891475 Change-Id: I92da63bf834e9d0d5d2bc77d8ddbde2eba067d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775642 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Jack Hsieh <chengweih@chromium.org> Commit-Queue: Alvin Ji <alvinji@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351008} 04 September 2024, 20:37:29 UTC
f427091 Adam Klein 04 September 2024, 19:00:34 UTC [wpt] Fix null-handling in `equals` JS String Builtins Equals specifically allows null inputs. Update the JS API tests and the polyfill to match, and remove expectations files now that the `basic` tests pass. The test changes are mirrored in an upstream PR: https://github.com/WebAssembly/js-string-builtins/pull/43 Bug: 42204114 Change-Id: I170f7e26e80033844a1d3e95fbe998d5f64f4a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836264 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350946} 04 September 2024, 19:34:07 UTC
5ef7907 Rune Lillesveen 04 September 2024, 18:33:51 UTC Forward SetScrollsnapchangeTargetIds to LayoutViewport() The RootFrameViewport did not implement forwarding of SetScrollsnapchangeTargetIds to the LayoutViewport() which meant triggering snapchange did not always work correctly. Specifically, a change in scroll-snap-type did not trigger the event. Bug: 364466903 Change-Id: I97fdd02a72dace4e74bc7fbf03f08fd396e87ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5830358 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: David Awogbemila <awogbemila@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350940} 04 September 2024, 19:34:04 UTC
93fe398 Tim Nguyen 04 September 2024, 18:44:37 UTC WebKit export: [view-transitions] Update callback can be called twice (#47963) https://bugs.webkit.org/show_bug.cgi?id=279087 04 September 2024, 18:44:37 UTC
dc910c7 Sandor Major 04 September 2024, 17:15:44 UTC [Partitioned Popins] Implement `popinContextTypesSupported()` JS API This CL implements `window.popinContextTypesSupported()` that returns the supported popin context types. Explainer: https://explainers-by-googlers.github.io/partitioned-popins/ I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/ Low-Coverage-Reason: COVERAGE_UNDERREPORTED Tested through WPTs. Bug: 340606651 Bug: b/362973176 Change-Id: I02b2a75778610a5d23ca929b328fbcdd21fa9403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5822620 Reviewed-by: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sandor «Alex» Major <sandormajor@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350876} 04 September 2024, 18:17:14 UTC
c8fad8c Joey Arhar 04 September 2024, 17:25:35 UTC Require ::picker(select) appearance:base-select opt-in This patch requires that not only appearance:base-select be applied to <select> to make the popup be a popover, but also for appearance:base-select to be applied to select::picker(select). This is being discussed here: https://github.com/w3c/csswg-drafts/issues/10440 Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5819694 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350885} 04 September 2024, 17:43:05 UTC
a154121 Sandor Major 04 September 2024, 17:15:51 UTC [Partitioned Popins] Implement `popinContextType()` JS API This CL implements `window.popinContextType()` that tells whether a page is inside of a Partitioned Popin. Explainer: https://explainers-by-googlers.github.io/partitioned-popins/ I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/ Low-Coverage-Reason: COVERAGE_UNDERREPORTED Tested through WPTs. Bug: 340606651 Bug: b/362973178 Change-Id: I053512217160d4875e7558be35eda3a3bbace833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826165 Reviewed-by: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sandor «Alex» Major <sandormajor@google.com> Cr-Commit-Position: refs/heads/main@{#1350877} 04 September 2024, 17:43:02 UTC
ab72b1d Mustaq Ahmed 04 September 2024, 15:54:22 UTC Add a WPT for coalesced event attributes on redispatch. The test is tentative due to: https://github.com/w3c/pointerevents/issues/514 Bug: 353538500 Change-Id: Id3ead2029e84a3100573558adbd7c14c272e821f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823713 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350816} 04 September 2024, 16:17:42 UTC
0e3495a Andres Ricardo Perez 04 September 2024, 13:22:53 UTC Add meta charset tag to canvas generator templates In order to fully test canvas text-related features, it is necessary to use different alphabets and special characters for coverage. Before this change, several special characters, for example the arabic alphabet and emojis, weren't actually supported when run from the WPT testing toolkit. This CL adds the `<meta charset="UTF-8">' line to all generator templates, and includes the results of running the generator. All generated files are modified, but only by adding this line. One test that uses special characters failed after updating the encoding (2d.text.measure.caret-position.tentative). This was added to the test expectations. See: https://crbug.com/364332944 Bug: 341213359, 364332944 Change-Id: I7acf60298ac49b790d58100044c2e6412011093d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817356 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org> Commit-Queue: Andres Ricardo Perez <andresrperez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350746} 04 September 2024, 16:06:05 UTC
ccbf285 Daniil Sakhapov 04 September 2024, 11:28:10 UTC Use length resolver for palette-mix() This CL adds length resolver to resolve calc() expressions inside palette-mix(). It also changes some code around it, that depends on the same functions. In some places where we don't have access to length resolver, for now, we will use default length resolver, with TODOs being placed there not to forget to deal with them later. Also, in this CL the correct interpolation is not addressed and it will be rewritten in following CL. Bug: 40946458 Change-Id: I74e808429ef50bcd689efc100e388af814c6c729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5831439 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350706} 04 September 2024, 11:44:59 UTC
eee46f0 Daniil Sakhapov 04 September 2024, 09:22:02 UTC Replace GetFloatValue with Compute* with length resolver for zoom Bug: 40946458 Change-Id: If2d5916fbc0f10b78ca228271b954717767143ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5833871 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350665} 04 September 2024, 10:26:52 UTC
6f16dba Matt Woodrow 03 September 2024, 21:50:02 UTC WebKit export of https://bugs.webkit.org/show_bug.cgi?id=278759 04 September 2024, 09:15:59 UTC
d461afe Matt Woodrow 03 September 2024, 21:35:23 UTC WebKit export of https://bugs.webkit.org/show_bug.cgi?id=279085 04 September 2024, 07:46:57 UTC
6d0d25c Karl Tomlinson 04 September 2024, 00:02:50 UTC skip highest start time comparison on duration change from endOfStream Microsecond truncation of duration but not highest start time was sometimes causing inappropriate InvalidStateError. HighestStartTime() is more efficient than and equivalent when Ended to GetHighestBufferedEndTime(), which constructs full TimeIntervals. Use ToBase(USECS_PER_S) for rounding for consistency with the SourceBuffer.buffered getter. Differential Revision: https://phabricator.services.mozilla.com/D220853 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916306 gecko-commit: 8a75f012299872cd99b281b82756046ff953b1ec gecko-reviewers: padenot 04 September 2024, 07:43:45 UTC
d7dae7e Boris Chiou 03 September 2024, 20:01:56 UTC Part 2: Support :only-child for view transition selectors. Introduce the concept of pseudo element tree and make sure we achieve the following behaviors: 1. `::view-transition` doesn't accept any non-functional pseudo class after it. 2. `::view-transition-*(name)` accepts only `only-child` pseudo class after it. So for named view transition pseudo elements, we make them accept non-functional pseudo classes and tree structural pseudo classes after them, for consistency. However, only `:only-child` is allowed. Differential Revision: https://phabricator.services.mozilla.com/D219714 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1911216 gecko-commit: 2a950d7be993124346592385bb82f3d3207fe9bf gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, emilio 04 September 2024, 07:43:01 UTC
58e5dfb Ting-Yu Lin 03 September 2024, 16:05:58 UTC Add two WPTs where the descendant has aspect-ratio and percentage height. The two testcases are adapted from Daniel Holbert's testcase 1 and 2 in the bug. Both are fixed by bug 1909761. Differential Revision: https://phabricator.services.mozilla.com/D220363 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1748339 gecko-commit: ec726d591b2f6ad7b1991444014156ed2bf921e7 gecko-reviewers: dholbert 04 September 2024, 07:41:46 UTC
ca9fddb Miao Bin 04 September 2024, 06:04:01 UTC WebNN: Add support limits for conv2d and convTranspose2d This CL adds data type support limits for `conv2d` and `convTranspose2d` operators. Bug: 345271830 Change-Id: I7488a7c6615672a5b10b3b98fb555667cf46bdcf Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5831063 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Reviewed-by: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350604} 04 September 2024, 06:22:13 UTC
957b628 Shiyi Zou 04 September 2024, 00:42:27 UTC webnn: add support limits for `batchNormalization` and more This CL adds data type support limits for `batchNormalization` `gru` `gruCell` `instanceNormalization` `layerNormalization` `lstm` and `lstmCell`. Bug: 345271830 Change-Id: I28644093140865e5bda68c3cfd53f55ff7b83f0f Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Fuchsia-Binary-Size: Size increase is unavoidable. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5821811 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: Phillis Tang <phillis@chromium.org> Auto-Submit: Shiyi Zou <shiyi.zou@intel.com> Commit-Queue: Shiyi Zou <shiyi.zou@intel.com> Cr-Commit-Position: refs/heads/main@{#1350512} 04 September 2024, 01:01:55 UTC
71420fd ChangSeok Oh 03 September 2024, 21:23:55 UTC Refine font-size-adjust-computed.html with precision adjustment for from-font tests The aspect value for font_size_adjust can vary slightly depending on font configurations. We initially fixed this by rounding the adjusted font size, but font-size-adjust-computed.html still wasn't happy. This update reverts the previous change and applies assert_approx_equals with a 0.00001 delta to the failing tests instead. Bug: 346773492 Change-Id: Ie18a79e877b1c9ec1bbec38a899d77c15bcc22d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799249 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: ChangSeok Oh <changseok.oh@bytedance.com> Cr-Commit-Position: refs/heads/main@{#1350393} 03 September 2024, 21:50:42 UTC
f201057 Matt Woodrow 03 September 2024, 01:00:53 UTC WebKit export of https://bugs.webkit.org/show_bug.cgi?id=277988 03 September 2024, 21:34:26 UTC
e7c680f Jonatan Klemets 03 September 2024, 08:24:25 UTC Part 20: Fix URL encoding in JSON module WPT tests We need to encode `content_type` by calling `encodeURIComponent`. Otherwise, the plus sign is treated as a space. Differential Revision: https://phabricator.services.mozilla.com/D218212 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1877792 gecko-commit: b0bf3998767e7d3dd70742809af2f41b48b553bd gecko-reviewers: spidermonkey-reviewers, jonco 03 September 2024, 20:18:06 UTC
e80aab4 Brandon Stewart 03 September 2024, 20:08:26 UTC WebKit export: Fix masonry-intrinsic-sizing-cols-002-expected.html fixed + auto + fr scenario (#47946) https://bugs.webkit.org/show_bug.cgi?id=278059 03 September 2024, 20:08:26 UTC
e3b7f2d Daniel Clark 03 September 2024, 19:52:36 UTC [ReferenceTarget] Add field to ShadowInit dict Add a field to ShadowInit dict that can be used to set referenceTarget upon creation of a new ShadowRoot. Bug: 353750121 Change-Id: If122fd64a77793b7cbe7a6f6bce860c2e402637c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829611 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350348} 03 September 2024, 20:02:51 UTC
c639183 Morten Stenshorne 03 September 2024, 17:58:28 UTC Reland "Support z-index on page margin boxes." This time without causing https://ci.chromium.org/ui/p/chromium/builders/ci/lacros64-archive-rel/119842/overview Original change's description: > Revert "Support z-index on page margin boxes." > > This reverts commit ec8a3455717b6e1bec96c86d44fbce326aab79e3. > > Reason for revert: broke the tree > > Original change's description: > > Support z-index on page margin boxes. > > > > If page margin boxes overlap with each other (which should be rare and > > normally not ideal and probably ugly), z-index may be used to specify > > paint order (default paint order being clockwise from top left corner > > margin box). > > > > This CL implements that, except that we cannot control the actual > > paginated content (the page area), which will be painted on top of > > everything else unconditionally, since it's in a separate layer. See > > crbug.com/363031541 > > > > Move paginated root / page container paint code into a separate function > > (rather than adding more code to the main paint machinery), and add > > support for z-index on children there. > > > > Also make sure that page border box fragments are set up to paint > > atomically, just like page margin box fragmets, or the page border would > > be painted in the background phase, and margin borders in the foreground > > phase (which is the phase that paints everything when painting is > > atomic). > > > > Bug: 40341678 > > Change-Id: I480ebf8e8fc2478dfa28163cd001b22371295270 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828544 > > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1349371} > > Bug: 40341678 > Change-Id: I547f5709a29eef90b865edfea159bb440e762593 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828933 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Owners-Override: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Owners-Override: Frank Liberato <liberato@google.com> > Cr-Commit-Position: refs/heads/main@{#1349377} Bug: 40341678 Change-Id: Id7c382af4e6e4668b5b96cfbb5cb7151c6ef85f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829205 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350248} 03 September 2024, 18:10:55 UTC
8c85e2c Matthieu Dubet 03 September 2024, 17:29:16 UTC WebKit export: [CSS] Contextually invalid selectors have a specificity of 0 (#47896) https://bugs.webkit.org/show_bug.cgi?id=277739 03 September 2024, 17:29:16 UTC
3e8deb5 Jonathan Lee 03 September 2024, 16:46:53 UTC [wptrunner] Reland "Implement `--leak-check` for Blink-based browsers" (#47903) This PR relands #47850 with two fixes: * Introduce `ProtocolPart.after_connect()`, then fetch the initial leak counters there after the `base` protocol part is initialized. This avoids requiring `base` to be `setup()` before `leak`, which was true by happenstance. * Tolerate `ExecutorBrowser` without `leak_check`, since some browsers that don't inherit from `ChromeBrowser` still use `ChromeDriverProtocol` sometimes (e.g., print-reftests for Chrome on Android). `ChromeDriverProtocol` still excludes its `leak` part altogether if `leak_check=False` to avoid running `after_connect()`. 03 September 2024, 16:46:53 UTC
6dddd38 mattwoodrow 03 September 2024, 15:42:45 UTC WebKit export: css-view-transitions/navigation/pageswap-ctor.html is (still) a flaky failure (#47935) https://bugs.webkit.org/show_bug.cgi?id=279045 Co-authored-by: Matt Woodrow <m_woodrow@apple.com> 03 September 2024, 15:42:45 UTC
2ee6fef Tim Nguyen 03 September 2024, 15:41:07 UTC WebKit export: [view-transitions] Skip view transition on hidden pages (#47931) https://bugs.webkit.org/show_bug.cgi?id=271248 03 September 2024, 15:41:07 UTC
a7e494b Daniil Sakhapov 03 September 2024, 13:57:27 UTC Replace GetDoubleValue for filter operations This CL replaces GetDoubleValue calls with Compute* calls with resolve data, it also changes InterpolableFilter value to support expressions. Bug: 40946458 Change-Id: I6f48cdc8282c01af173f3808fb07cb5eb58aa82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5830482 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350125} 03 September 2024, 14:14:17 UTC
a8d8c61 Morten Stenshorne 03 September 2024, 12:44:27 UTC Implement background-origin for @page backgrounds. Since the @page background is painted at the page container fragment, whereas borders and padding are part of the page border box child fragment, some extra work is required. Paginated fragment structure documented here: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/paginated_root_layout_algorithm.h;l=24-61;drc=01ab59ae08a38a361da7dac41e36f387f6600ed5 Bug: 40286153 Change-Id: I778c40a0c6d3cecd48c7f5d32a4f9071a5e618bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828871 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1350103} 03 September 2024, 13:20:14 UTC
0dfa2b8 Ting-Yu Lin 03 September 2024, 04:31:22 UTC Part 5 - Add web-platform reftests for percentage resolution during intrinsic size computation. All the tests pass in Google Chrome. They fail in the current Firefox Nightly but will pass with the patches in this bug. `intrinsic-percent-replaced-{012,013,014}.html` are adapted from the second testcase in bug 1231059 comment 0. `intrinsic-percent-replaced-{015,016}.html` are adapted from the testcase in bug 1800991 comment 2. `intrinsic-percent-replaced-017.html` is adapted from bug 1910290 comment 7. `intrinsic-percent-replaced-018.html` is adapted from dholbert's review comments in https://phabricator.services.mozilla.com/D219523#inline-1222435 Differential Revision: https://phabricator.services.mozilla.com/D219524 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1909761 gecko-commit: 4646bfebde8f95d2994a3336aeba92dd67a5b101 gecko-reviewers: dholbert 03 September 2024, 12:07:49 UTC
29c39a3 Emilio Cobos Álvarez 02 September 2024, 22:18:57 UTC Fix dir-shadow-39.html. The reference is just wrong. The spec says that unassigned nodes have no computed styles (they have nothing to inherit from). https://drafts.csswg.org/cssom/#dom-window-getcomputedstyle step 5: > If obj is not null, and elt is connected, part of the flat tree, and > ... Unassigned fallback content is not part of the flat tree, so we fail that check. Differential Revision: https://phabricator.services.mozilla.com/D220275 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1908067 gecko-commit: f87404cfc945bcecb551c6f482053bc9ef157168 gecko-reviewers: smaug 03 September 2024, 11:59:53 UTC
8dc9f0f Morten Stenshorne 03 September 2024, 10:55:31 UTC Ignore background-clip for @page backgrounds. See https://drafts.csswg.org/css-page-3/#painting Since the background painting area for the page box is the bleed area, which covers the entire page box, including its margins, background-clip should be ignored (treated as border-box). See also https://www.w3.org/TR/css-backgrounds-3/#background-clip and how the "root element has a different background painting area". Bug: 40286153 Change-Id: I45ff3ccd9e1a2b8c1b0759154fc01c132480800a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828872 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1350071} 03 September 2024, 11:17:40 UTC
31e23bc Butkovits Atila 02 September 2024, 10:00:43 UTC Backed out changeset e721121e5f57 (bug 1761634) for causing several issues with WebDriver clients. a=backout gecko-commit: c9a192c047cde29cd4369733df6c27c9326990e9 gecko-reviewers: backout 03 September 2024, 08:41:21 UTC
0b63da4 Andrea Marchesini 03 September 2024, 08:01:19 UTC Fix Intermittent failure in testing/web-platform/tests/webdriver/tests/bidi/network/continue_response/cookies.py Differential Revision: https://phabricator.services.mozilla.com/D220806 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916221 gecko-commit: a3575533802589a50ff0848d15368bb6ae1944c2 gecko-reviewers: webdriver-reviewers, Sasha 03 September 2024, 08:37:17 UTC
332a39b Mirko Brodesser 02 September 2024, 14:02:48 UTC part 2) Add WPT for checking reported CSP violations of sink type mismatches for `Element.insertAdjacentHTML`. Differential Revision: https://phabricator.services.mozilla.com/D217441 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1907928 gecko-commit: c068236b5f19c31eab8581e0256cadedee1ae497 gecko-reviewers: tschuster 02 September 2024, 22:11:09 UTC
f1b9fda Frédéric Wang 02 September 2024, 14:25:40 UTC Make MathML boolean attributes ASCII case-insensitive. This commit ensures MathML boolean attributes (namely displaystyle, mo@stretchy, mo@symmetric, mo@largeop, mo@movablelimits, munder@accentunder, mover@accent, munderover@accent, munderover@accentunder) are ASCII case-insensitive [1]. For displaystyle that was handled in [2]. For mover/munder/munderover attributes, this is covered by a test case from scriptlevel-001.html checking both case-insensitivity and dynamic changes at the same time ; the latter still seems broken, so these checks are moved into separate test cases. For mo attributes, a new WPT test is added. Note that mo@accent, mo@fence, mo@separator are not part of MathML Core (with the two last without visual effect), we make them case-insensitive for consistency but don't bother adding tests for them. [1] https://w3c.github.io/mathml-core/#dfn-boolean used here: [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1574087 Differential Revision: https://phabricator.services.mozilla.com/D218944 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1912435 gecko-commit: 7e71291be84261d2df2606da19bc61ac14f6c207 gecko-reviewers: emilio 02 September 2024, 22:09:42 UTC
9a99461 Andrea Marchesini 02 September 2024, 08:02:06 UTC Implement a max-age cap for cookies Differential Revision: https://phabricator.services.mozilla.com/D219216 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1913161 gecko-commit: 0a6895f886e745c4f276478099fd5744454187d3 gecko-reviewers: devtools-reviewers, cookie-reviewers, timhuang, webdriver-reviewers, Sasha 02 September 2024, 22:07:52 UTC
0f49329 Emilio Cobos Álvarez 02 September 2024, 17:50:42 UTC Map pattern/gradientTransform to the transform property. And fix a typo in a test which got me confused. Differential Revision: https://phabricator.services.mozilla.com/D220728 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914221 gecko-commit: fca4f8856943e88f8d7901826d4d6d5f100f06c6 gecko-reviewers: longsonr 02 September 2024, 21:59:49 UTC
f89ace0 Lingqi Chi 02 September 2024, 19:09:35 UTC [text-box-trim] add test for before and after pseudo elements Bug: 40254880 Change-Id: I797294696cace0236997f45cacddc3ac967d198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5815191 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/main@{#1349916} 02 September 2024, 19:58:24 UTC
b4e8422 David Baron 02 September 2024, 15:14:35 UTC Allow almost all other pseudo-elements after ::part(). This allows, behind the CSSPartAllowsMoreSelectorsAfter flag (status:experimental), using almost any pseudo-element other than ::part() itself after ::part(). It does not allow ::slotted(); see link to relevant spec issue in the code comments. NOTE: Some of the added tests are failing due to getComputedStyle() returning element styles for UA shadow pseudo-elements. See crbug.com/363015176. Bug: 40825557, 363015176 Change-Id: I85d11146c494407f2a6263b444ceed7bdd1ab4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823774 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1349865} 02 September 2024, 15:34:17 UTC
9c29d4e Anders Hartvoll Ruud 02 September 2024, 10:06:33 UTC [css-nesting] Add CSSNestedDeclarations support for insertRule As part of the overall CSSNestedDeclarations change, the "insert a CSS rule" algorithm [1] now includes a step to retry parsing of a failed rule as a CSSNestedDeclarations rule [1]. This CL implements that change. [1] https://drafts.csswg.org/cssom/#insert-a-css-rule Bug: 343463516 Change-Id: I4b81da404a26cc036a3fcf0aebdbef0775eac0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826512 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1349786} 02 September 2024, 10:35:04 UTC
e0be40b Anders Hartvoll Ruud 02 September 2024, 09:55:23 UTC [css-nesting] Traverse child rules of StyleRule in ReplaceRuleIfExists Since the selector list of a StyleRule is stored in the bytes trailing the object, we create a new StyleRule during setSelectorText, and replace the old rule with the new rule. However, the traversal ignored the child rules of StyleRule, causing invalidation problems. Note: Adjusted nested-declarations-matching.html to actually test CSSNestedDeclarations instead of '&'. There's still a bug related to that. Fixed: 361600667 Change-Id: I99dc2422e2d59088b293fb3e8728c05da9f1018c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828606 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1349780} 02 September 2024, 10:23:34 UTC
41a06b4 Florian Rivoal 02 September 2024, 04:42:30 UTC More tests about (-webkit-)line-clamp and BFCs This is a follow up to https://github.com/web-platform-tests/wpt/pull/46734 02 September 2024, 04:54:55 UTC
back to top