Skip to main content

Browse the archive

swh:1:snp:b37d435721bbd450624165f334724e3585346499
sort by:
Revision Author Date Message Commit Date
d0802e5 Philip Jägenstedt 20 December 2018, 16:48:28 UTC Revamp how idlharness.js handles iterable declarations Instead of adding IDL interface members in `add_iterable_members` in the style of what webidl2.js would have added if the declaration were expanded, instead test directly for what effect a single `iterable<T>` or `iterable<T1,T2>` declaration should have. This is more along the lines of `test_member_stringifier`, where no `toString` is added as IDL members. Alternative to https://github.com/web-platform-tests/wpt/pull/9790. 20 December 2018, 17:17:21 UTC
1bdc13d Harald Alvestrand 20 December 2018, 09:29:46 UTC Added tests for missing MID field in sdp This needs to be handled according to SDP negotiation rules. Bug: webrtc:9540 Change-Id: I3ed1ecead91d3e31dcc14c54061a0cb89be36a52 Reviewed-on: https://chromium-review.googlesource.com/c/1379752 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#618149} 20 December 2018, 09:40:08 UTC
3b18e18 Boris Chiou 20 December 2018, 04:22:22 UTC Part 2: Tests. Add some tests to make sure we clamp the interpolated result with negative easing function on circle(), ellipse(), and inset(). Depends on D14654 Differential Revision: https://phabricator.services.mozilla.com/D14655 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1512883 gecko-commit: c1b46f5fc73bf34193b70d8aba86a1d6f3597357 gecko-integration-branch: autoland gecko-reviewers: birtles 20 December 2018, 08:51:18 UTC
23ce30a Robert Ma 19 December 2018, 17:21:36 UTC Remove trailing spaces from MANIFEST.json https://github.com/web-platform-tests/wpt/commit/1ca46e0bec3da78ea11a824f7e6d07755e1f8399#diff-2a239eec150d25cf7486394513fb1e63L255 removed the `separators=(',', ': ')` argument to `json.dump`, which caused `json.dump` to use the default ", " separator that will add a trailing space after each item. Doc: https://docs.python.org/2/library/json.html#json.dump 19 December 2018, 18:45:00 UTC
79c4a43 Philip Jägenstedt 19 December 2018, 16:41:09 UTC Revert infrastructure/ expectations for Chrome (#14606) https://github.com/web-platform-tests/wpt/pull/14570 was merged when Travis checks were temporarily disabled. This reverts commit 53b12fdd0d1177428e4e9a2f4b986f689c5445d1. 19 December 2018, 16:41:09 UTC
41e17ed Chris Lilley 19 December 2018, 15:40:17 UTC Port filter subregion test from example in spec (#14532) 19 December 2018, 15:40:17 UTC
712c9f2 autofoolip 19 December 2018, 14:33:36 UTC Update interfaces/wai-aria.idl (#14600) Source: https://github.com/tidoust/reffy-reports/blob/d952a67/whatwg/idl/wai-aria.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/469883037 19 December 2018, 14:33:36 UTC
675ade1 Kouhei Ueno 19 December 2018, 10:06:04 UTC SignedExchange: Require nosniff in outer response headers To encourage servers to include the nosniff header, this CL makes Chromium reject SXG served without the "X-Content-Type-Options: nosniff" header. Bug: https://github.com/WICG/webpackage/pull/348, 916362 Change-Id: I5343a8d13a42a3c9144f05d871777d35a20a77b7 Reviewed-on: https://chromium-review.googlesource.com/c/1373430 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#617780} 19 December 2018, 14:28:09 UTC
f749cfb Jeremy Roman 19 December 2018, 01:56:40 UTC Add a test that the correct referrer policy is used for portals. Bug: 916310 Change-Id: Ib962a5873d2c313687eca7cc25bfb86f09e94b41 Reviewed-on: https://chromium-review.googlesource.com/c/1380799 Reviewed-by: Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#617706} 19 December 2018, 14:23:13 UTC
ac573f3 Ehsan Karamad 14 December 2018, 23:20:08 UTC lazy-load: Increase timeout value to reduce flakes The test is still a bit flaky after increasing the value to 400ms ( which did in fact reduce flakiness substantially). This CL will increase the value even further (600ms) to further reduce the flakiness. TBR=iclelland@chromium.org Bug: 915236 Change-Id: I1ad650ed14dbf9b054a966324ec033a4bd2f47f8 Reviewed-on: https://chromium-review.googlesource.com/c/1379105 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616867} 19 December 2018, 14:18:07 UTC
18b9480 autofoolip 19 December 2018, 13:25:08 UTC Update interfaces/shape-detection-api.idl (#13352) Source: https://github.com/tidoust/reffy-reports/blob/f128525/whatwg/idl/shape-detection-api.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/436975697 19 December 2018, 13:25:08 UTC
53b12fd Lan Wei 17 December 2018, 19:53:29 UTC Query the element's position right before dispatching the actions Because the page layout may be changed after each action, before we dispatch each pointermove action, we need to check the element's position on the page in case some layout changes happened. Bug: chromedriver:1897 Change-Id: I6404979ddd1af97fa194c4df5d616e93f7403fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1376713 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#617191} 19 December 2018, 13:15:46 UTC
9a6dabb Luke Bjerring 18 December 2018, 14:15:53 UTC Update test to match IDL change 19 December 2018, 12:42:32 UTC
a9df0c4 Automat af Gränssnitt 15 December 2018, 07:10:52 UTC Update interfaces/feature-policy.idl Source: https://github.com/tidoust/reffy-reports/blob/a990a0a/whatwg/idl/feature-policy.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/468318854 19 December 2018, 12:42:32 UTC
0e9a18f Manuel Rego Casasnovas 19 December 2018, 12:22:22 UTC [css-grid] Fix auto-placement on implicit tracks This fixes a regression introduced in r577855 due to the new implementation of ListGridIterator::NextEmptyGridArea() which was not taking into account some special situations in the previous code. When we call NextEmptyGridArea() it was returning null when it couldn't find any empty grid area, while the code in LayoutGrid was expecting an area anyway even if it's outside the bounds of the current grid tracks. This patch changes that code so it always returns an area, and also removes some unneeded code in LayoutGrid (of course it still keeps the code that checks that we can add new tracks in the direction of the new area, otherwise it discards it). Let's explain what the new test is checking to understand the problem. In the new tests cases the number of tracks of the grid is determined by the largest span among all the auto-placed items. In the tests we have an item that spans 2 tracks, so the grid is considered to have 2 tracks as minimum. Then the first cell is occupied by an item, so when we look for an empty area for the item spanning 2 tracks we were not finding it. Then we were creating an new area outside of the grid limits and leaving the second track empty (which is wrong). Instead of that we're now returning an area taking the 2nd and 3rd tracks, even when the 3rd track doesn't exist yet as it's going to be created on demand. BUG=910953,688640 TEST=external/wpt/css/css-grid/placement/grid-auto-placement-implicit-tracks-001.html Change-Id: If4eeb46a9d2a909b0772e75be90ff6dabd49c387 Reviewed-on: https://chromium-review.googlesource.com/c/1383055 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#617806} 19 December 2018, 12:33:26 UTC
26c5c00 Eric Willigers 19 December 2018, 09:52:28 UTC SVG Geometry: computed width and height (#14558) The properties width and height accept percentages and units. https://drafts.csswg.org/css-sizing-3/#preferred-size-properties https://svgwg.org/svg2-draft/geometry.html#Sizing Except when display is 'none' or 'contents', the resolved value of width and height is the used value (px only, no %). 19 December 2018, 09:52:28 UTC
5a5eead Jason Orendorff 15 December 2018, 01:01:36 UTC Part 2: In the WPT testharness.js, treat the absence of `global.location`, rather than `global.self`, as evidence that we're in the shell. We have to shim global.self for some tests that we want to run in the shell (see part 3). Differential Revision: https://phabricator.services.mozilla.com/D14315 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1513570 gecko-commit: 73be0af7269ff48f8c5d6ee0bb060b4ad545120f gecko-integration-branch: autoland gecko-reviewers: Ms2ger 19 December 2018, 09:42:31 UTC
a9a9c92 Jason Orendorff 15 December 2018, 01:01:35 UTC Part 1: Adapt stream tests to run in the shell. We don't support byte streams, transform streams, writable streams, or piping yet, but we will, and in the meantime our own meta files disable those tests for us. Differential Revision: https://phabricator.services.mozilla.com/D14314 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1513570 gecko-commit: 94c3c85adfa902e2b3133411bc04e89d254ef9b9 gecko-integration-branch: autoland gecko-reviewers: Ms2ger 19 December 2018, 09:42:31 UTC
e663fa0 Kunihiko Sakamoto 19 December 2018, 09:06:02 UTC SignedExchange: Reject SXG if fallback URL has invalid UTF-8 sequence GURL parser happily accepts invalid UTF-8 path, so we need to validate the fallback URL string before parsing. Spec: https://github.com/WICG/webpackage/pull/346 Bug: 916390 Change-Id: Ife25621e2a41beef01cbf36a5ab523eaee1ea222 Reviewed-on: https://chromium-review.googlesource.com/c/1382724 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#617772} 19 December 2018, 09:16:54 UTC
201f8cb Boris Chiou 19 December 2018, 01:31:47 UTC Part 3: Let logical height, block-size, accept keywords. We should let block-size/min-block-size/max-block-size accept keywords as the initial value, just like width in vertical writing mode or height in horizontal writing mode. Depends on D7536 Differential Revision: https://phabricator.services.mozilla.com/D14320 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1322780 gecko-commit: ecf13af1b4211804cb4210f17a667377cd911667 gecko-integration-branch: autoland gecko-reviewers: emilio 19 December 2018, 07:23:10 UTC
0c97390 Boris Chiou 19 December 2018, 01:31:45 UTC Part 2: Support unprefixed min-content and max-content. Support unprefixed min-content and max-content and treat the prefixed version as aliases for 1. width, min-width, max-width if inline-axis is horizontal, and 2. height, min-height, max-height if inline-axis is vertical, and 3. inline-size, min-inline-size, max-inline-size, and 4. flex-basis. Besides, update the test cases to use unprefixed max-content and min-content. Depends on D7535 Differential Revision: https://phabricator.services.mozilla.com/D7536 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1322780 gecko-commit: 3511904f12cf4e71e3e2baaa20c1845b936b3cbe gecko-integration-branch: autoland gecko-reviewers: mats, emilio 19 December 2018, 07:23:10 UTC
d4acd14 youennf 19 December 2018, 06:23:18 UTC MSID information change should trigger related track events (#14317) * MSID information change should trigger related track events 19 December 2018, 06:23:18 UTC
2e19cbe Kunihiko Sakamoto 19 December 2018, 03:04:16 UTC SignedExchange: Use unparsed URL string for signature verification Before this patch, SignedExchangeSignatureVerifier used GURL::spec() to stringify URLs when reconstructing the signed message. However, GURL::spec() may return a string which is differently percent-encoded from the original URL string, and then verification fails. This patch introduces URLWithRawString struct which holds original URL string along with parsed GURL, and use the original string for signature verification. Bug: 914247 Change-Id: I8950bf172391782ebb92338707245694b046052f Reviewed-on: https://chromium-review.googlesource.com/c/1377959 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#617714} 19 December 2018, 03:15:25 UTC
dadde0a Xianzhu Wang 19 December 2018, 01:22:02 UTC [BlinkGenPropertyTrees] Don't skip fragment clip above effect's output clip We don't allow an object's clip an object's clip to escape the output clip of the object's effect, so don't skip fragment clip if there is any effect between the object and the clip container has output clip. This won't get correct rendering (because of the extra clips), but avoids crash in PropertyTreeManager. Bug: 803649 Change-Id: I63c7feda09755be1ac04d9a788c4110449f73f04 Reviewed-on: https://chromium-review.googlesource.com/c/1382870 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#617701} 19 December 2018, 01:32:12 UTC
38c3785 Eric Willigers 18 December 2018, 23:52:22 UTC [css-grid] computed values of grid properties (#14515) The computed values are as specified, with lengths made absolute. We omit implicit 1 in grid-row-start, grid-row 18 December 2018, 23:52:22 UTC
ed74c4f Jeffrey Yasskin 18 December 2018, 22:44:37 UTC Test document.URL of <iframe src="javascript:..."> The document.URL should be about:blank. Follows https://github.com/whatwg/html/pull/4205. 18 December 2018, 22:44:37 UTC
7ed525a Ehsan Karamad 18 December 2018, 20:29:35 UTC vertical-scroll: Policy will not affect main document The purpose of 'vertical-scroll' is to block sub-frames from interfering with main-frame's scrolling. To enforce the policy on the main frame is wrong in that it will block all scrolling on the page. This CL will special-case the main frame scenairo and will not enforce the policy. Same-origin subframes are still affected. TBR=iclelland@chromium.org Bug: 611982 Change-Id: I2fbe882cc65af6f7ed542ebc0151df9f281e9ab2 Reviewed-on: https://chromium-review.googlesource.com/c/1378684 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#617603} 18 December 2018, 20:35:02 UTC
bbed5ce Jeremy Roman 18 December 2018, 19:07:37 UTC wptserve: Add a header_or_default function which works when the request header is absent (#14573) Fixes #14572. 18 December 2018, 19:07:37 UTC
b62fd30 Jacob DeWitt 18 December 2018, 18:17:13 UTC Rename XRDevicePose to XRViewerPose Update blink XR code files to rename XRDevicePose to XRViewerPose and XRFrame.getDevicePose to XRFrame.getViewerPose. This is one of several changes required to make Chromium conform to the latest version of the web XR API standards, which are at: https://github.com/immersive-web/webxr/blob/master/explainer.md#appendix-b-proposed-idl This also required updating many test and expected test output files. For example, global-interface-listing-expected.txt expected test output needs to have interfaces and methods in alphabetical order. Bug: 914978 Change-Id: I60801cab151ef44d9f88a59c1caed2d65def7b51 Reviewed-on: https://chromium-review.googlesource.com/c/1377142 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#617565} 18 December 2018, 18:27:50 UTC
d7187c1 Fredrik Söderquist 18 December 2018, 17:35:17 UTC Resolve computed 'transform-origin' for SVG elements Make the local helper ReferenceBoxForTransform available via ComputedStyleUtils and use it in TransformOrigin::CSSValueFromComp... Replace usages of MinimumValueForLength with FloatValueForLength. This matches what is done when resolving/applying transform in the general case. Also sink the common handling of the 'z' component out of the 'if'. Bug: 740300 Change-Id: Id0e6cbcc85942ccc8cdb3f8ed86ecc6e7aaf492e Reviewed-on: https://chromium-review.googlesource.com/c/1382434 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#617548} 18 December 2018, 17:45:30 UTC
a88f503 Rayan Kanso 18 December 2018, 17:24:18 UTC [Background Fetch] Apply CORS checks before sending progress events Bug: 915446 Change-Id: I346d38e456b916de9e5acb7640510fdb5080431b Reviewed-on: https://chromium-review.googlesource.com/c/1379765 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#617542} 18 December 2018, 17:30:02 UTC
fcc9512 Fredrik Söderquist 18 December 2018, 16:26:39 UTC Resolve percentages in computed 'transform' for SVG elements SVG (child; non-root) elements should resolve percentages in computed 'transform' values just like regular boxes. Rename ComputeTransformReferenceBox to ComputeSVGTransformReferenceBox (for clarity) and expose it for a wider audience. Make it apply the effective zoom, since both clients require that. Use ComputeSVGTransformReferenceBox in ComputedStyleUtils to compute the reference box for the LayoutObject in question. Bug: 915426 Change-Id: I5323056cc54ff07e0b3cf943f52a7210ea320c78 Reviewed-on: https://chromium-review.googlesource.com/c/1382433 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#617515} 18 December 2018, 16:42:42 UTC
d6a89e2 Jonas Olsson 18 December 2018, 14:11:39 UTC Switch to new ICE state implementation With this change the ice/dtls connection states should finally be compliant to the spec. Bug: webrtc:6145 Change-Id: I1e7c13f22e40b534e732ecd3fc103f617306f00a Reviewed-on: https://chromium-review.googlesource.com/c/1371392 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#617476} 18 December 2018, 14:17:50 UTC
e0c16fd Kouhei Ueno 18 December 2018, 13:36:23 UTC SignedExchange: Redirect if served from a non secure origin Before this CL, navigating to a sxg served over http triggered its download. This CL aligns the implementation to the loading spec [1] so that it will trigger redirect to the sxg's fallback url. [1] https://wicg.github.io/webpackage/loading.html#parsing-b1 Bug: 915576 Change-Id: I3b5dcf31b5e3a6d7c2287bcd8b8c7ad693b9d7e0 Reviewed-on: https://chromium-review.googlesource.com/c/1379791 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#617467} 18 December 2018, 13:46:29 UTC
230576f Mats Palmgren 18 December 2018, 01:15:08 UTC Fix a few baseline alignment tests that makes bogus assumptions about line-height metrics. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1514658 gecko-commit: 21c134f346bb9e2d25c85c1f6696738dbdec3b87 gecko-integration-branch: mozilla-inbound gecko-reviewers: emilio 18 December 2018, 12:55:26 UTC
dc8244a Fredrik Söderquist 18 December 2018, 11:41:15 UTC Narrow "is constrained" check for LayoutImage layout invalidation If our containing block has auto height, we need to relayout. Add !HasAutoHeightOrContainingBlockWithAutoHeight() to the condition for |image_size_is_constrained|. Bug: 870599 Change-Id: I22858843d7ad87c63eb7b8d6e771e0f8d6cfa09d Reviewed-on: https://chromium-review.googlesource.com/c/1373823 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#617446} 18 December 2018, 11:50:57 UTC
c3483ef Jeremy Roman 17 December 2018, 16:47:47 UTC Create portals/ directory and metadata. 18 December 2018, 10:35:04 UTC
a377796 Jakub Vrana 18 December 2018, 09:11:57 UTC Trusted Types: Fix type of HTMLObjectElement's data and codeBase These are TrustedScriptURL according to https://github.com/WICG/trusted-types/blob/1f6f3011/src/enforcer.js#L110-L111. Bug: 739170 Change-Id: If83044d0a8ba35354e9434f347f10f3f15cb237c Reviewed-on: https://chromium-review.googlesource.com/c/1374352 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#617422} 18 December 2018, 09:22:11 UTC
4d7f8d3 Michael[tm] Smith 18 December 2018, 07:40:44 UTC cc Change expected result for xml:base test xml:base was removed from the HTML and DOM specs quite a while ago (and has now also been removed from the validator.nu HTML parser). 18 December 2018, 08:33:29 UTC
748c200 Florian Rivoal 18 December 2018, 06:19:45 UTC Refiling which spec some tests are filed against The connection to writing-modes is a bit thin, but at least there's a section on bidi there. css-text was the wrong place to file it, and bikeshed's wpt facilities would complain if the tests weren't linked to from any section of the spec. 18 December 2018, 06:39:59 UTC
8506feb Emilio Cobos Álvarez 17 December 2018, 13:16:55 UTC Make <use> shadow trees lookup keyframe rules in the containing tree. The same thing we do for rule matching. Differential Revision: https://phabricator.services.mozilla.com/D14548 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1513920 gecko-commit: 1b1eaa3248a7c8652b31644aca098bb6bd32d1ab gecko-integration-branch: autoland gecko-reviewers: heycam 18 December 2018, 04:07:24 UTC
4984b19 Andreas Pehrson 17 December 2018, 14:27:50 UTC Remove Chrome-specific dependency and modernize. Differential Revision: https://phabricator.services.mozilla.com/D14596 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1514241 gecko-commit: b69e3c4f4afb50e5cd91b7b41bcb5030054e21c8 gecko-integration-branch: autoland gecko-reviewers: jib 18 December 2018, 01:40:23 UTC
c022477 Florian Rivoal 18 December 2018, 00:24:28 UTC [css-text] Fix typo in value name 18 December 2018, 00:48:56 UTC
691e737 Florian Rivoal 17 December 2018, 23:23:35 UTC [css-text] Remove "exploratory" comment for test backed up by the spec The comment about this test being exploratory is wrong. Assuming that the claim that “people using indic scripts expect the user agent to keep the orthographic syllable as a single unit” is true, the spec definition's of typographic character/letter unit are sufficient to justify the test. 17 December 2018, 23:36:22 UTC
209cda5 Florian Rivoal 17 December 2018, 23:14:18 UTC [css-text] Improve metadata Fix rel=help link, and rephrase assert. 17 December 2018, 23:26:52 UTC
a093a65 Joshua Bell 17 December 2018, 20:50:00 UTC TextDecoder: previous failure should not stick around When the {fatal:true} option is used, the decode() calls throw rather than generating U+FFFD on bad data. Subsequent decode() calls should work as the codec state should be flushed (unless {stream:true} was specified). Blink was not flushing the codec state, so subsequent calls would throw. Fix by flushing the codec state (instantiating a new codec), and align the implementation's code flow/state more closely with the spec. Also added a new WPT test case, based on the bug report. Bug: 910292 Change-Id: Ia47b902b69a4b469341e272ed42bb6b05248c1d8 Reviewed-on: https://chromium-review.googlesource.com/c/1376656 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#617215} 17 December 2018, 20:59:59 UTC
3cdc983 Manuel Rego Casasnovas 17 December 2018, 20:08:18 UTC [css-contain] Layout containment suppress baseline We were not suppressing baseline in all the cases. This patch fixes the bug detected by Mozilla test contain-layout-suppress-baseline-002.html. At the same time it adds a new test for more elements, however it's not passing yet due to a different bug crbug.com/671132. BUG=909599 TEST=external/wpt/css/css-contain/contain-layout-baseline-005.html TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-suppress-baseline-002.html Change-Id: Id1b984aae1f2a21f655b9c1e42a54115d0a4659c Reviewed-on: https://chromium-review.googlesource.com/c/1380033 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#617195} 17 December 2018, 20:19:10 UTC
cac03f7 Mike West 17 December 2018, 16:55:53 UTC Ship strict MIME checks for 'importScripts()' (#14557) Supporting https://github.com/whatwg/html/pull/4001. 17 December 2018, 16:55:53 UTC
05f3782 Geoffrey Sneddon 17 December 2018, 13:31:15 UTC Remove support for testharness/reftest tests in IE In reality, all that's been run for a long time is WebDriver tests, and the testharness/reftest automation scripts almost certainly don't work in any version of IE. 17 December 2018, 16:21:27 UTC
eb97f99 Florian Rivoal 17 December 2018, 14:27:51 UTC [css-text] Correct test metadata (#14551) The section title is out of date and unneeded. Deleting it. The link is broken. Fixing it. 17 December 2018, 14:27:51 UTC
10945ec pyup.io bot 17 December 2018, 14:22:00 UTC Update requests from 2.20.1 to 2.21.0 (#14534) 17 December 2018, 14:22:00 UTC
6e9c62b Philip Jägenstedt 17 December 2018, 14:14:55 UTC Let `./wpt run --affected revish` ignore testharness* (#14559) This matches the behavior of `./wpt tests-affected`: https://github.com/web-platform-tests/wpt/blob/503a7143f0bd8b719e8ef62d12530b6390d0241d/tools/wpt/testfiles.py#L312-L317 Reported in https://github.com/web-platform-tests/wpt/pull/14540. Added TODOs for https://github.com/web-platform-tests/wpt/issues/14560. 17 December 2018, 14:14:55 UTC
ae0eccd autofoolip 17 December 2018, 13:17:12 UTC Update interfaces/input-events.idl (#14552) Source: https://github.com/tidoust/reffy-reports/blob/e64cb71/whatwg/idl/input-events.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/468885960 17 December 2018, 13:17:12 UTC
79001b1 Yoav Weiss 12 December 2018, 17:16:56 UTC Align resource timing buffer full processing to spec PR 168 (take 3) This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of [2] which is a reland of [3] (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1350950 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1345269 Bug: 908181, 908414 Change-Id: I3a6c6e9d6a9aa5b5f907d1e86bec701ff2fa022d Reviewed-on: https://chromium-review.googlesource.com/c/1373819 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615929} 17 December 2018, 12:01:57 UTC
6ac8aaf autofoolip 17 December 2018, 11:12:12 UTC Update interfaces/webxr.idl (#14553) Source: https://github.com/tidoust/reffy-reports/blob/e64cb71/whatwg/idl/webxr.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/468885960 17 December 2018, 11:12:12 UTC
81f23a9 Florian Rivoal 17 December 2018, 08:09:44 UTC [css-text] Typo in Thai text Since we're testing dictionary based word-boundary detection, it seems quite important to avoid spelling mistakes. The Thai word “and” is spelled “และ” and not “แและ”. 17 December 2018, 08:35:02 UTC
0065f28 Florian Rivoal 17 December 2018, 07:58:48 UTC [css-text] Fix test It used an incorrect flag (ahem), and the description sentence was ambiguous. 17 December 2018, 08:19:06 UTC
75f5494 Florian Rivoal 17 December 2018, 05:39:32 UTC Delete tests that can never fail These tests claims to test overflow-wrap, but it never overflows, so the property never gets the chance to do anything. The description is also confusing, as it asks the reviewer to check things that cannot be seen visually: whether the black box is one or two rows cannot be seen, since they are contiguous. 17 December 2018, 06:34:46 UTC
a22f78b Florian Rivoal 17 December 2018, 03:59:05 UTC Remove incorrect tests Both these tests will render incorrectly if a specific font isn't available, and they don't install it themselves, making them misleading. Moreover, word-break-break-all-009's reference is just a copy of the test, and relies on automatic line breaking instead of manually inserted <br>s, so it will always pass. Finally, these tests could be fixed, but they are testing things that are already covered by other tests, so deleting them is appropriate. 17 December 2018, 04:43:24 UTC
7275e40 Andrew Comminos 17 December 2018, 04:14:13 UTC Verify TTFB in resource-timing.html WPT by measuring that the delay occurs between responseStart and responseEnd When simulating a delay after a statusline, measure that the delay is not included in the TTFB by measuring that it occurred between responseStart and responseEnd rather than requestStart and responseStart. This makes the tests less flaky when subject to shaky network and thread scheduling conditions, as might be present using Firefox's chaos mode. Bug: 568024 Change-Id: I0356f6256af6bc87fbb14860ed05472526c03e5d Reviewed-on: https://chromium-review.googlesource.com/c/1377725 Reviewed-by: Yoav Weiss <yoav@yoav.ws> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#617021} 17 December 2018, 04:29:13 UTC
6d3120b Andrew Comminos 12 December 2018, 11:34:30 UTC Add WPT to verify that 1XX responses are used to provide responseStart timing Verifies that the UA sets responseStart to the time that an initial 1XX response was received by returning {100, delay, 200} and testing that the delay is not included in responseStart. Bug: 568024 Change-Id: I7295e6478a95abe1b6154ddf1feab764f596a5ec Reviewed-on: https://chromium-review.googlesource.com/c/1372359 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615853} 17 December 2018, 04:03:58 UTC
1a70ecd Florian Rivoal 17 December 2018, 03:49:14 UTC Remove unneeded tests These 4 tests are not technically wrong, but they are not automated, and they don't cover any aspect of the spec that isn't already covered by other tests. 17 December 2018, 04:02:53 UTC
11971ac Zirro 16 December 2018, 12:48:38 UTC Update <button type="menu"> test to reflect its removal <button type="menu"> got removed in https://github.com/whatwg/html/pull/2342 and this test was failing in all browsers. 16 December 2018, 14:14:12 UTC
4094d6a Daniel Holbert 15 December 2018, 05:23:47 UTC part 1: Include the 'unsafe' keyword in serializations of css-align properties. Previously we'd omit it since it was merely an explicit way of requesting the default behavior. But the spec has changed such that it's not necessarily equivalent to the default anymore: https://drafts.csswg.org/css-align/#overflow-values (Technically the behaviors are probably still equivalent in our implementation, pending bug 1451380, but we don't have to publicize that via our serialization.) Differential Revision: https://phabricator.services.mozilla.com/D14599 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1514309 gecko-commit: 4fe457a643097dd7f2b2245ed919a3106b532774 gecko-integration-branch: central gecko-reviewers: emilio 15 December 2018, 06:07:08 UTC
fcb8094 Stephen Chenney 15 December 2018, 04:12:05 UTC Fix gradient background sizing This is a hard-to-fix situation. We size generated background images according to the tile size, which is a snapped rectangle sized according to the destination values, in general. But then we compute a src rect for image drawing using the unsnapped values, because that is best for bitmap images where we want to pull out the most accurate src rect possible. However, that source rect ends up larger than the tile size due to rounding without the original offset in the layer (because now we are working in image space). The gradient painting code then sees that it has a src rect that is larger than the tile size and hence the gradient image size. The code thinks that we want to have some more pixels than the gradient provides, which is true in some cases, and scales things to get those extra pixels in the painted output. Hence empty pixels on the screen when we really want the gradient to be filling the dest rect. Changing the gradient painting code will break valid use cases. Changing the tile size breaks things in a different way and doesn't really fix the problem. So change the src rect computation to use snapped sizes for generated content in an attempt to get a src that matches the tile size. R=fmalita@chromium.org Bug: 898950 Change-Id: I100575ad4f4fa3004fbc232a72c90b0032ccef4e Reviewed-on: https://chromium-review.googlesource.com/c/1376814 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#616944} 15 December 2018, 04:22:09 UTC
a3efcf1 Seth Hampson 15 December 2018, 03:44:21 UTC Update for RTCQuicStream.write() function. Combines functionality of finish() into write() by adding a new QuicStreamWriteParameters input parameter that includes a finish boolean. This is consistent with the latest spec draft and also adds symmetry between readInto() and write(). Bug: 874296 Change-Id: I0def0ca25587ebf00a4b179ce8e9e7a124c818f6 Reviewed-on: https://chromium-review.googlesource.com/c/1376720 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#616941} 15 December 2018, 04:07:11 UTC
ac42741 Henri Sivonen 15 December 2018, 00:31:30 UTC Ignore charset= in <meta content> if followed by unmatched quote. Differential Revision: https://phabricator.services.mozilla.com/D14410 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1469580 gecko-commit: d02d14a3dd6e172c4cc8efb5c749752d3893fc90 gecko-integration-branch: central gecko-reviewers: mrbkap 15 December 2018, 01:04:00 UTC
e183d86 youennf 14 December 2018, 23:25:41 UTC WebKit export of https://bugs.webkit.org/show_bug.cgi?id=192706 (#14530) 14 December 2018, 23:25:41 UTC
cf8b055 Stephen McGruer 14 December 2018, 21:33:35 UTC [CSS Transitions] Add test for reparenting As per https://github.com/w3c/csswg-drafts/issues/3309, any CSS Transition on a reparented element should be cancelled, as it leaves and then re-enters the Document. This already works on Chrome, Firefox, and Safari but fails on Edge. Bug: 902328 Change-Id: I097675a8146c8047417dd48193d0747216418cfb Reviewed-on: https://chromium-review.googlesource.com/c/1374742 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#616830} 14 December 2018, 21:39:41 UTC
ca3a8d6 npm1 14 December 2018, 17:10:59 UTC Merge pull request #14511 from web-platform-tests/chromium-export-cl-1377129 [UserTiming] Fix mark-measure-return-null test 14 December 2018, 17:10:59 UTC
f6c4282 James Graham 13 December 2018, 14:04:11 UTC Ensure we call __wptrunner_process_next_event whenever we put a message on the queue 14 December 2018, 16:59:52 UTC
e4ba26c James Graham 05 November 2018, 17:55:24 UTC Make testharness tests run in a top-level browsing context Traditionally testharness tests ran in a auxillary browsing context opened using window.open and with access to the opener. This works well because the long-lived nature of the opener helps to avoid some of the race conditions that would otherwise occur. But it doesn't work *that* well; the recent refactor to stop continually focusing the opener broke tests that alter document.domain or otherwise prevent the opener being same-domain with the test window. And future platform features may cause the opener to be nulled out entirely so even a postMessage based fix wouldn't work. To solve all of this, this patch refactors things so that the initial window doesn't contain any logic at all and is just used to keep the browser alive between tests. Most of the logic moves to testharnessreport.js which is loaded once per test. In order to get the right timeout when timeout_multiplier is set this requires an addition to the product API in wptrunner to expose a function for getting the timeout multiplier. This allows us to get the timeout_multiplier for testharness tests upfront and avoids the need to change the content of testharnessreport when we start running testharness tests, or to restart the server for each test type. The main issue with the single-window implementation is that we need to start injecting script once the test page has loaded testharnessreport.js. For most browsers we are able to use pageLoadStrategy=eager to control this; in that case we can start running tests once DOMContentLoaded is reached. Chrome doesn't support this pageLoadStrategy, however, so we have to fake support with custom script. 14 December 2018, 16:59:52 UTC
3a8ff1c Xida Chen 14 December 2018, 15:33:56 UTC [LayoutTest] Split animations-parsing.html into two tests Currently it tests both style.animation and getComputedStyle.animation. This CL splits the test into two tests, one for style.animation, and the other one for getComputedStyle.animation such that each test is minimal. Bug: 772852 Change-Id: I3c3f43305497ffe9d91c4e3806efe2e65ff17806 Reviewed-on: https://chromium-review.googlesource.com/c/1378230 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616677} 14 December 2018, 15:52:47 UTC
1dd43ed Nicolas Pena 14 December 2018, 15:51:03 UTC [UserTiming] Fix mark-measure-return-null test The test was incorrect per L2 spec: a void method 'returns' an undefined value, not a null object. This CL changes the test to show how to perform feature detection and compares L2 and L3 behavior. Bug: 914441 Change-Id: Id7173b2693d5bd42013dcdd25266d64fa8956e6a 14 December 2018, 15:51:03 UTC
4559dab Fredrik Söderquist 14 December 2018, 15:33:47 UTC Add reftest-wait to css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html Attempt to stabilize in Gecko. Bug: 626744 Change-Id: Idfa06176948d1ffaf6ba8e65263bf5818ffd321b Reviewed-on: https://chromium-review.googlesource.com/c/1375875 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#616543} 14 December 2018, 15:42:53 UTC
ceebcb8 Fredrik Söderquist 13 December 2018, 14:54:19 UTC Regression test for crbug.com/626744 Bug: 626744 Change-Id: I4244c3f0316ceb55bc69655212f6677345b0a6cc Reviewed-on: https://chromium-review.googlesource.com/c/1374988 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#616311} 14 December 2018, 15:30:15 UTC
8a97b8a Fredrik Söderquist 14 December 2018, 14:20:42 UTC Use StyleColor for the stop-color property This changes the ComputedStyle storage for the stop-color property to be a StyleColor rather than a plain color. This fixes explicit inheritance for the property ('currentcolor' computes to itself). It also means we'll properly pick up changes to 'color'. Bug: 914728 Change-Id: I3c78a3615220b9149d1ea5102a6e5863526a6d51 Reviewed-on: https://chromium-review.googlesource.com/c/1377437 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#616660} 14 December 2018, 14:39:38 UTC
6c14d36 Mike Pennisi 13 December 2018, 22:33:22 UTC [wptrunner] Correct support for eager page loading Many reftests schedule behavior to occur when the document reaches the "complete" readyState by setting the `onload` property of the document element. Previously, the automation scripts were written to conditionally defer execution for that event by setting the `onload` property of the global object. The two strategies are mutually exclusive. The sequence of script execution is not controlled, so either consumer of the "load" event could be blocked by the other. Update the automation scripts to register for the event using `addEventListener` in order to avoid unintended interaction with test code. 14 December 2018, 14:26:09 UTC
506442f pyup-bot 10 December 2018, 15:47:34 UTC Update requests from 2.20.1 to 2.21.0 14 December 2018, 14:25:17 UTC
f378387 Xida Chen 14 December 2018, 11:58:45 UTC Serialize animation in the right order Per spec: https://drafts.csswg.org/css-animations/#animation The name of the animation should be the end of the value list, to avoid ambiguity when serializing/deserializing the animation. This CL fixes the problem for both element.style and the window.getComputedStyle. A wpt test is added. Since this CL changes the output of an existing web API, an Intent to Ship has been sent to blink-dev and 3 LGTMs has been granted. https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/KUelGRZP73Y/F4YxTGBOBwAJ Bug: 772852 Change-Id: I88b06b57c68013d99c8c4fd4bd39bdfcf9b807fc Reviewed-on: https://chromium-review.googlesource.com/c/1367935 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616639} 14 December 2018, 12:07:35 UTC
ed62f0a Boris Zbarsky 14 December 2018, 07:30:57 UTC Fix serialization of explicitly case-sensitive attr selectors with a namespace. Differential Revision: https://phabricator.services.mozilla.com/D14493 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1514029 gecko-commit: a704ad19e3ad3ce99f3aa5addfc57c144e54c4fd gecko-integration-branch: central gecko-reviewers: emilio 14 December 2018, 11:04:39 UTC
68a96eb Ting-Yu Lin 14 December 2018, 05:13:24 UTC Fix <table> having "column-span:all" style. The main style of <table> is set on the inner TableFrame, not the outer TableWrapperFrame. Thus, we fail to spot the table as a column-span kid in nsCSSFrameConstructor::ConstructionBlock(). Differential Revision: https://phabricator.services.mozilla.com/D13957 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1506306 gecko-commit: 5b7718956a45cb09019e4bd8aabd23bee6e3d0f0 gecko-integration-branch: autoland gecko-reviewers: bzbarsky 14 December 2018, 10:37:21 UTC
15886f0 Rakina Zata Amni 14 December 2018, 09:42:30 UTC Ignore adopted stylesheets from different document tree If we adopt a subtree containing a shadowRoot that has adoptedStyleSheets from one document to a different document, the adoptedStyleSheets will be moved along with it. We want to ignore the stylesheets that are constructed in a different document tree when we're doing style calculation. Draft spec: https://wicg.github.io/construct-stylesheets/ Bug: 807560 Change-Id: If36676e642b5d1b5c1c403c14cc24be8e670f153 Reviewed-on: https://chromium-review.googlesource.com/c/1377486 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#616621} 14 December 2018, 09:52:06 UTC
1a74566 James Graham 14 December 2018, 01:32:42 UTC Change wpt crash handling API to be a single method Because mozcrash is stateful we can't check for crashes and then later log them; we need to do everything in one shot. Therefore remove the check_for_crashes call, rename log_crash to check_crash and make it return a boolean indicating whether any crashes occured, as well as handling the logging. Differential Revision: https://phabricator.services.mozilla.com/D14437 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1513927 gecko-commit: 517fdabf94bdc2eaceb697e6098d14ce649ba93c gecko-integration-branch: autoland gecko-reviewers: ted 14 December 2018, 07:32:30 UTC
e1d7b9d Emilio Cobos Álvarez 13 December 2018, 08:06:01 UTC Handle nested slots correctly in slotted matching and invalidation. The patch and test should be pretty much self-descriptive. Differential Revision: https://phabricator.services.mozilla.com/D14063 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1512026 gecko-commit: 7b04cdcfdcf4f7e071df42fd19d29c79f1786db5 gecko-integration-branch: autoland gecko-reviewers: heycam 14 December 2018, 04:56:35 UTC
443fc38 James Graham 13 December 2018, 21:47:17 UTC Ensure we only load the wpt test types we requested Differential Revision: https://phabricator.services.mozilla.com/D14438 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1513580 gecko-commit: bfca182e8a80c68fc78b3dde6626fa53fec50cc9 gecko-integration-branch: autoland gecko-reviewers: Ms2ger 14 December 2018, 03:47:36 UTC
1db8f79 youennf 14 December 2018, 03:21:45 UTC WebKit export of https://bugs.webkit.org/show_bug.cgi?id=192685 (#14516) 14 December 2018, 03:21:45 UTC
c85f06e Olli Pettay 12 December 2018, 13:49:56 UTC clear.py relies on old Gecko's <button> hit testing bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498383 gecko-commit: 7029e8b4d7d01b8c62cc366c215a2f187dc03782 gecko-integration-branch: mozilla-inbound gecko-reviewers: ato 14 December 2018, 01:34:28 UTC
e75e7b6 Fredrik Söderquist 13 December 2018, 17:17:43 UTC Return used width/height for SVG <image>, <rect> and <foreignObject> Per https://drafts.csswg.org/cssom/#resolved-values we should return the "used value" for 'width' and 'height' on these elements [1]. This behavior was clarified in SVGWG GitHub issue #349 [2]. [1] And also on <svg>, but we don't support those properties there yet. Tests added for that case too though. [2] https://github.com/w3c/svgwg/issues/349 Bug: 772707 Change-Id: Ic7b6b148883d4380daadb41b62bddd02da55e1af Reviewed-on: https://chromium-review.googlesource.com/c/1374291 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#616343} 13 December 2018, 17:39:51 UTC
04c862e autofoolip 13 December 2018, 13:56:14 UTC Update interfaces/webrtc-stats.idl (#14490) Source: https://github.com/tidoust/reffy-reports/blob/1d1a9ed/whatwg/idl/webrtc-stats.idl Build: https://travis-ci.org/tidoust/reffy-reports/builds/467371826 13 December 2018, 13:56:14 UTC
9377b49 Philip Jägenstedt 13 December 2018, 09:46:54 UTC Revert "Make testharness tests run in a top-level browsing context" (#14496) This reverts commit 74522a275bea481821e789145578e9e16fd27be3. Fixes https://github.com/web-platform-tests/wpt/issues/14495. Reopens https://github.com/web-platform-tests/wpt/issues/13418. 13 December 2018, 09:46:54 UTC
bc5122d Matt Falkenhagen 13 December 2018, 08:44:42 UTC service worker: XSLT: Use response URL for the base URL. This aligns with the standard. See https://github.com/whatwg/fetch/pull/146 Chrome Status: https://www.chromestatus.com/feature/4857368017895424 No intent to ship because it's a trivial change. Bug: 914135 Change-Id: I229aec6f8473bb6b7cdc88429afa830bc6eb80ed Reviewed-on: https://chromium-review.googlesource.com/c/1372109 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#616248} 13 December 2018, 08:53:47 UTC
483983d Mike Pennisi 12 December 2018, 22:46:20 UTC [resource-timing] Avoid race condition Depending on the scheduling of resource retrieval, performance entries for the test harness files may be observable by this test. That behavior is beyond the focus of this test, so such entries should be ignored if present. 13 December 2018, 08:07:49 UTC
16b2635 Yutaka Hirano 13 December 2018, 06:47:26 UTC Fix Headers mutation with "request-no-cors" guard https://github.com/whatwg/fetch/pull/833 Bug: 905677 Change-Id: Ie4141c2b900931ef88e7734cb152b6d28955999f Reviewed-on: https://chromium-review.googlesource.com/c/1352075 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#616230} 13 December 2018, 06:52:46 UTC
f0e18fa Rakina Zata Amni 13 December 2018, 06:05:35 UTC Move constructable stylesheets layout test to WPT We're shipping constructable stylesheets soon, so moving the layout test to WPT now. Draft spec: https://wicg.github.io/construct-stylesheets/index.html Bug: 807560 Change-Id: I37b45b6bbb1b17da51fbc41fbac5f11caabc5070 Reviewed-on: https://chromium-review.googlesource.com/c/1375296 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#616226} 13 December 2018, 06:15:24 UTC
e90dc47 Stephen Chenney 12 December 2018, 21:34:22 UTC Reland "Fix SVG-As-Background sizing" This is a reland of aed99d7e12bd036ab3ebb4fe522ce8faf347a32f It was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1373285 But the real culprit is a recipe change which is being reverted in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509 Original change's description: > Fix SVG-As-Background sizing > > Addresses a TODO where we were snapping the intrinsic size of an SVG image, > even when that is no longer useful. This was posing issues with operations > using aspect ratio, because the computed aspect ratio on the snapped value > was wrong when then used on un-snapped values. > > R=fs@opera.com > BUG=855882 > > Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c > Reviewed-on: https://chromium-review.googlesource.com/c/1370486 > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#615798} Bug: 855882 Change-Id: Icdd1ad0af2aaae6f633b8940522115e9742d1d7f Reviewed-on: https://chromium-review.googlesource.com/c/1373286 Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#615840} 13 December 2018, 04:44:28 UTC
beeeae3 Koji Ishii 13 December 2018, 01:58:56 UTC [LayoutNG] Exclude trailing preserved spaces when avoiding floats This patch fixes an interoperability issue where trailing preserved spaces should be excluded when avoiding floats. All 4 implementations are interoperable on this regard. This patch adds NGLineInfo::HasOverflow(), because knowing whether the line has overflow or not is easy and fast, while knowing the exact inline size excluding trailing preserved spaces may involve reshaping. Other cases also have interoperability problems, such as `text-align` or `min-content`. I'll investigate them in following patches. Bug: 913995 Change-Id: Ibf13f1fcc28bbd99d44b56611141efa49d6d1c89 Reviewed-on: https://chromium-review.googlesource.com/c/1374329 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#616155} 13 December 2018, 02:08:33 UTC
4052654 Nicolas Pena 12 December 2018, 20:53:51 UTC [EventTiming] Report events without event handlers This CL allows reporting events without event handlers. In particular, this implies that slow clicks cause slow mousedown events, so the tests are modified accordingly. Bug: 823744 Change-Id: I9578519ae538496404bb220001d3ca97565b7bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1368458 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#616026} 12 December 2018, 21:40:13 UTC
05ccfd8 Shuotao Gao 12 December 2018, 08:36:11 UTC Revert "Fix SVG-As-Background sizing" This reverts commit aed99d7e12bd036ab3ebb4fe522ce8faf347a32f. Reason for revert: Speculative revert for the compile failure on Android and ChromeOS, because this CL is the single CL that shows up in the blamelist of both failed builds. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5507 https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59554 Original change's description: > Fix SVG-As-Background sizing > > Addresses a TODO where we were snapping the intrinsic size of an SVG image, > even when that is no longer useful. This was posing issues with operations > using aspect ratio, because the computed aspect ratio on the snapped value > was wrong when then used on un-snapped values. > > R=​fs@opera.com > BUG=855882 > > Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c > Reviewed-on: https://chromium-review.googlesource.com/c/1370486 > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#615798} TBR=fs@opera.com,schenney@chromium.org Change-Id: I6bd43ac3ad23393be353249657566e9080cd69c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855882 Reviewed-on: https://chromium-review.googlesource.com/c/1373285 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615831} 12 December 2018, 21:21:46 UTC
c3f2a6c Mounir Lamouri 12 December 2018, 19:40:40 UTC Merge pull request #14435 from web-platform-tests/beaufortfrancois-patch-1 Fix timeout issue by calling play() 12 December 2018, 19:40:40 UTC
back to top