Revision 642e6e93355f589304ebcdce91039c5ec9c5c1cb authored by Simeon Schaub on 14 June 2021, 19:40:14 UTC, committed by Simeon Schaub on 14 June 2021, 22:11:15 UTC
- `hash` did not respect the type of a factorization, so completely different factorizations with the same underlying data would result in same `hash` leading to inconsistencies with `isequal`. This likely doesn't occur very often in practice, but definitely seems worth fixing. - `==` and `isequal` only returned true if two factorizations are of exactly the same type, which is inconsistent with their implementation for other objects and with the definition of `hash` for factorizations. - Equality for `QRCompactWY` did not ignore the subdiagonal entries of `T` leading to nondeterministic behavior. Perhaps `T` should be directly stored as `UpperTriangular` in `QRCompactWY`, but that seems potentially breaking. Relying on implementation details of `DataType` here is certainly less than ideal, but I could not come up with a nicer solution.
1 parent 4a81b08
File | Mode | Size |
---|---|---|
.buildkite | ||
.devcontainer | ||
.github | ||
base | ||
cli | ||
contrib | ||
deps | ||
doc | ||
etc | ||
src | ||
stdlib | ||
test | ||
.clang-format | -rw-r--r-- | 3.3 KB |
.gitattributes | -rw-r--r-- | 65 bytes |
.gitignore | -rw-r--r-- | 283 bytes |
.mailmap | -rw-r--r-- | 11.0 KB |
CITATION.bib | -rw-r--r-- | 513 bytes |
CONTRIBUTING.md | -rw-r--r-- | 19.3 KB |
HISTORY.md | -rw-r--r-- | 333.2 KB |
LICENSE.md | -rw-r--r-- | 5.0 KB |
Make.inc | -rw-r--r-- | 48.7 KB |
Makefile | -rw-r--r-- | 25.5 KB |
NEWS.md | -rw-r--r-- | 1015 bytes |
README.md | -rw-r--r-- | 6.8 KB |
VERSION | -rw-r--r-- | 10 bytes |
sysimage.mk | -rw-r--r-- | 4.0 KB |
Computing file changes ...