Revision 72ed9e04394746495f021133915e6bf7c1d3b5b1 authored by Michael Catanzaro on 25 May 2019, 23:30:12 UTC, committed by Michael Catanzaro on 26 May 2019, 15:17:15 UTC
The GTask must be destroyed on the thread that is running its
GMainContext, i.e. the thread that started the task. It must never be
destroyed on the actual task thread when running with
g_task_run_in_thread(), because when it is destroyed, it will unref its
source object and destroy its user data (if a GDestroyNotify was set for
the data using g_task_set_task_data()). The source object and task data
might not be safe to destroy on a secondary thread, though, so this is
incorrect. We have to ensure they are destroyed on the task's context's
thread.

There are different ways we could do this, but the simplest by far is to
ensure the task thread has unreffed the task before the context's thread
executes the callback. And that is simple enough to do using a condition
variable. We have to keep a static global map of all GTasks with
outstanding task threads, which is slightly unfortunate, but we already
have a bunch of global data in this file for managing the thread pool,
and the map will only contain tasks that are currently running in
threads, so it should be small.

Fixes #1346
1 parent e10eff1
History
File Mode Size
.gitlab-ci
docs
fuzzing
gio
glib
gmodule
gobject
gthread
m4macros
po
subprojects
tests
.dir-locals.el -rw-r--r-- 41 bytes
.gitattributes -rw-r--r-- 27 bytes
.gitignore -rw-r--r-- 231 bytes
.gitlab-ci.yml -rw-r--r-- 7.8 KB
AUTHORS -rw-r--r-- 1.3 KB
CONTRIBUTING.md -rw-r--r-- 10.8 KB
COPYING -rw-r--r-- 25.9 KB
HACKING -rw-r--r-- 571 bytes
INSTALL.in -rw-r--r-- 4.3 KB
NEWS -rw-r--r-- 412.5 KB
NEWS.pre-1-3 -rw-r--r-- 8.5 KB
README -rw-r--r-- 14 bytes
README.md -rw-r--r-- 15.1 KB
README.rationale -rw-r--r-- 505 bytes
README.win32 -rw-r--r-- 9.1 KB
check-abis.sh -rwxr-xr-x 796 bytes
glib-gettextize.in -rwxr-xr-x 5.3 KB
glib.doap -rw-r--r-- 2.3 KB
glib.supp -rw-r--r-- 11.3 KB
meson.build -rw-r--r-- 67.4 KB
meson_options.txt -rw-r--r-- 2.7 KB
msvc_recommended_pragmas.h -rw-r--r-- 1.8 KB
sanity_check -rwxr-xr-x 715 bytes
template-tap.test.in -rw-r--r-- 73 bytes
template.test.in -rw-r--r-- 57 bytes

README.md

back to top