https://github.com/tendermint/tendermint

sort by:
Revision Author Date Message Commit Date
3d2f989 remove remotesignererror and fix proto-lint 15 June 2020, 13:50:10 UTC
7906da2 Merge branch 'master' into marko/4698grpc_priv 15 June 2020, 13:45:40 UTC
b8b5073 encoding: remove codecs (#4996) ## Description This pr removes amino from tendermint. Closes: #4278 15 June 2020, 11:17:12 UTC
74cae49 proto: leftover amino (#4986) 15 June 2020, 09:14:36 UTC
893c2fc fix test-harness 14 June 2020, 21:47:05 UTC
a37480c tools: update gogoproto get cmd (#5007) ## Description Update gogoproto tools cmd to download the correct version. I still need to update the docker container and test that they generate the same Closes: #XXX 14 June 2020, 19:41:25 UTC
2df2ce0 Merge branch 'master' into marko/4698grpc_priv 14 June 2020, 19:34:08 UTC
206c814 UPGRADING.md: write about the LastResultsHash change (#5000) Refs #1007 12 June 2020, 16:07:44 UTC
a8d8600 [block#LastResultsHash] add Events + GasWanted/Used (#4845) Closes #1007 12 June 2020, 08:49:14 UTC
a39d4bc bring back binary:fixed64 (#4997) ## Description Binary: fixed64 is used for ledger support in signing for validators. This can be useful for other hsms as well Closes: #XXX 11 June 2020, 17:44:57 UTC
0fe4ebf define service 11 June 2020, 14:56:14 UTC
8b59eb6 Merge branch 'master' into marko/4698grpc_priv 11 June 2020, 14:49:49 UTC
bdac081 p2p: proto leftover (#4995) ## Description removing codec.go from p2p pkg and some leftover amino encoding Closes: #XXX 11 June 2020, 14:37:29 UTC
f6243d8 privval: migrate to protobuf (#4985) 11 June 2020, 09:54:02 UTC
31a361d proto: move keys to oneof (#4983) 11 June 2020, 09:10:37 UTC
18d333c docs: update amnesia adr (#4994) 10 June 2020, 18:17:32 UTC
a057da6 toml: make sections standout (#4993) ## Description make sections in the toml standout. Making this PR as I found it hard to find different sections on the `config.toml` when it was generated. This makes it somewhat simpler Closes: #XXX 10 June 2020, 17:49:27 UTC
b1dba35 light: added more tests for pruning, initialization and bisection (#4978) 10 June 2020, 16:56:24 UTC
46f6d17 crypto/merkle: remove simple prefix (#4989) ## Description This PR removes simple prefix from all types in the crypto/merkle directory. The two proto types `Proof` & `ProofOp` have been moved to the `proto/crypto/merkle` directory. proto messge `Proof` was renamed to `ProofOps` and `SimpleProof` message to `Proof`. Closes: #2755 10 June 2020, 14:57:38 UTC
d54de61 consensus: proto migration (#4984) ## Description migrate consensus to protobuf Closes: #XXX 10 June 2020, 12:08:47 UTC
5697e14 evidence: adr56 form amnesia evidence (#4821) Creates Amnesia Evidence which is formed from Potential Amnesia Evidence with either a matching proof or after a period of time denoted as the Amnesia Trial Period. This also adds the code necessary so that Amnesia Evidence can be validated and committed on a block 10 June 2020, 11:53:55 UTC
65909a1 consensus: stricter on LastCommitRound check (#4970) LastCommitRound should always be >= 0 for heights > 1. In State.updateToState, last precommit is computed only when round greater than -1 and has votes. But "LastCommit" is always updated regardless of the condition. If there's no last precommit, "LastCommit" is set to (*types.VoteSet)(nil). That's why "LastCommit" can be -1 for heights > 1. To fix it, only update State.RoundState.LastCommit when there is last precommit. Fixes #2737 Co-authored-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> 10 June 2020, 07:13:38 UTC
660e72a p2p/conn: migrate to Protobuf (#4990) Migrates the p2p connections to Protobuf. Supersedes #4800. gogoproto's `NewDelimitedReader()` uses an internal buffer, which makes it unsuitable for reading individual messages from a shared reader (since any remaining data in the buffer will be discarded). We therefore add a new `protoio` package with an unbuffered `NewDelimitedReader()`. Additionally, the `NewDelimitedWriter()` returns the number of bytes written, and we've added `MarshalDelimited()` and `UnmarshalDelimited()`, to ease migration of existing code. 09 June 2020, 16:09:51 UTC
4d9f573 migration of privval module to gRPC 09 June 2020, 15:51:30 UTC
89665e7 types: Remove duplicated validation in VerifyCommit (#4991) 09 June 2020, 15:15:32 UTC
6961c7e crypto: removal of multisig (#4988) ## Description deprecation & removal of multisig. This key was only used in the sdk and now it has been added there Closes: #4715 Closes: #2163 09 June 2020, 08:13:49 UTC
9998527 evidence: migrate reactor to proto (#4949) ## Description migration of evidence reactor to proto Closes: #XXX 09 June 2020, 07:54:47 UTC
6ec58f1 rpc: support EXISTS operator in /tx_search query (#4979) Closes #4763 * check for Error after for loop ends so we don't silently ignore errors, which would lead to clients getting incomplete results Refs https://github.com/tendermint/tendermint/pull/4979/files#r436511572 09 June 2020, 05:30:05 UTC
a89f258 blockchain: proto migration (#4969) ## Description migration of blockchain reactors to protobuf Closes: #XXX 08 June 2020, 12:45:03 UTC
db8f1b3 migrate all JSON to new JSON encoder (#4975) Uses new JSON encoder in #4955 for all JSON. Branched off of #4968. 08 June 2020, 12:22:59 UTC
ba3a2dd rpc: replace Amino with new JSON encoder (#4968) Migrates the `rpc` package to use new JSON encoder in #4955. Branched off of that PR. Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing. 08 June 2020, 12:04:05 UTC
ccc9904 json: add Amino-compatible encoder/decoder (#4955) Amino-compatible JSON encoder/decoder, including bug compatibility. Interface types must be registered via `json.RegisterType()`. Unlike Amino, this allows floats to be encoded/decoded. Partial fix for #4828, needs code migration. 08 June 2020, 11:42:35 UTC
7a8224f state: proto migration (#4972) ## Description the second part of state proto migration Closes: #XXX 08 June 2020, 10:16:35 UTC
bd950c1 build(deps): [Security] Bump websocket-extensions from 0.1.3 to 0.1.4 in /docs (#4976) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** <details> <summary>Vulnerabilities fixed</summary> <p><em>Sourced from <a href="https://github.com/advisories/GHSA-g78m-2chm-r7qv">The GitHub Security Advisory Database</a>.</em></p> <blockquote> <p><strong>Regular Expression Denial of Service in websocket-extensions (NPM package)</strong></p> <h3>Impact</h3> <p>The ReDoS flaw allows an attacker to exhaust the server's capacity to process incoming requests by sending a WebSocket handshake request containing a header of the following form:</p> <pre><code>Sec-WebSocket-Extensions: a; b=&quot;\c\c\c\c\c\c\c\c\c\c ... </code></pre> <p>That is, a header containing an unclosed string parameter value whose content is a repeating two-byte sequence of a backslash and some other character. The parser takes exponential time to reject this header as invalid, and this will block the processing of any other work on the same thread. Thus if you are running a single-threaded server, such a request can render your service completely unavailable.</p> <h3>Patches</h3> <p>Users should upgrade to version 0.1.4.</p> <h3>Workarounds</h3> </tr></table> ... (truncated) <p>Affected versions: &lt; 0.1.4</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=websocket-extensions&package-manager=npm_and_yarn&previous-version=0.1.3&new-version=0.1.4)](https://dependabot.com/compatibility-score/?dependency-name=websocket-extensions&package-manager=npm_and_yarn&previous-version=0.1.3&new-version=0.1.4) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once CI passes on it, as requested by @marbar3778. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 08 June 2020, 10:03:04 UTC
dcc6764 proto: remove amino proto tests (#4982) ## Description These tests were made to test the compatibility of amino and protobuf. Since we are moving to protobuf they are not needed anymore. The proto3 directory was created to be used only in these tests Closes: #XXX 08 June 2020, 09:49:47 UTC
4d422e4 p2p: expose SaveAs on NodeKey (#4981) Closes #4681 08 June 2020, 09:36:46 UTC
3b256cc p2p/pex: migrate to Protobuf (#4973) ## Description migrate p2p/pex to protobuf Closes: #XXX 08 June 2020, 09:23:58 UTC
0bc0446 readme: add source graph badge (#4980) ## Description <img width="1140" alt="Screen Shot 2020-06-08 at 9 29 15 AM" src="https://user-images.githubusercontent.com/24299864/84003556-87e85800-a96a-11ea-828b-3656f116b518.png"> Closes: #XXX 08 June 2020, 07:51:52 UTC
4a87d60 light: migrate to proto (#4964) 08 June 2020, 07:14:58 UTC
f9f4916 store: proto migration (#4974) ## Description migrate store to protobuf Closes: #XXX 08 June 2020, 06:43:29 UTC
6cfbe1e build(deps): Bump github.com/stretchr/testify from 1.6.0 to 1.6.1 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.6.0...v1.6.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> 08 June 2020, 05:05:29 UTC
b76b270 blockchain/v2: correctly set block store base in status responses (#4971) See: https://github.com/tendermint/tendermint/pull/4969#pullrequestreview-425298225 05 June 2020, 15:18:12 UTC
9ef266b types: migrate params to protobuf (#4962) 05 June 2020, 13:29:53 UTC
d4f1876 consensus: change logging and handling of height mismatch (#4954) 05 June 2020, 13:04:45 UTC
245794a types: remove VerifyFutureCommit (#4961) It was previously used by the now removed `lite` package. 05 June 2020, 12:31:30 UTC
b4aca98 proto: change to use gogofaster (#4957) 05 June 2020, 12:18:44 UTC
b9af87c state: proto migration (#4951) 05 June 2020, 08:47:16 UTC
ee91312 proto: add more to/from (#4956) ## Description adding in some more to/from methods/functions Closes: #XXX 05 June 2020, 04:42:04 UTC
dc49dcc evidence: json tags for DuplicateVoteEvidence (#4959) ## Description Add json tags to duplicate evidence Closes: #4958 04 June 2020, 22:41:16 UTC
a88537b ints: stricter numbers (#4939) 04 June 2020, 14:34:56 UTC
7c576f0 keys: change to []bytes (#4950) 04 June 2020, 13:32:42 UTC
d53a8d0 light: implement validate basic (#4916) run a validate basic on inbound validator sets and headers before further processing them 04 June 2020, 11:45:39 UTC
2302422 swagger: define version (#4952) ## Description try to further resolve rpc docs issue Closes: #XXX 04 June 2020, 09:58:25 UTC
7f8415d fix swagger page (#4948) ## Description _Please add a description of the changes that this PR introduces and the files that are the most critical to review._ Closes: #XXX 03 June 2020, 13:25:02 UTC
ce3c9c2 rpc/core: return an error if `page=0` (#4947) * rpc/core: return an error if `page=0` Closes #4942 affected endpoints: - /validators - /tx_search * swagger: update doc for /unconfirmed_txs 03 June 2020, 12:51:51 UTC
9949122 p2p/conn: add a test for MakeSecretConnection (#4829) Refs #4154 03 June 2020, 12:28:23 UTC
c848353 consensus: attempt to repair the WAL file on data corruption (#4682) Closes: #4578 Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> 03 June 2020, 11:14:12 UTC
c2578e2 light: rename lite2 to light & remove lite (#4946) This PR removes lite & renames lite2 to light throughout the repo Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> Closes: #4944 03 June 2020, 10:13:42 UTC
395d58c docs: document open file limit in production guide (#4945) See e.g. https://github.com/tendermint/tendermint/issues/4925#issuecomment-637929251 for people getting hit by this. Should we document it elsewhere as well? 03 June 2020, 09:34:25 UTC
4e6a844 statesync: use Protobuf instead of Amino for p2p traffic (#4943) ## Description Closes: #XXX 03 June 2020, 08:43:50 UTC
123beea lite2: compare header with witnesses in parallel (#4935) Closes #4801 03 June 2020, 07:32:51 UTC
2af939a lite2: check header w/ witnesses only when doing bisection (#4929) * lite2: check header w/ witnesses only when doing bisection Closes #4872 We don't need to check witnesses if we're doing backwards hash chain verification. I also think we don't need to do it when sequential verification is being used. * lite2: require 1 witness only when verificationMode=skipping https://github.com/tendermint/tendermint/pull/4929#pullrequestreview-423256477 we don't need witnesses when performing sequential verification (except when primary fails) 03 June 2020, 07:11:19 UTC
af1d16b lite2: allow bigger requests to LC proxy (#4930) Closes #4838 Previously, we're only setting MaxOpenConnections, whereas we should set all config variables based on user's config.toml. 03 June 2020, 06:54:14 UTC
99d88cb crypto: remove key suffixes (#4941) ## Description - remove keyname suffix from keys Closes: #2228 03 June 2020, 05:46:29 UTC
0da7d87 proto: move mempool to proto (#4940) * proto: move mempool to proto - changes according to moving the mempool reactor to proto Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> Closes: #2883 03 June 2020, 05:30:52 UTC
26bea83 evidence: retrieve header at height of evidence for validation (#4870) validation of lunatic evidence requires that the node retrieve the header at the height of the infringement from the block store for comparison 03 June 2020, 04:44:06 UTC
e538ea0 consensus: fix startnextheightcorrectly test (#4938) 02 June 2020, 20:46:03 UTC
8ab0a4c lite2: correctly return the results of the "latest" block (#4931) Closes #4837 - `/block_results` before: failed to update light client to 7: failed to obtain the header #7: signed header not found after: We can't return the latest block results because we won't be able to prove them. Return the results for the previous block instead. - /block_results?height=X` no changes 02 June 2020, 14:51:50 UTC
da924fc rpc: add BlockByHash to Client (#4923) Ethermint currently has to maintain a map height-> block hash on the store (see here) as it needs to expose the eth_getBlockByHash JSON-RPC query for Web3 compatibility. This query is currently not supported by the tendermint RPC client. 01 June 2020, 05:04:45 UTC
0572315 build(deps): Bump vuepress-theme-cosmos from 1.0.165 to 1.0.166 in /docs (#4920) Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.165 to 1.0.166. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/cosmos/vuepress-theme-cosmos/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=vuepress-theme-cosmos&package-manager=npm_and_yarn&previous-version=1.0.165&new-version=1.0.166)](https://dependabot.com/compatibility-score/?dependency-name=vuepress-theme-cosmos&package-manager=npm_and_yarn&previous-version=1.0.165&new-version=1.0.166) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @marbar3778. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 29 May 2020, 12:45:08 UTC
29e5079 CHANGELOG: add 0.32.12 changelog entry (#4918) 29 May 2020, 11:49:10 UTC
4f009e3 build(deps): Bump github.com/stretchr/testify from 1.5.1 to 1.6.0 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.5.1 to 1.6.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](https://github.com/stretchr/testify/compare/v1.5.1...v1.6.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> 29 May 2020, 11:35:10 UTC
d5a60b0 rpc: increase waitForEventTimeout to 8 seconds (#4917) ## Description I was able to reproduce this non-determinism locally After increasing the timeout to 8 seconds from 5 I was not able to reproduce it Closes: #2856 29 May 2020, 11:05:50 UTC
bdf268e CHANGELOG: update to reflect 0.33.5 (#4915) Final step of a point release. 29 May 2020, 10:49:44 UTC
8b50ff6 only retrieve pubkey once for all validators (partially fixes #4865) (#4895) ## Description in consensus/state.go, when calulating metrics, retrieve address (ergo, pubkey) once prior to iterating over validatorset to ensure we do not make excessive calls to signer. Partially closes: #4865 29 May 2020, 06:15:46 UTC
89cdc4b consensus: increase ensureTimeout (#4891) attempt to fix #4270 TestMempoolProgressAfterCreateEmptyBlocksInterval and other tests which rely on ensureTimeout 29 May 2020, 06:02:24 UTC
75e19f9 CONTRIBUTING: update minor release process (#4909) Updates our development and release process to match the process outlined in #4860. Also elaborates on a few git/Github conventions that we've discussed in the past. 28 May 2020, 20:28:59 UTC
a27317d ci: add timeouts (#4912) ## Description Add Timeouts to Github action jobs. The goal of adding timeouts is so if a job is hanging on something it gets killed and the author will get notified. I picked these times based on previous circle and Github action times then doubled & in some places tripled the times. Closes: #XXX 28 May 2020, 13:09:59 UTC
aded0b0 build(deps): Bump vuepress-theme-cosmos from 1.0.164 to 1.0.165 in /docs Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.164 to 1.0.165. - [Release notes](https://github.com/cosmos/vuepress-theme-cosmos/releases) - [Commits](https://github.com/cosmos/vuepress-theme-cosmos/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> 28 May 2020, 11:56:48 UTC
8cd3dec types: create ValidateBasic() funcs for validator and validator set (#4905) 28 May 2020, 09:40:39 UTC
e69a3d9 rpc/test: wait for subscription in TestTxEventsSentWithBroadcastTxAsync (#4907) Mitigates race condition causing these test failures: ``` === RUN TestTxEventsSentWithBroadcastTxAsync === RUN TestTxEventsSentWithBroadcastTxAsync/*http.HTTP I[2020-05-25|12:29:08.477] Starting WSEvents service impl=WSEvents TestTxEventsSentWithBroadcastTxAsync/*http.HTTP: event_test.go:124: Error Trace: event_test.go:124 Error: Expected nil, but got: &errors.errorString{s:"timed out waiting for event"} Test: TestTxEventsSentWithBroadcastTxAsync/*http.HTTP Messages: 0: timed out waiting for event ``` 27 May 2020, 11:49:57 UTC
f146ef2 p2p: remove nil guard (#4901) https://github.com/tendermint/tendermint/pull/4893#discussion_r430940912 27 May 2020, 11:36:42 UTC
804e2d1 rpc/test: wait for mempool CheckTx callback (#4908) Fixes race conditions causing the following test failures: ``` === RUN TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:342: Error Trace: rpc_test.go:342 Error: Not equal: expected: 1 actual : 0 Test: TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:343: Error Trace: rpc_test.go:343 Error: Not equal: expected: 1 actual : 0 Test: TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:345: Error Trace: rpc_test.go:345 Error: Not equal: expected: types.Txs{types.Tx{0x39, 0x44, 0x4d, 0x6c, 0x4b, 0x66, 0x46, 0x78, 0x3d, 0x45, 0x33, 0x33, 0x68, 0x47, 0x6e, 0x79, 0x58}} actual : types.Txs(nil) Diff: --- Expected +++ Actual @@ -1,4 +1,2 @@ -(types.Txs) (len=1) { - (types.Tx) (len=17) Tx{39444D6C4B6646783D45333368476E7958} -} +(types.Txs) <nil> Test: TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:342: Error Trace: rpc_test.go:342 Error: Not equal: expected: 1 actual : 0 Test: TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:343: Error Trace: rpc_test.go:343 Error: Not equal: expected: 1 actual : 0 Test: TestUnconfirmedTxs TestUnconfirmedTxs: rpc_test.go:345: Error Trace: rpc_test.go:345 Error: Not equal: expected: types.Txs{types.Tx{0x39, 0x44, 0x4d, 0x6c, 0x4b, 0x66, 0x46, 0x78, 0x3d, 0x45, 0x33, 0x33, 0x68, 0x47, 0x6e, 0x79, 0x58}} actual : types.Txs{} Diff: --- Expected +++ Actual @@ -1,3 +1,2 @@ -(types.Txs) (len=1) { - (types.Tx) (len=17) Tx{39444D6C4B6646783D45333368476E7958} +(types.Txs) { } Test: TestUnconfirmedTxs --- FAIL: TestUnconfirmedTxs (0.20s) === RUN TestNumUnconfirmedTxs TestNumUnconfirmedTxs: rpc_test.go:364: Error Trace: rpc_test.go:364 Error: Not equal: expected: 1 actual : 0 Test: TestNumUnconfirmedTxs TestNumUnconfirmedTxs: rpc_test.go:365: Error Trace: rpc_test.go:365 Error: Not equal: expected: 1 actual : 0 Test: TestNumUnconfirmedTxs TestNumUnconfirmedTxs: rpc_test.go:364: Error Trace: rpc_test.go:364 Error: Not equal: expected: 1 actual : 0 Test: TestNumUnconfirmedTxs TestNumUnconfirmedTxs: rpc_test.go:365: Error Trace: rpc_test.go:365 Error: Not equal: expected: 1 actual : 0 Test: TestNumUnconfirmedTxs --- FAIL: TestNumUnconfirmedTxs (0.09s) ``` 27 May 2020, 11:24:05 UTC
f100079 types/test: remove slow test cases in TestValSetUpdatePriorityOrderTests (#4903) These test cases are extremely slow when running with the race detector, often taking more that 2 minutes on my local machine. I can easily see them timing out on the much slower CI machines, causing these failures: ``` panic: test timed out after 5m0s goroutine 234 [running]: testing.(*M).startAlarm.func1() /usr/local/go/src/testing/testing.go:1460 +0x11c created by time.goFunc /usr/local/go/src/time/sleep.go:168 +0x52 goroutine 1 [chan receive, 4 minutes]: testing.(*T).Run(0xc000172c60, 0x107a5a2, 0x22, 0x11bfc68, 0x1) /usr/local/go/src/testing/testing.go:1044 +0x699 testing.runTests.func1(0xc000172c60) /usr/local/go/src/testing/testing.go:1285 +0xa7 testing.tRunner(0xc000172c60, 0xc00012bcc8) /usr/local/go/src/testing/testing.go:992 +0x1ec testing.runTests(0xc00000e2c0, 0x1901500, 0x72, 0x72, 0x0) /usr/local/go/src/testing/testing.go:1283 +0x528 testing.(*M).Run(0xc000214380, 0x0) /usr/local/go/src/testing/testing.go:1200 +0x300 github.com/tendermint/tendermint/types.TestMain(0xc000214380) /go/src/github.com/tendermint/tendermint/types/block_test.go:30 +0x59 main.main() _testmain.go:380 +0x334 goroutine 255 [runnable]: bytes.Equal(...) /usr/local/go/src/bytes/bytes.go:20 github.com/tendermint/tendermint/types.(*ValidatorSet).GetByAddress(0xc005499020, 0xc006056650, 0x5, 0x8, 0x13af, 0xc005514100) /go/src/github.com/tendermint/tendermint/types/validator_set.go:253 +0xfd github.com/tendermint/tendermint/types.verifyUpdates.func1(0xc00614b940, 0xc005499020, 0x47cd) /go/src/github.com/tendermint/tendermint/types/validator_set.go:415 +0x84 github.com/tendermint/tendermint/types.verifyUpdates(0xc006110000, 0x11b7, 0x1780, 0xc005499020, 0xb52ff, 0x0, 0x0, 0x5c9) /go/src/github.com/tendermint/tendermint/types/validator_set.go:429 +0x220 github.com/tendermint/tendermint/types.(*ValidatorSet).updateWithChangeSet(0xc005499020, 0xc00602c000, 0x1780, 0x1780, 0xc006098201, 0xc00608d4b8, 0xc006037bf8) /go/src/github.com/tendermint/tendermint/types/validator_set.go:600 +0x2f3 github.com/tendermint/tendermint/types.(*ValidatorSet).UpdateWithChangeSet(0xc005499020, 0xc00602c000, 0x1780, 0x1780, 0x1780, 0x1780) /go/src/github.com/tendermint/tendermint/types/validator_set.go:636 +0x78 github.com/tendermint/tendermint/types.applyChangesToValSet(0xc0005c8ea0, 0x0, 0x0, 0xc005499020, 0xc0005d1160, 0x3, 0x3) /go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1169 +0x1bb github.com/tendermint/tendermint/types.verifyValSetUpdatePriorityOrder(0xc0005c8ea0, 0xc005499020, 0x0, 0x0, 0xc005600000, 0x2710, 0x2710, 0xc0055c8000, 0x5c9, 0x5c9, ...) /go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1239 +0x217 github.com/tendermint/tendermint/types.TestValSetUpdatePriorityOrderTests(0xc0005c8ea0) /go/src/github.com/tendermint/tendermint/types/validator_set_test.go:1228 +0x1205 testing.tRunner(0xc0005c8ea0, 0x11bfc68) /usr/local/go/src/testing/testing.go:992 +0x1ec created by testing.(*T).Run /usr/local/go/src/testing/testing.go:1043 +0x661 FAIL github.com/tendermint/tendermint/types 300.677s FAIL ``` 27 May 2020, 11:10:49 UTC
287110d consensus: bring back log.Error statement (#4899) Refs #3406 cs.Logger is protected by a global mutex, so it cannot be a reason for the halt in #3401. 27 May 2020, 09:31:02 UTC
2014357 evidence: remove header from phantom evidence (#4892) 27 May 2020, 07:20:45 UTC
d0dcf81 rpc/test: fix test race in TestAppCalls (#4894) Fixes the following test race condition: ``` === RUN TestAppCalls TestAppCalls: rpc_test.go:216: Error Trace: rpc_test.go:216 Error: Expected value not to be nil. Test: TestAppCalls --- FAIL: TestAppCalls (2.20s) ``` 26 May 2020, 16:08:42 UTC
f497846 p2p/test: fix Switch test race condition (#4893) 26 May 2020, 15:50:07 UTC
3c1cb77 lite2/http: fix provider test by increasing the block retention value (#4890) 26 May 2020, 15:17:43 UTC
40d5c7f p2p/test: wait for listener to get ready (#4881) Attempt to fix this the below test failure by waiting for the listener to get ready. I am not at all convinced that this is the correct fix - the below indicates that the TCP socket was closed after it was set up - but I'm unable to come up with an actionable hypothesis for what caused it. ``` 2020/05/14 17:25:11 Failed to accept conn: accept tcp 127.0.0.1:44737: use of closed network connection 2020/05/14 17:25:11 Failed to accept conn: accept tcp 127.0.0.1:42589: use of closed network connection 2020/05/14 17:25:11 Failed to accept conn: accept tcp 127.0.0.1:40905: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:39847: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:39989: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:43587: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:35415: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:38657: use of closed network connection 2020/05/14 17:25:12 Failed to accept conn: accept tcp 127.0.0.1:38217: use of closed network connection 2020/05/14 17:25:13 Failed to accept conn: accept tcp 127.0.0.1:42247: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:39705: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:39491: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:37107: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:39909: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:37987: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:41505: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:39121: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:46569: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:45643: use of closed network connection 2020/05/14 17:25:16 Failed to accept conn: accept tcp 127.0.0.1:35289: use of closed network connection --- FAIL: TestTransportMultiplexAcceptMultiple (0.43s) transport_test.go:200: auth failure: handshake failed: EOF FAIL ``` 26 May 2020, 13:34:28 UTC
187120a types: remove unnecessary sort call (#4876) in TestValSetUpdatePriorityOrderTests https://app.circleci.com/pipelines/github/tendermint/tendermint/3849/workflows/6d241fc8-72a8-4a3b-b3fc-887a48518f82/jobs/114996 also, reduce the number of reactors in TestReactorBroadcastTxMessage https://app.circleci.com/pipelines/github/tendermint/tendermint/3797/workflows/935cda34-dfb3-46e9-8257-92277171c91b/jobs/114562 26 May 2020, 13:16:58 UTC
b9a0d47 test/blockchain/v0: mitigate test data race (#4886) Mitigates the below data race. The proper fix involves not fiddling with reactor internals, which needs a rewrite of the test and possible additional reactor infrastructure. ``` ================== WARNING: DATA RACE Write at 0x00c001118e78 by goroutine 187: github.com/tendermint/tendermint/blockchain/v0.TestBadBlockStopsPeer() /go/src/github.com/tendermint/tendermint/blockchain/v0/reactor_test.go:234 +0x9d7 testing.tRunner() /usr/local/go/src/testing/testing.go:992 +0x1eb Previous read at 0x00c001118e78 by goroutine 326: [failed to restore the stack] Goroutine 187 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:1043 +0x660 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1285 +0xa6 testing.tRunner() /usr/local/go/src/testing/testing.go:992 +0x1eb testing.runTests() /usr/local/go/src/testing/testing.go:1283 +0x527 testing.(*M).Run() /usr/local/go/src/testing/testing.go:1200 +0x2ff main.main() _testmain.go:112 +0x337 Goroutine 326 (running) created at: github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).OnStart() /go/src/github.com/tendermint/tendermint/blockchain/v0/reactor.go:118 +0x12c github.com/tendermint/tendermint/libs/service.(*BaseService).Start() /go/src/github.com/tendermint/tendermint/libs/service/service.go:140 +0x504 github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).Start() <autogenerated>:1 +0x43 github.com/tendermint/tendermint/p2p.(*Switch).OnStart() /go/src/github.com/tendermint/tendermint/p2p/switch.go:225 +0x120 github.com/tendermint/tendermint/libs/service.(*BaseService).Start() /go/src/github.com/tendermint/tendermint/libs/service/service.go:140 +0x504 github.com/tendermint/tendermint/p2p.StartSwitches() /go/src/github.com/tendermint/tendermint/p2p/test_util.go:168 +0x75 github.com/tendermint/tendermint/p2p.MakeConnectedSwitches() /go/src/github.com/tendermint/tendermint/p2p/test_util.go:89 +0x17d github.com/tendermint/tendermint/blockchain/v0.TestBadBlockStopsPeer() /go/src/github.com/tendermint/tendermint/blockchain/v0/reactor_test.go:209 +0x768 testing.tRunner() /usr/local/go/src/testing/testing.go:992 +0x1eb ================== panic: BlockStore can only save contiguous blocks. Wanted 149, got 147 goroutine 1259 [running]: github.com/tendermint/tendermint/store.(*BlockStore).SaveBlock(0xc000ff9cc0, 0xc001997180, 0xc0010c6a00, 0xc0013b3000) /go/src/github.com/tendermint/tendermint/store/store.go:276 +0xbc4 github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).poolRoutine(0xc001118d00, 0x107c000) /go/src/github.com/tendermint/tendermint/blockchain/v0/reactor.go:355 +0xe90 created by github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).OnStart /go/src/github.com/tendermint/tendermint/blockchain/v0/reactor.go:118 +0x12d FAIL github.com/tendermint/tendermint/blockchain/v0 11.447s FAIL ``` 26 May 2020, 11:51:37 UTC
0566646 test/abci: use random socket names to avoid collisions (#4885) Fixes these test failures: ``` === RUN TestKVStore ### Testing KVStore I[2020-05-25|13:32:31.303] Starting ABCIServer service module=abci-server impl=ABCIServer TestKVStore: example_test.go:48: Error Trace: example_test.go:48 example_test.go:28 Error: Received unexpected error: listen unix test.sock: bind: address already in use Test: TestKVStore Messages: Error starting socket server --- FAIL: TestKVStore (0.00s) ``` 26 May 2020, 11:33:49 UTC
7866f4a ci: migrate localnet to github actions (#4878) ## Description This PR moves `localnet` from circleci to github actions. Would we like to add longer lived nets? Closes: #XXX 26 May 2020, 08:10:41 UTC
89a3cb2 libs: remove kv (#4874) ## Description In https://github.com/tendermint/tendermint/pull/4466 a new type was created (EventAttribute) that replaced KV.Pair. This made the type Pair deadcode, this pr removes that type. I don't think a changelog entry is needed since it is not being used anymore. But will add a section to the upgrading.md to let users know that it was replaced Closes: #XXX 26 May 2020, 06:37:24 UTC
e03b61a proto: add proto files for ibc unblock (#4853) ## Description these proto files are meant to help unblock ibc in their quest of migrating the ibc module to proto. Closes: #XXX 25 May 2020, 15:52:34 UTC
970cbba blockchain[v1]: increased timeout times for peer tests (#4871) 25 May 2020, 15:33:13 UTC
439a06a p2p: TestTransportMultiplexAcceptNonBlocking and TestTransportMultiplexConnFilterTimeout (#4868) * p2p: log error in transport tests * p2p: exit from fast peer only when handshake is done TestTransportMultiplexAcceptNonBlocking fixes panic: write to a closed channel * p2p: increase timeout in TestTransportMultiplexConnFilterTimeout Fixes https://github.com/tendermint/tendermint/issues/4854#issuecomment-630739200 * p2p: yield control to another goroutine manually * increase timeout in TestTransportMultiplexAcceptNonBlocking 25 May 2020, 15:01:34 UTC
976eebe ci: bump the timeout for test_coverage (#4864) ## Description bumping the timeout on test_coverage as the amount of tests have increased causing quite a few timeouts. Closes: #XXX 22 May 2020, 12:04:01 UTC
1b50b4e lite2: fix pivot height during bisection (#4850) 20 May 2020, 04:33:45 UTC
back to top