Skip to main content

Browse the archive

https://github.com/tendermint/tendermint
05 April 2024, 22:58:32 UTC
sort by:
Revision Author Date Message Commit Date
716e67e William Banfield 27 January 2022, 16:24:58 UTC add changelog entry 27 January 2022, 16:24:58 UTC
5abe68e William Banfield 27 January 2022, 16:10:26 UTC remove initial height time from timely 27 January 2022, 16:10:26 UTC
b2be476 William Banfield 27 January 2022, 16:03:31 UTC Merge branch 'master' into wb/genesis-time-change 27 January 2022, 16:03:31 UTC
4b34911 William Banfield 27 January 2022, 15:50:55 UTC rename firstHeight 27 January 2022, 15:50:55 UTC
fc32180 William Banfield 27 January 2022, 15:45:04 UTC rename height1 to firstHeight 27 January 2022, 15:45:04 UTC
71923c8 Anca Zamfir 27 January 2022, 14:58:53 UTC Use proposer timestamp instead of genesis time for height 1 block time (#7541) 27 January 2022, 15:33:17 UTC
db3044f mempirate 27 January 2022, 15:24:01 UTC rpc: add application info to `status` call (#7701) * rpc/coretypes: add `ApplicationInfo` to `ResultStatus` * internal/rpc/core: return application version Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: M. J. Fromberger <michael.j.fromberger@gmail.com> 27 January 2022, 15:24:01 UTC
04bcfec William Banfield 27 January 2022, 14:42:56 UTC metrics: add metric for proposal timestamp difference (#7709) Moving this over from the proposer-based timestamps branch #7550. 27 January 2022, 14:42:56 UTC
5eb50a4 M. J. Fromberger 27 January 2022, 13:33:11 UTC ci: fix super-linter configuration settings (#7708) - Revert the version pin from #7706. - Override the YAML linter config to be more forgiving. - Update YAML lint warnings in a number of files. The choice of which lints to fix and which to override was ad hoc: I fixed the ones that were mainly whitespace oriented, and suppressed the ones that were document-structure related. Fixes #7707. 27 January 2022, 13:33:11 UTC
1ac5846 M. J. Fromberger 26 January 2022, 20:40:23 UTC Forward-port v0.35.1 changelogs. (#7705) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> 26 January 2022, 20:40:23 UTC
b37c10c William Banfield 26 January 2022, 20:29:54 UTC params: increase default synchrony params (#7704) 26 January 2022, 20:29:54 UTC
09c41dc M. J. Fromberger 26 January 2022, 19:57:44 UTC Pin super-linter to a less noisy version. (#7706) The latest point release includes https://github.com/github/super-linter/pull/2295 which enables a bunch of checks that break existing use. 26 January 2022, 19:57:44 UTC
61f3aa0 William Banfield 26 January 2022, 19:50:31 UTC consensus: use buffered channel in TestStateFullRound1 (#7668) 26 January 2022, 19:50:31 UTC
7fbad97 dependabot[bot] 26 January 2022, 17:26:40 UTC build(deps): Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (#7695) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](https://github.com/grpc/grpc-go/compare/v1.43.0...v1.44.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 26 January 2022, 17:26:40 UTC
2c9dec5 JayT106 26 January 2022, 17:12:00 UTC remove duplicate ABCIVersion (#7703) 26 January 2022, 17:12:00 UTC
05d8a0b M. J. Fromberger 26 January 2022, 16:33:13 UTC Mark ADR 075 as "accepted". (#7699) 26 January 2022, 16:33:13 UTC
0aa3b0b William Banfield 26 January 2022, 16:00:23 UTC Proposer-Based Timestamps Merge (#7605) This pull request merges in the changes for implementing Proposer-based timestamps into `master`. The power was primarily being done in the `wb/proposer-based-timestamps` branch, with changes being merged into that branch during development. This pull request represents an amalgamation of the changes made into that development branch. All of the changes that were placed into that branch have been cleanly rebased on top of the latest `master`. The changes compile and the tests pass insofar as our tests in general pass. ### Note To Reviewers These changes have been extensively reviewed during development. There is not much new here. In the interest of making effective use of time, I would recommend against trying to perform a complete audit of the changes presented and instead examine for mistakes that may have occurred during the process of rebasing the changes. I gave the complete change set a first pass for any issues, but additional eyes would be very appreciated. In sum, this change set does the following: closes #6942 merges in #6849 26 January 2022, 16:00:23 UTC
441ecba M. J. Fromberger 26 January 2022, 15:01:55 UTC types: rename and extend the EventData interface (#7687) This is the interface shared by types that can be used as event data in, for example, subscriptions via the RPC. To be compatible with the RPC service, data need to support JSON encoding. Require this as part of the interface. 26 January 2022, 15:01:55 UTC
fcfe157 M. J. Fromberger 26 January 2022, 14:23:20 UTC Remove unused xsalsa20symmetric package. (#7691) This package has no uses within Tendermint core. PR https://github.com/cosmos/cosmos-sdk/pull/11027 replaces the use in the Cosmos SDK. A follow-up to #7689 and #7690. 26 January 2022, 14:23:20 UTC
f64d64a M. J. Fromberger 26 January 2022, 14:19:32 UTC ADR 074: RPC Event Subscription Interface (#7677) Status: Proposed. 26 January 2022, 14:19:32 UTC
b920cd4 dependabot[bot] 26 January 2022, 14:05:21 UTC build(deps): Bump github.com/golangci/golangci-lint from 1.43.0 to 1.44.0 (#7692) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.43.0 to 1.44.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p> <blockquote> <h2>v1.44.0</h2> <h2>Changelog</h2> <ul> <li>32cf48ed Add &quot;grouper&quot; linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2497">#2497</a>)</li> <li>63f150ea Add decorder linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2453">#2453</a>)</li> <li>55358972 Add errchkjson linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2362">#2362</a>)</li> <li>e3d0247e Add maintidx linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2435">#2435</a>)</li> <li>d2093896 Add support for multiple outputs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2386">#2386</a>)</li> <li>efb35995 Bump github.com/ashanbrown/forbidigo from 1.2.0 to 1.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2487">#2487</a>)</li> <li>6e2e51d8 Bump makezero to v1.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2490">#2490</a>)</li> <li>e788757b Ensure that the Issues key in JSON format is a list (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2358">#2358</a>)</li> <li>eaed228d Print error text in tag content for more readable junit report (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2460">#2460</a>)</li> <li>b5d8e698 Return error if any linter fails to run (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2471">#2471</a>)</li> <li>ec58c481 Show deprecated mark in the CLI linters help (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2350">#2350</a>)</li> <li>68f530a8 add containedctx linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2382">#2382</a>)</li> <li>c53eb78a asciicheck: bump to v0.1.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2510">#2510</a>)</li> <li>ae537189 bodyclose: bump to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2508">#2508</a>)</li> <li>ba3453d2 build(deps): bump actions/cache from 2.1.6 to 2.1.7 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2383">#2383</a>)</li> <li>80659f85 build(deps): bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2491">#2491</a>)</li> <li>8bc95624 build(deps): bump github.com/breml/bidichk from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2354">#2354</a>)</li> <li>f311ffd2 build(deps): bump github.com/breml/errchkjson from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2493">#2493</a>)</li> <li>ec2820c5 build(deps): bump github.com/esimonov/ifshort from 1.0.3 to 1.0.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2436">#2436</a>)</li> <li>83962f47 build(deps): bump github.com/fzipp/gocyclo from 0.3.1 to 0.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2425">#2425</a>)</li> <li>6ddb9071 build(deps): bump github.com/go-critic/go-critic from 0.6.1 to 0.6.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2474">#2474</a>)</li> <li>a79803fa build(deps): bump github.com/kulti/thelper from 0.4.0 to 0.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2492">#2492</a>)</li> <li>9e129498 build(deps): bump github.com/ldez/tagliatelle from 0.2.0 to 0.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2454">#2454</a>)</li> <li>0ac5d371 build(deps): bump github.com/mattn/go-colorable from 0.1.11 to 0.1.12 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2384">#2384</a>)</li> <li>620bd9bb build(deps): bump github.com/mgechev/revive from 1.1.2 to 1.1.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2517">#2517</a>)</li> <li>ecbb9c47 build(deps): bump github.com/nishanths/exhaustive from 0.3.6 to 0.6.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2353">#2353</a>)</li> <li>fc888cf0 build(deps): bump github.com/nishanths/exhaustive from 0.6.0 to 0.7.11 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2371">#2371</a>)</li> <li>88d3ec0f build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2455">#2455</a>)</li> <li>131ab76b build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2472">#2472</a>)</li> <li>441d8443 build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2519">#2519</a>)</li> <li>7d5bc8f0 build(deps): bump github.com/securego/gosec/v2 from 2.9.1 to 2.9.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2372">#2372</a>)</li> <li>d0aead44 build(deps): bump github.com/securego/gosec/v2 from 2.9.2 to 2.9.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2385">#2385</a>)</li> <li>56f27d0a build(deps): bump github.com/securego/gosec/v2 from 2.9.3 to 2.9.5 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2413">#2413</a>)</li> <li>9bad615c build(deps): bump github.com/securego/gosec/v2 from 2.9.5 to 2.9.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2516">#2516</a>)</li> <li>d29d9f12 build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.10 to 3.21.11 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2405">#2405</a>)</li> <li>b4a3bd8c build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2456">#2456</a>)</li> <li>ca8cd60f build(deps): bump github.com/spf13/cobra from 1.2.1 to 1.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2426">#2426</a>)</li> <li>4ca6a2fc build(deps): bump github.com/spf13/viper from 1.10.0 to 1.10.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2424">#2424</a>)</li> <li>f960879b build(deps): bump github.com/spf13/viper from 1.9.0 to 1.10.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2412">#2412</a>)</li> <li>018befd3 build(deps): bump github.com/tommy-muehle/go-mnd/v2 from 2.4.0 to 2.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2518">#2518</a>)</li> <li>8cdecc96 build(deps): bump gitlab.com/bosi/decorder from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2473">#2473</a>)</li> <li>4119132f build(deps): bump honnef.co/go/tools from 0.2.1 to 0.2.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2370">#2370</a>)</li> <li>b845512b build(deps): bump mvdan.cc/gofumpt from 0.1.1 to 0.2.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2373">#2373</a>)</li> <li>107b8307 build(deps): bump mvdan.cc/gofumpt from 0.2.0 to 0.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2427">#2427</a>)</li> <li>49501691 bump bidichk from v0.1.1 to v0.2.0</li> <li>a471733b bump github.com/yeya24/promlinter from v0.1.0 to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2500">#2500</a>)</li> <li>7f25fee1 bump varnamelen from v0.4.0 to v0.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2369">#2369</a>)</li> <li>1b535204 bump varnamelen to v0.4.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2348">#2348</a>)</li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md">github.com/golangci/golangci-lint's changelog</a>.</em></p> <blockquote> <h3>v1.44.0</h3> <ol> <li>new linters: <ul> <li><code>containedctx</code>: <a href="https://github.com/sivchari/containedctx">https://github.com/sivchari/containedctx</a></li> <li><code>decorder</code>: <a href="https://gitlab.com/bosi/decorder">https://gitlab.com/bosi/decorder</a></li> <li><code>errchkjson</code>: <a href="https://github.com/breml/errchkjson">https://github.com/breml/errchkjson</a></li> <li><code>maintidx</code>: <a href="https://github.com/yagipy/maintidx">https://github.com/yagipy/maintidx</a></li> <li><code>grouper</code>: <a href="https://github.com/leonklingele/grouper">https://github.com/leonklingele/grouper</a></li> </ul> </li> <li>updated linters: <ul> <li><code>asciicheck</code>: bump to v0.1.1</li> <li><code>bidichk</code>: from 0.1.1 to 0.2.1</li> <li><code>bodyclose</code>: bump to HEAD</li> <li><code>decorder</code>: from 0.2.0 to 0.2.1</li> <li><code>depguard</code>: from 1.0.1 to 1.1.0</li> <li><code>errchkjson</code>: from 0.2.0 to 0.2.1</li> <li><code>errorlint</code>: bump to HEAD</li> <li><code>exhaustive</code>: drop deprecated/unused settings</li> <li><code>exhaustive</code>: from v0.2.3 to 0.7.11</li> <li><code>forbidigo</code>: from 1.2.0 to 1.3.0</li> <li><code>forcetypeassert</code>: bump to v0.1.0</li> <li><code>gocritic</code>: from 0.6.1 to 0.6.2</li> <li><code>gocritic</code>: support autofix</li> <li><code>gocyclo</code>: from 0.3.1 to 0.4.0</li> <li><code>godot</code>: add period option</li> <li><code>gofumpt</code>: from 0.1.1 to 0.2.1</li> <li><code>gomnd</code>: from 2.4.0 to 2.5.0</li> <li><code>gomnd</code>: new configuration</li> <li><code>gosec</code>: from 2.9.1 to 2.9.6</li> <li><code>ifshort</code>: from 1.0.3 to 1.0.4</li> <li><code>ineffassign</code>: bump to HEAD</li> <li><code>makezero</code>: to v1.1.0</li> <li><code>promlinter</code>: from v0.1.0 to HEAD</li> <li><code>revive</code>: fix <code>enableAllRules</code></li> <li><code>revive</code>: from 1.1.2 to 1.1.3</li> <li><code>staticcheck</code>: from 0.2.1 to 0.2.2</li> <li><code>tagliatelle</code>: from 0.2.0 to 0.3.0</li> <li><code>thelper</code>: from 0.4.0 to 0.5.0</li> <li><code>unparam</code>: bump to HEAD</li> <li><code>varnamelen</code>: bump to v0.5.0</li> <li><code>wrapcheck</code>: update configuration to include <code>ignoreSignRegexps</code></li> </ul> </li> <li>documentation: <ul> <li>linters: improve pages about configuration</li> <li>improve page about false-positive</li> <li><code>nolintlint</code>: fix wrong default value in comment</li> <li><code>revive</code>: add a more detailed configuration</li> </ul> </li> <li>misc: <ul> <li>outputs: Add support for multiple outputs</li> <li>outputs: Print error text in <code>&lt;failure&gt;</code> tag content for more readable JUnit output</li> <li>outputs: ensure that the Issues key in JSON format is a list</li> <li>Return error if any linter fails to run</li> </ul> </li> </ol> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint/commit/617470fa9e2c54dd91ab91c14e0d20030e183c20"><code>617470f</code></a> docs(revive): fix typo on the option <code>disabled</code>(<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2520">#2520</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/32cf48edc90e1c5ac21aa6d0ad21bd0dc9fcdf39"><code>32cf48e</code></a> Add &quot;grouper&quot; linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2497">#2497</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/620bd9bb3dbf9fc757ff70c9ab5993ef51cfef6f"><code>620bd9b</code></a> build(deps): bump github.com/mgechev/revive from 1.1.2 to 1.1.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2517">#2517</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/9bad615c906a37dba22dea92f2baa02fee1ba988"><code>9bad615</code></a> build(deps): bump github.com/securego/gosec/v2 from 2.9.5 to 2.9.6 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2516">#2516</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/441d84436d26b39a9ddef5f6355956e6fda5c275"><code>441d844</code></a> build(deps): bump github.com/quasilyte/go-ruleguard/dsl (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2519">#2519</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/018befd392339262c11a490ee437a6b0a39c3134"><code>018befd</code></a> build(deps): bump github.com/tommy-muehle/go-mnd/v2 from 2.4.0 to 2.5.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2518">#2518</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/1b53352339c85a026e711572159dea614569e737"><code>1b53352</code></a> docs: improve configuration documentation (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2514">#2514</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/44474a103e15ecbc631ce7cff0c714d5e3ad4440"><code>44474a1</code></a> forcetypeassert: bump to v0.1.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2511">#2511</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/c53eb78ae1c8973b7d0da15743d7d91e16cc6ab8"><code>c53eb78</code></a> asciicheck: bump to v0.1.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2510">#2510</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/171b3caef45032fce61ba66164eccc62c0f1855a"><code>171b3ca</code></a> ineffassign: bump to HEAD (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/2509">#2509</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.43.0...v1.44.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/golangci/golangci-lint&package-manager=go_modules&previous-version=1.43.0&new-version=1.44.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 26 January 2022, 14:05:21 UTC
51ffb95 M. J. Fromberger 26 January 2022, 13:44:24 UTC Remove unused chacha20poly1305 package. (#7690) Fixes #7689. 26 January 2022, 13:44:24 UTC
079c7af M. J. Fromberger 25 January 2022, 19:16:48 UTC pubsub: use concrete queries instead of an interface (#7686) Remove the pubsub.Query interface and instead use the concrete query type. Nothing uses any other implementation but pubsub/query. * query: remove the error from the Matches method * Update all usage. 25 January 2022, 19:16:48 UTC
f163acf Sam Kleinman 25 January 2022, 18:48:24 UTC clist: reduce size of test workload for clist implementation (#7682) 25 January 2022, 18:48:24 UTC
6a02714 Sam Kleinman 25 January 2022, 18:35:03 UTC rpc: check error code for broadcast_tx_commit (#7683) 25 January 2022, 18:35:03 UTC
5db7a7d dependabot[bot] 25 January 2022, 13:47:49 UTC build(deps): Bump github.com/vektra/mockery/v2 from 2.9.4 to 2.10.0 (#7685) Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.9.4 to 2.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p> <blockquote> <h2>v2.10.0</h2> <h2>Changelog</h2> <ul> <li>95b8d4d Add mock generation with expecter</li> <li>e5889c6 Merge branch 'master' into gejo-expecter-support</li> <li>66d6564 Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/396">#396</a> from Gevrai/gejo-expecter-support</li> <li>b702d89 Update README.md</li> </ul> <h2>v2.9.5</h2> <h2>Changelog</h2> <ul> <li>ff24d35 Adding more dependencies</li> <li>5626edf Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/427">#427</a> from vektra/update_deps</li> <li>21d2728 Upgrade all dependencies</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vektra/mockery/commit/66d6564919bfeb52daed0324189061793796de15"><code>66d6564</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/396">#396</a> from Gevrai/gejo-expecter-support</li> <li><a href="https://github.com/vektra/mockery/commit/e5889c659c99ac3c3e658fb45b877f0c6b75d916"><code>e5889c6</code></a> Merge branch 'master' into gejo-expecter-support</li> <li><a href="https://github.com/vektra/mockery/commit/b702d895c7a3b0b79926c2ca556a1e1810e6d779"><code>b702d89</code></a> Update README.md</li> <li><a href="https://github.com/vektra/mockery/commit/5626edfab263bbb19ee512e3f8de32560b8d4002"><code>5626edf</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/vektra/mockery/issues/427">#427</a> from vektra/update_deps</li> <li><a href="https://github.com/vektra/mockery/commit/ff24d35774bd4ef423484a5521d921363a472ab9"><code>ff24d35</code></a> Adding more dependencies</li> <li><a href="https://github.com/vektra/mockery/commit/21d27283772a6da6f31e46a759dbfcc593e6e3aa"><code>21d2728</code></a> Upgrade all dependencies</li> <li><a href="https://github.com/vektra/mockery/commit/95b8d4d7f0ce7034112f69343ed91a9544702147"><code>95b8d4d</code></a> Add mock generation with expecter</li> <li>See full diff in <a href="https://github.com/vektra/mockery/compare/v2.9.4...v2.10.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.9.4&new-version=2.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 25 January 2022, 13:47:49 UTC
2c90a86 Sam Kleinman 24 January 2022, 22:47:53 UTC tests: reduce timeout to 4m from 8m (#7681) 24 January 2022, 22:47:53 UTC
7878ca6 M. J. Fromberger 24 January 2022, 16:15:34 UTC Delete the custom libs/json (tmjson) package. (#7673) There are no further uses of this package anywhere in Tendermint. All the uses in the Cosmos SDK are for types that now work correctly with the standard encoding/json package. 24 January 2022, 16:15:34 UTC
f6ebd84 dependabot[bot] 24 January 2022, 13:57:39 UTC build(deps): Bump vuepress-theme-cosmos from 1.0.182 to 1.0.183 in /docs (#7680) Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.182 to 1.0.183. - [Release notes](https://github.com/cosmos/vuepress-theme-cosmos/releases) - [Commits](https://github.com/cosmos/vuepress-theme-cosmos/commits) --- updated-dependencies: - dependency-name: vuepress-theme-cosmos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> 24 January 2022, 13:57:39 UTC
80d3765 dependabot[bot] 24 January 2022, 10:25:34 UTC build(deps): Bump docker/build-push-action from 2.7.0 to 2.8.0 (#7679) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2.7.0 to 2.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v2.8.0</h2> <ul> <li>Allow specifying subdirectory with default git context (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531">#531</a>)</li> <li>Add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501">#501</a>)</li> <li>Don't set outputs if empty or nil (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/470">#470</a>)</li> <li>docs: example to sanitize tags with metadata-action (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/476">#476</a>)</li> <li>docs: wrong syntax to sanitize repo slug (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/475">#475</a>)</li> <li>docs: test before pushing your image (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/455">#455</a>)</li> <li>readme: remove v1 section (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500">#500</a>)</li> <li>ci: virtual env file system info (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510">#510</a>)</li> <li>dev: update workflow (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499">#499</a>)</li> <li>Bump <code>@​actions/core</code> from 1.5.0 to 1.6.0 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/160">#160</a>)</li> <li>Bump ansi-regex from 5.0.0 to 5.0.1 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/469">#469</a>)</li> <li>Bump tmpl from 1.0.4 to 1.0.5 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/465">#465</a>)</li> <li>Bump csv-parse from 4.16.0 to 4.16.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/451">#451</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/459">#459</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/1814d3dfb36d6f84174e61f4a4b05bd84089a4b9"><code>1814d3d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/531">#531</a> from BeyondEvil/subdir-with-default-context</li> <li><a href="https://github.com/docker/build-push-action/commit/fc5a732e0cd2fa9f30a1011a4d6ba3dbd5bcc2b5"><code>fc5a732</code></a> Add subdirectory for Git context</li> <li><a href="https://github.com/docker/build-push-action/commit/b1aeb1103e6b3b5648dbd6deaf0559919456ca6b"><code>b1aeb11</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/510">#510</a> from crazy-max/venv</li> <li><a href="https://github.com/docker/build-push-action/commit/e31f93ab9f173213268bb18cabc11fd04b4f941d"><code>e31f93a</code></a> ci: virtual env file system info</li> <li><a href="https://github.com/docker/build-push-action/commit/9ed5823618d7aa277d31c9106594ecb63692bef4"><code>9ed5823</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/501">#501</a> from crazy-max/new-inputs</li> <li><a href="https://github.com/docker/build-push-action/commit/4222161e3eb8351d8999164540f8c32116f921fa"><code>4222161</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/500">#500</a> from crazy-max/readme</li> <li><a href="https://github.com/docker/build-push-action/commit/67ff4df4b75d117a14363bce59aacd34c783c27c"><code>67ff4df</code></a> add <code>cgroup-parent</code>, <code>shm-size</code>, <code>ulimit</code> inputs</li> <li><a href="https://github.com/docker/build-push-action/commit/91274a04dae5b06f1c73a9140206dd49fbfd07c2"><code>91274a0</code></a> sort flags</li> <li><a href="https://github.com/docker/build-push-action/commit/ff329397c050186994fead34d679855583698611"><code>ff32939</code></a> readme: remove v1 section</li> <li><a href="https://github.com/docker/build-push-action/commit/04841f2a72f42f983fee5aeaea3f39559ff858f2"><code>04841f2</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/499">#499</a> from crazy-max/update-workflow</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v2.7.0...v2.8.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=2.7.0&new-version=2.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 24 January 2022, 10:25:34 UTC
f9c6cc9 M. J. Fromberger 21 January 2022, 23:10:28 UTC rpc: use encoding/json rather than tmjson (#7670) The main change here is to use encoding/json to encode and decode RPC parameters, rather than the custom tmjson package. This includes: - Update the HTTP POST handler parameter handling. - Add field tags to 64-bit integer types to get string encoding (to match amino/tmjson). - Add marshalers to struct types that mention interfaces. - Inject wrappers to decode interface arguments in RPC handlers. 21 January 2022, 23:10:28 UTC
72c2e6a M. J. Fromberger 21 January 2022, 17:51:21 UTC jsontypes: improve tests and error diagnostics (#7669) Avert panics for corner cases (e.g., nil pointers) and for implementations that reside only on the pointer type. Add documentation and tests. 21 January 2022, 17:51:21 UTC
8280672 Sam Kleinman 21 January 2022, 17:07:58 UTC mempool: reactor concurrency test tweaks (#7651) 21 January 2022, 17:07:58 UTC
5a1b5b0 M. J. Fromberger 21 January 2022, 16:00:03 UTC Update pending changelog from #7607. (#7666) 21 January 2022, 16:00:03 UTC
3f2da0e Alexander Shcherbakov 21 January 2022, 14:24:46 UTC Fix query against the latest state in light client (#7642) 21 January 2022, 14:24:46 UTC
db7d4ab William Banfield 20 January 2022, 22:21:41 UTC consensus: fix height advances in test state (#7648) The problem with the `TestStateFullRound1` is that the state that we are observeing, `cs`, can advance to the next height before we query its data. Specifically, on line `388`, when we called `validatePrevote`, the `cs` State had already advanced to height 2, so querying that State for the votes of height 1 either yielded nil or an erroneous value. This change adds a `ensurePrevoteMatch` function that checks that the prevote occurred and checks that it is for the expected block at the same time. If this change looks reasonable I can just apply the same fix to all of the places where we perform `ensurePrevote` followed by `validatePrevote` to use this function instead. 20 January 2022, 22:21:41 UTC
78e4c7d Sam Kleinman 20 January 2022, 22:06:44 UTC autofile: avoid shutdown race (#7650) 20 January 2022, 22:06:44 UTC
9dd67ad Sam Kleinman 20 January 2022, 20:48:26 UTC tests: update cleanup opertunities (#7647) 20 January 2022, 20:48:26 UTC
449e127 kmax.eth 20 January 2022, 20:06:13 UTC privval: avoid re-signing vote when RHS and signbytes are equal (#7592) * avoid re-signing vote when RHS and signbytes are equal * avoid re-signing proposal when RHS and signbytes are equal Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> 20 January 2022, 20:06:13 UTC
9f4f513 Sam Kleinman 20 January 2022, 17:17:32 UTC tests: update docker versions to match build version (#7646) 20 January 2022, 17:17:32 UTC
d68d25d Jasmina Malicevic 20 January 2022, 13:53:20 UTC light: return light client status on rpc /status (#7536) *light: rpc /status returns status of light client ; code refactoring light: moved lightClientInfo into light.go, renamed String to ID test/e2e: Return light client trusted height instead of SyncInfo trusted height test/e2e/start.go: Not waiting for light client to catch up in tests. Removed querying of syncInfo in start if the node is a light node * light: Removed call to primary /status. Added trustedPeriod to light info * light/provider: added ID function to return IP of primary and witnesses * light/provider/http/http_test: renamed String() to ID() 20 January 2022, 13:53:20 UTC
4e5c2b5 Sam Kleinman 19 January 2022, 21:58:12 UTC consensus: use delivertxsync (#7616) 19 January 2022, 21:58:12 UTC
ebbc3f0 Gui 19 January 2022, 21:39:59 UTC p2p: always advertise self, to enable mutual address discovery (#7594) Fixes #7593 19 January 2022, 21:39:59 UTC
c8e8a62 M. J. Fromberger 19 January 2022, 18:58:56 UTC abci/client: simplify client interface (#7607) This change has two main effects: 1. Remove most of the Async methods from the abci.Client interface. Remaining are FlushAsync, CommitTxAsync, and DeliverTxAsync. 2. Rename the synchronous methods to remove the "Sync" suffix. The rest of the change is updating the implementations, subsets, and mocks of the interface, along with the call sites that point to them. * Fix stringly-typed mock stubs. * Rename helper method. 19 January 2022, 18:58:56 UTC
68d4fed M. J. Fromberger 19 January 2022, 18:47:06 UTC consensus/state: avert a data race with state update and tests (#7643) 19 January 2022, 18:47:06 UTC
7bc3a72 William Banfield 19 January 2022, 17:42:09 UTC privval: do not use old proposal timestamp (#7621) After #7592, @cmwaters noticed that the logic for re-using old timestamps for proposals may not work with proposer-based timestamps. This change removes the logic to re-use old proposal timestamps since it is no longer correct. Two proposals with different timestamps can no longer be treated as equivalent. Signing a proposal that only differs by timestamp in the new algorithm can be thought of as roughly equivalent to signing a proposal that only differs by `BlockID` in the old scheme. I also investigated the codebase and checked for any place we updated a timestamp using the pattern `(Timestamp = |Timestamp: )` and saw no additional places where we are updating the timestamp of a proposal message. Here is the output of that search: ``` privval/file.go:372: vote.Timestamp = timestamp privval/file.go:453: lastVote.Timestamp = now privval/file.go:454: newVote.Timestamp = now internal/test/factory/commit.go:25: Timestamp: now, internal/test/factory/vote.go:34: Timestamp: time, internal/consensus/state.go:2261: Timestamp: cs.voteTime(), internal/consensus/state.go:2286: vote.Timestamp = v.Timestamp light/detector.go:414: ev.Timestamp = common.Time light/detector.go:418: ev.Timestamp = trusted.Time types/block.go:616: Timestamp: ts, types/block.go:725: Timestamp: cs.Timestamp, types/block.go:736: cs.Timestamp = csp.Timestamp types/block.go:800: Timestamp: commitSig.Timestamp, types/evidence.go:84: Timestamp: blockTime, types/evidence.go:190: dve.Timestamp = evidenceTime types/evidence.go:202: Timestamp: dve.Timestamp, types/evidence.go:228: Timestamp: pb.Timestamp, types/evidence.go:382: Timestamp: %v}#%X`, types/evidence.go:491: l.Timestamp = evidenceTime types/evidence.go:517: Timestamp: l.Timestamp, types/evidence.go:546: Timestamp: lpb.Timestamp, types/evidence.go:722: Timestamp: time, types/vote.go:80: Timestamp: vote.Timestamp, types/vote.go:216: Timestamp: vote.Timestamp, types/vote.go:240: vote.Timestamp = pv.Timestamp types/test_util.go:27: Timestamp: now, types/proposal.go:44: Timestamp: tmtime.Now(), types/proposal.go:132: pb.Timestamp = p.Timestamp types/proposal.go:157: p.Timestamp = pp.Timestamp types/canonical.go:49: Timestamp: proposal.Timestamp, types/canonical.go:62: Timestamp: vote.Timestamp, test/e2e/runner/evidence.go:186: Timestamp: evTime, ``` 19 January 2022, 17:42:09 UTC
a806739 M. J. Fromberger 19 January 2022, 16:58:35 UTC abci/client: use a no-op logger in the test (#7633) This averts a log-after-close issue. We should probably also chase the shutdown issues, but since ABCI clients should generally only shut down once per process I don't think this is a real priority, and the trace is hairy. 19 January 2022, 16:58:35 UTC
1af4113 M. J. Fromberger 19 January 2022, 16:24:12 UTC Increase test splits from 4 to 6. (#7630) Decrease the likelihood that two flaky tests will hit the same batch. Account for the increase in test load from #7608. 19 January 2022, 16:24:12 UTC
e6f6a13 dependabot[bot] 19 January 2022, 10:50:52 UTC build(deps): Bump github.com/prometheus/client_golang (#7636) 19 January 2022, 10:50:52 UTC
aea428d M. J. Fromberger 19 January 2022, 02:36:46 UTC build: Make sure to test packages with external tests (#7608) The test filter was looking for "TestGoFiles", which does not include tests in a separate package (e.g., "package foo_test" for "package foo"). This caused several packages not to be tested in CI, including: github.com/tendermint/tendermint/abci/client github.com/tendermint/tendermint/crypto github.com/tendermint/tendermint/crypto/tmhash github.com/tendermint/tendermint/internal/eventbus github.com/tendermint/tendermint/internal/evidence github.com/tendermint/tendermint/internal/inspect github.com/tendermint/tendermint/internal/jsontypes github.com/tendermint/tendermint/internal/libs/protoio github.com/tendermint/tendermint/internal/libs/sync github.com/tendermint/tendermint/internal/p2p/pex github.com/tendermint/tendermint/internal/pubsub github.com/tendermint/tendermint/internal/pubsub/query github.com/tendermint/tendermint/internal/pubsub/query/syntax github.com/tendermint/tendermint/internal/state/indexer github.com/tendermint/tendermint/internal/state/indexer/block/kv github.com/tendermint/tendermint/libs/json github.com/tendermint/tendermint/libs/log github.com/tendermint/tendermint/libs/os github.com/tendermint/tendermint/light github.com/tendermint/tendermint/light/provider/http github.com/tendermint/tendermint/privval/grpc github.com/tendermint/tendermint/proto/tendermint/blocksync github.com/tendermint/tendermint/proto/tendermint/consensus github.com/tendermint/tendermint/proto/tendermint/statesync github.com/tendermint/tendermint/rpc/client github.com/tendermint/tendermint/rpc/client/mock github.com/tendermint/tendermint/test/e2e/tests github.com/tendermint/tendermint/test/fuzz/mempool github.com/tendermint/tendermint/test/fuzz/p2p/secretconnection github.com/tendermint/tendermint/test/fuzz/rpc/jsonrpc/server Updates #7626 and #7634. 19 January 2022, 02:36:46 UTC
b6307c4 William Banfield 19 January 2022, 00:57:00 UTC consensus: check proposal non-nil in prevote message delay metric (#7625) 19 January 2022, 00:57:00 UTC
5eae2e6 M. J. Fromberger 19 January 2022, 00:36:09 UTC privval: synchronize leak check with shutdown (#7629) The interaction between defers and t.Cleanup can be delicate. For this case, which regularly flakes in CI, be explicit: Defer the closes and waits before making any attempt to leaktest. 19 January 2022, 00:36:09 UTC
a7eb950 M. J. Fromberger 18 January 2022, 22:57:20 UTC autofile: ensure files are not reopened after closing (#7628) During file rotation and WAL shutdown, there was a race condition between users of an autofile and its termination. To fix this, ensure operations on an autofile are properly synchronized, and report errors when attempting to use an autofile after it was closed. Notably: - Simplify the cancellation protocol between signal and Close. - Exclude writers to an autofile during rotation. - Add documentation about what is going on. There is a lot more that could be improved here, but this addresses the more obvious races that have been panicking unit tests. 18 January 2022, 22:57:20 UTC
5cca45b M. J. Fromberger 18 January 2022, 22:32:22 UTC pex: improve handling of closed channels (#7623) Reverts and improves on #7622. The problem turns out not to be on the PEX channel side, but on the pass-through (Go) channel. 18 January 2022, 22:32:22 UTC
4171667 M. J. Fromberger 18 January 2022, 20:01:04 UTC pex: do not send nil envelopes to the reactor (#7622) 18 January 2022, 20:01:04 UTC
7fd97bf M. J. Fromberger 18 January 2022, 15:22:50 UTC pex: avert a data race on map access in the reactor (#7614) There was a path on which computing the next delivery time did not hold the lock, defying the admonition on its comment. 18 January 2022, 15:22:50 UTC
0c82cea William Banfield 18 January 2022, 14:55:18 UTC consensus: calculate prevote message delay metric (#7551) ## What does this pull request do? This pull requests adds two metrics intended for use in calculating an experimental value for `MessageDelay`. The metrics are as follows: ``` # HELP tendermint_consensus_complete_prevote_message_delay Difference in seconds between the proposal timestamp and the timestamp of the prevote that achieved 100% of the voting power in the prevote step. # TYPE tendermint_consensus_complete_prevote_message_delay gauge tendermint_consensus_complete_prevote_message_delay{chain_id="test-chain-aZbwF1"} 0.013025505 # HELP tendermint_consensus_quorum_prevote_message_delay Difference in seconds between the proposal timestamp and the timestamp of the prevote that achieved a quorum in the prevote step. # TYPE tendermint_consensus_quorum_prevote_message_delay gauge tendermint_consensus_quorum_prevote_message_delay{chain_id="test-chain-aZbwF1"} 0.013025505 ``` ## Why this change? For more information on what these metrics are calculating, see #7202. The aim is to merge to backport these metrics to v0.34 and run nodes on a few popular chains with these metrics to determine the experimental values for `MessageDelay` on these popular chains and use these to select our default `SynchronyParams.MessageDelay` value. ## Why Gauges for the metrics? Gauges allow us to overwrite the metric on each successive observation. We can then capture these metrics over time to track the highest and lowest observed value. 18 January 2022, 14:55:18 UTC
b10c746 Sam Kleinman 18 January 2022, 14:08:20 UTC testing: use noop loger with leakteset in more places (#7604) 18 January 2022, 14:08:20 UTC
c0b56e2 Sam Kleinman 18 January 2022, 13:55:13 UTC consensus: test shutdown to avoid hangs (#7603) 18 January 2022, 13:55:13 UTC
49153b7 Kene 18 January 2022, 09:58:32 UTC rpc: paginate mempool /unconfirmed_txs endpoint (#7612) This commit changes the behaviour of the /unconfirmed_txs endpoint by replacing limit with a page and perPage parameter for pagination. The test case for unconfirmed_txs have been accommodated to properly test this change and the documentation for the API as well. 18 January 2022, 09:58:32 UTC
679b6a6 M. J. Fromberger 16 January 2022, 21:48:21 UTC light: fix provider error plumbing (#7610) The custom error types in the provider package did not propagate their wrapped underlying reasons, making it difficult for the test to check that the correct error was observed. - Fix the custom errors to have a true underlying error (not just a string). - Add Unwrap methods to support inspection by errors.Is. - Update usage in a few places. - Fix the test to check for acceptable variation. Fixes #7609. 16 January 2022, 21:48:21 UTC
c24f003 M. J. Fromberger 16 January 2022, 20:39:37 UTC protoio: fix incorrect test assertion (#7606) After writing and then reading a bunch of random messages, the test was checking that it did not read the same number of messages that it wrote. The sense of this check was inverted; they should match. Introduced by accident in #7522. I'm not sure why this did not show up in CI. Edit: I now know why it didn't show up in ci: #7608. 16 January 2022, 20:39:37 UTC
701e602 Sebastian Gröbler 15 January 2022, 02:33:47 UTC Update README.md (#7602) Fixed typo in exchange Co-authored-by: M. J. Fromberger <fromberger@interchain.io> 15 January 2022, 02:33:47 UTC
dbe2146 M. J. Fromberger 15 January 2022, 02:14:09 UTC rpc: simplify the encoding of interface-typed arguments in JSON (#7600) Add package jsontypes that implements a subset of the custom libs/json package. Specifically it handles encoding and decoding of interface types wrapped in "tagged" JSON objects. It omits the deep reflection on arbitrary types, preserving only the handling of type tags wrapper encoding. - Register interface types (Evidence, PubKey, PrivKey) for tagged encoding. - Update the existing implementations to satisfy the type. - Register those types with the jsontypes registry. - Add string tags to 64-bit integer fields where needed. - Add marshalers to structs that export interface-typed fields. 15 January 2022, 02:14:09 UTC
7ed57ef Sam Kleinman 14 January 2022, 21:34:12 UTC statesync: more orderly dispatcher shutdown (#7601) 14 January 2022, 21:34:12 UTC
2199e0a Sam Kleinman 14 January 2022, 21:18:50 UTC light: convert validation panics to errors (#7597) 14 January 2022, 21:18:50 UTC
887cb21 Sam Kleinman 14 January 2022, 18:16:43 UTC light: remove test panic (#7588) 14 January 2022, 18:16:43 UTC
82b6586 Sam Kleinman 14 January 2022, 18:04:01 UTC node+autofile: avoid leaks detected during WAL shutdown (#7599) 14 January 2022, 18:04:01 UTC
2f75899 William Banfield 14 January 2022, 16:48:59 UTC ADR-74: Migrate Timeout Parameters to Consensus Parameters (#7503) related to: #7274 and #7275 Still somewhat uncertain on two things that I'd appreciate more feedback on: 1. The optional temporary local overrides. Perhaps this is superfluous and we can simply make the transition without the override? 2. If this set of parameters seems to be large enough to allow application developers to create the chains they want but not so large as to be needlessly complex. 14 January 2022, 16:48:59 UTC
abb7c8c William Banfield 14 January 2022, 16:47:02 UTC RFC-009: Consensus Parameter Upgrades (#7524) Related to #7503 14 January 2022, 16:47:02 UTC
c065eeb M. J. Fromberger 14 January 2022, 16:07:53 UTC Add changelog entries from release v0.34.15. (#7598) Fixes #7596. 14 January 2022, 16:07:53 UTC
1ff6936 M. J. Fromberger 14 January 2022, 15:53:53 UTC rpc: remove dependency of URL (GET) requests on tmjson (#7590) The parameters for RPC GET requests are parsed from query arguments in the request URL. Rework this code to remove the need for tmjson. The structure of a call still requires reflection, and still works the same way as before, but the code structure has been simplified and cleaned up a bit. Points of note: - Consolidate handling of pointer types, so we only need to dereference once. - Reduce the number of allocations of reflective types. - Report errors for unsupported types rather than returning untyped nil. Update the tests as well. There was one test case that checked for an error on a behaviour the OpenAPI docs explicitly demonstrates as supported, so I fixed that test case, and also added some new ones for cases that weren't checked. Related: * Update e2e base Go image to 1.17 (to match config). 14 January 2022, 15:53:53 UTC
159d763 Sam Kleinman 14 January 2022, 14:58:41 UTC light: avoid panic for integer underflow (#7589) 14 January 2022, 14:58:41 UTC
9409cde M. J. Fromberger 14 January 2022, 14:41:57 UTC rpc: update fuzz criteria to match the implementation (#7595) I missed this during my previous pass. Requirements for handlers: - First argument is context.Context. - Last of two results is error. 14 January 2022, 14:41:57 UTC
ec59b1a M. J. Fromberger 13 January 2022, 21:27:45 UTC rpc: check RPC service functions more carefully (#7587) Require that RPC functions take a context as their first argument, and return an error as either their only result, or the second of two results. This does not change how functions are dispatched, but will make it a little easier to make more invasive changes in the near future. 13 January 2022, 21:27:45 UTC
7e8fa4e Sam Kleinman 13 January 2022, 21:11:51 UTC consensus: explicit test timeout (#7585) 13 January 2022, 21:11:51 UTC
b7c19a5 M. J. Fromberger 13 January 2022, 20:13:28 UTC rpc: clean up the RPCFunc constructor signature (#7586) Instead of taking a comma-separated string of parameter names, take each parameter name as a separate argument. Now that we no longer have an extra flag for caching, this fits nicely into a variadic trailer. * Update all usage of NewRPCFunc and NewWSRPCFunc. 13 January 2022, 20:13:28 UTC
8ff367a Sam Kleinman 13 January 2022, 19:38:54 UTC log: avoid use of legacy test logging (#7583) 13 January 2022, 19:38:54 UTC
81ee412 M. J. Fromberger 13 January 2022, 18:45:36 UTC rpc: consolidate RPC route map construction (#7582) Define interfaces for the various methods a service may implement. This is basically just the set of things on Environment that are exported as RPCs, but these are also implemented by the light proxy. * internal/rpc: use NewRoutesMap to construct routes on service start * light/proxy: use NewRoutesMap to construct RPC routes 13 January 2022, 18:45:36 UTC
cef17e1 Sam Kleinman 13 January 2022, 17:39:48 UTC node+rpc: rpc environment should own it's creation (#7573) 13 January 2022, 17:39:48 UTC
fd2eccb Sam Kleinman 13 January 2022, 17:05:12 UTC consensus: use noop logger for WAL test (#7580) 13 January 2022, 17:05:12 UTC
ed660bd Sam Kleinman 13 January 2022, 16:53:05 UTC node+privval: refactor privval construction (#7574) 13 January 2022, 16:53:05 UTC
5a89263 M. J. Fromberger 13 January 2022, 15:02:21 UTC rpc: simplify panic recovery in the server middleware (#7578) Rather than installing two separate panic handlers, defer the bookkeeping separately from recovery, and lift the delegated handler call out to the top level of the wrapper. Also: Regularize the server middleware wrappers. 13 January 2022, 15:02:21 UTC
904957a M. J. Fromberger 13 January 2022, 01:25:58 UTC rpc: rework how responses are written back via HTTP (#7575) Add writeRPCResponse and writeHTTPResponse helpers, that handle the way RPC responses are written to HTTP replies. These replace the exported helpers. Visible effects: - JSON results are now marshaled without indentation. - HTTP status codes are now normalized. - Cache control headers are no longer set. Details: - When writing a response to a URL (GET) request, do not marshal the whole JSON-RPC object into the body, only encode the result or the error object. This is a user-visible change. - Do not change the HTTP status code for RPC errors. The RPC error already reports what went wrong, the HTTP status should only report problems with the HTTP transaction itself. This is a user-visible change. - Encode JSON without indentation in POST response bodies. This is mainly cosmetic but saves quite a bit of response data. Indent is still applied to GET responses to make life easier for code examples. - Remove an obsolete TODO about reporting an HTTP error on websocket upgrade. Nothing needed to change; the upgrader already reports an error. - Report an HTTP error when starting the server loop fails. - Improve logging for encoding errors. - Log less aggressively. 13 January 2022, 01:25:58 UTC
2a348cc Sam Kleinman 12 January 2022, 21:56:49 UTC logging: remove reamining instances of SetLogger interface (#7572) 12 January 2022, 21:56:49 UTC
7a9a38d Sam Kleinman 12 January 2022, 21:17:43 UTC service: avoid debug logs before error (#7564) 12 January 2022, 21:17:43 UTC
25e665d Sam Kleinman 12 January 2022, 20:55:42 UTC internal/libs: delete unused functionality (#7569) 12 January 2022, 20:55:42 UTC
e07c4cd Sam Kleinman 12 January 2022, 20:32:22 UTC node: collapse initialization internals (#7567) 12 January 2022, 20:32:22 UTC
5c1399d M. J. Fromberger 12 January 2022, 20:17:53 UTC rpc: fix mock test cases (#7571) In two cases, we check for the content of an error right after asserting that no error occurs. Fix the sense of those checks. In one case, we check that there is no error with the diagnostic "expected error". It's not clear whether this means "an error was expected" (which is what I believe) or "we got the expected error". However, given the way the mock plumbing is set up, the first interpretation seems right. 12 January 2022, 20:17:53 UTC
6efdba8 Sam Kleinman 12 January 2022, 18:38:23 UTC statesync: SyncAny test buffering (#7570) 12 January 2022, 18:38:23 UTC
1f5e64e M. J. Fromberger 12 January 2022, 18:20:59 UTC rpc: remove cache control settings from the HTTP server (#7568) We should not set cache-control headers on RPC responses. HTTP caching interacts poorly with resources that are expected to change frequently, or whose rate of change is unpredictable. More subtly, all calls to the POST endpoint use the same URL, which means a cacheable response from one call may actually "hide" an uncacheable response from a subsequent one. This is less of a problem for the GET endpoints, but that means the behaviour of RPCs varies depending on which HTTP method your client happens to use. Websocket requests were already marked statically uncacheable, adding yet a third combination. To address this: - Stop setting cache-control headers. - Update the tests that were checking for those headers. - Remove the flags to request cache-control. Apart from affecting the HTTP response headers, this change does not modify the behaviour of any of the RPC methods. 12 January 2022, 18:20:59 UTC
fb10d1c Sam Kleinman 12 January 2022, 17:57:23 UTC statesync: clarify test cleanup (#7565) 12 January 2022, 17:57:23 UTC
46f56fc Sam Kleinman 12 January 2022, 17:33:17 UTC node: move seed node implementation to its own file (#7566) 12 January 2022, 17:33:17 UTC
4d11336 dependabot[bot] 12 January 2022, 14:25:23 UTC build(deps): Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0 (#7562) Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 0.4.1 to 1.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/BurntSushi/toml/releases">github.com/BurntSushi/toml's releases</a>.</em></p> <blockquote> <h2>v1.0.0</h2> <p>This release adds much more detailed errors, support for the <code>toml.Marshaler</code> interface, and several fixes.</p> <p>There is no special meaning in the jump to v1.0; the 0.x releases were always treated as if they're 1.x with regards to compatibility; the versioning scheme for this library predates the release of modules.</p> <h2>New features</h2> <ul> <li> <p>Error reporting is much improved; the reported position of errors should now always be correct and the library can print more detailed errors (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/299">#299</a>, <a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/332">#332</a>)</p> <p>Decode always return a <code>toml.ParseError</code>, which has three methods:</p> <ul> <li> <p><code>Error()</code> behaves as before and shows a single concise line with the error.</p> </li> <li> <p><code>ErrorWithLocation()</code> shows the same error, but also shows the line the error occurred at, similar to e.g. clang or the Rust compiler.</p> </li> <li> <p><code>ErrorWithUsage()</code> is the same as <code>ErrorWithPosition()</code>, but may also show a longer usage guidance message. This isn't always present (in which case it behaves identical to <code>ErrorWithPosition()</code>), but it should be present for most common mistakes and sources of confusion.</p> </li> </ul> <p>Which error the correct one to use is depends on your application and preferences; in general I would recommend using at least <code>ErrorWithPosition()</code> for user-facing errors, as it's much more helpful for users of any skill level. If your users are likely to be non-technical then <code>ErrorWithUsage()</code> is probably a good idea; I did my best to avoid technical jargon such as &quot;newline&quot; and phrase things in a way that's understandable by most people not intimately familiar with these sort of things.</p> <p>Additionally, the TOML key that fialed should now always be reported in all errors.</p> </li> <li> <p>Add <code>toml.Marshaler</code> interface. This can be used if you want full control over how something is marshalled as TOML, similar to <code>json.Marshaler</code> etc. This takes precedence over <code>encoding.TextMarshaler</code>. (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/327">#327</a>)</p> </li> <li> <p>Allow TOML integers to be decoded to a Go float (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/325">#325</a>)</p> <p>Previously <code>int = 42</code> could only be decoded to an <code>int*</code> type; now this can also be decoded in a <code>float</code> type as long as it can be represented without loss of data.</p> </li> </ul> <h2>Fixes</h2> <ul> <li> <p>Key.String() is now quoted when needed (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/333">#333</a>)</p> </li> <li> <p>Fix decoding of nested structs on 32bit platforms (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/314">#314</a>)</p> </li> <li> <p>Empty slices are now always <code>[]T{}</code> rather than nil, which was the behaviour in v0.3.1 and before. While they are identical for most purposes, encoding/json encodes them different (<code>[]</code> vs. <code>null</code>), making it an (accidentally) incompatible change (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/339">#339</a>)</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/BurntSushi/toml/commit/4272474656f1b35414cdee32185a45e36b39246e"><code>4272474</code></a> Reject control characters everywhere</li> <li><a href="https://github.com/BurntSushi/toml/commit/9bbaaec997900f53eebd078adb4f041f7f45f5ef"><code>9bbaaec</code></a> Update toml-test</li> <li><a href="https://github.com/BurntSushi/toml/commit/8a54f3e8df7eea389c18e58707d6215333f1e47e"><code>8a54f3e</code></a> Merge TestDecodeInterfaceSlice in TestDecodeSlices</li> <li><a href="https://github.com/BurntSushi/toml/commit/9515b929790931bfe0e72976a031c3a5f0e4c664"><code>9515b92</code></a> Decode S=[] into a non-nil []interface{}. (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/339">#339</a>)</li> <li><a href="https://github.com/BurntSushi/toml/commit/7d0236fe74765a731cf768bea23b9132b8c2b9e0"><code>7d0236f</code></a> Make sure quoted keys with dots work well (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/333">#333</a>)</li> <li><a href="https://github.com/BurntSushi/toml/commit/ff0a3f89c20b18b5a8637bc3526e5abc0bce25e1"><code>ff0a3f8</code></a> Add back build tags for toml-test files</li> <li><a href="https://github.com/BurntSushi/toml/commit/7356d5f88875523b62c873d04211212bcf03553b"><code>7356d5f</code></a> Few staticcheck fixes</li> <li><a href="https://github.com/BurntSushi/toml/commit/b1471ff6cfa7e6d80627cbae2eefcb7ecec96c99"><code>b1471ff</code></a> Don't allow &quot;0_0&quot;</li> <li><a href="https://github.com/BurntSushi/toml/commit/847ee8a07aeacf66cbe16c51cde1dfed0d81fcf1"><code>847ee8a</code></a> Update toml-test</li> <li><a href="https://github.com/BurntSushi/toml/commit/461925704ed4d72ccc1fd51fe69bb3ac47091330"><code>4619257</code></a> Clearer errors when decoding to invalid types (<a href="https://github-redirect.dependabot.com/BurntSushi/toml/issues/332">#332</a>)</li> <li>Additional commits viewable in <a href="https://github.com/BurntSushi/toml/compare/v0.4.1...v1.0.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/BurntSushi/toml&package-manager=go_modules&previous-version=0.4.1&new-version=1.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 12 January 2022, 14:25:23 UTC
cc51bf7 Sam Kleinman 11 January 2022, 21:39:31 UTC tests: remove in-test logging (#7558) 11 January 2022, 21:39:31 UTC
841629f Sam Kleinman 11 January 2022, 20:09:19 UTC privval: improve client shutdown to prevent resource leak (#7544) 11 January 2022, 20:09:19 UTC
50ac52e M. J. Fromberger 11 January 2022, 19:47:56 UTC rpc: replace custom context-like argument with context.Context (#7559) * Rename rpctypes.Context to CallInfo. Add methods to attach and recover this value from a context.Context. * Rework RPC method handlers to accept "real" contexts. - Replace *rpctypes.Context arguments with context.Context. - Update usage of RPC context fields to use CallInfo. 11 January 2022, 19:47:56 UTC
a4d0a43 M. J. Fromberger 11 January 2022, 19:04:55 UTC rpc: refactor the HTTP POST handler (#7555) No functional changes. - Pull out a some helper code to simplify the control flow within the body of the HTTP request handler. - Front-load the URL path check so it does not get repeated for each request. 11 January 2022, 19:04:55 UTC
5bf1bdc Sam Kleinman 11 January 2022, 17:56:52 UTC reactors: skip log on some routine cancels (#7556) 11 January 2022, 17:56:52 UTC
7f8b75e M. J. Fromberger 11 January 2022, 14:37:38 UTC rpc: replace anonymous arguments with structured types (#7552) Instead of using anonymous maps, define tagged struct types for JSON argument encoding. This allows us to have the encoding rules we want without tmjson. This commit handles the "easy" cases. BroadcastEvidence is omitted here, because it depends on the interface encoding rules from tmjson. I will address that in a forthcoming change. 11 January 2022, 14:37:38 UTC
back to top