| d72c32a | Tom Lane | 12 February 2006, 22:37:44 UTC | Stamp 8.1.3. | 12 February 2006, 22:37:44 UTC |
| ef434eb | Tom Lane | 12 February 2006, 22:35:36 UTC | Update release notes. | 12 February 2006, 22:35:36 UTC |
| 20334a9 | Tom Lane | 12 February 2006, 22:32:57 UTC | Fix bug that allowed any logged-in user to SET ROLE to any other database user id (CVE-2006-0553). Also fix related bug in SET SESSION AUTHORIZATION that allows unprivileged users to crash the server, if it has been compiled with Asserts enabled. The escalation-of-privilege risk exists only in 8.1.0-8.1.2. However, the Assert-crash risk exists in all releases back to 7.3. Thanks to Akio Ishida for reporting this problem. | 12 February 2006, 22:32:57 UTC |
| b71e2bb | Tom Lane | 12 February 2006, 21:13:00 UTC | Fix broken markup. | 12 February 2006, 21:13:00 UTC |
| 68f34bf | Bruce Momjian | 12 February 2006, 19:24:35 UTC | Update README file. Joshua D. Drake | 12 February 2006, 19:24:35 UTC |
| 544ccf6 | Bruce Momjian | 12 February 2006, 19:19:37 UTC | Update wording for 8.1.X, remove <only>: This option can <only> be set at server start or in the <filename>postgresql.conf</filename> configuration file. | 12 February 2006, 19:19:37 UTC |
| a22873a | Bruce Momjian | 12 February 2006, 19:02:28 UTC | > Actually, if you submit a patch that says either "SCROLL is the default" > or "NO SCROLL is the default", it will be rejected as incorrect. The > reason is that the default behavior is different from either of these, > as is explained in the NOTES section. Ok, so *that's* where the bit about the query plan being simple enough. Based on that, ISTM that it should be premissable for us to decide that a cursor requiring a sort isn't "simple enough" to support SCROLL. In any case, here's a patch that makes the non-standard behavior easier for people to find. Jim C. Nasby | 12 February 2006, 19:02:28 UTC |
| 34d9bbe | Bruce Momjian | 12 February 2006, 18:42:20 UTC | Stamp releases for 2006-02-14 release | 12 February 2006, 18:42:20 UTC |
| 003daaf | Bruce Momjian | 12 February 2006, 18:14:29 UTC | Fix release item ordering. | 12 February 2006, 18:14:29 UTC |
| 12ea69a | Bruce Momjian | 12 February 2006, 17:58:31 UTC | Update back branch release notes. | 12 February 2006, 17:58:31 UTC |
| d9dafcc | Bruce Momjian | 12 February 2006, 17:28:23 UTC | Fix release markup. | 12 February 2006, 17:28:23 UTC |
| a318438 | Bruce Momjian | 12 February 2006, 17:17:39 UTC | Stamp 8.1.3, but exclude configure.in/configure change. | 12 February 2006, 17:17:39 UTC |
| 3a9c81e | Bruce Momjian | 12 February 2006, 17:11:28 UTC | Update release notes for 8.1.3. | 12 February 2006, 17:11:28 UTC |
| b919f3f | Tom Lane | 10 February 2006, 21:52:34 UTC | Check that SID is enabled while checking for Windows admin privileges. Magnus | 10 February 2006, 21:52:34 UTC |
| 2d26c4b | Tom Lane | 10 February 2006, 19:01:22 UTC | Change search for default operator classes so that it examines all opclasses regardless of the current schema search path. Since CREATE OPERATOR CLASS only allows one default opclass per datatype regardless of schemas, this should have minimal impact, and it fixes problems with failure to find a desired opclass while restoring dump files. Per discussion at http://archives.postgresql.org/pgsql-hackers/2006-02/msg00284.php. Remove now-redundant-or-unused code in typcache.c and namespace.c, and backpatch as far as 8.0. | 10 February 2006, 19:01:22 UTC |
| f9e03aa | Tom Lane | 09 February 2006, 18:28:35 UTC | Provide the libpq error message when PQputline or PQendcopy fails. | 09 February 2006, 18:28:35 UTC |
| f527f08 | Tom Lane | 09 February 2006, 03:40:30 UTC | Reject out-of-range dates in date_in(). Kris Jurka | 09 February 2006, 03:40:30 UTC |
| cfcf54a | Bruce Momjian | 07 February 2006, 00:26:38 UTC | Fix HTML alignment in PQprint. Christoph Zwerschke | 07 February 2006, 00:26:38 UTC |
| 763b9c1 | Bruce Momjian | 06 February 2006, 02:23:17 UTC | Fix PQprint HTML tag, "centre" -> "center". | 06 February 2006, 02:23:17 UTC |
| 7d41ef1 | Tom Lane | 05 February 2006, 20:58:57 UTC | Fix pg_restore to properly discard COPY data when trying to continue after an error in a COPY statement. Formerly it thought the COPY data was SQL commands, and got quite confused. Stephen Frost | 05 February 2006, 20:58:57 UTC |
| c75c372 | Bruce Momjian | 05 February 2006, 18:19:33 UTC | Fix typo in configuration docs. Devrim GUNDUZ | 05 February 2006, 18:19:33 UTC |
| 3bf6284 | Bruce Momjian | 05 February 2006, 02:48:20 UTC | Update PL/pgSQL trigger example to be clearer about how to "merge" data into a table. Jim C. Nasby | 05 February 2006, 02:48:20 UTC |
| 180b23c | Bruce Momjian | 01 February 2006, 12:42:00 UTC | Fix const cast in get_progname(). Backpatch. | 01 February 2006, 12:42:00 UTC |
| bc1c9ad | Bruce Momjian | 01 February 2006, 00:32:06 UTC | Set progname early in the postmaster/postgres binary, rather than doing it later. This fixes a problem where EXEC_BACKEND didn't have progname set, causing a segfault if log_min_messages was set below debug2 and our own snprintf.c was being used. Also alway strdup() progname. Backpatch to 8.1.X and 8.0.X. | 01 February 2006, 00:32:06 UTC |
| 2aa231b | Tom Lane | 31 January 2006, 22:40:12 UTC | Allow %TYPE to be used with SETOF, per gripe from Murat Tasan. | 31 January 2006, 22:40:12 UTC |
| ecde421 | Tom Lane | 30 January 2006, 16:19:04 UTC | Fix ALTER COLUMN TYPE bug: it sometimes tried to drop UNIQUE or PRIMARY KEY constraints before FOREIGN KEY constraints that depended on them. Originally reported by Neil Conway on 29-Jun-2005. Patch by Nakano Yoshihisa. | 30 January 2006, 16:19:04 UTC |
| 0ab9d3a | Tom Lane | 29 January 2006, 18:55:55 UTC | When building a bitmap scan, must copy the bitmapqualorig expression tree to avoid sharing substructure with the lower-level indexquals. This is currently only an issue if there are SubPlans in the indexquals, which is uncommon but not impossible --- see bug #2218 reported by Nicholas Vinen. We use the same kluge for indexqual vs indexqualorig in the index scans themselves ... would be nice to clean this up someday. | 29 January 2006, 18:55:55 UTC |
| 2d98f46 | Tom Lane | 29 January 2006, 17:27:50 UTC | Fix code that checks to see if an index can be considered to match the query's requested sort order. It was assuming that build_index_pathkeys always generates a pathkey per index column, which was not true if implied equality deduction had determined that two index columns were effectively equated to each other. Simplest fix seems to be to install an option that causes build_index_pathkeys to support this behavior as well as the original one. Per report from Brian Hirt. | 29 January 2006, 17:27:50 UTC |
| 18d6948 | Andrew Dunstan | 28 January 2006, 16:21:33 UTC | Undo perl's nasty locale setting on Windows. Since we can't do that as elsewhere by setting the environment appropriately, we make perl do it right after interpreter startup by calling its POSIX::setlocale(). | 28 January 2006, 16:21:33 UTC |
| 81dbda0 | Neil Conway | 28 January 2006, 03:28:19 UTC | Per a bug report from Theo Schlossnagle, plperl_return_next() leaks memory in the executor's per-query memory context. It also inefficient: it invokes get_call_result_type() and TupleDescGetAttInMetadata() for every call to return_next, rather than invoking them once (per PL/Perl function call) and memoizing the result. This patch makes the following changes: - refactor the code to include all the "per PL/Perl function call" data inside a single struct, "current_call_data". This means we don't need to save and restore N pointers for every recursive call into PL/Perl, we can just save and restore one. - lookup the return type metadata needed by plperl_return_next() once, and then stash it in "current_call_data", so as to avoid doing the lookup for every call to return_next. - create a temporary memory context in which to evaluate the return type's input functions. This memory context is reset for each call to return_next. The patch appears to fix the memory leak, and substantially reduces the overhead imposed by return_next. | 28 January 2006, 03:28:19 UTC |
| 108a2e5 | Tom Lane | 26 January 2006, 17:08:26 UTC | Fix display of whole-row Var appearing at the top level of a SELECT list. While we normally prefer the notation "foo.*" for a whole-row Var, that does not work at SELECT top level, because in that context the parser will assume that what is wanted is to expand the "*" into a list of separate target columns, yielding behavior different from a whole-row Var. We have to emit just "foo" instead in that context. Per report from Sokolov Yura. | 26 January 2006, 17:08:26 UTC |
| f31a584 | Tom Lane | 25 January 2006, 20:44:49 UTC | Remove unnecessary PQconsumeInput call from PQputCopyData; it's redundant because pqSendSome will absorb input data anytime it'd be forced to block. Avoiding a kernel call per PQputCopyData call helps COPY speed materially. Alon Goldshuv | 25 January 2006, 20:44:49 UTC |
| b34608f | Tom Lane | 24 January 2006, 16:38:50 UTC | Fix unportable usage of socklen_t: should use ACCEPT_TYPE_ARG3 macro provided by configure, instead. Per bug #2205. | 24 January 2006, 16:38:50 UTC |
| 16582d3 | Tom Lane | 21 January 2006, 04:38:27 UTC | Repair longstanding bug in slru/clog logic: it is possible for two backends to try to create a log segment file concurrently, but the code erroneously specified O_EXCL to open(), resulting in a needless failure. Before 7.4, it was even a PANIC condition :-(. Correct code is actually simpler than what we had, because we can just say O_CREAT to start with and not need a second open() call. I believe this accounts for several recent reports of hard-to-reproduce "could not create file ...: File exists" errors in both pg_clog and pg_subtrans. | 21 January 2006, 04:38:27 UTC |
| 4977c2b | Tom Lane | 20 January 2006, 22:46:40 UTC | Replace bitwise looping with bytewise looping in hemdistsign and sizebitvec of tsearch2, as well as identical code in several other contrib modules. This provided about a 20X speedup in building a large tsearch2 index ... didn't try to measure its effects for other operations. Thanks to Stephan Vollmer for providing a test case. | 20 January 2006, 22:46:40 UTC |
| 4a651c9 | Bruce Momjian | 20 January 2006, 16:42:02 UTC | Update EXPLAIN wording for GEQO usage. | 20 January 2006, 16:42:02 UTC |
| 517056b | Tom Lane | 20 January 2006, 15:17:13 UTC | Fix thinko in autovacuum's test to skip temp tables: want to skip any temp table not only our own process' tables. It's not real important since vacuum.c will skip temp tables anyway, but might as well make the code do what it claims to do. | 20 January 2006, 15:17:13 UTC |
| 936433b | Bruce Momjian | 19 January 2006, 23:09:46 UTC | Doc patch that adds an example of a correllated UPDATE. David Fetter | 19 January 2006, 23:09:46 UTC |
| b148ce8 | Bruce Momjian | 19 January 2006, 22:52:20 UTC | Clarify STABLE function documentation to highlight how such functions can be optimized. | 19 January 2006, 22:52:20 UTC |
| 337cc41 | Tom Lane | 19 January 2006, 21:49:30 UTC | Add some test scaffolding to allow cache-flush stress testing (and I do mean stress ... system is orders of magnitude slower with this enabled). | 19 January 2006, 21:49:30 UTC |
| 36cdb24 | Bruce Momjian | 19 January 2006, 21:19:15 UTC | Remove $(DESTDIR) from the pgxs BE_DLLLIBS= -L path for AIX and Darwin. | 19 January 2006, 21:19:15 UTC |
| 128cd9d | Bruce Momjian | 19 January 2006, 20:45:34 UTC | Remove $(DESTDIR) from the pgxs BE_DLLLIBS= -L path. | 19 January 2006, 20:45:34 UTC |
| ab2cd72 | Tom Lane | 19 January 2006, 20:28:48 UTC | Avoid crashing if relcache flush occurs while trying to load data into an index's support-function cache (in index_getprocinfo). Since none of that data can change for an index that's in active use, it seems sufficient to treat all open indexes the same way we were treating "nailed" system indexes --- that is, just re-read the pg_class row and leave the rest of the relcache entry strictly alone. The pg_class re-read might not be strictly necessary either, but since the reltablespace and relfilenode can change in normal operation it seems safest to do it. (We don't support changing any of the other info about an index at all, at the moment.) Back-patch as far as 8.0. It might be possible to adapt the patch to 7.4, but it would take more work than I care to expend for such a low-probability problem. 7.3 is out of luck for sure. | 19 January 2006, 20:28:48 UTC |
| b5dc716 | Bruce Momjian | 19 January 2006, 20:01:01 UTC | Fix pgxs -L library path specification for Win32 and Cygwin, was /bin, now /lib. | 19 January 2006, 20:01:01 UTC |
| 7618330 | Tom Lane | 19 January 2006, 04:45:47 UTC | It turns out that TablespaceCreateDbspace fails badly if a relcache flush occurs when it tries to heap_open pg_tablespace. When control returns to smgrcreate, that routine will be holding a dangling pointer to a closed SMgrRelation, resulting in mayhem. This is of course a consequence of the violation of proper module layering inherent in having smgr.c call a tablespace command routine, but the simplest fix seems to be to change the locking mechanism. There's no real need for TablespaceCreateDbspace to touch pg_tablespace at all --- it's only opening it as a way of locking against a parallel DROP TABLESPACE command. A much better answer is to create a special-purpose LWLock to interlock these two operations. This drops TablespaceCreateDbspace quite a few layers down the food chain and makes it something reasonably safe for smgr to call. | 19 January 2006, 04:45:47 UTC |
| 49a2630 | Tom Lane | 19 January 2006, 00:27:27 UTC | Fix a tiny memory leak (one List header) in RelationCacheInvalidate(). This is utterly insignificant in normal operation, but it becomes a problem during cache inval stress testing. The original coding in fact had no leak --- the 8.0 List rewrite created the issue. I wonder whether list_concat should pfree the discarded header? | 19 January 2006, 00:27:27 UTC |
| 2e2c4f4 | Bruce Momjian | 18 January 2006, 22:26:01 UTC | Clarify use of btree indexes for ILIKE and ~*. | 18 January 2006, 22:26:01 UTC |
| 0bfd90f | Tom Lane | 18 January 2006, 20:35:16 UTC | Modify pgstats code to reduce performance penalties from oversized stats data files: avoid creating stats hashtable entries for tables that aren't being touched except by vacuum/analyze, ensure that entries for dropped tables are removed promptly, and tweak the data layout to avoid storing useless struct padding. Also improve the performance of pgstat_vacuum_tabstat(), and make sure that autovacuum invokes it exactly once per autovac cycle rather than multiple times or not at all. This should cure recent complaints about 8.1 showing much higher stats I/O volume than was seen in 8.0. It'd still be a good idea to revisit the design with an eye to not re-writing the entire stats dataset every half second ... but that would be too much to backpatch, I fear. | 18 January 2006, 20:35:16 UTC |
| 9e72b3c | Tom Lane | 17 January 2006, 23:52:50 UTC | Fix fsync code to test whether F_FULLFSYNC is available, instead of assuming it always is on Darwin. Per report from Neil Brandt. | 17 January 2006, 23:52:50 UTC |
| 7b3d936 | Tom Lane | 17 January 2006, 17:33:23 UTC | Repair problems with the result of lookup_rowtype_tupdesc() possibly being discarded by cache flush while still in use. This is a minimal patch that just copies the tupdesc anywhere it could be needed across a flush. Applied to back branches only; Neil Conway is working on a better long-term solution for HEAD. | 17 January 2006, 17:33:23 UTC |
| afe91ca | Neil Conway | 15 January 2006, 22:47:10 UTC | When using GCC on AMD64 and PPC, ECPGget_variable() takes a va_list *, not a va_list. Christof Petig's previous patch made this change, but neglected to update ecpglib/descriptor.c, resulting in a compiler warning (and a likely runtime crash) on AMD64 and PPC. | 15 January 2006, 22:47:10 UTC |
| 5032245 | Peter Eisentraut | 14 January 2006, 16:16:08 UTC | Fix pg_ctl crash on "unregister" when a data directory is not specified. by Magnus Hagander | 14 January 2006, 16:16:08 UTC |
| 5dc3d1b | Neil Conway | 12 January 2006, 22:29:11 UTC | We neglected to apply domain constraints on UNKNOWN parameters to prepared statements, per report from David Wheeler. | 12 January 2006, 22:29:11 UTC |
| a933c4e | Tom Lane | 12 January 2006, 21:49:07 UTC | Repair "Halloween problem" in EvalPlanQual: a tuple that's been inserted by our own command (or more generally, xmin = our xact and cmin >= current command ID) should not be seen as good. Else we may try to update rows we already updated. This error was inserted last August while fixing the even bigger problem that the old coding wouldn't see *any* tuples inserted by our own transaction as good. Per report from Euler Taveira de Oliveira. | 12 January 2006, 21:49:07 UTC |
| e2c60a2 | Tom Lane | 12 January 2006, 19:23:41 UTC | Use a more bulletproof test for whether finite() and isinf() are present. It seems that recent gcc versions can optimize away calls to these functions even when the functions do not exist on the platform, resulting in a bogus positive result. Avoid this by using a non-constant argument and ensuring that the function result is not simply discarded. Per report from François Laupretre. | 12 January 2006, 19:23:41 UTC |
| 34b0ac6 | Tom Lane | 12 January 2006, 18:09:42 UTC | Remove extraneous backslash from 'fixseq.sql' example --- mea culpa certainly. Per report from George Woodring. | 12 January 2006, 18:09:42 UTC |
| db55a80 | Tom Lane | 10 January 2006, 22:00:07 UTC | Improve error messages for missing-FROM-entry cases, as per recent discussion. | 10 January 2006, 22:00:07 UTC |
| e838df6 | Neil Conway | 10 January 2006, 00:33:30 UTC | In PLy_function_build_args(), the code loops repeatedly, constructing one argument at a time and then inserting the argument into a Python list via PyList_SetItem(). This "steals" the reference to the argument: that is, the reference to the new list member is now held by the Python list itself. This works fine, except if an elog occurs. This causes the function's PG_CATCH() block to be invoked, which decrements the reference counts on both the current argument and the list of arguments. If the elog happens to occur during the second or subsequent iteration of the loop, the reference count on the current argument will be decremented twice. The fix is simple: set the local pointer to the current argument to NULL immediately after adding it to the argument list. This ensures that the Py_XDECREF() in the PG_CATCH() block doesn't double-decrement. | 10 January 2006, 00:33:30 UTC |
| d3934a3 | Tom Lane | 09 January 2006, 21:16:25 UTC | Fix pg_dump to add the required OPERATOR() decoration to schema-qualified operator names. This is needed when dumping operator definitions that have COMMUTATOR (or similar) links to operators in other schemas. Apparently Daniel Whitter is the first person ever to try this :-( | 09 January 2006, 21:16:25 UTC |
| ed47146 | Andrew Dunstan | 08 January 2006, 15:50:00 UTC | Stop perl from hijacking stdio and other stuff on Windows. | 08 January 2006, 15:50:00 UTC |
| e1926aa | Tom Lane | 07 January 2006, 22:45:53 UTC | Add RelationOpenSmgr() calls to ensure rd_smgr is valid when we try to use it. While it normally has been opened earlier during btree index build, testing shows that it's possible for the link to be closed again if an sinval reset occurs while the index is being built. | 07 January 2006, 22:45:53 UTC |
| c66f4ec | Tom Lane | 07 January 2006, 21:16:44 UTC | During CatCacheRemoveCList, we must now remove any members that are dead and have become unreferenced. Before 8.1, such members were left for AtEOXact_CatCache() to clean up, but now AtEOXact_CatCache isn't supposed to have anything to do. In an assert-enabled build this bug leads to an assertion failure at transaction end, but in a non-assert build the dead member is effectively just a small memory leak. Per report from Jeremy Drake. | 07 January 2006, 21:16:44 UTC |
| 4b1f09d | Tom Lane | 06 January 2006, 20:11:18 UTC | Fix failure to apply domain constraints to a NULL constant that's added to an INSERT target list during rule rewriting. Per report from John Supplee. | 06 January 2006, 20:11:18 UTC |
| 68f4ed4 | Tom Lane | 06 January 2006, 03:00:06 UTC | Release-note updates and copy editing. | 06 January 2006, 03:00:06 UTC |
| c628930 | Tom Lane | 06 January 2006, 02:58:32 UTC | Fix Windows-only postmaster code to reject a connection request and continue, rather than elog(FATAL), when there is no more room in ShmemBackendArray. This is a security issue since too many connection requests arriving close together could cause the postmaster to shut down, resulting in denial of service. Reported by Yoshiyuki Asaba, fixed by Magnus Hagander. | 06 January 2006, 02:58:32 UTC |
| 9395f49 | Tom Lane | 06 January 2006, 00:15:58 UTC | Convert Assert checking for empty page into a regular test and elog. The consequences of overwriting a non-empty page are bad enough that we should not omit this test in production builds. | 06 January 2006, 00:15:58 UTC |
| cf3c9c1 | Tom Lane | 06 January 2006, 00:04:26 UTC | Fix ReadBuffer() to correctly handle the case where it's trying to extend the relation but it finds a pre-existing valid buffer. The buffer does not correspond to any page known to the kernel, so we *must* do smgrextend to ensure that the space becomes allocated. The 7.x branches all do this correctly, but the corner case got lost somewhere during 8.0 bufmgr rewrites. (My fault no doubt :-( ... I think I assumed that such a buffer must be not-BM_VALID, which is not so.) | 06 January 2006, 00:04:26 UTC |
| ffc7186 | Bruce Momjian | 05 January 2006, 15:19:52 UTC | New pgcrypto item wording. | 05 January 2006, 15:19:52 UTC |
| 61180e8 | Bruce Momjian | 05 January 2006, 15:13:26 UTC | Wording improvements. | 05 January 2006, 15:13:26 UTC |
| 045de2d | Bruce Momjian | 05 January 2006, 14:54:07 UTC | Improve markup. | 05 January 2006, 14:54:07 UTC |
| 3e62f08 | Peter Eisentraut | 05 January 2006, 09:32:12 UTC | Translation update | 05 January 2006, 09:32:12 UTC |
| e0f1f8a | Bruce Momjian | 05 January 2006, 05:16:03 UTC | Update release notes for 8.1.X, 8.0.X, 7.4.X, and 7.3.X. | 05 January 2006, 05:16:03 UTC |
| f54a68d | Bruce Momjian | 05 January 2006, 04:02:26 UTC | Stamp release 8.1.2. | 05 January 2006, 04:02:26 UTC |
| e9bb12d | Tom Lane | 05 January 2006, 00:54:51 UTC | Arrange to set the LC_XXX environment variables to match our locale setup. Back-patch of previous fix in HEAD for plperl-vs-locale issue. | 05 January 2006, 00:54:51 UTC |
| f336613 | Tom Lane | 04 January 2006, 19:16:32 UTC | Fix another case in which autovacuum would fail while analyzing expressional indexes. Per report from Brian Hirt. | 04 January 2006, 19:16:32 UTC |
| f5b50af | Tom Lane | 03 January 2006, 23:46:38 UTC | There is a signedness bug in Openwall gen_salt code that pgcrypto uses. This makes the salt space for md5 and xdes algorithms a lot smaller than it should be. Marko Kreen | 03 January 2006, 23:46:38 UTC |
| 17903a7 | Joe Conway | 03 January 2006, 23:46:32 UTC | When the remote query result has a different number of columns than the local query specifies (e.g. in the FROM clause), throw an ERROR (instead of crashing). Fix for bug #2129 reported by Akio Iwaasa. | 03 January 2006, 23:46:32 UTC |
| 54b84d4 | Tom Lane | 03 January 2006, 23:32:34 UTC | Fix incorrect treatment of RL_PROMPT_START_IGNORE/RL_PROMPT_END_IGNORE, per http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=343616 via Martin Pitt. | 03 January 2006, 23:32:34 UTC |
| 495be39 | Tom Lane | 03 January 2006, 22:48:21 UTC | Add checks to verify that a plpgsql function returning a rowtype is actually returning the rowtype it's supposed to return. Per reports from David Niblett and Michael Fuhr. | 03 January 2006, 22:48:21 UTC |
| a61ca09 | Tom Lane | 02 January 2006, 19:55:31 UTC | Reset flex state in a way that works for both flex 2.5.4 and 2.5.31. | 02 January 2006, 19:55:31 UTC |
| 7833a88 | Tom Lane | 01 January 2006, 19:53:48 UTC | Rewrite ProcessConfigFile() to avoid misbehavior at EOF, as per report from Andrus Moor. The former state-machine-style coding wasn't actually doing much except obscuring the control flow, and it didn't extend readily to fix this case, so I just took it out. Also, add a YY_FLUSH_BUFFER call to ensure the lexer is reset correctly if the previous scan failed partway through the file. | 01 January 2006, 19:53:48 UTC |
| 49d3d5d | Neil Conway | 01 January 2006, 10:14:21 UTC | Remove DOS line endings ("\r\n") from several .po files. DOS line endings are inconsistent with the rest of the .po files, and apparently cause problems for Sun's cc. Per report on IRC from "bitvector2". | 01 January 2006, 10:14:21 UTC |
| fff24e9 | Tom Lane | 30 December 2005, 18:34:27 UTC | Repair EXPLAIN failure when trying to display a plan condition that involves selection of a field from the result of a function returning RECORD. I believe this case is new in 8.1; it's due to the addition of OUT parameters. Per example from Michael Fuhr. | 30 December 2005, 18:34:27 UTC |
| ff48fb9 | Neil Conway | 29 December 2005, 21:47:40 UTC | Index: src/pl/plpython/plpython.c =================================================================== RCS file: /Users/neilc/postgres/cvs_root/pgsql/src/pl/plpython/plpython.c,v retrieving revision 1.67 diff -c -r1.67 plpython.c *** src/pl/plpython/plpython.c 26 Dec 2005 04:28:48 -0000 1.67 --- src/pl/plpython/plpython.c 29 Dec 2005 16:54:57 -0000 *************** *** 2,8 **** * plpython.c - python as a procedural language for PostgreSQL * * This software is copyright by Andrew Bosma ! * but is really shameless cribbed from pltcl.c by Jan Weick, and * plperl.c by Mark Hollomon. * * The author hereby grants permission to use, copy, modify, --- 2,8 ---- * plpython.c - python as a procedural language for PostgreSQL * * This software is copyright by Andrew Bosma ! * but is really shamelessly cribbed from pltcl.c by Jan Wieck, and * plperl.c by Mark Hollomon. * * The author hereby grants permission to use, copy, modify, *************** *** 1996,2002 **** int i, rv; PLyPlanObject *plan; - char *nulls; MemoryContext oldcontext; if (list != NULL) --- 1996,2001 ---- *************** *** 2018,2024 **** if (nargs != plan->nargs) { char *sv; - PyObject *so = PyObject_Str(list); if (!so) --- 2017,2022 ---- *************** *** 2036,2048 **** oldcontext = CurrentMemoryContext; PG_TRY(); { ! nulls = palloc(nargs * sizeof(char)); for (i = 0; i < nargs; i++) { PyObject *elem, *so; - char *sv; elem = PySequence_GetItem(list, i); if (elem != Py_None) --- 2034,2045 ---- oldcontext = CurrentMemoryContext; PG_TRY(); { ! char *nulls = palloc(nargs * sizeof(char)); for (i = 0; i < nargs; i++) { PyObject *elem, *so; elem = PySequence_GetItem(list, i); if (elem != Py_None) *************** *** 2051,2070 **** if (!so) PLy_elog(ERROR, "function \"%s\" could not execute plan", PLy_procedure_name(PLy_curr_procedure)); ! sv = PyString_AsString(so); ! /* ! * FIXME -- if this elogs, we have Python reference leak ! */ ! plan->values[i] = ! FunctionCall3(&(plan->args[i].out.d.typfunc), ! CStringGetDatum(sv), ! ObjectIdGetDatum(plan->args[i].out.d.typioparam), ! Int32GetDatum(-1)); ! Py_DECREF(so); ! Py_DECREF(elem); nulls[i] = ' '; } else --- 2048,2073 ---- if (!so) PLy_elog(ERROR, "function \"%s\" could not execute plan", PLy_procedure_name(PLy_curr_procedure)); ! Py_DECREF(elem); ! PG_TRY(); ! { ! char *sv = PyString_AsString(so); ! plan->values[i] = ! FunctionCall3(&(plan->args[i].out.d.typfunc), ! CStringGetDatum(sv), ! ObjectIdGetDatum(plan->args[i].out.d.typioparam), ! Int32GetDatum(-1)); ! } ! PG_CATCH(); ! { ! Py_DECREF(so); ! PG_RE_THROW(); ! } ! PG_END_TRY(); + Py_DECREF(so); nulls[i] = ' '; } else | 29 December 2005, 21:47:40 UTC |
| 8136eca | Bruce Momjian | 29 December 2005, 04:02:41 UTC | Remove a space that incorrectly precedes a comma in the PL/pgSQL documentation. Michael Fuhr | 29 December 2005, 04:02:41 UTC |
| 5fcf4a9 | Bruce Momjian | 28 December 2005, 15:07:13 UTC | Add COPY CSV test that tests CSV output of \. | 28 December 2005, 15:07:13 UTC |
| c54fee8 | Bruce Momjian | 28 December 2005, 14:38:43 UTC | Update COPY CSV \. wording for externally created files. | 28 December 2005, 14:38:43 UTC |
| c7fc2cc | Bruce Momjian | 28 December 2005, 05:38:27 UTC | Add regression tests for CSV and \., and add automatic quoting of a single column dump that has a \. value, so the load works properly. I also added documentation describing this issue. Backpatch to 8.1.X. | 28 December 2005, 05:38:27 UTC |
| 3f99c2d | Bruce Momjian | 27 December 2005, 18:10:57 UTC | Our code had: if (c == '\\' && cstate->line_buf.len == 0) The problem with that is the because of the input and _output_ buffering, cstate->line_buf.len could be zero even if we are not on the first character of a line. In fact, for a typical line, it is zero for all characters on the line. The proper solution is to introduce a boolean, first_char_in_line, that we set as we enter the loop and clear once we process a character. I have restructured the line-reading code in copy.c by: o merging the CSV/non-CSV functions into a single function o used macros to centralize and clarify the buffering code o updated comments o renamed client_encoding_only to encoding_embeds_ascii o added a high-bit test to the encoding_embeds_ascii test for performance o in CSV mode, allow a backslash followed by a non-period to continue being processed as a data value There should be no performance impact from this patch because it is functionally equivalent. If you apply the patch you will see copy.c is much clearer in this area now and might suggest additional optimizations. I have also attached a 8.1-only patch to fix the CSV \. handling bug with no code restructuring. | 27 December 2005, 18:10:57 UTC |
| ab2d8c4 | Tatsuo Ishii | 24 December 2005, 09:42:30 UTC | Fix long standing Asian multibyte charsets bug. See: Subject: [HACKERS] bugs with certain Asian multibyte charsets From: Tatsuo Ishii <ishii@sraoss.co.jp> To: pgsql-hackers@postgresql.org Date: Sat, 24 Dec 2005 18:25:33 +0900 (JST) for more details. | 24 December 2005, 09:42:30 UTC |
| 5343bca | Tatsuo Ishii | 24 December 2005, 00:49:18 UTC | Fix for rearranging encoding id ISO-8859-5 to ISO-8859-8. Also make the code more robust by searching for target encoding in the internal charset map. Problem reported by Sagi Bashari on 2005/12/21. See "[BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 encoding conversion" on pgsql-bugs list for more details. Back patch for 8.1_STABLE. | 24 December 2005, 00:49:18 UTC |
| 13d954d | Tom Lane | 23 December 2005, 22:34:27 UTC | Fix make_relative_path() to support cases where target_path and bin_path differ by more than the last directory component. Instead of insisting that they match up to the last component, accept whatever common prefix they have, and try to replace the non-matching part of bin_path with the non-matching part of target_path in the actual executable's path. In one way this is tighter than the old code, because it insists on a match to the part of bin_path we want to substitute for, rather than blindly stripping one directory component from the executable's path. Per gripe from Martin Pitt and subsequent discussion. | 23 December 2005, 22:34:27 UTC |
| e6242ba | Tom Lane | 22 December 2005, 22:50:07 UTC | Adjust string comparison so that only bitwise-equal strings are considered equal: if strcoll claims two strings are equal, check it with strcmp, and sort according to strcmp if not identical. This fixes inconsistent behavior under glibc's hu_HU locale, and probably under some other locales as well. Also, take advantage of the now-well-defined behavior to speed up texteq, textne, bpchareq, bpcharne: they may as well just do a bitwise comparison and not bother with strcoll at all. NOTE: affected databases may need to REINDEX indexes on text columns to be sure they are self-consistent. | 22 December 2005, 22:50:07 UTC |
| f545a05 | Bruce Momjian | 22 December 2005, 21:45:30 UTC | Update interval documenation to mention the storage system used. | 22 December 2005, 21:45:30 UTC |
| 14e9a17 | Bruce Momjian | 21 December 2005, 23:23:09 UTC | Add documentation example of using interval multiplication with 'days'. Backpatch to 8.1.X. | 21 December 2005, 23:23:09 UTC |
| 2469b99 | Bruce Momjian | 21 December 2005, 16:02:44 UTC | Add additional example for interval multiplication. Fix example for day and hours interval subtraction for new computation method. Update interval examples to display zero seconds, which is our default. Backpatch to 8.1.X. | 21 December 2005, 16:02:44 UTC |
| dacf7e7 | Teodor Sigaev | 21 December 2005, 13:07:38 UTC | Fix word's length in pg_regexec call | 21 December 2005, 13:07:38 UTC |
| ba7fd49 | Tom Lane | 14 December 2005, 17:06:37 UTC | Defend against crash while processing Describe Statement or Describe Portal messages, when client attempts to execute these outside a transaction (start one) or in a failed transaction (reject message, except for COMMIT/ROLLBACK statements which we can handle). Per report from Francisco Figueiredo Jr. | 14 December 2005, 17:06:37 UTC |
| 599e225 | Tom Lane | 14 December 2005, 16:28:49 UTC | Fix problem with whole-row Vars referencing sub-select outputs, per example from Jim Dew. Add some simple regression tests, since this is an area we seem to break regularly :-( | 14 December 2005, 16:28:49 UTC |
| f23e9f7 | Tom Lane | 10 December 2005, 19:21:17 UTC | Teach deparsing of CASE expressions to cope with the simplified forms that simplify_boolean_equality() may leave behind. This is only relevant if the user writes something a bit silly, like CASE x=y WHEN TRUE THEN. Per example from Michael Fuhr; may or may not explain bug #2106. | 10 December 2005, 19:21:17 UTC |
