| 9e647a1 | Marc G. Fournier | 01 February 2008, 04:16:29 UTC | configure tag'd 8.3.0 and built witih autoconf 2.59 | 01 February 2008, 04:16:29 UTC |
| aad140b | Bruce Momjian | 01 February 2008, 02:59:02 UTC | Stamp 8.3 in CVS. _No_ update of configure/configure.in. | 01 February 2008, 02:59:02 UTC |
| 1ac0994 | Bruce Momjian | 01 February 2008, 02:55:41 UTC | Update FAQ for most recent release as 8.3. | 01 February 2008, 02:55:41 UTC |
| ea3db8f | Bruce Momjian | 01 February 2008, 02:41:10 UTC | Update item: < * Improve deadlock detection when deleting items from shared buffers > * Improve deadlock detection when a page cleaning lock conflicts > with a shared buffer that is pinned | 01 February 2008, 02:41:10 UTC |
| b07e548 | Bruce Momjian | 31 January 2008, 23:31:33 UTC | Fix spelling typo in comment. | 31 January 2008, 23:31:33 UTC |
| 694403d | Bruce Momjian | 31 January 2008, 23:30:31 UTC | Add comment about possible URL changes for www7.hp.com: <!-- If this URL chnages replace it with a URL to www.archive.org. --> | 31 January 2008, 23:30:31 UTC |
| 162dc31 | Bruce Momjian | 31 January 2008, 23:03:16 UTC | Update spoofing /tmp symlink instructions to be more specific about the name of the needed symlink file. | 31 January 2008, 23:03:16 UTC |
| 06462f5 | Tom Lane | 31 January 2008, 21:31:33 UTC | Mention synchronize_seqscans GUC variable in release notes. Update expected release date. | 31 January 2008, 21:31:33 UTC |
| 73d9544 | Tom Lane | 31 January 2008, 20:29:30 UTC | Remove the old table of "supported platforms" in favor of a link to the buildfarm plus a narrative description of the CPU types and operating systems on which Postgres is likely to work. Now that we've almost completely decoupled CPU and OS considerations, the former tabular style isn't all that enlightening anyway. Perhaps more importantly, no one seems particularly interested in maintaining the table by hand when we have the buildfarm. | 31 January 2008, 20:29:30 UTC |
| cf82aee | Tom Lane | 31 January 2008, 18:58:30 UTC | Fix pg_GSS_error to use conn->errorMessage more sanely, ie, actually work with the PQExpBuffer code instead of fighting it. This avoids an unnecessary limit on message length and fixes the latent bug that errorMessage.len wasn't getting set. | 31 January 2008, 18:58:30 UTC |
| 7c15b10 | Tom Lane | 31 January 2008, 18:40:02 UTC | Improve pg_autovacuum documentation to clarify that the enabled field cannot prevent anti-wraparound vacuuming, and to caution against setting unreasonably small values of freeze_max_age. Also put in a notice that this catalog is likely to disappear entirely in some future release. Per discussion of bug #3898 from Steven Flatt. | 31 January 2008, 18:40:02 UTC |
| 3c9ae73 | Peter Eisentraut | 31 January 2008, 18:04:52 UTC | Translation updates | 31 January 2008, 18:04:52 UTC |
| 8e9c7fe | Bruce Momjian | 31 January 2008, 17:22:43 UTC | Document the idea of creating a symbolic link in /tmp to prevent server spoofing when the socket file has been moved. | 31 January 2008, 17:22:43 UTC |
| 7ae4318 | Andrew Dunstan | 31 January 2008, 16:30:24 UTC | Remove 3 hex digit limit on symbol number in recent fix. | 31 January 2008, 16:30:24 UTC |
| 55986a5 | Bruce Momjian | 31 January 2008, 15:05:09 UTC | Add: > * Improve deadlock detection when deleting items from shared buffers > > http://archives.postgresql.org/pgsql-bugs/2008-01/msg00138.php > http://archives.postgresql.org/pgsql-hackers/2008-01/msg00873.php > http://archives.postgresql.org/pgsql-committers/2008-01/msg00365.php | 31 January 2008, 15:05:09 UTC |
| 0ace923 | Magnus Hagander | 31 January 2008, 09:21:17 UTC | Add pid to the pgident event name on win32. Should fix a problem where two clusters are running under two different service accounts and get colliding names, causing only the first cluster to contain the pgident event description. Per report from Stephen Denne. | 31 January 2008, 09:21:17 UTC |
| 0a4ef62 | Andrew Dunstan | 31 January 2008, 03:26:14 UTC | Fix test that wrongly excluded some dumpbin symbols. Keep the intermediate symbol file rather then blowing it away, for easier debugging. | 31 January 2008, 03:26:14 UTC |
| 0688d84 | Tom Lane | 30 January 2008, 19:46:48 UTC | Add checks to TRUNCATE, CLUSTER, and REINDEX to prevent performing these operations when the current transaction has any open references to the target relation or index (implying it has an active query using the relation). The need for this was previously recognized in connection with ALTER TABLE, but anything that summarily eliminates tuples or moves them around would confuse an active scan. While this patch does not in itself fix bug #3883 (the deadlock would happen before the new check fires), it will discourage people from attempting the sequence of operations that creates a deadlock risk, so it's at least a partial response to that problem. In passing, add a previously-missing check to REINDEX to prevent trying to reindex another backend's temp table. This isn't a security problem since only a superuser would get past the schema permission checks, but if we are testing for this in other utility commands then surely REINDEX should too. | 30 January 2008, 19:46:48 UTC |
| 47df4f6 | Tom Lane | 30 January 2008, 18:35:55 UTC | Add a GUC variable "synchronize_seqscans" to allow clients to disable the new synchronized-scanning behavior, and make pg_dump disable sync scans so that it will reliably preserve row ordering. Per recent discussions. | 30 January 2008, 18:35:55 UTC |
| 6dfa40d | Peter Eisentraut | 30 January 2008, 11:05:41 UTC | Translation updates | 30 January 2008, 11:05:41 UTC |
| f73f18f | Peter Eisentraut | 30 January 2008, 10:49:55 UTC | Improve table reference | 30 January 2008, 10:49:55 UTC |
| c7640c3 | Peter Eisentraut | 30 January 2008, 10:37:36 UTC | Update key words table for 8.3 | 30 January 2008, 10:37:36 UTC |
| b58d8c9 | Tom Lane | 30 January 2008, 04:11:19 UTC | Don't putenv() a string that is allocated in a context that will go away soon. I suspect this explains bug #3902, though I'm still not able to reproduce that. | 30 January 2008, 04:11:19 UTC |
| 65b39ec | Bruce Momjian | 29 January 2008, 16:13:09 UTC | Update wording: < * Add anonymous transactions > * Add autonomous transactions | 29 January 2008, 16:13:09 UTC |
| 1567133 | Bruce Momjian | 29 January 2008, 16:11:19 UTC | Add item: > * Add anonymous transactions > > http://archives.postgresql.org/pgsql-hackers/2008-01/msg00893.php > | 29 January 2008, 16:11:19 UTC |
| 522f362 | Bruce Momjian | 29 January 2008, 16:09:28 UTC | Remove duplicat item: < o Allow the PITR process to be debugged and data examined | 29 January 2008, 16:09:28 UTC |
| a38fae6 | Peter Eisentraut | 29 January 2008, 13:03:50 UTC | markup correct from Gevik Babakhani | 29 January 2008, 13:03:50 UTC |
| 5037ed8 | Tom Lane | 29 January 2008, 02:06:30 UTC | Fix up closePGconn() so that PQreset() will work on GSSAPI/SSPI connections; the patch for those features put its cleanup code into freePGconn() which is really the wrong place. Remove redundant code from freePGconn() and add comments in hopes of preventing similar mistakes in future. Noticed while trying (futilely) to reproduce bug #3902. | 29 January 2008, 02:06:30 UTC |
| fad2b99 | Tom Lane | 29 January 2008, 02:03:39 UTC | Arrange to ignore SIGPIPE during SSL_read() and SSL_shutdown(), as these are known to write on the socket sometimes and thus we are vulnerable to being killed by the signal if the server happens to go away unexpectedly. Noticed while trying (futilely) to reproduce bug #3902. This bug has been there all along, but since the situation is usually only of interest to developers, I chose not to back-patch the changes. | 29 January 2008, 02:03:39 UTC |
| cf9990c | Bruce Momjian | 28 January 2008, 18:43:55 UTC | Add "Communication Method" row to HA feature matrix documentation. | 28 January 2008, 18:43:55 UTC |
| b5518c8 | Tom Lane | 27 January 2008, 19:12:28 UTC | Minor editorial improvements in documentation of session_replication_role; in particular correct the obsolete claim that it can't be changed once any plans have been cached. | 27 January 2008, 19:12:28 UTC |
| 6322e84 | Tom Lane | 26 January 2008, 19:55:08 UTC | Change StatementCancelHandler() to check the DoingCommandRead flag to decide whether to execute an immediate interrupt, rather than testing whether LockWaitCancel() cancelled a lock wait. The old way misclassified the case where we were blocked in ProcWaitForSignal(), and arguably would misclassify any other future additions of new ImmediateInterruptOK states too. This allows reverting the old kluge that gave LockWaitCancel() a return value, since no callers care anymore. Improve comments in the various implementations of PGSemaphoreLock() to explain that on some platforms, the assumption that semop() exits after a signal is wrong, and so we must ensure that the signal handler itself throws elog if we want cancel or die interrupts to be effective. Per testing related to bug #3883, though this patch doesn't solve those problems fully. Perhaps this change should be back-patched, but since pre-8.3 branches aren't really relying on autovacuum to respond to SIGINT, it doesn't seem critical for them. | 26 January 2008, 19:55:08 UTC |
| ace1b29 | Tom Lane | 25 January 2008, 20:42:10 UTC | Fix two different copy-and-paste-os in CSV log rotation logic; one that led to a double-pfree crash and another that effectively disabled size-based rotation for CSV logs. Also suppress a memory leak and make some trivial cosmetic improvements. Per bug #3901 from Chris Hoover and additional code-reading. | 25 January 2008, 20:42:10 UTC |
| a794b99 | Andrew Dunstan | 25 January 2008, 15:28:35 UTC | Fix example of de-escaping bytea argument, per Florian Weimer. Also fix example of escaping bytea return value. Both cases did not handle backslash values properly. | 25 January 2008, 15:28:35 UTC |
| 353a1cc | Tom Lane | 25 January 2008, 04:46:07 UTC | Release any detoasted copies of arrays that are made temporarily in ri_FetchConstraintInfo, to avoid a query-duration memory leak when that routine is called by RI_FKey_keyequal_upd_fk (which isn't executed in a short-lived context). This problem was latent when the routine was added in February, but it didn't become serious until the varvarlena patch made it quite likely that the fields being examined would be "toasted" (ie, have short headers). Per report from Stephen Denne. | 25 January 2008, 04:46:07 UTC |
| 79a323a | Peter Eisentraut | 24 January 2008, 06:23:33 UTC | Change /contrib to contrib for consistency. | 24 January 2008, 06:23:33 UTC |
| b9ff744 | Tom Lane | 23 January 2008, 21:26:13 UTC | Prevent integer overflow within the integer-datetimes version of TimestampTzPlusMilliseconds. An integer argument of more than INT_MAX/1000 milliseconds (ie, about 35 minutes) would provoke a wrong result, resulting in incorrect enforcement of statement_timestamp values larger than that. Bug was introduced in my rewrite of 2006-06-20, which fixed some other overflow risks, but missed this one :-( Per report from Elein. | 23 January 2008, 21:26:13 UTC |
| 1570d04 | Tom Lane | 23 January 2008, 20:21:37 UTC | Provide a concrete example of parameter expansion in archive_command. Per discussion of bug #3877. Simon Riggs, some fixes by moi. | 23 January 2008, 20:21:37 UTC |
| 216e63b | Tom Lane | 23 January 2008, 19:51:29 UTC | Avoid mathematical inconsistency in example about avoiding division by zero with a CASE expression. Per gripe from Russell Smith. | 23 January 2008, 19:51:29 UTC |
| 8984c8b | Alvaro Herrera | 23 January 2008, 15:36:38 UTC | Improve lock level choices in pg_shdepend.c. Noticed by Tom Lane. | 23 January 2008, 15:36:38 UTC |
| 6a7a63d | Tom Lane | 23 January 2008, 02:04:47 UTC | Reference pgAdmin as a typical client-side tool, rather than the no-longer-maintained PgAccess. Per Erik Rijkers. | 23 January 2008, 02:04:47 UTC |
| cd76ad6 | Andrew Dunstan | 23 January 2008, 00:55:47 UTC | Document the fix for perl 5.10 with this comment: * The temporary enabling of the caller opcode here is to work around a * bug in perl 5.10, which unkindly changed the way its Safe.pm works, without * notice. It is quite safe, as caller is informational only, and in any case * we only enable it while we load the 'strict' module. | 23 January 2008, 00:55:47 UTC |
| ac11d9d | Andrew Dunstan | 22 January 2008, 20:17:37 UTC | Work around for perl 5.10 bug - fix due to perl hacker Simon Cozens. | 22 January 2008, 20:17:37 UTC |
| 6f8f8d2 | Peter Eisentraut | 21 January 2008, 11:17:46 UTC | Provide a clearer error message if the pg_control version number looks wrong because of mismatched byte ordering. | 21 January 2008, 11:17:46 UTC |
| 1e98572 | Tom Lane | 21 January 2008, 03:28:42 UTC | Improve description of bgwriter_lru_multiplier, per discussion. | 21 January 2008, 03:28:42 UTC |
| 716e8b8 | Tom Lane | 21 January 2008, 02:46:11 UTC | Fix RS_isRegis() to agree exactly with RS_compile()'s idea of what's a valid regis. Correct the latter's oversight that a bracket-expression needs to be terminated. Reduce the ereports to elogs, since they are now not expected to ever be hit (thus addressing Alvaro's original complaint). In passing, const-ify the string argument to RS_compile. | 21 January 2008, 02:46:11 UTC |
| f7108ce | Tom Lane | 20 January 2008, 21:13:55 UTC | Fix psql \h output for case of no parameters (ie, list all the known commands) to format properly for the actually needed column width, instead of having a hard-wired assumption about the longest command name length. Also make it respond to the current screen width. In passing, const-ify the constant table. | 20 January 2008, 21:13:55 UTC |
| 000666b | Alvaro Herrera | 20 January 2008, 17:50:41 UTC | Split error message. | 20 January 2008, 17:50:41 UTC |
| f10589e | Tom Lane | 19 January 2008, 17:43:42 UTC | Make pg_regress clean out the testtablespace directory only on Windows. On other platforms it's better to let the Makefile handle it, but we want the regression tests to be invokable without make on Windows. A batch file would be a better solution, but no time for that before 8.3. Per my discovery that this breaks testing under SELinux, and subsequent discussion. | 19 January 2008, 17:43:42 UTC |
| aeeef41 | Marc G. Fournier | 18 January 2008, 04:47:32 UTC | must commit after autoconf ... and yes, I used the right autoconf | 18 January 2008, 04:47:32 UTC |
| 7b4be2b | Bruce Momjian | 18 January 2008, 00:13:50 UTC | Stamp release for 8.3RC2; configure will be stamped by packager. | 18 January 2008, 00:13:50 UTC |
| 70066eb | Tom Lane | 17 January 2008, 21:21:50 UTC | Insert into getCopyDataMessage() the same logic that already existed in the main code path for enlarging libpq's input buffer in one swoop when needing to read a long data message. Without this, the code will double the buffer size, read more data, notice it still hasn't got the whole message, and repeat till it finally has a large enough buffer. Which wastes a lot of data-moving effort and also memory (since malloc probably can't do anything very useful with the freed-up smaller buffers). Not sure why this wasn't there already; certainly the COPY data path is a place where we're quite likely to see long data messages. I'm not backpatching though, since this is just a marginal performance issue rather than a real bug. | 17 January 2008, 21:21:50 UTC |
| a44174c | Tom Lane | 17 January 2008, 20:35:27 UTC | Fix subselect.c to avoid assuming that a SubLink's testexpr references each subquery output column exactly once left-to-right. Although this is the case in the original parser output, it might not be so after rewriting and constant-folding, as illustrated by bug #3882 from Jan Mate. Instead scan the subquery's target list to obtain needed per-column information; this is duplicative of what the parser did, but only a couple dozen lines need be copied, and we can clean up a couple of notational uglinesses. Bug was introduced in 8.2 as part of revision of SubLink representation. | 17 January 2008, 20:35:27 UTC |
| 0df7717 | Tom Lane | 17 January 2008, 18:56:54 UTC | Fix ALTER INDEX RENAME so that if the index belongs to a unique or primary key constraint, the constraint is renamed as well. This avoids inconsistent situations that could confuse pg_dump (not to mention humans). We might at some point provide ALTER TABLE RENAME CONSTRAINT as a more general solution, but there seems no reason not to allow doing it this way too. Per bug #3854 and related discussions. | 17 January 2008, 18:56:54 UTC |
| d07de6c | Bruce Momjian | 17 January 2008, 18:53:20 UTC | Update Japanese FAQ. Jun Kuwamura | 17 January 2008, 18:53:20 UTC |
| e467168 | Magnus Hagander | 17 January 2008, 14:34:45 UTC | Typo fix. Erik Rijkers | 17 January 2008, 14:34:45 UTC |
| 98bb697 | Magnus Hagander | 17 January 2008, 11:06:28 UTC | pgcrypto doc updates Marko Kreen | 17 January 2008, 11:06:28 UTC |
| c7d7c15 | Andrew Dunstan | 16 January 2008, 22:07:04 UTC | Document the fact that COPY always uses the client encoding. | 16 January 2008, 22:07:04 UTC |
| 97e3a6e | Tom Lane | 16 January 2008, 21:00:25 UTC | Remove inappropriate cd commands, per David Wheeler. Also make the PATH responsive to the installation prefix, which was the apparent intent of the previous edit, but not well executed. | 16 January 2008, 21:00:25 UTC |
| bfde21a | Bruce Momjian | 16 January 2008, 20:13:44 UTC | Improve usage message for pgindent. | 16 January 2008, 20:13:44 UTC |
| cd42dd5 | Teodor Sigaev | 16 January 2008, 13:01:03 UTC | Fix core dump with buffer-overrun by too long infinitive. Add checking of using fixed length arrays to prevent array's overrun. Per report by Hannes Dorbath <light@theendofthetunnel.de> and comments by Tom. | 16 January 2008, 13:01:03 UTC |
| 0153c4c | Tom Lane | 15 January 2008, 22:18:20 UTC | Be less wishy-washy in the documentation and comments about whether a ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function. | 15 January 2008, 22:18:20 UTC |
| 14e2a26 | Tom Lane | 15 January 2008, 21:20:28 UTC | Prevent CLUSTER from decreasing a relation's relfrozenxid. Bug introduced in rewrite to make CLUSTER MVCC-safe. | 15 January 2008, 21:20:28 UTC |
| ac12412 | Tom Lane | 15 January 2008, 18:57:00 UTC | Revise memory management for libxml calls. Instead of keeping libxml's data in whichever context happens to be current during a call of an xml.c function, use a dedicated context that will not go away until we explicitly delete it (which we do at transaction end or subtransaction abort). This makes recovery after an error much simpler --- we don't have to individually delete the data structures created by libxml. Also, we need to initialize and cleanup libxml only once per transaction (if there's no error) instead of once per function call, so it should be a bit faster. We'll need to keep an eye out for intra-transaction memory leaks, though. Alvaro and Tom. | 15 January 2008, 18:57:00 UTC |
| deb7ded | Tom Lane | 15 January 2008, 18:22:47 UTC | Tweak new error message to conform to style guidelines. | 15 January 2008, 18:22:47 UTC |
| f7807f1 | Teodor Sigaev | 15 January 2008, 17:16:01 UTC | Add check of headline method presence. Per report by Yoshiyuki Asaba <y-asaba@sraoss.co.jp> | 15 January 2008, 17:16:01 UTC |
| dbdc2e5 | Michael Meskes | 15 January 2008, 10:31:47 UTC | Re-enabled variables in fetch/move command. | 15 January 2008, 10:31:47 UTC |
| abab776 | Tom Lane | 15 January 2008, 01:36:53 UTC | Somebody forgot to add this ERRCODE everywhere it should go ... | 15 January 2008, 01:36:53 UTC |
| 1272ac8 | Bruce Momjian | 14 January 2008, 22:14:30 UTC | Add: > > * Add the ability to automatically create materialized views > > Right now materialized views require the user to create triggers on the > main table to keep the summary table current. SQL syntax should be able > to manager the triggers and summary table automatically. A more > sophisticated implementation would automatically retrieve from the > summary table when the main table is referenced, if possible. > | 14 January 2008, 22:14:30 UTC |
| be8451e | Bruce Momjian | 14 January 2008, 20:39:30 UTC | Most recent Postgres version is 8.2.6, per report from Robert Treat. | 14 January 2008, 20:39:30 UTC |
| ea00ab8 | Tom Lane | 14 January 2008, 19:27:41 UTC | Prevent pg_dump from dumping the comment (if any) on the 'public' schema. This is to avoid uselessly requiring superuser permissions to restore the dump without errors. Pretty grotty, but no better alternative seems available, at least not in the near term. | 14 January 2008, 19:27:41 UTC |
| 98c0ebc | Tom Lane | 14 January 2008, 19:18:53 UTC | Avoid cluttering the postmaster log with bogus complaints during transaction abort, per my note from a couple days ago. | 14 January 2008, 19:18:53 UTC |
| 5c76714 | Tom Lane | 14 January 2008, 18:46:17 UTC | Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode: we need to be able to swallow NOTICE messages, and potentially also ParameterStatus messages (although the latter would be a bit weird), without exiting COPY OUT state. Fix it, and adjust the protocol documentation to emphasize the need for this. Per off-list report from Alexander Galler. | 14 January 2008, 18:46:17 UTC |
| 7aa4164 | Alvaro Herrera | 14 January 2008, 13:39:25 UTC | Mark autovacuum entries in pg_stat_activity so that they can be easily distinguished from user-invoked commands. Per suggestion from Tom Lane. | 14 January 2008, 13:39:25 UTC |
| 1460c82 | Michael Meskes | 14 January 2008, 09:43:42 UTC | Set valid return values even in case of an error to prevent segfaults. | 14 January 2008, 09:43:42 UTC |
| b775d93 | Tom Lane | 14 January 2008, 02:53:31 UTC | Fix pgstat_heap() to not be broken by syncscans starting from a block higher than zero. Same problem as just detected in CREATE INDEX CONCURRENTLY. | 14 January 2008, 02:53:31 UTC |
| 6666185 | Tom Lane | 14 January 2008, 02:49:47 UTC | Use an indexscan not a heapscan to search pg_index in get_pkey_attnames. Noted while looking for heapscans that might need to start from block zero. | 14 January 2008, 02:49:47 UTC |
| d3b1b1f | Tom Lane | 14 January 2008, 01:39:09 UTC | Fix CREATE INDEX CONCURRENTLY so that it won't use synchronized scan for its second pass over the table. It has to start at block zero, else the "merge join" logic for detecting which TIDs are already in the index doesn't work. Hence, extend heapam.c's API so that callers can enable or disable syncscan. (I put in an option to disable buffer access strategy, too, just in case somebody needs it.) Per report from Hannes Dorbath. | 14 January 2008, 01:39:09 UTC |
| 689d02a | Tom Lane | 13 January 2008, 21:17:46 UTC | Fix a regression test that fails if default_text_search_config isn't 'english'. | 13 January 2008, 21:17:46 UTC |
| 05a381a | Tom Lane | 13 January 2008, 17:58:54 UTC | Add note pointing out that read-only commands no longer consume command IDs. | 13 January 2008, 17:58:54 UTC |
| 149db6b | Michael Meskes | 13 January 2008, 11:53:16 UTC | Changed prototype for ECPGdo because some compilers don't like int/enum aliasing in there. | 13 January 2008, 11:53:16 UTC |
| 9f2a20b | Bruce Momjian | 12 January 2008, 21:51:36 UTC | Update documentation for tsvector duplicate elimination: ! Duplicate positions for the same lexeme are discarded. | 12 January 2008, 21:51:36 UTC |
| 1bbf870 | Tom Lane | 12 January 2008, 21:14:08 UTC | It turns out the LIBXML_TEST_VERSION macro calls xmlInitParser(). Therefore we must xmlCleanupParser(), or we risk leaving behind dangling pointers to whatever memory context is current when xml_init() is called. This seems to fix bug #3860, though we might still want the more invasive solution being worked on by Alvaro. | 12 January 2008, 21:14:08 UTC |
| 5217663 | Neil Conway | 12 January 2008, 10:50:03 UTC | Fix two places in xml.c that neglected to check the return values of SPI_prepare() and SPI_cursor_open(), to silence a Coverity warning. | 12 January 2008, 10:50:03 UTC |
| 25b7583 | Neil Conway | 12 January 2008, 10:38:32 UTC | Minor perf tweak for _SPI_strdup(): if we're going to call strlen() anyway, it is faster to memcpy() than to strcpy(). | 12 January 2008, 10:38:32 UTC |
| 208d0a2 | Tom Lane | 12 January 2008, 00:11:39 UTC | Fix logical errors in constraint exclusion: we cannot assume that a CHECK constraint yields TRUE for every row of its table, only that it does not yield FALSE (a NULL result isn't disallowed). This breaks a couple of implications that would be true in two-valued logic. I had put in one such mistake in an 8.2.5 patch: foo IS NULL doesn't refute a strict operator on foo. But there was another in the original 8.2 release: NOT foo doesn't refute an expression whose truth would imply the truth of foo. Per report from Rajesh Kumar Mallah. To preserve the ability to do constraint exclusion with one partition holding NULL values, extend relation_excluded_by_constraints() to check for attnotnull flags, and add col IS NOT NULL expressions to the set of constraints we hope to refute. | 12 January 2008, 00:11:39 UTC |
| 89c0a87 | Tom Lane | 11 January 2008, 18:39:41 UTC | The original implementation of polymorphic aggregates didn't really get the checking of argument compatibility right; although the problem is only exposed with multiple-input aggregates in which some arguments are polymorphic and some are not. Per bug #3852 from Sokolov Yura. | 11 January 2008, 18:39:41 UTC |
| df62977 | Tom Lane | 11 January 2008, 17:00:45 UTC | Fix an old error in clause_selectivity: the default selectivity estimate for unhandled clause types ought to be 0.5, not 1.0. I fear I introduced this silliness due to misreading the intent of the very-poorly-structured code that was there when we inherited the file from Berkeley. The lack of sanity in this behavior was exposed by an example from Sim Zacks. (Arguably this is a bug fix and should be back-patched, but I'm a bit hesitant to introduce a possible planner behavior change in the back branches; it might detune queries that worked acceptably in the past.) While at it, make estimation for DistinctExpr do something marginally realistic, rather than just defaulting. | 11 January 2008, 17:00:45 UTC |
| f3e3f2e | Bruce Momjian | 11 January 2008, 16:49:27 UTC | Add: > * Add ability to trigger on TRUNCATE > > http://archives.postgresql.org/pgsql-sql/2008-01/msg00050.php | 11 January 2008, 16:49:27 UTC |
| da758c2 | Michael Meskes | 11 January 2008, 15:19:16 UTC | Fixed lexer to correctly parse C quotes. | 11 January 2008, 15:19:16 UTC |
| 59fc64a | Tom Lane | 11 January 2008, 04:02:18 UTC | Fix a conceptual error in my patch of 2007-10-26 that avoided considering clauseless joins of relations that have unexploited join clauses. Rather than looking at every other base relation in the query, the correct thing is to examine the other relations in the "initial_rels" list of the current make_rel_from_joinlist() invocation, because those are what we actually have the ability to join against. This might be a subset of the whole query in cases where join_collapse_limit or from_collapse_limit or full joins have prevented merging the whole query into a single join problem. This is a bit untidy because we have to pass those rels down through a new PlannerInfo field, but it's necessary. Per bug #3865 from Oleg Kharin. | 11 January 2008, 04:02:18 UTC |
| e6a442c | Tom Lane | 11 January 2008, 00:54:09 UTC | Restructure the shutdown procedure for the archiver process to allow it to finish archiving everything (when there's no error), and to eliminate various hazards as best we can. This fixes a previous 8.3 patch that caused the postmaster to kill and then restart the archiver during shutdown (!?). The new behavior is that the archiver is allowed to run unmolested until the bgwriter has exited; then it is sent SIGUSR2 to tell it to do a final archiving cycle and quit. We only SIGQUIT the archiver if we want a panic stop; this is important since SIGQUIT will also be sent to any active archive_command. The postmaster also now doesn't SIGQUIT the stats collector until the bgwriter is done, since the bgwriter can send stats messages in 8.3. The postmaster will not exit until both the archiver and stats collector are gone; this provides some defense (not too bulletproof) against conflicting archiver or stats collector processes being started by a new postmaster instance. We continue the prior practice that the archiver will check for postmaster death immediately before issuing any archive_command; that gives some additional protection against conflicting archivers. Also, modify the archiver process to notice SIGTERM and refuse to issue any more archive commands if it gets it. The postmaster doesn't ever send it SIGTERM; we assume that any such signal came from init and is a notice of impending whole-system shutdown. In this situation it seems imprudent to try to start new archive commands --- if they aren't extremely quick they're likely to get SIGKILL'd by init. All per discussion. | 11 January 2008, 00:54:09 UTC |
| 21a00dc | Magnus Hagander | 10 January 2008, 16:03:00 UTC | Generate and include manifest in standalone libpq build on Windows. Hiroshi Saito | 10 January 2008, 16:03:00 UTC |
| 77015b5 | Bruce Momjian | 10 January 2008, 02:50:01 UTC | vacuum_cost_limit has a minimum value of 1, not zero; update postgresql.conf comment to match. | 10 January 2008, 02:50:01 UTC |
| a9742f1 | Tom Lane | 09 January 2008, 23:43:54 UTC | Remove incorrect (and ill-advised anyway) pfree's in pg_convert_from and pg_convert_to. Per bug #3866 from Andrew Gilligan. | 09 January 2008, 23:43:54 UTC |
| ceb9360 | Tom Lane | 09 January 2008, 21:52:36 UTC | Fix CREATE INDEX CONCURRENTLY to not deadlock against an automatic or manual VACUUM that is blocked waiting to get lock on the table being indexed. Per report and fix suggestion from Greg Stark. | 09 January 2008, 21:52:36 UTC |
| 6a65225 | Tom Lane | 09 January 2008, 20:42:29 UTC | Fix some planner issues found while investigating Kevin Grittner's report of poorer planning in 8.3 than 8.2: 1. After pushing a constant across an outer join --- ie, given "a LEFT JOIN b ON (a.x = b.y) WHERE a.x = 42", we can deduce that b.y is sort of equal to 42, in the sense that we needn't fetch any b rows where it isn't 42 --- loop to see if any additional deductions can be made. Previous releases did that by recursing, but I had mistakenly thought that this was no longer necessary given the EquivalenceClass machinery. 2. Allow pushing constants across outer join conditions even if the condition is outerjoin_delayed due to a lower outer join. This is safe as long as the condition is strict and we re-test it at the upper join. 3. Keep the outer-join clause even if we successfully push a constant across it. This is *necessary* in the outerjoin_delayed case, but even in the simple case, it seems better to do this to ensure that the join search order heuristics will consider the join as reasonable to make. Mark such a clause as having selectivity 1.0, though, since it's not going to eliminate very many rows after application of the constant condition. 4. Tweak have_relevant_eclass_joinclause to report that two relations are joinable when they have vars that are equated to the same constant. We won't actually generate any joinclause from such an EquivalenceClass, but again it seems that in such a case it's a good idea to consider the join as worth costing out. 5. Fix a bug in select_mergejoin_clauses that was exposed by these changes: we have to reject candidate mergejoin clauses if either side was equated to a constant, because we can't construct a canonical pathkey list for such a clause. This is an implementation restriction that might be worth fixing someday, but it doesn't seem critical to get it done for 8.3. | 09 January 2008, 20:42:29 UTC |
| 8d546c7 | Magnus Hagander | 09 January 2008, 09:16:43 UTC | Don't enforce 32-bit time_t for FRONTEND apps. Fixes standalone builds of libpq in both 32 and 64-bit. Per gripe from Hiroshi Saito. | 09 January 2008, 09:16:43 UTC |
| bbee1c5 | Neil Conway | 09 January 2008, 08:46:44 UTC | Fix an omission in the outfuncs.c support for Agg nodes: the grpColIdx and grpOperators fields were not emitted by _outAgg(). | 09 January 2008, 08:46:44 UTC |
| ccd3e32 | Alvaro Herrera | 09 January 2008, 05:27:22 UTC | Add index entry. | 09 January 2008, 05:27:22 UTC |
