Skip to main content

Browse the archive

https://github.com/tendermint/tendermint
05 April 2024, 22:58:32 UTC
sort by:
Revision Author Date Message Commit Date
bf23f74 Ethan Buchman 16 April 2019, 20:52:07 UTC Merge pull request #3570 from tendermint/ismail/backport-release/v0.30.4 Release/v0.30.4 16 April 2019, 20:52:07 UTC
62f90f0 Ismail Khoffi 16 April 2019, 12:30:58 UTC Prep release: bump version & add changelog entry Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> 16 April 2019, 12:30:58 UTC
362ef77 Alexander Simmerl 12 April 2019, 10:31:02 UTC Bring back NodeInfo NetAddress form the dead (#3545) A prior change to address accidental DNS lookups introduced the SocketAddr on peer, which was then used to add it to the addressbook. Which in turn swallowed the self reported port of the peer, which is important on a reconnect. This change revives the NetAddress on NodeInfo which the Peer carries, but now returns an error to avoid nil dereferencing another issue observed in the past. Additionally we could potentially address #3532, yet the original problem statemenf of that issue stands. As a drive-by optimisation `MarkAsGood` now takes only a `p2p.ID` which makes it interface a bit stricter and leaner. (cherry picked from commit b5b3b85697a9c29adaab0e1ab5d1380459e2c5eb) Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> 16 April 2019, 12:24:29 UTC
91fd553 Ethan Buchman 02 April 2019, 20:47:28 UTC Merge pull request #3526 from tendermint/release/v0.30.3 Release/v0.30.3 02 April 2019, 20:47:28 UTC
4ae9b63 Ethan Buchman 02 April 2019, 20:01:59 UTC Merge pull request tendermint/security#77 from tendermint/sec/bucky/backport-v0.30.3 Backport fixes for v0.30.3 02 April 2019, 20:01:59 UTC
1fb900f Ismail Khoffi 02 April 2019, 19:49:05 UTC changelog and version v0.30.3 02 April 2019, 19:49:05 UTC
eb7af9a Ismail Khoffi 02 April 2019, 19:47:46 UTC Backport release automation scripts for v0.30.3 * Release management using CircleCI (#3498) * Release management using CircleCI * Changelog updated * Fix for wrong version tag (#3517) * Fix for wrong version tag (tag on the release branch instead of master) * Release message changelog link fix (#3519) 02 April 2019, 19:47:46 UTC
5a7a975 Ismail Khoffi 02 April 2019, 19:38:50 UTC delete dummy mock, mockPeer, and use mock.Peer instead * delete dummy mock and use mock mock instead: - this fixes the build/test/linter issues in #77 - this replicates some of the changes of https://github.com/tendermint/tendermint/commit/d2f3a306be5ca4e6890fcab18b14785cceaffb65 (see https://github.com/tendermint/tendermint/pull/3487#discussion_r269620510) * delete obsolete mockPeer (how often did we mock this?) 02 April 2019, 19:38:50 UTC
df2f25f Ethan Buchman 01 April 2019, 23:59:57 UTC Fixes tendermint/tendermint#3522 * OriginalAddr -> SocketAddr OriginalAddr records the originally dialed address for outbound peers, rather than the peer's self reported address. For inbound peers, it was nil. Here, we rename it to SocketAddr and for inbound peers, set it to the RemoteAddr of the connection. * use SocketAddr Numerous places in the code call peer.NodeInfo().NetAddress(). However, this call to NetAddress() may perform a DNS lookup if the reported NodeInfo.ListenAddr includes a name. Failure of this lookup returns a nil address, which can lead to panics in the code. Instead, call peer.SocketAddr() to return the static address of the connection. * remove nodeInfo.NetAddress() Expose `transport.NetAddress()`, a static result determined when the transport is created. Removing NetAddress() from the nodeInfo prevents accidental DNS lookups. * fixes from review * linter * fixes from review 02 April 2019, 01:21:34 UTC
f0c2c9b Ethan Buchman 01 April 2019, 23:45:57 UTC Fixes tendermint/tendermint#3439 * make sure we create valid private keys: - genPrivKey samples and rejects invalid fieldelems (like libsecp256k1) - GenPrivKeySecp256k1 uses `(sha(secret) mod (n − 1)) + 1` - fix typo, rename test file: s/secpk256k1/secp256k1/ * Update crypto/secp256k1/secp256k1.go 02 April 2019, 01:20:18 UTC
9768195 Ethan Buchman 11 March 2019, 12:17:14 UTC Merge pull request #3399 from tendermint/release/v0.30.2 Release/v0.30.2 11 March 2019, 12:17:14 UTC
f996b10 Anton Kaliaev 10 March 2019, 09:06:34 UTC update changelog and bump version to 0.30.2 10 March 2019, 09:06:34 UTC
36d7180 Yumin Xia 10 March 2019, 08:46:32 UTC libs/db: close batch (#3397) ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close Fixes the memory leak in https://github.com/cosmos/cosmos-sdk/issues/3842 10 March 2019, 08:56:04 UTC
e0f8936 Ethan Buchman 20 February 2019, 15:10:49 UTC Merge pull request #3326 from tendermint/release/v0.30.1 Release/v0.30.1 20 February 2019, 15:10:49 UTC
f2351dc Ethan Buchman 20 February 2019, 15:05:57 UTC update changelog 20 February 2019, 15:05:57 UTC
9d4f59b Anton Kaliaev 18 February 2019, 11:27:07 UTC update changelog and bump version 18 February 2019, 11:27:26 UTC
d2c7f8d Ismail Khoffi 18 February 2019, 10:08:22 UTC p2p: check secret conn id matches dialed id (#3321) ref: [#3010 (comment)](https://github.com/tendermint/tendermint/issues/3010#issuecomment-464287627) > I tried searching for code where we authenticate a peer against its NetAddress.ID and couldn't find it. I don't see a reason to switch to Noise, but a need to ensure that the node's ID is authenticated e.g. after dialing from the address book. * p2p: check secret conn id matches dialed id * Fix all p2p tests & make code compile * add simple test for dialing with wrong ID * update changelog * address review comments * yet another place where to use IDAddressString and fix testSetupMultiplexTransport 18 February 2019, 10:08:22 UTC
8283ca7 Anton Kaliaev 18 February 2019, 09:23:40 UTC 3291 follow-up (#3323) * changelog: use issue number instead of PR number * follow up to #3291 - rpc/test/helpers.go add StopTendermint(node) func - remove ensureDir(filepath.Dir(walFile), 0700) - mempool/mempool_test.go add type cleanupFunc func() * cmd/show_validator: wrap err to make it more clear 18 February 2019, 09:23:40 UTC
59cc6d3 Alessio Treglia 18 February 2019, 07:45:27 UTC improve ResetTestRootWithChainID() concurrency safety (#3291) * improve ResetTestRootWithChainID() concurrency safety Rely on ioutil.TempDir() to create test root directories and ensure multiple same-chain id test cases can run in parallel. * Update config/toml.go Co-Authored-By: alessio <quadrispro@ubuntu.com> * clean up test directories after completion Closes: #1034 * Remove redundant EnsureDir call * s/PanicSafety()/panic()/s * Put create dir functionality back in ResetTestRootWithChainID * Place test directories in OS's tempdir In modern UNIX and UNIX-like systems /tmp is very often mounted as tmpfs. This might speed test execution a bit. * Set 0700 to a const * rootsDirs -> configRootDirs * Don't double remove directories * Avoid global variables * Fix consensus tests * Reduce defer stack * Address review comments * Try to fix tests * Update CHANGELOG_PENDING.md Co-Authored-By: alessio <quadrispro@ubuntu.com> * Update consensus/common_test.go Co-Authored-By: alessio <quadrispro@ubuntu.com> * Update consensus/common_test.go Co-Authored-By: alessio <quadrispro@ubuntu.com> 18 February 2019, 07:45:27 UTC
af8793c Zarko Milosevic 18 February 2019, 07:29:41 UTC cs: reset triggered timeout precommit (#3310) * Reset TriggeredTimeoutPrecommit as part of updateToState * Add failing test and fix * fix DATA RACE in TestResetTimeoutPrecommitUponNewHeight ``` WARNING: DATA RACE Read at 0x00c001691d28 by goroutine 691: github.com/tendermint/tendermint/consensus.decideProposal() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:133 +0x121 github.com/tendermint/tendermint/consensus.TestResetTimeoutPrecommitUponNewHeight() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1389 +0x958 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous write at 0x00c001691d28 by goroutine 931: github.com/tendermint/tendermint/consensus.(*ConsensusState).updateToState() /go/src/github.com/tendermint/tendermint/consensus/state.go:562 +0x5b2 github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1340 +0x141e github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1255 +0x66e github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1() /go/src/github.com/tendermint/tendermint/consensus/state.go:1201 +0x135 github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1232 +0x94b github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1657 +0x132e github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1503 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:694 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:655 +0x7dd github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:655 +0x7dd Goroutine 691 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:878 +0x659 testing.runTests.func1() /usr/local/go/src/testing/testing.go:1119 +0xa8 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 testing.runTests() testing.(*M).Run() /usr/local/go/src/testing/testing.go:1034 +0x2ee main.main() _testmain.go:216 +0x332 ``` * fix another DATA RACE by locking consensus ``` WARNING: DATA RACE Read at 0x00c009b835a8 by goroutine 871: github.com/tendermint/tendermint/consensus.(*ConsensusState).createProposalBlock() /go/src/github.com/tendermint/tendermint/consensus/state.go:955 +0x7c github.com/tendermint/tendermint/consensus.decideProposal() /go/src/github.com/tendermint/tendermint/consensus/common_test.go:127 +0x53 github.com/tendermint/tendermint/consensus.TestResetTimeoutPrecommitUponNewHeight() /go/src/github.com/tendermint/tendermint/consensus/state_test.go:1389 +0x958 testing.tRunner() /usr/local/go/src/testing/testing.go:827 +0x162 Previous write at 0x00c009b835a8 by goroutine 931: github.com/tendermint/tendermint/consensus.(*ConsensusState).updateHeight() /go/src/github.com/tendermint/tendermint/consensus/state.go:446 +0xb7 github.com/tendermint/tendermint/consensus.(*ConsensusState).updateToState() /go/src/github.com/tendermint/tendermint/consensus/state.go:542 +0x22f github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1340 +0x141e github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1255 +0x66e github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1() /go/src/github.com/tendermint/tendermint/consensus/state.go:1201 +0x135 github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit() /go/src/github.com/tendermint/tendermint/consensus/state.go:1232 +0x94b github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1657 +0x132e github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote() /go/src/github.com/tendermint/tendermint/consensus/state.go:1503 +0x8f github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg() /go/src/github.com/tendermint/tendermint/consensus/state.go:694 +0xa1e github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:655 +0x7dd github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:642 +0x948 github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine() /go/src/github.com/tendermint/tendermint/consensus/state.go:655 +0x7dd ``` * Fix failing test * Delete profile.out * fix data races 18 February 2019, 07:29:41 UTC
0b0a8b3 Anton Kaliaev 18 February 2019, 07:23:06 UTC cs/wal: refuse to encode msg that is bigger than maxMsgSizeBytes (#3303) Earlier this week somebody posted this in GoS Riot chat: ``` E[2019-02-12|10:38:37.596] Corrupted entry. Skipping... module=consensus wal=/home/gaia/.gaiad/data/cs.wal/wal err="DataCorruptionError[length 878916964 exceeded maximum possible value of 1048576 bytes]" E[2019-02-12|10:38:37.596] Corrupted entry. Skipping... module=consensus wal=/home/gaia/.gaiad/data/cs.wal/wal err="DataCorruptionError[length 825701731 exceeded maximum possible value of 1048576 bytes]" E[2019-02-12|10:38:37.596] Corrupted entry. Skipping... module=consensus wal=/home/gaia/.gaiad/data/cs.wal/wal err="DataCorruptionError[length 1631073634 exceeded maximum possible value of 1048576 bytes]" E[2019-02-12|10:38:37.596] Corrupted entry. Skipping... module=consensus wal=/home/gaia/.gaiad/data/cs.wal/wal err="DataCorruptionError[length 912418148 exceeded maximum possible value of 1048576 bytes]" E[2019-02-12|10:38:37.600] Corrupted entry. Skipping... module=consensus wal=/home/gaia/.gaiad/data/cs.wal/wal err="DataCorruptionError[failed to read data: EOF]" E[2019-02-12|10:38:37.600] Error on catchup replay. Proceeding to start ConsensusState anyway module=consensus err="Cannot replay height 7242. WAL does not contain #ENDHEIGHT for 7241" E[2019-02-12|10:38:37.861] Error dialing peer module=p2p err="dial tcp 35.183.126.181:26656: i/o timeout ``` Note the length error messages. What has happened is the length field got corrupted probably. I've looked at the code and noticed that we don't check the msg size during encoding. This PR fixes that. It also improves a few error messages in WALDecoder. 18 February 2019, 07:23:06 UTC
7ced9e4 Anton Kaliaev 16 February 2019, 05:46:02 UTC rpc/net_info: change RemoteIP type from net.IP to String (#3309) * rpc/net_info: change RemoteIP type from net.IP to String Before: "AAAAAAAAAAAAAP//rB8ktw==" which is amino-encoded net.IP byte slice After: "192.0.2.1" Fixes #3251 * rpc/net_info: non-empty response in docs 16 February 2019, 05:46:02 UTC
af3ba51 Ismail Khoffi 16 February 2019, 05:12:00 UTC fix test-vectors to actually match the sign bytes: (#3312) - sign bytes are length prefixed - change test to use SignBytes methods instead of calling amino methods directly Resolves #3311 ref: #2455 #2508 16 February 2019, 05:12:00 UTC
cf737ec Alexander Bezobchuk 16 February 2019, 05:07:18 UTC return an error on `show_validator` (#3316) * return a command error prior to init * add a pending log entry * Update CHANGELOG_PENDING.md Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com> closes: #3314 16 February 2019, 05:07:18 UTC
d32f7d2 Zach 13 February 2019, 04:26:01 UTC update codeowners (#3305) limit the scope of @zramsay because he's annoyed by notifications 13 February 2019, 04:26:01 UTC
dc6567c Ethan Buchman 12 February 2019, 05:32:40 UTC consensus: flush wal on stop (#3297) Should fix #3295 Also partial fix of #3043 12 February 2019, 05:32:40 UTC
08dabab Ethan Buchman 12 February 2019, 05:04:23 UTC types: validator set update tests (#3284) * types: validator set update tests * docs: abci val updates must not include duplicates 12 February 2019, 05:04:23 UTC
8a9eecc Anca Zamfir 12 February 2019, 05:02:44 UTC test blockExec does not panic if all vals removed (#3241) Fix for #3224 Also address #2084 12 February 2019, 05:02:44 UTC
b089587 Ismail Khoffi 12 February 2019, 04:54:12 UTC make gosec linter pass (#3294) * not related to linter: remove obsolete constants: - `Insecure` and `Secure` and type `Security` are not used anywhere * not related to linter: update example - NewInsecure was deleted; change example to NewRemoteDB * address: Binds to all network interfaces (gosec): - bind to localhost instead of 0.0.0.0 - regenerate test key and cert for this purpose (was valid for ::) and otherwise we would see: transport: authentication handshake failed: x509: certificate is valid for ::, not 127.0.0.1\" (used https://github.com/google/keytransparency/blob/master/scripts/gen_server_keys.sh to regenerate certs) * use sha256 in tests instead of md5; time difference is negligible * nolint usage of math/rand in test and add comment on its import - crypto/rand is slower and we do not need sth more secure in tests * enable linter in circle-ci * another nolint math/rand in test * replace another occurrence of md5 * consistent comment about importing math/rand 12 February 2019, 04:54:12 UTC
7fd51e6 Anton Kaliaev 11 February 2019, 12:31:34 UTC make govet linter pass (#3292) * make govet linter pass Refs #3262 * close PipeReader and check for err 11 February 2019, 12:31:34 UTC
966b5bd Anca Zamfir 11 February 2019, 12:21:51 UTC fix failure in TestProposerFrequency (#3293) ``` --- FAIL: TestProposerFrequency (2.50s) panic: empty validator set [recovered] panic: empty validator set goroutine 91 [running]: testing.tRunner.func1(0xc000a98c00) /usr/local/go/src/testing/testing.go:792 +0x6a7 panic(0xeae7e0, 0x11fbb30) /usr/local/go/src/runtime/panic.go:513 +0x1b9 github.com/tendermint/tendermint/types.(*ValidatorSet).RescalePriorities(0xc0000e7380, 0x0) /go/src/github.com/tendermint/tendermint/types/validator_set.go:106 +0x1ac github.com/tendermint/tendermint/state.TestProposerFrequency(0xc000a98c00) /go/src/github.com/tendermint/tendermint/state/state_test.go:335 +0xb44 testing.tRunner(0xc000a98c00, 0x111a4d8) /usr/local/go/src/testing/testing.go:827 +0x163 created by testing.(*T).Run /usr/local/go/src/testing/testing.go:878 +0x65a FAIL github.com/tendermint/tendermint/state 3.139s ``` 11 February 2019, 12:21:51 UTC
021b5cc Ethan Buchman 09 February 2019, 15:07:49 UTC Merge pull request #3290 from tendermint/master Merge pull request #3288 from tendermint/release/v0.30.0 09 February 2019, 15:07:49 UTC
28d75ec Ethan Buchman 09 February 2019, 15:07:22 UTC Merge pull request #3288 from tendermint/release/v0.30.0 Release/v0.30.0 09 February 2019, 15:07:22 UTC
792b125 Ethan Buchman 08 February 2019, 23:50:02 UTC Prepare v0.30.0 (#3287) * changelog, upgrading, version * update for evidence fixes * linkify * fix an entry 08 February 2019, 23:50:02 UTC
4f2ef36 Ethan Buchman 08 February 2019, 23:40:41 UTC types.NewCommit (#3275) * types.NewCommit * use types.NewCommit everywhere * fix log in unsafe_reset * memoize height and round in constructor * notes about deprecating toVote * bring back memoizeHeightRound 08 February 2019, 23:40:41 UTC
6b1b595 Ethan Buchman 08 February 2019, 23:33:45 UTC Merge pull request #3286 from tendermint/bucky/fix-duplicate-evidence Fixes for duplicate evidence 08 February 2019, 23:33:45 UTC
87bdc42 Ismail Khoffi 08 February 2019, 23:30:45 UTC Reject blocks with committed evidence (#37) * evidence: NewEvidencePool takes evidenceDB * evidence: failing TestStoreCommitDuplicate tendermint/security#35 * GetEvidence -> GetEvidenceInfo * fix TestStoreCommitDuplicate * comment in VerifyEvidence * add check if evidence was already seen - modify EventPool interface (EventStore is not known in ApplyBlock): - add IsCommitted method to iface - add test * update changelog * fix TestStoreMark: - priority in evidence info gets reset to zero after evidence gets committed * review comments: simplify EvidencePool.IsCommitted - delete obsolete EvidenceStore.IsCommitted * add simple test for IsCommitted * update changelog: this is actually breaking (PR number still missing) * fix TestStoreMark: - priority in evidence info gets reset to zero after evidence gets committed * review suggestion: simplify return 08 February 2019, 23:30:45 UTC
90ba639 Ethan Buchman 08 February 2019, 23:25:48 UTC Sec/bucky/35 commit duplicate evidence (#36) Don't add committed evidence to evpool 08 February 2019, 23:25:48 UTC
cce4d21 Anca Zamfir 08 February 2019, 18:05:09 UTC treat validator updates as set (#3222) * Initial commit for 3181..still early * unit test updates * unit test updates * fix check of dups accross updates and deletes * simplify the processChange() func * added overflow check utest * Added checks for empty valset, new utest * deepcopy changes in processUpdate() * moved to new API, fixed tests * test cleanup * address review comments * make sure votePower > 0 * gofmt fixes * handle duplicates and invalid values * more work on tests, review comments * Renamed and explained K * make TestVal private * split verifyUpdatesAndComputeNewPriorities.., added check for deletes * return error if validator set is empty after processing changes * address review comments * lint err * Fixed the total voting power and added comments * fix lint * fix lint 08 February 2019, 18:05:09 UTC
c1f7399 Ismail Khoffi 08 February 2019, 14:48:09 UTC review comment: cleaner constant for N/2, delete secp256k1N and use (#3279) `secp256k1.S256().N` directly instead 08 February 2019, 14:48:09 UTC
44a89a3 Ethan Buchman 08 February 2019, 14:43:36 UTC Merge pull request #3282 from tendermint/master Merge master back to develop 08 February 2019, 14:43:36 UTC
a8dbc64 Ethan Buchman 08 February 2019, 14:42:52 UTC Merge pull request #3276 from tendermint/release/v0.29.2 Release/v0.29.2 08 February 2019, 14:42:52 UTC
af6e6cd Ethan Buchman 08 February 2019, 01:12:57 UTC remove MixEntropy (#3278) * remove MixEntropy * changelog 08 February 2019, 01:12:57 UTC
ad4bd92 Ethan Buchman 08 February 2019, 00:57:30 UTC secp256k1: change build tags (#3277) 08 February 2019, 00:57:30 UTC
f571ee8 Ethan Buchman 08 February 2019, 00:34:01 UTC prepare v0.29.2 (#3272) * update changelog * linkify * bump version * update main changelog * final fixes * entry for wal fix * changelog preamble * remove a line 08 February 2019, 00:34:01 UTC
11e36d0 Anton Kaliaev 07 February 2019, 13:16:31 UTC addrbook_test: preallocate memory for bookSizes (#3268) Fixes https://circleci.com/gh/tendermint/tendermint/44901 07 February 2019, 13:16:31 UTC
354a08c Ethan Buchman 07 February 2019, 11:58:23 UTC p2p: fix infinite loop in addrbook (#3232) * failing test * fix infinite loop in addrbook There are cases where we only have a small number of addresses marked good ("old"), but the selection mechanism keeps trying to select more of these addresses, and hence ends up in an infinite loop. Here we fix this to only try and select such "old" addresses if we have enough of them. Note this means, if we don't have enough of them, we may return more "new" addresses than otherwise expected by the newSelectionBias. This whole GetSelectionWithBias method probably needs to be rewritten, but this is a quick fix for the issue. * changelog * fix infinite loop if not enough new addrs * fix another potential infinite loop if a.nNew == 0 -> pickFromOldBucket=true, but we don't have enough items (a.nOld > len(oldBucketToAddrsMap) false) * Revert "fix another potential infinite loop" This reverts commit 146540c1125597162bd89820d611f6531f5e5e4b. * check num addresses instead of buckets, new test * fixed the int division * add slack to bias % in test, lint fixes * Added checks for selection content in test * test cleanup * Apply suggestions from code review Co-Authored-By: ebuchman <ethan@coinculture.info> * address review comments * change after Anton's review comments * use the same docker image we use for testing when building a binary for localnet * switch back to circleci classic * more review comments * more review comments * refactor addrbook_test * build linux binary inside docker in attempt to fix ``` --> Running dep + make build-linux GOOS=linux GOARCH=amd64 make build make[1]: Entering directory `/home/circleci/.go_workspace/src/github.com/tendermint/tendermint' CGO_ENABLED=0 go build -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`git rev-parse --short=8 HEAD`" -tags 'tendermint' -o build/tendermint ./cmd/tendermint/ p2p/pex/addrbook.go:373:13: undefined: math.Round ``` * change dir from /usr to /go * use concrete Go version for localnet binary * check for nil addresses just to be sure 07 February 2019, 11:58:23 UTC
e70f27c Thane Thomson 07 February 2019, 06:32:32 UTC Add remote signer test harness (KMS) (#3149) * WIP: Starts adding remote signer test harness This commit adds a new command to Tendermint to allow for us to build a standalone binary to test remote signers such as KMS (https://github.com/tendermint/kms). Right now, all it does is test that the local public key matches the public key reported by the client, and fails at the point where it attempts to get the client to sign a proposal. * Fixes typo * Fixes proposal validation test This commit fixes the proposal validation test as per #3149. It also moves the test harness into its own internal package to isolate its exports from the `privval` package. * Adds vote signing validation * Applying recommendations from #3149 * Adds function descriptions for test harness * Adds ability to ask remote signer to shut down Prior to this commit, the remote signer needs to manually be shut down, which is not ideal for automated testing. This commit allows us to send a poison pill message to the KMS to let it shut down gracefully once testing is done (whether the tests pass or fail). * Adds tests for remote signer test harness This commit makes some minor modifications to a few files to allow for testing of the remote signer test harness. Two tests are added here: checking for a fully successful (the ideal) case, and for the case where the maximum number of retries has been reached when attempting to accept incoming connections from the remote signer. * Condenses serialization of proposals and votes using existing Tendermint functions * Removes now-unnecessary amino import and codec * Adds error message for vote signing failure * Adds key extraction command for integration test Took the code from here: https://gist.github.com/Liamsi/a80993f24bff574bbfdbbfa9efa84bc7 to create a simple utility command to extract a key from a local Tendermint validator for use in KMS integration testing. * Makes path expansion success non-compulsory * Fixes segfault on SIGTERM We need an additional variable to keep track of whether we're successfully connected, otherwise hitting Ctrl+Break during execution causes a segmentation fault. This now allows for a clean shutdown. * Consolidates shutdown checks * Adds comments indicating codes for easy lookup * Adds Docker build for remote signer harness Updates the `DOCKER/build.sh` and `DOCKER/push.sh` files to allow one to override the image name and Dockerfile using environment variables. Updates the primary `Makefile` as well as the `DOCKER/Makefile` to allow for building the `remote_val_harness` Docker image. * Adds build_remote_val_harness_docker_image to .PHONY * Removes remote signer poison pill messaging functionality * Reduces fluff code in command line parsing As per https://github.com/tendermint/tendermint/pull/3149#pullrequestreview-196171788, this reduces the amount of fluff code in the PR down to the bare minimum. * Fixes ordering of error check and info log * Moves remove_val_harness cmd into tools folder It seems to make sense to rather keep the remote signer test harness in its own tool folder (now rather named `tm-signer-harness` to keep with the tool naming convention). It is actually a separate tool, not meant to be one of the core binaries, but supplementary and supportive. * Updates documentation for tm-signer-harness * Refactors flag parsing to be more compact and less redundant * Adds version sub-command help * Removes extraneous flags parsing * Adds CHANGELOG_PENDING entry for tm-signer-harness * Improves test coverage Adds a few extra parameters to the `MockPV` type to fake broken vote and proposal signing. Also adds some more tests for the test harness so as to increase coverage for failed cases. * Fixes formatting for CHANGELOG_PENDING.md * Fix formatting for documentation config * Point users towards official Tendermint docs for tools documentation * Point users towards official Tendermint docs for tm-signer-harness * Remove extraneous constant * Rename TestHarness.sc to TestHarness.spv for naming consistency * Refactor to remove redundant goroutine * Refactor conditional to cleaner switch statement and better error handling for listener protocol * Remove extraneous goroutine * Add note about installing tmkms via Cargo * Fix typo in naming of output signing key * Add note about where to find chain ID * Replace /home/user with ~/ for brevity * Fixes "signer.key" typo * Minor edits for clarification for tm-signer-harness bulid/setup process 07 February 2019, 06:32:32 UTC
fcebdf6 Anton Kaliaev 07 February 2019, 06:28:22 UTC Merge pull request #3261 from tendermint/anton/circle Revert "quick fix for CircleCI (#2279)" 07 February 2019, 06:28:22 UTC
9e90264 Ethan Buchman 06 February 2019, 15:29:51 UTC p2p/conn: don't hold stopMtx while waiting (#3254) * p2p/conn: fix deadlock in FlushStop/OnStop * makefile: set_with_deadlock * close doneSendRoutine at end of sendRoutine * conn: initialize channs in OnStart 06 February 2019, 15:29:51 UTC
45b70ae Ethan Buchman 06 February 2019, 15:24:43 UTC fix non deterministic test failures and race in privval socket (#3258) * node: decrease retry conn timeout in test Should fix #3256 The retry timeout was set to the default, which is the same as the accept timeout, so it's no wonder this would fail. Here we decrease the retry timeout so we can try many times before the accept timeout. * p2p: increase handshake timeout in test This fails sometimes, presumably because the handshake timeout is so low (only 50ms). So increase it to 1s. Should fix #3187 * privval: fix race with ping. closes #3237 Pings happen in a go-routine and can happen concurrently with other messages. Since we use a request/response protocol, we expect to send a request and get back the corresponding response. But with pings happening concurrently, this assumption could be violated. We were using a mutex, but only a RWMutex, where the RLock was being held for sending messages - this was to allow the underlying connection to be replaced if it fails. Turns out we actually need to use a full lock (not just a read lock) to prevent multiple requests from happening concurrently. * node: fix test name. DelayedStop -> DelayedStart * autofile: Wait() method In the TestWALTruncate in consensus/wal_test.go we remove the WAL directory at the end of the test. However the wal.Stop() does not properly wait for the autofile group to finish shutting down. Hence it was possible that the group's go-routine is still running when the cleanup happens, which causes a panic since the directory disappeared. Here we add a Wait() method to properly wait until the go-routine exits so we can safely clean up. This fixes #2852. 06 February 2019, 15:24:43 UTC
4429826 Ethan Buchman 06 February 2019, 15:14:03 UTC cmn: GetFreePort (#3255) 06 February 2019, 15:14:03 UTC
1386707 Anton Kaliaev 06 February 2019, 14:36:54 UTC rename TestGCRandom to _TestGCRandom 06 February 2019, 14:36:54 UTC
1a35895 Anton Kaliaev 06 February 2019, 14:23:25 UTC remove gotype linter WARN [runner/nolint] Found unknown linters in //nolint directives: gotype 06 February 2019, 14:26:56 UTC
6941d1b Anton Kaliaev 06 February 2019, 14:20:10 UTC use nolint label instead of commenting 06 February 2019, 14:21:32 UTC
23314da Anton Kaliaev 06 February 2019, 11:38:02 UTC comment out clist tests w/ depend on runtime.SetFinalizer 06 February 2019, 11:38:02 UTC
3c8156a Anton Kaliaev 06 February 2019, 11:24:54 UTC preallocating memory when we can 06 February 2019, 11:24:54 UTC
ffd3bf8 Anton Kaliaev 06 February 2019, 11:16:38 UTC remove or comment out unused code 06 February 2019, 11:16:38 UTC
da33dd0 Anton Kaliaev 06 February 2019, 11:00:55 UTC switch to golangci-lint from gometalinter :speedboat: 06 February 2019, 11:00:55 UTC
d8f0bc3 Anton Kaliaev 06 February 2019, 10:11:35 UTC Revert "quick fix for CircleCI (#2279)" This reverts commit 1cf6712a36e8ecc843a68aa373748e89e0afecba. 06 February 2019, 10:11:35 UTC
1809efa Ethan Buchman 04 February 2019, 18:01:59 UTC Introduce CommitSig alias for Vote in Commit (#3245) * types: memoize height/round in commit instead of first vote * types: commit.ValidateBasic in VerifyCommit * types: new CommitSig alias for Vote In preparation for reducing the redundancy in Commits, we introduce the CommitSig as an alias for Vote. This is non-breaking on the protocol, and minor breaking on the Go API, as Commit now contains a list of CommitSig instead of Vote. * remove dependence on ToVote * update some comments * fix tests * fix tests * fixes from review 04 February 2019, 18:01:59 UTC
39eba4e Ethan Buchman 04 February 2019, 18:00:06 UTC WAL: better errors and new fail point (#3246) * privval: more info in errors * wal: change Debug logs to Info * wal: log and return error on corrupted wal instead of panicing * fail: Exit right away instead of sending interupt * consensus: FAIL before handling our own vote allows to replicate #3089: - run using `FAIL_TEST_INDEX=0` - delete some bytes from the end of the WAL - start normally Results in logs like: ``` I[2019-02-03|18:12:58.225] Searching for height module=consensus wal=/Users/ethanbuchman/.tendermint/data/cs.wal/wal height=1 min=0 max=0 E[2019-02-03|18:12:58.225] Error on catchup replay. Proceeding to start ConsensusState anyway module=consensus err="failed to read data: EOF" I[2019-02-03|18:12:58.225] Started node module=main nodeInfo="{ProtocolVersion:{P2P:6 Block:9 App:1} ID_:35e87e93f2e31f305b65a5517fd2102331b56002 ListenAddr:tcp://0.0.0.0:26656 Network:test-chain-J8JvJH Version:0.29.1 Channels:4020212223303800 Moniker:Ethans-MacBook-Pro.local Other:{TxIndex:on RPCAddress:tcp://0.0.0.0:26657}}" E[2019-02-03|18:12:58.226] Couldn't connect to any seeds module=p2p I[2019-02-03|18:12:59.229] Timed out module=consensus dur=998.568ms height=1 round=0 step=RoundStepNewHeight I[2019-02-03|18:12:59.230] enterNewRound(1/0). Current: 1/0/RoundStepNewHeight module=consensus height=1 round=0 I[2019-02-03|18:12:59.230] enterPropose(1/0). Current: 1/0/RoundStepNewRound module=consensus height=1 round=0 I[2019-02-03|18:12:59.230] enterPropose: Our turn to propose module=consensus height=1 round=0 proposer=AD278B7767B05D7FBEB76207024C650988FA77D5 privValidator="PrivValidator{AD278B7767B05D7FBEB76207024C650988FA77D5 LH:1, LR:0, LS:2}" E[2019-02-03|18:12:59.230] enterPropose: Error signing proposal module=consensus height=1 round=0 err="Error signing proposal: Step regression at height 1 round 0. Got 1, last step 2" I[2019-02-03|18:13:02.233] Timed out module=consensus dur=3s height=1 round=0 step=RoundStepPropose I[2019-02-03|18:13:02.233] enterPrevote(1/0). Current: 1/0/RoundStepPropose module=consensus I[2019-02-03|18:13:02.233] enterPrevote: ProposalBlock is nil module=consensus height=1 round=0 E[2019-02-03|18:13:02.234] Error signing vote module=consensus height=1 round=0 vote="Vote{0:AD278B7767B0 1/00/1(Prevote) 000000000000 000000000000 @ 2019-02-04T02:13:02.233897Z}" err="Error signing vote: Conflicting data" ``` Notice the EOF, the step regression, and the conflicting data. * wal: change errors to be DataCorruptionError * exit on corrupt WAL * fix log * fix new line 04 February 2019, 18:00:06 UTC
eb4e23b Ethan Buchman 04 February 2019, 15:30:24 UTC fix FlushStop (#3247) * p2p/pex: failing test * p2p/conn: add stopMtx for FlushStop and OnStop * changelog 04 February 2019, 15:30:24 UTC
6485e68 Ismail Khoffi 04 February 2019, 08:24:54 UTC Use ethereum's secp256k1 lib (#3234) * switch from fork (tendermint/btcd) to orig package (btcsuite/btcd); also - remove obsolete check in test `size != -1` is always true - WIP as the serialization still needs to be wrapped * WIP: wrap signature & privkey, pubkey needs to be wrapped as well * wrap pubkey too * use "github.com/ethereum/go-ethereum/crypto/secp256k1" if cgo is available, else use "github.com/btcsuite/btcd/btcec" and take care of lower-S when verifying Annoyingly, had to disable pruning when importing github.com/ethereum/go-ethereum/ :-/ * update comment * update comment * emulate signature_nocgo.go for additional benchmarks: https://github.com/ethereum/go-ethereum/blob/592bf6a59cac9697f0491b24e5093cb759d7e44c/crypto/signature_nocgo.go#L60-L76 * use our format (r || s) in lower-s form when in the non-cgo case * remove comment about using the C library directly * vendor github.com/btcsuite/btcd too * Add test for the !cgo case * update changelog pending Closes #3162 #3163 Refs #1958, #2091, tendermint/btcd#1 04 February 2019, 08:24:54 UTC
d470945 Anton Kaliaev 30 January 2019, 08:24:26 UTC update gometalinter to 3.0.0 (#3233) in the attempt to fix https://circleci.com/gh/tendermint/tendermint/43165 also code is simplified by running gofmt -s . remove unused vars enable linters we're currently passing remove deprecated linters 30 January 2019, 08:24:26 UTC
8985a1f Anton Kaliaev 29 January 2019, 09:16:43 UTC pubsub: fixes after Ethan's review (#3212) in https://github.com/tendermint/tendermint/pull/3209 29 January 2019, 09:16:43 UTC
6dd817c Ismail Khoffi 29 January 2019, 08:44:59 UTC secret connection: check for low order points (#3040) > Implement a check for the blacklisted low order points, ala the X25519 has_small_order() function in libsodium (#3010 (comment)) resolves first half of #3010 29 January 2019, 08:44:59 UTC
0b3a87a rickyyangz 29 January 2019, 06:12:07 UTC mempool: correct args order in the log msg (#3221) Before: Unexpected tx response from proxy during recheck\n Expected: {r.CheckTx.Data}, got: {memTx.tx} After: Unexpected tx response from proxy during recheck\n Expected: {memTx.tx}, got: {tx} Closes #3214 29 January 2019, 06:12:07 UTC
e1edd2a Zach 28 January 2019, 19:41:37 UTC hardcode rpc link (#3223) 28 January 2019, 19:41:37 UTC
9a0bfaf Thane Thomson 28 January 2019, 13:41:39 UTC docs: fix links (#3220) Because there's nothing worse than having to copy/paste a link from a web page to navigate to it :grin: 28 January 2019, 13:41:39 UTC
a335caa Thane Thomson 28 January 2019, 12:13:17 UTC alias amino imports (#3219) As per conversation here: https://github.com/tendermint/tendermint/pull/3218#discussion_r251364041 This is the result of running the following code on the repo: ```bash find . -name '*.go' | grep -v 'vendor/' | xargs -n 1 goimports -w ``` 28 January 2019, 12:13:17 UTC
ff3c4bf Anton Kaliaev 28 January 2019, 10:57:47 UTC add go-deadlock tool to help detect deadlocks (#3218) * add go-deadlock tool to help detect deadlocks Run it with `make test_with_deadlock`. After it's done, use Git to cleanup `git checkout .` Link: https://github.com/sasha-s/go-deadlock/ Replaces https://github.com/tendermint/tendermint/pull/3148 * add a target to cleanup changes 28 January 2019, 10:57:47 UTC
8d2dd7e Anton Kaliaev 28 January 2019, 08:38:11 UTC refactor TestListenerConnectDeadlines to avoid data races (#3201) Fixes #3179 28 January 2019, 08:38:11 UTC
71e5939 cong 28 January 2019, 07:36:35 UTC start eventBus & indexerService before replay and use them while replaying blocks (#3194) so if we did not index the last block (because of panic or smth else), we index it during replay Closes #3186 28 January 2019, 07:36:35 UTC
d91ea9b Ethan Buchman 25 January 2019, 23:28:06 UTC adr-033 update 26 January 2019, 10:30:29 UTC
9b6b792 Ethan Buchman 25 January 2019, 23:11:31 UTC pubsub: comments 26 January 2019, 10:30:29 UTC
57af99d Ethan Buchman 25 January 2019, 20:01:39 UTC types: comments on user vs internal events Distinguish between user events and internal consensus events 26 January 2019, 10:30:29 UTC
a58d589 Ethan Buchman 25 January 2019, 20:01:22 UTC note about TmCoreSemVer 26 January 2019, 10:30:29 UTC
ddbdffb Jae Kwon 25 January 2019, 19:00:55 UTC add design philosophy doc (#3034) 25 January 2019, 19:00:55 UTC
d6dd43c Ismail Khoffi 25 January 2019, 13:38:26 UTC adr: style fixes (#3206) - links to issues - fix a few markdown glitches - inline code - etc 25 January 2019, 13:38:26 UTC
75cbe4a Joon 25 January 2019, 13:10:36 UTC R4R: Config TestRoot modification for LCD test (#3177) * add ResetTestRootWithChainID * modify chainid 25 January 2019, 13:10:36 UTC
27c1563 Ethan Buchman 24 January 2019, 16:35:01 UTC Merge pull request #3205 from tendermint/master Merge master back to develop 24 January 2019, 16:35:01 UTC
4d7b29c Ethan Buchman 24 January 2019, 16:34:20 UTC Merge pull request #3203 from tendermint/release/v0.29.1 Release/v0.29.1 24 January 2019, 16:34:20 UTC
90970d0 Ethan Buchman 24 January 2019, 16:19:52 UTC fix changelog 24 January 2019, 16:19:52 UTC
bb0a9b3 Anton Kaliaev 24 January 2019, 15:18:32 UTC bump version 24 January 2019, 15:18:32 UTC
8992596 Anton Kaliaev 24 January 2019, 15:17:53 UTC update changelog 24 January 2019, 15:17:53 UTC
c20fbed Zarko Milosevic 24 January 2019, 14:33:47 UTC [WIP] fix halting issue (#3197) fix halting issue 24 January 2019, 14:33:47 UTC
c415754 Anton Kaliaev 24 January 2019, 09:53:02 UTC only log "Reached max attempts to dial" once (#3144) Closes #3037 24 January 2019, 09:53:02 UTC
fbd1e79 Infinytum 24 January 2019, 08:10:34 UTC docs: fix lite client formatting (#3198) Closes #3180 24 January 2019, 08:10:34 UTC
1efacaa Anton Kaliaev 24 January 2019, 07:33:58 UTC docs: update pubsub ADR (#3131) * docs: update pubsub ADR * third version 24 January 2019, 07:33:58 UTC
98b42e9 Gautham Santhosh 24 January 2019, 06:45:43 UTC docs: explain how someone can run his/her own ABCI app on localnet (#3195) Closes #3192. 24 January 2019, 06:45:43 UTC
2449bf7 Anton Kaliaev 22 January 2019, 18:23:18 UTC p2p: file descriptor leaks (#3150) * close peer's connection to avoid fd leak Fixes #2967 * rename peer#Addr to RemoteAddr * fix test * fixes after Ethan's review * bring back the check * changelog entry * write a test for switch#acceptRoutine * increase timeouts? :( * remove extra assertNPeersWithTimeout * simplify test * assert number of peers (just to be safe) * Cleanup in OnStop * run tests with verbose flag on CircleCI * spawn a reading routine to prevent connection from closing * get port from the listener random port is faster, but often results in ``` panic: listen tcp 127.0.0.1:44068: bind: address already in use [recovered] panic: listen tcp 127.0.0.1:44068: bind: address already in use goroutine 79 [running]: testing.tRunner.func1(0xc0001bd600) /usr/local/go/src/testing/testing.go:792 +0x387 panic(0x974d20, 0xc0001b0500) /usr/local/go/src/runtime/panic.go:513 +0x1b9 github.com/tendermint/tendermint/p2p.MakeSwitch(0xc0000f42a0, 0x0, 0x9fb9cc, 0x9, 0x9fc346, 0xb, 0xb42128, 0x0, 0x0, 0x0, ...) /home/vagrant/go/src/github.com/tendermint/tendermint/p2p/test_util.go:182 +0xa28 github.com/tendermint/tendermint/p2p.MakeConnectedSwitches(0xc0000f42a0, 0x2, 0xb42128, 0xb41eb8, 0x4f1205, 0xc0001bed80, 0x4f16ed) /home/vagrant/go/src/github.com/tendermint/tendermint/p2p/test_util.go:75 +0xf9 github.com/tendermint/tendermint/p2p.MakeSwitchPair(0xbb8d20, 0xc0001bd600, 0xb42128, 0x2f7, 0x4f16c0) /home/vagrant/go/src/github.com/tendermint/tendermint/p2p/switch_test.go:94 +0x4c github.com/tendermint/tendermint/p2p.TestSwitches(0xc0001bd600) /home/vagrant/go/src/github.com/tendermint/tendermint/p2p/switch_test.go:117 +0x58 testing.tRunner(0xc0001bd600, 0xb42038) /usr/local/go/src/testing/testing.go:827 +0xbf created by testing.(*T).Run /usr/local/go/src/testing/testing.go:878 +0x353 exit status 2 FAIL github.com/tendermint/tendermint/p2p 0.350s ``` 22 January 2019, 18:23:18 UTC
3362da0 Ethan Buchman 22 January 2019, 18:19:58 UTC Merge pull request #3191 from tendermint/master Merge master to develop 22 January 2019, 18:19:58 UTC
4514842 Ethan Buchman 22 January 2019, 18:19:28 UTC Merge pull request #3185 from tendermint/release/v0.29.0 Release/v0.29.0 22 January 2019, 18:19:28 UTC
a97d699 Ethan Buchman 22 January 2019, 17:24:26 UTC fix changelog indent (#3190) 22 January 2019, 17:24:26 UTC
d9d4f3e Ethan Buchman 22 January 2019, 00:32:10 UTC Prepare v0.29.0 (#3184) * update changelog and upgrading * add note about max voting power in abci spec * update version * changelog 22 January 2019, 00:32:10 UTC
7a8aeff Ethan Buchman 21 January 2019, 15:02:57 UTC update spec for Merkle RFC 6962 (#3175) * spec: specify when MerkleRoot is on hashes * remove unnecessary hash methods * update changelog * fix test 21 January 2019, 15:02:57 UTC
de5a601 Ethan Buchman 21 January 2019, 14:21:04 UTC fix DynamicVerifier for large validator set changes (#3171) * base verifier: bc->bv and check chainid * improve some comments * comments in dynamic verifier * fix comment in doc about BaseVerifier It requires the validator set to perfectly match. * failing test for #2862 * move errTooMuchChange to types. fixes #2862 * changelog, comments * ic -> dv * update comment, link to issue 21 January 2019, 14:21:04 UTC
da95f4a Ethan Buchman 20 January 2019, 22:27:49 UTC mempool: enforce maxMsgSize limit in CheckTx (#3168) - fixes #3008 - reactor requires encoded messages are less than maxMsgSize - requires size of tx + amino-overhead to not exceed maxMsgSize 20 January 2019, 22:27:49 UTC
4f87691 Ethan Buchman 19 January 2019, 21:08:57 UTC [types] hash of ConsensusParams includes only a subset of fields (#3165) * types: dont hash entire ConsensusParams * update encoding spec * update blockchain spec * spec: consensus params hash * changelog 19 January 2019, 21:08:57 UTC
back to top