1e26c84 | Brad King | 01 July 2020, 11:14:26 UTC | CMake 3.18.0-rc3 | 01 July 2020, 11:14:26 UTC |
0ca6bb8 | Brad King | 01 July 2020, 11:00:34 UTC | Merge topic 'file-ARCHIVE-files-dirs' into release-3.18 bbcff21f71 file(ARCHIVE*): Collapse FILES and DIRECTORY options Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4955 | 01 July 2020, 11:00:42 UTC |
208b8a8 | Brad King | 30 June 2020, 18:40:53 UTC | Merge topic 'fileapi-version-doc' into release-3.18 e9be17ab42 Help: Update FileAPI codemodel version to 2.1, add release notes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4956 | 30 June 2020, 18:41:00 UTC |
e9be17a | Kyle Edwards | 30 June 2020, 17:18:09 UTC | Help: Update FileAPI codemodel version to 2.1, add release notes This fixes the documentation which should have been fixed in 9f6d40ee. | 30 June 2020, 18:04:13 UTC |
221fd89 | Brad King | 30 June 2020, 12:04:00 UTC | Merge topic 'file-CONFIGURE-subdir' into release-3.18 e5f5eeca2f file: Fix CONFIGURE output relative path Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4951 | 30 June 2020, 12:04:07 UTC |
bbcff21 | Craig Scott | 30 June 2020, 11:43:37 UTC | file(ARCHIVE*): Collapse FILES and DIRECTORY options The two options were concatenated internally for both ARCHIVE_CREATE and ARCHIVE_EXTRACT. The distinction between files and dirs was not meaningful. Therefore, replace them with PATHS or PATTERNS to more accurately describe the way the options are used. Fixes: #20884 | 30 June 2020, 12:01:35 UTC |
e9f667c | Brad King | 30 June 2020, 11:25:46 UTC | Merge topic 'find_library-file-readable' into release-3.18 f2c903fb9a find_library: Check that library files are readable Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4945 | 30 June 2020, 11:25:53 UTC |
e5f5eec | Brad King | 29 June 2020, 13:18:06 UTC | file: Fix CONFIGURE output relative path In commit a6fee09484 (file: Add CONFIGURE subcommand, 2020-03-06, v3.18.0-rc1~584^2) we accidentally treated relative path outputs with respect to the current working directory. Treat them with respect to the current binary directory instead. Fixes: #20885 | 29 June 2020, 13:20:42 UTC |
e23428c | Brad King | 29 June 2020, 12:23:14 UTC | Merge topic 'file-ARCHIVE_CREATE-rename-TYPE-option' into release-3.18 95159b7dea file(ARCHIVE_CREATE): Rename TYPE option to COMPRESSION bc45bdc819 Help: Fix contents indenting for file(ARCHIVE_...) subcommands Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4948 | 29 June 2020, 12:23:20 UTC |
4c28bf2 | Brad King | 29 June 2020, 12:21:01 UTC | Merge topic 'gtest-xml-output' into release-3.18 75aa3ee7e7 GoogleTest: Fix name generation for XML_OUTPUT_DIR Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4942 | 29 June 2020, 12:21:07 UTC |
df8ba4f | Brad King | 29 June 2020, 12:16:11 UTC | Merge topic 'intel-c++20' into release-3.18 99c8dbf497 Intel: Add flags for C++20 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4946 | 29 June 2020, 12:16:16 UTC |
f2c903f | Brad King | 26 June 2020, 10:33:16 UTC | find_library: Check that library files are readable Refactoring in commit 6b85166920 (ENH: Refactor find_library search logic, 2008-09-22, v2.8.0~1665) dropped a call to `FileExists` on the path under the assumption that the presence of a file in a directory listing means it exists. However, dropping that also dropped a check that verifies the file is readable. Restore the `FileExists` call to ensure that we only find readable libraries. | 29 June 2020, 11:50:47 UTC |
95159b7 | Craig Scott | 27 June 2020, 08:36:16 UTC | file(ARCHIVE_CREATE): Rename TYPE option to COMPRESSION Fixes: #20883 | 27 June 2020, 08:38:28 UTC |
bc45bdc | Craig Scott | 27 June 2020, 06:33:29 UTC | Help: Fix contents indenting for file(ARCHIVE_...) subcommands | 27 June 2020, 06:33:29 UTC |
75aa3ee | Stefan Floeren | 25 June 2020, 14:57:43 UTC | GoogleTest: Fix name generation for XML_OUTPUT_DIR The Google test framework allows to write the results into an XML file since commit e9ab39eb1d (GoogleTest: Add XML_OUTPUT_DIR parameter, 2020-03-06, v3.18.0-rc1~538^2~2). This file is passed on the command line: `--gtest_output=xml:FILE_NAME`. The module allows to specify a directory to save those files with **TEST_XML_OUTPUT_PARAM**. If the option is set, the filename will be set to `${prefix}${pretty_suite}.${pretty_test}${suffix}.xml`. The pretty names contain parameters for the tests, if value-parameterized tests are used. These parameters may not be safe to use in file names. There are two possible options: 1. sanitize the file name 2. omit the values and use the internal numbering of gtest This commit chose option 2. The testname needs to be a valid C++ identifier and should therefore be reasonable for a filename. Note that the generated names contain slashes. This will lead to subdirectories, but works on both Linux and Windows. Fixes: #20877 | 26 June 2020, 13:39:51 UTC |
4f55038 | Brad King | 26 June 2020, 13:31:14 UTC | Merge topic 'GoogleTest-DISCOVERY_MODE-cleanups' into release-3.18 1458b4c048 Help: Add CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE to release notes 642ea49115 GoogleTest: Replace SEND_ERROR with FATAL_ERROR 09c38e8de6 Tests: Don't ask for things not required for GoogleTest Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4938 | 26 June 2020, 13:31:19 UTC |
42d9b3d | Brad King | 26 June 2020, 13:30:18 UTC | Merge topic 'update-curl' into release-3.18 e5ff413f41 curl: Set build options the way we need for CMake 0ef8fa5000 Merge branch 'upstream-curl' into update-curl 5717fdc114 curl 2020-06-23 (e9db32a0) 39f7cfad31 curl: Update script to get curl 7.71.0 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4937 | 26 June 2020, 13:30:25 UTC |
99c8dbf | Brad King | 26 June 2020, 12:21:21 UTC | Intel: Add flags for C++20 Patch-by: Matheus Izvekov Fixes: #20880 | 26 June 2020, 12:21:21 UTC |
1458b4c | Craig Scott | 24 June 2020, 13:19:06 UTC | Help: Add CMAKE_GTEST_DISCOVER_TESTS_DISCOVERY_MODE to release notes | 24 June 2020, 13:19:06 UTC |
e5ff413 | Brad King | 24 June 2020, 12:23:52 UTC | curl: Set build options the way we need for CMake | 24 June 2020, 12:23:52 UTC |
0ef8fa5 | Brad King | 24 June 2020, 12:13:02 UTC | Merge branch 'upstream-curl' into update-curl * upstream-curl: curl 2020-06-23 (e9db32a0) | 24 June 2020, 12:13:02 UTC |
642ea49 | Craig Scott | 24 June 2020, 11:57:19 UTC | GoogleTest: Replace SEND_ERROR with FATAL_ERROR We want to fail and halt immediately upon any error, not continue past a fatal problem. | 24 June 2020, 11:57:19 UTC |
09c38e8 | Craig Scott | 24 June 2020, 11:56:26 UTC | Tests: Don't ask for things not required for GoogleTest The test cases only need C or C++, but not both. The CTest module is also not needed because we are not running a dashboard script. | 24 June 2020, 11:56:26 UTC |
5717fdc | Curl Upstream | 23 June 2020, 21:41:50 UTC | curl 2020-06-23 (e9db32a0) Code extracted from: https://github.com/curl/curl.git at commit e9db32a09af03f27e86d1251a9e68e9b7486d371 (curl-7_71_0). | 24 June 2020, 11:55:09 UTC |
39f7cfa | Brad King | 24 June 2020, 11:54:53 UTC | curl: Update script to get curl 7.71.0 | 24 June 2020, 11:54:53 UTC |
1f47a65 | Brad King | 23 June 2020, 12:50:49 UTC | Merge topic 'doc-get_target_property' into release-3.18 f4b911a2c9 Help: Update docs for failure result of get_target_property Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4933 | 23 June 2020, 12:50:54 UTC |
f4b911a | Christopher Tetreault | 22 June 2020, 22:48:09 UTC | Help: Update docs for failure result of get_target_property If `get_target_property` fails to find a value for a non-inherited property, it appends `-NOTFOUND` to the var name and sets that as the result, rather than setting the value of the var to `NOTFOUND`. | 23 June 2020, 12:17:59 UTC |
ba0ff76 | Brad King | 23 June 2020, 12:00:25 UTC | Merge topic 'VxWorks-platform-id' into release-3.18 b22586be01 VxWorks: Add Platform ID for Modules/CMakePlatformId.h.in Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4922 | 23 June 2020, 12:00:31 UTC |
b22586b | Lihua Zhao | 19 June 2020, 01:34:06 UTC | VxWorks: Add Platform ID for Modules/CMakePlatformId.h.in | 23 June 2020, 11:59:32 UTC |
22dbe54 | Brad King | 23 June 2020, 11:56:32 UTC | Merge topic 'makefile-fix-verbose' into release-3.18 7f78bc42cb Makefile: Fix regression in .SILENT rule Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4928 | 23 June 2020, 11:57:33 UTC |
069e904 | Brad King | 23 June 2020, 11:55:41 UTC | Merge topic 'fix-win-flex-bison' into release-3.18 0faa2b9870 Find{FLEX,BISON}: Add 'win-' executable names Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4931 | 23 June 2020, 11:56:39 UTC |
df69cb3 | Brad King | 23 June 2020, 11:55:35 UTC | Merge topic 'FindCUDA-11' into release-3.18 1d9f2f9714 FindCUDA: Do not search for the deprecated nppicom when CUDA >= 11 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4929 | 23 June 2020, 11:55:40 UTC |
86cd7d6 | Brad King | 23 June 2020, 11:53:38 UTC | Merge topic 'test-all-find-modules' into release-3.18 6c6b227813 Tests: Drop redundant FindModulesExecuteAll test Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4930 | 23 June 2020, 11:53:44 UTC |
6c6b227 | Brad King | 22 June 2020, 18:11:31 UTC | Tests: Drop redundant FindModulesExecuteAll test This test has been superseded by `CMakeOnly.AllFindModules`, which does much more checking anyway. | 23 June 2020, 11:48:53 UTC |
0faa2b9 | Yan | 22 June 2020, 19:42:10 UTC | Find{FLEX,BISON}: Add 'win-' executable names Distributions of these tools on Windows now use a `win-` prefix instead of the previously-seen `win_` prefix. Search for both. | 22 June 2020, 19:50:22 UTC |
1d9f2f9 | Robert Maynard | 22 June 2020, 15:48:23 UTC | FindCUDA: Do not search for the deprecated nppicom when CUDA >= 11 The nppicom library has been removed in preference of nvjpeg starting in CUDA 11. Fixes: #20845 | 22 June 2020, 15:56:51 UTC |
7f78bc4 | Daniel Colascione | 22 June 2020, 00:40:25 UTC | Makefile: Fix regression in .SILENT rule Since commit d74e651b78 (Makefiles: Re-implement makefile target path escaping and quoting, 2020-04-10, v3.18.0-rc1~334^2~1), `WriteMakeRule` now correctly escapes `$` in make target paths as `$$`. However, this caused an existing call site to escape the `$(VERBOSE)` variable reference in the `.SILENT` prefix, making it ineffective. Sub-makefiles are invoked with `MAKESILENT`, so this bug matters only for the `all` target, which emits progress messages from toplevel. Before: # Suppress display of executed commands. $$(VERBOSE).SILENT: After: # Suppress display of executed commands. $(VERBOSE).SILENT: | 22 June 2020, 12:48:53 UTC |
c0b44e6 | Brad King | 19 June 2020, 12:13:19 UTC | Merge topic 'try_compile-nfs' into release-3.18 a9a258c302 try_compile: Do not try to remove '.nfs*' files Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Robert Maynard <robert.maynard@kitware.com> Acked-by: Axel Huebl <axel.huebl@plasma.ninja> Merge-request: !4913 | 19 June 2020, 12:14:05 UTC |
21d0961 | Brad King | 19 June 2020, 12:13:02 UTC | Merge topic 'CUDAToolkit-cuda-11' into release-3.18 b284a3c764 CudaToolkit: Update for new/removed libraries in CUDA 11 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4917 | 19 June 2020, 12:13:08 UTC |
c7561c0 | Brad King | 19 June 2020, 12:11:59 UTC | Merge topic 'cuda-toolkit-vs' into release-3.18 a0280801f4 CUDA: Fix CMAKE_CUDA_COMPILER_TOOLKIT_ROOT detection in Visual Studio 90be0916b5 CUDA: Re-order some logic for determining the compiler 4ab5f109f0 CUDA: Remove unused variables while determining compiler 492e5f01fa CUDA: Simplify CMAKE_CUDA_COMPILER_TOOLKIT_ROOT computation 4785bd6153 CUDA: Skip the entire search for nvcc when it is CMAKE_CUDA_COMPILER Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4921 | 19 June 2020, 12:12:04 UTC |
33e1dc4 | Brad King | 19 June 2020, 12:10:25 UTC | Merge topic 'cuda_nvcc_exe_search' into release-3.18 d9c1f05924 CUDA: Fix NVCC executable search during compiler detection Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4920 | 19 June 2020, 12:10:33 UTC |
a028080 | Brad King | 18 June 2020, 19:55:18 UTC | CUDA: Fix CMAKE_CUDA_COMPILER_TOOLKIT_ROOT detection in Visual Studio When using a Visual Studio generator, we do not know the path to `CMAKE_CUDA_COMPILER` until after the compiler id detection project extracts it. However, based on the VS toolchain configuration we know that the compiler id will be NVIDIA, so use that to drive the CUDA architecture flag logic. After the main compiler id step we know `CMAKE_CUDA_COMPILER`, so `CMAKE_CUDA_COMPILER_TOOLKIT_ROOT` can then be computed. | 18 June 2020, 19:58:38 UTC |
90be091 | Brad King | 18 June 2020, 19:52:42 UTC | CUDA: Re-order some logic for determining the compiler | 18 June 2020, 19:53:45 UTC |
4ab5f10 | Brad King | 18 June 2020, 19:50:10 UTC | CUDA: Remove unused variables while determining compiler | 18 June 2020, 19:50:10 UTC |
492e5f0 | Brad King | 18 June 2020, 19:49:25 UTC | CUDA: Simplify CMAKE_CUDA_COMPILER_TOOLKIT_ROOT computation | 18 June 2020, 19:49:25 UTC |
4785bd6 | Brad King | 18 June 2020, 19:48:40 UTC | CUDA: Skip the entire search for nvcc when it is CMAKE_CUDA_COMPILER | 18 June 2020, 19:48:40 UTC |
d9c1f05 | Raul Tambre | 18 June 2020, 17:03:25 UTC | CUDA: Fix NVCC executable search during compiler detection The result variable was `CUDAToolkit_NVCC_EXECUTABLE` instead of `_CUDA_NVCC_EXECUTABLE`, which the rest of the code used. Also, we can simply `set()` the `_CUDA_NVCC_EXECUTABLE` value without searching. Fixes: #20847 | 18 June 2020, 19:07:31 UTC |
c268537 | Brad King | 18 June 2020, 16:44:15 UTC | Merge topic 'improve_device_link_policy_cross_ref' into release-3.18 e5279c2c8f Help: Better document that CMP0105 controls DEVICE_LINK parsing Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4919 | 18 June 2020, 16:45:27 UTC |
310e953 | Brad King | 18 June 2020, 16:44:08 UTC | Merge topic 'doc-3.18-fixups' into release-3.18 947cfc732d Help: Explicitly say transaction, don't abbreviate to trans 90c73479bc Help: Correct and condense examples for VS_SOLUTION_DEPLOY 0420de10b5 Help: Add missing cross-referencing for generator expressions 013f7a2647 Help: Formatting, crossref for FRAMEWORK_MULTI_CONFIG_POSTFIX_<CONFIG> a12d53acf3 Help: Add missing PCH_WARN_INVALID docs and related cleanups 95a16f7805 Help: Fix formatting error and consistency for gtest_discover_tests() Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4915 | 18 June 2020, 16:44:14 UTC |
e5279c2 | Robert Maynard | 18 June 2020, 16:07:26 UTC | Help: Better document that CMP0105 controls DEVICE_LINK parsing | 18 June 2020, 16:07:26 UTC |
b8d1366 | Brad King | 18 June 2020, 13:36:56 UTC | Merge topic 'armclang-typo' into release-3.18 2ff68c00e0 ARMClang: Fix typo in -Xlinker flag Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4916 | 18 June 2020, 13:37:46 UTC |
8896a12 | Brad King | 18 June 2020, 13:36:41 UTC | Merge topic 'test-split-RunCMake.target_link_libraries' into release-3.18 5f97e44912 Tests: Shorten case names in RunCMake.target_link_libraries-* tests 0951b1fe07 Tests: Split RunCMake.target_link_libraries test Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4908 | 18 June 2020, 13:36:47 UTC |
b284a3c | Robert Maynard | 18 June 2020, 12:48:59 UTC | CudaToolkit: Update for new/removed libraries in CUDA 11 | 18 June 2020, 12:52:58 UTC |
2ff68c0 | Osama Moharam | 18 June 2020, 11:38:20 UTC | ARMClang: Fix typo in -Xlinker flag Fix a typo from commit ef816610be (ARMClang: allow fallback to -march and correct setting of --cpu flags, 2020-06-03, v3.18.0-rc1~18^2). | 18 June 2020, 11:43:22 UTC |
947cfc7 | Craig Scott | 18 June 2020, 10:32:36 UTC | Help: Explicitly say transaction, don't abbreviate to trans The release notes need to make sense to people not so familiar with each item. For those less familiar with RPM, spelling out "transaction" makes this line item much clearer in isolation. | 18 June 2020, 10:43:46 UTC |
90c7347 | Craig Scott | 18 June 2020, 10:30:30 UTC | Help: Correct and condense examples for VS_SOLUTION_DEPLOY | 18 June 2020, 10:43:46 UTC |
0420de1 | Craig Scott | 18 June 2020, 10:29:21 UTC | Help: Add missing cross-referencing for generator expressions | 18 June 2020, 10:43:46 UTC |
013f7a2 | Craig Scott | 18 June 2020, 10:43:23 UTC | Help: Formatting, crossref for FRAMEWORK_MULTI_CONFIG_POSTFIX_<CONFIG> | 18 June 2020, 10:43:46 UTC |
a12d53a | Craig Scott | 18 June 2020, 10:26:03 UTC | Help: Add missing PCH_WARN_INVALID docs and related cleanups | 18 June 2020, 10:26:03 UTC |
95a16f7 | Craig Scott | 18 June 2020, 10:23:57 UTC | Help: Fix formatting error and consistency for gtest_discover_tests() | 18 June 2020, 10:23:57 UTC |
a9a258c | Brad King | 17 June 2020, 19:13:47 UTC | try_compile: Do not try to remove '.nfs*' files These files are part of the NFS implementation and should not be removed. They will automatically disappear when NFS is done with them. Fixes: #20844 | 17 June 2020, 19:15:02 UTC |
843c39b | Brad King | 17 June 2020, 17:44:56 UTC | Merge topic 'doc-relnotes' into release-3.18 4f6ce41446 Help: Fix order of FindCUDAToolkit entry in 3.18 release notes Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4910 | 17 June 2020, 17:45:12 UTC |
4f6ce41 | Brad King | 17 June 2020, 15:28:31 UTC | Help: Fix order of FindCUDAToolkit entry in 3.18 release notes | 17 June 2020, 15:28:31 UTC |
e66fe75 | Brad King | 17 June 2020, 13:58:40 UTC | CMake 3.18.0-rc2 | 17 June 2020, 13:58:40 UTC |
5f97e44 | Brad King | 16 June 2020, 15:02:53 UTC | Tests: Shorten case names in RunCMake.target_link_libraries-* tests Drop the portion of the case names that repeats the name of the containing test. | 17 June 2020, 12:13:57 UTC |
0951b1f | Marc Chevrier | 17 June 2020, 08:51:39 UTC | Tests: Split RunCMake.target_link_libraries test Fixes: #20836 | 17 June 2020, 12:02:33 UTC |
2ae33f7 | Brad King | 17 June 2020, 10:44:18 UTC | Merge topic 'cuda_clang_limitations' into release-3.18 bdb105ee94 Help: Mention CUDA Clang limitations in 3.18 release notes fec7dd33d3 CUDA: Add issue number to Clang separable compilation error 14163d7d6b CUDA: Throw error for Clang on Windows Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4903 | 17 June 2020, 10:44:25 UTC |
56134e3 | Brad King | 17 June 2020, 10:43:16 UTC | Merge topic 'test-file-GET_RUNTIME_DEPENDENCIES' into release-3.18 9ae3382855 Tests: Shorten case names in RunCMake.file-GET_RUNTIME_DEPENDENCIES test 248d0570c9 Tests: Factor out RunCMake.file-GET_RUNTIME_DEPENDENCIES test Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4904 | 17 June 2020, 10:43:22 UTC |
66d323b | Brad King | 17 June 2020, 10:41:50 UTC | Merge topic 'test-CudaOnly.StaticRuntimePlusToolkit' into release-3.18 cb9fab49dd Tests: Fix CudaOnly.StaticRuntimePlusToolkit build rpath Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4901 | 17 June 2020, 10:41:56 UTC |
bdb105e | Raul Tambre | 16 June 2020, 14:18:22 UTC | Help: Mention CUDA Clang limitations in 3.18 release notes | 16 June 2020, 18:07:39 UTC |
fec7dd3 | Raul Tambre | 16 June 2020, 17:54:04 UTC | CUDA: Add issue number to Clang separable compilation error | 16 June 2020, 18:07:30 UTC |
14163d7 | Raul Tambre | 16 June 2020, 14:13:56 UTC | CUDA: Throw error for Clang on Windows Supporting compiling on Windows is more complicated than initially expected, so it won't make it into CMake 3.18. Add a helpful error for users. | 16 June 2020, 18:06:43 UTC |
9ae3382 | Brad King | 16 June 2020, 15:02:53 UTC | Tests: Shorten case names in RunCMake.file-GET_RUNTIME_DEPENDENCIES test Now that these cases are in a dedicated test we can drop the `file-GET_RUNTIME_DEPENDENCIES-` prefix from their name. | 16 June 2020, 15:17:55 UTC |
248d057 | Brad King | 16 June 2020, 14:50:27 UTC | Tests: Factor out RunCMake.file-GET_RUNTIME_DEPENDENCIES test Move the `file(GET_RUNTIME_DEPENDENCIES)` cases out of `RunCMake.install`. | 16 June 2020, 15:17:55 UTC |
3f110a0 | Brad King | 16 June 2020, 13:18:02 UTC | Merge topic 'test-RunCMake.GeneratorExpression' into release-3.18 6308bfb737 Tests: Factor out RunCMake.GenEx-GENEX_EVAL test abe1c27499 Tests: Factor out RunCMake.GenEx-TARGET_FILE test fbead761fe Tests: Factor out RunCMake.GenEx-DEVICE_LINK test 64a8587332 Tests: Factor out RunCMake.GenEx-HOST_LINK test 6f224a065c Tests: Factor out RunCMake.GenEx-LINK_LANG_AND_ID test f3f6317ca3 Tests: Factor out RunCMake.GenEx-LINK_LANGUAGE test 983adb8bed Tests: Factor out RunCMake.GenEx-COMPILE_LANG_AND_ID test 931a6702f6 Tests: Factor out RunCMake.GenEx-COMPILE_LANGUAGE test Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4899 | 16 June 2020, 13:18:09 UTC |
cb9fab4 | Robert Maynard | 15 June 2020, 21:31:48 UTC | Tests: Fix CudaOnly.StaticRuntimePlusToolkit build rpath | 16 June 2020, 12:30:42 UTC |
6308bfb | Brad King | 15 June 2020, 18:45:01 UTC | Tests: Factor out RunCMake.GenEx-GENEX_EVAL test Move the `GENEX_EVAL` cases and friends out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:36 UTC |
abe1c27 | Brad King | 15 June 2020, 18:41:57 UTC | Tests: Factor out RunCMake.GenEx-TARGET_FILE test Move the `TARGET_FILE` cases and friends out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
fbead76 | Brad King | 15 June 2020, 18:34:51 UTC | Tests: Factor out RunCMake.GenEx-DEVICE_LINK test Move the `DEVICE_LINK` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
64a8587 | Brad King | 15 June 2020, 18:33:09 UTC | Tests: Factor out RunCMake.GenEx-HOST_LINK test Move the `HOST_LINK` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
6f224a0 | Brad King | 15 June 2020, 18:30:52 UTC | Tests: Factor out RunCMake.GenEx-LINK_LANG_AND_ID test Move the `LINK_LANG_AND_ID` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
f3f6317 | Brad King | 15 June 2020, 18:27:44 UTC | Tests: Factor out RunCMake.GenEx-LINK_LANGUAGE test Move the `LINK_LANGUAGE` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
983adb8 | Brad King | 15 June 2020, 18:25:22 UTC | Tests: Factor out RunCMake.GenEx-COMPILE_LANG_AND_ID test Move the `COMPILE_LANG_AND_ID` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:35 UTC |
931a670 | Brad King | 15 June 2020, 18:18:08 UTC | Tests: Factor out RunCMake.GenEx-COMPILE_LANGUAGE test Move the `COMPILE_LANGUAGE` cases out of `RunCMake.GeneratorExpression`. | 16 June 2020, 12:03:34 UTC |
f37ff96 | Brad King | 15 June 2020, 14:31:29 UTC | Merge topic 'gitlab-ci-restructure' into release-3.18 6d168c41e3 gitlab-ci: split linux and macos shared before scripts a1fe6ad621 gitlab-ci: use `extends` fda8b79f88 gitlab-ci: add a comment describing what goes into a job 2b4523c5f2 gitlab-ci: make rules a bit more uniform d6fe877cf9 gitlab-ci: split into multiple files Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4885 | 15 June 2020, 14:31:35 UTC |
7fa5ea1 | Brad King | 15 June 2020, 13:25:11 UTC | Merge topic 'cuda_clang_toolkit_path' into release-3.18 ec59fb6c31 CUDA: Determine CUDA toolkit location for NVCC 0a056246a1 CUDA: Pass toolkit path to Clang 9c43972127 FindCUDAToolkit: Avoid unnecessary temporary variable computing binary dir 9eebb5b8b2 FindCUDAToolkit: Remove unnecessary checks around searches 8f01fe7bf1 FindCUDAToolkit: Use list(SORT) to sort in natural order 8c144fe9ad FindCUDAToolkit: Compute CUDAToolkit_INCLUDE_DIR instead of searching 403f8d31e3 FindCUDAToolkit: Add CUDAToolkit_LIBRARY_ROOT 6636693134 FindCUDAToolkit: Re-unify with Internal/CUDAToolkit Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4828 | 15 June 2020, 13:25:29 UTC |
a3881d6 | Brad King | 15 June 2020, 13:24:31 UTC | Merge topic 'cuda_architectures_disable' into release-3.18 877a92e968 CUDA: Add support for disabling CUDA_ARCHITECTURES Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4886 | 15 June 2020, 13:24:37 UTC |
877a92e | Raul Tambre | 12 June 2020, 16:59:32 UTC | CUDA: Add support for disabling CUDA_ARCHITECTURES The ability to disable adding architectures completely for packaging purposes and cases requiring passing the architectures flags explicitly has been requested. Support a false value for CUDA_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for this purpose. Implements #20821. | 15 June 2020, 13:13:32 UTC |
9fb67f6 | Brad King | 15 June 2020, 13:01:38 UTC | Merge topic 'clang_cxx20' into release-3.18 b365385d66 Clang: Record Clang 6.0+ as fully supporting C++17 5d26efe38f Clang: Add final C++20 flag for Clang 11.0+ Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4887 | 15 June 2020, 13:01:44 UTC |
05546d6 | Brad King | 15 June 2020, 12:57:58 UTC | Merge topic 'revert-find_program-exe-no-read' into release-3.18 cc02ced530 find_program: Revert "Find programs that are executable but not readable" Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !4871 | 15 June 2020, 12:58:06 UTC |
b365385 | Raul Tambre | 13 June 2020, 08:26:11 UTC | Clang: Record Clang 6.0+ as fully supporting C++17 | 13 June 2020, 08:29:55 UTC |
5d26efe | Raul Tambre | 13 June 2020, 08:13:55 UTC | Clang: Add final C++20 flag for Clang 11.0+ -std=c++20 superseded -std=c++2a in upstream Clang commit 24ad121582454e625bdad125c90d9ac0dae948c8. | 13 June 2020, 08:29:51 UTC |
ec59fb6 | Raul Tambre | 12 June 2020, 14:30:17 UTC | CUDA: Determine CUDA toolkit location for NVCC Similar to how we already do for Clang. Avoids a lot of redundant work in FindCUDAToolkit. | 12 June 2020, 20:13:57 UTC |
0a05624 | Raul Tambre | 30 May 2020, 11:24:57 UTC | CUDA: Pass toolkit path to Clang Clang isn't very good at finding the installed CUDA toolkit. The upstream recommendation is that we should pass the toolkit explicitly. Additionally: * Avoids Clang having to search for the toolkit on every invocation. * Allows the user to use a toolkit from a non-standard location by simply setting CUDAToolkit_ROOT. The same way as with FindCUDAToolkit. Clang wants the directory containing the device library and version.txt as the toolkit path. We thus pass the newly introduced CUDAToolkit_LIBRARY_ROOT as the toolkit path. We save CUDAToolkit_ROOT_DIR and CUDAToolkit_LIBRARY_ROOT on Clang to have them available in try_compile() and avoid unnecessary re-searching or a possibly different installation being found in FindCUDAToolkit. This however means that the selected toolkit can't be changed after the initial language enablement. We now determine CUDA compiler ID before doing actual detection, as we don't want to spend time finding the CUDA toolkit for NVIDIA. Implements #20754. | 12 June 2020, 18:50:05 UTC |
9c43972 | Raul Tambre | 12 June 2020, 17:42:09 UTC | FindCUDAToolkit: Avoid unnecessary temporary variable computing binary dir | 12 June 2020, 18:49:15 UTC |
9eebb5b | Raul Tambre | 12 June 2020, 17:39:25 UTC | FindCUDAToolkit: Remove unnecessary checks around searches find_*() don't search if the result variable is already set. Remove the if()s around such cases. | 12 June 2020, 18:49:15 UTC |
8f01fe7 | Raul Tambre | 10 June 2020, 17:08:17 UTC | FindCUDAToolkit: Use list(SORT) to sort in natural order We had a custom loop to sort in the natural order. Since CMake 3.18 this is supported natively by CMake and simplifies the code significantly. | 12 June 2020, 18:49:15 UTC |
8c144fe | Raul Tambre | 11 June 2020, 16:50:04 UTC | FindCUDAToolkit: Compute CUDAToolkit_INCLUDE_DIR instead of searching We can avoid searching for this since CUDAToolkit_TARGET_DIR always contains the include/ directory. But add a warning just in case. Also apply this in CMakeDetermineCUDACompiler for Clang code. | 12 June 2020, 18:49:15 UTC |
403f8d3 | Raul Tambre | 06 June 2020, 15:36:22 UTC | FindCUDAToolkit: Add CUDAToolkit_LIBRARY_ROOT On scattered installations version.txt and nvvm are located at this location. This may be useful to users and will allow us in the future to parse version.txt instead of invoking nvcc to figure out the CUDA toolkit version. We also add it to CMakeDetermineCUDACompiler in preparation for future use by Clang code. | 12 June 2020, 18:49:15 UTC |
6636693 | Raul Tambre | 11 June 2020, 15:48:33 UTC | FindCUDAToolkit: Re-unify with Internal/CUDAToolkit A portion of FindCUDAToolkit was previously split in commit dc2eae1f (FindCUDAToolkit: Factor out discovery code into a separate file, 2020-04-22) out into Internal/CUDAToolkit to allow re-use of the code in CMakeDetermineCUDACompiler for Clang support. This has turned out to be a bad solution due to Clang requiring quite a bit of special handling and special handling for NVCC leaking out from Internal/CUDAToolkit into the Clang code using it. Thus it seems better to re-unify this code and duplicate the parts of the code necessary for Clang where it's required. This will help us get logic correct for both NVCC and CUDA handling. We can still unify the common parts in the future once the code has matured. | 12 June 2020, 18:49:15 UTC |