| aaa5eab | Brad King | 20 August 2020, 12:20:32 UTC | CMake 3.18.2 | 20 August 2020, 12:20:32 UTC |
| 4fc1dd2 | Brad King | 20 August 2020, 11:55:16 UTC | Merge topic 'FindMPI-cuda-pthread' into release-3.18 47abe5f225 FindMPI: Fix regression in pthread guard Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Raul Tambre <raul@tambre.ee> Merge-request: !5147 | 20 August 2020, 11:55:23 UTC |
| 590b879 | Brad King | 20 August 2020, 11:53:06 UTC | Merge topic 'gitlab-ci-msvc-14.27' into release-3.18 983cb0c891 gitlab-ci: Update Windows builds to MSVC 19.27 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5144 | 20 August 2020, 11:53:12 UTC |
| eeaa890 | Brad King | 20 August 2020, 11:49:22 UTC | Merge topic 'msvc_c11' into release-3.18 f4373feda8 Tests: Fix RunCMake.try_compile test for C standards with MSVC 19.27 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5145 | 20 August 2020, 11:49:27 UTC |
| 47abe5f | Axel Huebl | 20 August 2020, 00:12:23 UTC | FindMPI: Fix regression in pthread guard Fix a regression with MPI and CUDA<10.2 that did let `-pthread` flags slip to nvcc again. In commit b725a19072 (FindMPI: Deny -fexceptions from NVCC, 2020-07-02, v3.18.0-rc4~12^2) we accidentally forgot to use the variable containing the replacement result. Fixes: #21108 | 20 August 2020, 10:52:45 UTC |
| 983cb0c | Brad King | 19 August 2020, 18:29:23 UTC | gitlab-ci: Update Windows builds to MSVC 19.27 | 19 August 2020, 18:53:46 UTC |
| f4373fe | Brad King | 19 August 2020, 18:48:35 UTC | Tests: Fix RunCMake.try_compile test for C standards with MSVC 19.27 Since commit f7347f28c7 (MSVC: Record support for C11 and c_restrict, 2020-08-09) we know about MSVC C language standards. Update the `RunCMake.try_compile` test to be aware of this even when CMake is itself configured by an older CMake that does not know this. | 19 August 2020, 18:52:52 UTC |
| 281a87f | Brad King | 19 August 2020, 15:39:56 UTC | Merge topic 'ep-patch-skip-update-dep' into release-3.18 715324742f ExternalProject: Stop configure target from always appearing out-of-date c0b7198ad9 ExternalProject: Stop patch target from always appearing out-of-date Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5136 | 19 August 2020, 15:40:02 UTC |
| 833e84c | Brad King | 19 August 2020, 15:37:05 UTC | Merge topic 'llvm-rc-quote-cmake' into release-3.18 3937536d16 llvm-rc: Fix quoting of path to cmake in CMAKE_RC_COMPILE_OBJECT Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5139 | 19 August 2020, 15:37:54 UTC |
| e9d0059 | Brad King | 19 August 2020, 15:36:35 UTC | Merge topic 'FindPython-enhance-version-extraction-from-lib-name' into release-3.18 72822e26c9 FindPython: enhance robustness of version extraction from library name Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5135 | 19 August 2020, 15:36:51 UTC |
| 09e8de7 | Brad King | 19 August 2020, 15:35:00 UTC | Merge topic 'CMakeFindBinUtils-fallback' into release-3.18 6896e50967 CMakeFindBinUtils: Always consider plain binutils when not cross-compiling Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5137 | 19 August 2020, 15:35:00 UTC |
| 3937536 | Thomas Bernard | 18 August 2020, 20:40:06 UTC | llvm-rc: Fix quoting of path to cmake in CMAKE_RC_COMPILE_OBJECT When the installation path to cmake includes spaces, the `<CMAKE_COMMAND>` is required to have proper quotation of the cmake call. Fixes: #21095 | 18 August 2020, 21:15:34 UTC |
| 6896e50 | Robert Maynard | 18 August 2020, 14:41:22 UTC | CMakeFindBinUtils: Always consider plain binutils when not cross-compiling Since commit c5dd2ca538 (DetermineCompiler: Relax _CMAKE_TOOLCHAIN_PREFIX detection, 2020-03-25, v3.18.0-rc1~430^2), `_CMAKE_TOOLCHAIN_PREFIX` may be set even when not cross-compiling. In this case we may still need to use binutils without any prefix. Fixes: #21103 | 18 August 2020, 17:19:24 UTC |
| 7153247 | Craig Scott | 18 August 2020, 13:24:17 UTC | ExternalProject: Stop configure target from always appearing out-of-date When updates are disconnected, don't depend on skip-update because that target is always considered out of date. Depend directly on the patch target instead because it already depends on the appropriate target regardless of whether updates are disconnected or not. This in turn means nothing depends on the skip-update target, so it has also been removed. Relates: #21086 | 18 August 2020, 13:27:47 UTC |
| c0b7198 | Craig Scott | 18 August 2020, 13:01:09 UTC | ExternalProject: Stop patch target from always appearing out-of-date The skip-update target is always considered out-of-date. The change in 7249ba9677 (ExternalProject: Enforce that patch depends on update, 2020-04-03) made the patch target depend on skip-update, which in turn made it always out of date too. The patch command should only be re-run if the download needs to be performed again where updates are disconnected. Fixes: #21086 | 18 August 2020, 13:21:36 UTC |
| 72822e2 | Marc Chevrier | 18 August 2020, 10:30:47 UTC | FindPython: enhance robustness of version extraction from library name Fixes: #21105 | 18 August 2020, 10:30:47 UTC |
| acd15bf | Brad King | 12 August 2020, 16:22:37 UTC | Merge topic 'FindRuby_document_deprecated_variables' into release-3.18 e7fe0b24c4 FindRuby: Add documentation for deprecated variables Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5120 | 12 August 2020, 16:22:45 UTC |
| e7fe0b2 | Daniele E. Domenichelli | 11 August 2020, 10:02:18 UTC | FindRuby: Add documentation for deprecated variables Since commit e672db628b (FindRuby: Rename variables to match case of module name, 2020-03-11, v3.18.0-rc1~546^2), the upper-case-prefixed variable names are for compatibility only but still exist. Put them back in the documentation. Issue: #21064 | 12 August 2020, 15:25:45 UTC |
| eaf8181 | Brad King | 12 August 2020, 15:13:12 UTC | Merge topic 'msvc_c11' into release-3.18 f7347f28c7 MSVC: Record support for C11 and c_restrict Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5115 | 12 August 2020, 15:14:51 UTC |
| 0ca6d57 | Brad King | 12 August 2020, 15:13:08 UTC | Merge topic 'FindPython-manage-SOABI-in-all-versions' into release-3.18 951640f1f9 FindPython: manage SOABI for all Python versions Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5119 | 12 August 2020, 15:13:16 UTC |
| edd908f | Brad King | 11 August 2020, 17:40:33 UTC | Merge topic 'gitlab-ci-tag-cmake' into release-3.18 778ea72b59 gitlab-ci: add 'cmake' tag to all jobs Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5121 | 11 August 2020, 17:40:47 UTC |
| 778ea72 | Brad King | 11 August 2020, 17:17:14 UTC | gitlab-ci: add 'cmake' tag to all jobs This will give us more granular control over which runners accept jobs for CMake. | 11 August 2020, 17:19:05 UTC |
| f7347f2 | Raul Tambre | 09 August 2020, 12:22:03 UTC | MSVC: Record support for C11 and c_restrict MSVC >=19.27 supports a C11 switch. The `c_restrict` feature has also been implemented. Fixes: #21069 | 11 August 2020, 13:08:21 UTC |
| 9ccd13d | Brad King | 11 August 2020, 12:54:32 UTC | Merge topic 'findhdf5-fix-nohl' into release-3.18 e038107ee7 FindHDF5: fix compiler detection when HL is disabled Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5112 | 11 August 2020, 12:55:45 UTC |
| 5c9edd3 | Brad King | 11 August 2020, 12:54:09 UTC | Merge topic 'osx-archs-apple-only' into release-3.18 70ce1ad64a PCH: Avoid Apple-specific architecture flags on other platforms Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5118 | 11 August 2020, 12:54:15 UTC |
| e524819 | Brad King | 11 August 2020, 12:50:54 UTC | Merge topic 'automoc-path-prefix-off' into release-3.18 5b5be34811 Help: Add 3.18.2 release note about AUTOMOC_PATH_PREFIX default change db659e18bc Merge branch 'backport-3.17-automoc-path-prefix-off' e503fbe38a Merge branch 'backport-3.16-automoc-path-prefix-off' 4c33b305a0 Autogen: Turn off moc path prefix generation by default 56510b7d85 Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.17 effc9a1032 Merge branch 'backport-3.17-automoc_timestamp_deps' into release-3.17 507fecd7e2 Merge branch 'ninja-multi-rsp-remove-path' into release-3.17 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5105 | 11 August 2020, 12:51:01 UTC |
| 951640f | Marc Chevrier | 11 August 2020, 08:16:40 UTC | FindPython: manage SOABI for all Python versions Fixes: #21070 | 11 August 2020, 08:16:40 UTC |
| 70ce1ad | Brad King | 10 August 2020, 17:29:29 UTC | PCH: Avoid Apple-specific architecture flags on other platforms Since commit f593b354da (PCH: Add support for multi architecture iOS projects, 2020-04-02, v3.18.0-rc1~414^2) the `OSX_ARCHITECTURES` target property (and corresponding `CMAKE_OSX_ARCHITECTURES` variable) affects flags on non-Apple platforms by accident. Add a missing condition to avoid this. Fixes: #21072 | 10 August 2020, 17:29:29 UTC |
| e038107 | Seth R Johnson | 08 August 2020, 14:50:19 UTC | FindHDF5: fix compiler detection when HL is disabled A valid HDF5 installation with the "high level" extensions not configured will *fail* to be correctly detected by CMake since commit d9e39f3f89 (FindHDF5: check that compiler wrapper can compile a minimal program, 2020-02-10, v3.18.0-rc1~744^2~1): ``` /.../hdf5/cmake_hdf5_test.c:2:10: fatal error: 'hdf5_hl.h' file not found ``` This does not stop the configuration but does prevent flags and libraries from being recognized. | 10 August 2020, 15:53:58 UTC |
| b8214a8 | Brad King | 10 August 2020, 15:19:14 UTC | Merge topic 'FPHSA-name-mismatches-chained-via-include' into release-3.18 98844ec9db FPHSA: detect inclusion between find modules Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Logan Barnes <barneslt63@gmail.com> Merge-request: !5107 | 10 August 2020, 15:25:09 UTC |
| b6da87c | Brad King | 10 August 2020, 15:20:53 UTC | Merge topic 'xcode-try_compile-no-sign-backport' into release-3.18 97d581b25d Xcode: Explicitly turn off signing in try_compile projects Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5117 | 10 August 2020, 15:23:14 UTC |
| cb1f2cf | Brad King | 10 August 2020, 15:19:00 UTC | Merge topic 'FindRuby-restore-include-path' into release-3.18 6959744131 FindRuby: Restore compatibility variable RUBY_INCLUDE_PATH Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5109 | 10 August 2020, 15:21:20 UTC |
| b88fb7e | Brad King | 10 August 2020, 15:18:58 UTC | Merge topic 'FindPython-user-policies' into release-3.18 a92d384548 FindPython: ensure user's policies are respected Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Henry Schreiner <henryschreineriii@gmail.com> Merge-request: !5098 | 10 August 2020, 15:19:17 UTC |
| 5b5be34 | Joerg Bornemann | 06 August 2020, 06:20:16 UTC | Help: Add 3.18.2 release note about AUTOMOC_PATH_PREFIX default change | 10 August 2020, 14:49:55 UTC |
| db659e1 | Brad King | 10 August 2020, 14:49:18 UTC | Merge branch 'backport-3.17-automoc-path-prefix-off' | 10 August 2020, 14:49:18 UTC |
| 72409ee | Brad King | 10 August 2020, 14:45:48 UTC | Merge topic 'test-FindPkgConfig-isolate-env' into release-3.18 8b12982653 Merge branch 'backport-test-FindPkgConfig-isolate-env' 4c939b0d39 Tests: Isolate RunCMake.FindPkgConfig from caller environment 20eeb40aaf Tests: Isolate RunCMake.FindPkgConfig from caller environment Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5108 | 10 August 2020, 14:45:54 UTC |
| e503fbe | Brad King | 10 August 2020, 14:41:06 UTC | Merge branch 'backport-3.16-automoc-path-prefix-off' | 10 August 2020, 14:41:06 UTC |
| 4c33b30 | Joerg Bornemann | 06 August 2020, 06:20:16 UTC | Autogen: Turn off moc path prefix generation by default Change the default value of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF` to restore compatibility with behavior of CMake 3.15 and below. C++ source files that are generated by Qt's meta object compiler (moc) include the header file that was passed as input argument to moc. This is usually a path relative to the source directory, for example #include "../../source/dir/myobject.h" That is problematic for reproducible builds as described in #18815. To cope with that, the target property AUTOMOC_PATH_PREFIX was introduced in CMake 3.16 by commit d018d27c10 (Autogen: Add moc path prefix generation (AUTOMOC_PATH_PREFIX), 2019-09-13, v3.16.0-rc1~94^2~4). The property is default-initialized from the variable `CMAKE_AUTOMOC_PATH_PREFIX`, which defaults to `ON`. If this property is ON, and myobject.h is located in an include directory of the target, moc-generated C++ files include the file without the "path prefix": #include "myobject.h" This behavior, however, can break projects that have equally named header files in different include directories. As "not breaking existing projects" trumps "have reproducible builds by default" we change the default of `CMAKE_AUTOMOC_PATH_PREFIX` to `OFF`. Also, it is now possible to pass `-DCMAKE_AUTOMOC_PATH_PREFIX=ON` on the CMake command line. Before, it was overridden in `CMakeGenericSystem`. Fixes: #20598 Issue: #18815 | 10 August 2020, 14:36:17 UTC |
| 97d581b | Brad King | 16 July 2020, 14:37:42 UTC | Xcode: Explicitly turn off signing in try_compile projects Fixes: #18407, #20571, #20688 | 10 August 2020, 12:28:38 UTC |
| 6959744 | Brad King | 07 August 2020, 16:40:26 UTC | FindRuby: Restore compatibility variable RUBY_INCLUDE_PATH Since commit e672db628b (FindRuby: Rename variables to match case of module name, 2020-03-11, v3.18.0-rc1~546^2), the result variables named with the old `RUBY_` prefix are provided by compatibility code that maps from the new `Ruby_` prefix variables. There is no `Ruby_INCLUDE_PATH` variable, so do not try to map it to `RUBY_INCLUDE_PATH`. The latter is provided by dedicated compatibility code left from before that transition. Fixes: #21064 | 07 August 2020, 16:40:26 UTC |
| 56510b7 | Brad King | 07 August 2020, 14:51:48 UTC | Merge branch 'backport-test-FindPkgConfig-isolate-env' into release-3.17 Merge-request: !5108 | 07 August 2020, 14:51:48 UTC |
| 8b12982 | Brad King | 07 August 2020, 14:49:15 UTC | Merge branch 'backport-test-FindPkgConfig-isolate-env' | 07 August 2020, 14:49:19 UTC |
| 4c939b0 | Brad King | 07 August 2020, 14:30:42 UTC | Tests: Isolate RunCMake.FindPkgConfig from caller environment Avoid interference from `CMAKE_PREFIX_PATH` and friends if they happen to be set in the environment from which the tests are run. | 07 August 2020, 14:47:25 UTC |
| 20eeb40 | Brad King | 07 August 2020, 14:30:42 UTC | Tests: Isolate RunCMake.FindPkgConfig from caller environment Avoid interference from `CMAKE_PREFIX_PATH` and friends if they happen to be set in the environment from which the tests are run. | 07 August 2020, 14:37:28 UTC |
| 98844ec | Ben Boeckel | 06 August 2020, 16:38:04 UTC | FPHSA: detect inclusion between find modules Various find modules include each other to delegate finding some subset or variant of the package. Ideally, these would use `find_dependency` or some other actual `find_package` mechanism, but that is a larger change. Instead, just detect inclusion and suppress FPHSA name mismatch warnings. Fixes: #21060 | 07 August 2020, 13:41:38 UTC |
| a92d384 | Marc Chevrier | 04 August 2020, 14:40:50 UTC | FindPython: ensure user's policies are respected Do not set the policy version before recording our internal macros such as `__Python_add_library`. Otherwise callers get our policy version instead of theirs. Instead just set the specific policies we need. Also fix one case in our test suite where we were accidentally relying on the policy version to be set by `FindPython`. Fixes: #21042 | 07 August 2020, 13:24:18 UTC |
| 13e5df1 | Brad King | 06 August 2020, 14:38:27 UTC | Merge topic 'reuse_pch_no_delay' into release-3.18 ef97fbe6c2 PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5102 | 06 August 2020, 14:39:46 UTC |
| 9c4130e | Brad King | 06 August 2020, 14:36:56 UTC | Merge topic 'support_list_google_test_executor' into release-3.18 8829d2caba GoogleTest: Restore support for list arguments in TEST_EXECUTOR Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5084 | 06 August 2020, 14:37:03 UTC |
| ab4895d | Brad King | 06 August 2020, 14:29:17 UTC | Merge topic 'automoc_timestamp_deps' into release-3.18 9a9ed4b9d3 Merge branch 'backport-3.17-automoc_timestamp_deps' 7445c9a58a AutoGen: Add test to check for correct AutoMoc dependencies a79056bb02 AutoGen: Fix over-specified direct dependencies of custom command Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Aleix <aleixpol@kde.org> Merge-request: !5085 | 06 August 2020, 14:31:23 UTC |
| ce4216d | Brad King | 06 August 2020, 14:28:11 UTC | Merge topic 'ninja-multi-rsp-remove-path' into release-3.18 cdb50af2f6 Ninja: Restore shorter path to response files Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: alcroito <alexandru.croitor@qt.io> Merge-request: !5094 | 06 August 2020, 14:28:27 UTC |
| ef97fbe | Cristian Adam | 05 August 2020, 12:05:56 UTC | PCH: Avoid unnecessary 30s delay on MSBuild Generator with REUSE_FROM Fix logic added by commit 1f791eb160 (Multi-Ninja: Fix reusable PCHs for MSVC, 2020-05-24, v3.18.0-rc1~72^2) to avoid an unnecessary delay. Fixes: #21054 | 05 August 2020, 19:52:05 UTC |
| effc9a1 | Brad King | 03 August 2020, 18:09:53 UTC | Merge branch 'backport-3.17-automoc_timestamp_deps' into release-3.17 Merge-request: !5085 | 05 August 2020, 19:44:14 UTC |
| 9a9ed4b | Brad King | 05 August 2020, 19:42:39 UTC | Merge branch 'backport-3.17-automoc_timestamp_deps' | 05 August 2020, 19:42:39 UTC |
| 7445c9a | Alexandru Croitor | 03 August 2020, 10:23:07 UTC | AutoGen: Add test to check for correct AutoMoc dependencies When using Qt 5.15.0 or above together with Ninja, check that touching a source file of a dependency does not needlessly re-run AUTOMOC for the dependee target. | 03 August 2020, 17:38:16 UTC |
| a79056b | Alexandru Croitor | 31 July 2020, 15:50:37 UTC | AutoGen: Fix over-specified direct dependencies of custom command The AutoMoc timestamp creating custom command explicitly depended on all dependencies of the origin target (associated to the AutoGen target). When an origin target depended on a shared library 'libfoo.so', if it was re-linked, the AutoMoc custom command would touch its output timestamp file, and thus cause needless rebuilding of sources, despite the shared library not having any influence on the AutoMoc generated files. Introduce a new '<target>_autogen_timestamp_deps' utility target, which will serve as an 'order-only' dependency for the custom command. This will prevent needless rebuilding, because touching 'libfoo.so' will not cause the custom command to be re-executed. The new AutoMoc dependency tree looks like: '_autogen_timestamp_deps (serves as order-only dep)' <- '<target_autogen>/timestamp' file ( + moc deps file) <- '<target>_autogen' target. Fixes: #21020 | 03 August 2020, 17:38:11 UTC |
| 507fecd | Brad King | 03 August 2020, 16:25:10 UTC | Merge branch 'ninja-multi-rsp-remove-path' into release-3.17 Merge-request: !5094 | 03 August 2020, 16:25:10 UTC |
| cdb50af | Kyle Edwards | 03 August 2020, 14:45:17 UTC | Ninja: Restore shorter path to response files In commit 99ed39b011 (Ninja Multi-Config: Make link response files per-config, 2020-07-15, v3.17.4~3^2), we added the target directory to the response file under the mistaken assumption that two different targets with the same name could be in different directories. However, this causes the path to the response file to be too long to fit on a command line. Take the path back out, while leaving in the per-config split. Fixes: #21050 | 03 August 2020, 16:14:16 UTC |
| 8829d2c | Laurits Riple | 31 July 2020, 02:03:18 UTC | GoogleTest: Restore support for list arguments in TEST_EXECUTOR Refactoring in commit 889a7146ff (GoogleTestAddTests: Refactor into callable method, 2020-03-16, v3.18.0-rc1~450^2~3) accidentally parsed `TEST_EXECUTOR` as a single-value argument instead of a list. | 03 August 2020, 16:10:58 UTC |
| 63a65ba | Brad King | 30 July 2020, 16:34:59 UTC | CMake 3.18.1 | 30 July 2020, 16:34:59 UTC |
| d908a89 | Brad King | 30 July 2020, 16:32:16 UTC | Merge branch 'release-3.17' into release-3.18 | 30 July 2020, 16:32:16 UTC |
| 103d6fa | Brad King | 30 July 2020, 14:30:07 UTC | CMake 3.17.4 | 30 July 2020, 14:30:07 UTC |
| 533a625 | Brad King | 30 July 2020, 12:39:43 UTC | Merge topic 'clang-msvc-cxx-std' into release-3.18 21e497fe63 Clang: Fix fallback compile features when simulating old MSVC versions Acked-by: Kitware Robot <kwrobot@kitware.com> Reviewed-by: Raul Tambre <raul@tambre.ee> Merge-request: !5082 | 30 July 2020, 12:39:58 UTC |
| 2fdb7c5 | Brad King | 30 July 2020, 12:28:41 UTC | Merge topic 'unity_no_skip_autogen' into release-3.18 7051250a6c Unity Builds: Do not set SKIP_AUTOGEN to source files Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5081 | 30 July 2020, 12:28:49 UTC |
| 21e497f | Brad King | 29 July 2020, 17:02:21 UTC | Clang: Fix fallback compile features when simulating old MSVC versions Refactoring in commit 25439c7d62 (Clang: Refactor CXX standard flags into __compiler_clang_cxx_standards(), 2020-03-16, v3.18.0-rc1~362^2~4) accidentally broke the `cxx_std_*` fallback feature names. Issue: #21033 | 29 July 2020, 17:02:21 UTC |
| 7051250 | Cristian Adam | 29 July 2020, 15:33:00 UTC | Unity Builds: Do not set SKIP_AUTOGEN to source files Fixes: #21028 | 29 July 2020, 15:57:50 UTC |
| 7b4ffd4 | Brad King | 29 July 2020, 12:05:40 UTC | Merge topic 'FindCURL-list-index-if' into release-3.18 0faedae335 FindCURL: Fix list index check after search Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5070 | 29 July 2020, 12:05:47 UTC |
| 0faedae | Mike Gelfand | 27 July 2020, 22:05:13 UTC | FindCURL: Fix list index check after search Fix logic added by commit fc5afbe970 (FindCURL: support COMPONENTS to check features, 2018-11-28, v3.14.0-rc1~287^2~2). When searching for particular components and `curl-config` reports one of the components being searched for first in the list, `find_package` fails. This is due to the check that treats non-zero index in the list as success and zero index as failure, while documentation on `list(FIND)` states that failure to find an element results in return value of -1 (not 0). I'm hitting this when building cURL with support for HTTP and HTTPS protocols only, and then trying to `find_package(CURL COMPONENTS HTTP HTTPS)`. I'm using `if(NOT x EQUAL -1)` check form as it appears to be the most used throughout the modules. While fixing this issue I've looked through all the uses of `list(FIND)` in other modules but wasn't able to find improper use except here. | 28 July 2020, 13:09:43 UTC |
| dde9768 | Brad King | 28 July 2020, 12:22:20 UTC | Merge topic 'revert-add_test-special-chars' into release-3.18 5fc5f4d26e add_test: Revert "Allow special characters in test name" Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5067 | 28 July 2020, 12:24:34 UTC |
| 825e19b | Brad King | 28 July 2020, 12:21:55 UTC | Merge topic 'sysroot-prefix' into release-3.18 e67d9c6e31 Compilers: Ignore -print-sysroot prefix when it is '/' Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5066 | 28 July 2020, 12:22:35 UTC |
| 5fc5f4d | Brad King | 27 July 2020, 13:26:21 UTC | add_test: Revert "Allow special characters in test name" Revert commit f84af8e270 (add_test: Allow special characters in test name, 2020-05-16, v3.18.0-rc1~142^2). Unfortunately the fix breaks projects that were working around the limitation with manual escaping. The fix can be re-introduced with a policy in a future version. Also add a 3.18.1 release note explaining the change. Fixes: #21017, #20965 Issue: #19391 | 27 July 2020, 22:04:11 UTC |
| e67d9c6 | Brad King | 27 July 2020, 13:07:42 UTC | Compilers: Ignore -print-sysroot prefix when it is '/' Since commit 8cc384f629 (Compilers: Add paths from -print-sysroot to system prefix path, 2020-03-25, v3.18.0-rc1~337^2) we prepend the compiler's sysroot to `CMAKE_SYSTEM_PREFIX_PATH`. This does not make sense when the prefix is just `/`, such as on Ubuntu 16.04's system compiler. Fixes: #21019 | 27 July 2020, 14:53:43 UTC |
| 7c99b7d | Brad King | 27 July 2020, 14:52:34 UTC | Merge topic 'fix-dependent-pipelines' into release-3.18 726766713b gitlab-ci: avoid failing dependent steps Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5069 | 27 July 2020, 14:52:44 UTC |
| 16f77ce | Brad King | 27 July 2020, 14:44:13 UTC | Merge topic 'bootstrap-intel' into release-3.18 796466284b bootstrap: Fix support for Intel compiler with modern GNU system compiler Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5057 | 27 July 2020, 14:47:57 UTC |
| 90c8830 | Brad King | 27 July 2020, 14:44:54 UTC | Merge topic 'externalproject-download-git-2.20-fix' into release-3.18 8dbefc3ca6 ExternalProject: omit --no-checkout from git clone when using git 2.20.x. Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5054 | 27 July 2020, 14:46:35 UTC |
| 4b0c4ca | Brad King | 27 July 2020, 14:43:05 UTC | Merge topic 'xcode-12-legacy-deprecation' into release-3.18 36fc3a1e84 Xcode: Suppress legacy build system deprecation warning Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5052 | 27 July 2020, 14:45:14 UTC |
| fadedcb | Brad King | 27 July 2020, 14:43:35 UTC | Merge topic 'FindXalanC-1.12' into release-3.18 4bf102418b FindXalanC: Fix version parsing for XalanC 1.12 Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5056 | 27 July 2020, 14:43:54 UTC |
| e19a62e | Brad King | 27 July 2020, 14:42:38 UTC | Merge topic 'vs-lang-flags' into release-3.18 c4109a1bc8 VS: Restore toleration of target-wide -TP flag with MSVC Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5051 | 27 July 2020, 14:42:44 UTC |
| 7267667 | Ben Boeckel | 27 July 2020, 13:56:24 UTC | gitlab-ci: avoid failing dependent steps This avoids making busted jobs if a prerequisite fails. | 27 July 2020, 14:02:34 UTC |
| 8dbefc3 | Nate Avers | 24 July 2020, 02:25:22 UTC | ExternalProject: omit --no-checkout from git clone when using git 2.20.x. The optimization from commit 627fc5b44f (ExternalProject: Avoid unnecessary checkout on clone, 2019-07-29, v3.16.0-rc1~325^2) triggers a bug in the Git 2.20.x series that is not in older or newer versions. Drop the optimization for that specific range of Git versions. Fixes: #21009 | 24 July 2020, 13:39:06 UTC |
| e82bc59 | Brad King | 24 July 2020, 12:59:11 UTC | Merge branch 'bootstrap-intel' into release-3.17 Merge-request: !5057 | 24 July 2020, 12:59:11 UTC |
| 7964662 | Brad King | 24 July 2020, 12:48:02 UTC | bootstrap: Fix support for Intel compiler with modern GNU system compiler On systems with older GNU system compilers, the Intel C++ compiler does not define `__cplusplus` to any version newer than C++11. This prevented `bootstrap` from detecting that a given C++ standard flag has enabled C++17 mode in the compiler. In commit 033a4b12a5 (bootstrap: Extend C++17 check for our cast functions, 2019-12-14, v3.17.0-rc1~291^2) we added a preprocessor condition to attempt to detect C++17 mode in the Intel compiler on such systems by looking for `__cpp_if_constexpr`. However, on systems with a modern GNU system compiler, that definition is available even in C++11 mode. Switch to using `__cpp_deduction_guides` to detect C++17 mode for the Intel C++ compiler. That seems to be defined exclusively in C++17 mode regardless of the version of the system compiler. Fixes: #21013 | 24 July 2020, 12:53:13 UTC |
| 4bf1024 | Brad King | 24 July 2020, 11:14:35 UTC | FindXalanC: Fix version parsing for XalanC 1.12 The version header now puts parentheses around the components. Fixes: #21010 | 24 July 2020, 11:23:19 UTC |
| 1632708 | Brad King | 23 July 2020, 18:11:47 UTC | Merge topic 'file-GET_RUNTIME_DEPENDENCIES-terms' into release-3.18 2b60088d14 Help: Update file(GET_RUNTIME_DEPENDENCIES) prose to match option names Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5053 | 23 July 2020, 18:11:52 UTC |
| 2b60088 | Brad King | 23 July 2020, 17:47:24 UTC | Help: Update file(GET_RUNTIME_DEPENDENCIES) prose to match option names | 23 July 2020, 17:47:24 UTC |
| 36fc3a1 | Brad King | 23 July 2020, 16:59:14 UTC | Xcode: Suppress legacy build system deprecation warning Xcode 12 beta 3 now warns about using the legacy build system. Since generation of the build system is CMake's responsibility, the warning is not relevant to our users. Suppress it. Issue: #18088 | 23 July 2020, 17:00:42 UTC |
| c4109a1 | Brad King | 23 July 2020, 14:30:59 UTC | VS: Restore toleration of target-wide -TP flag with MSVC Since commit 3b547e2e4b (VS: Simplify logic adding source file C/C++ language flag to MSVC, 2020-05-15, v3.18.0-rc1~139^2~1) we only add a per-source language selection flag when the source file extension does not match the compiler's default. This approach breaks when a project adds a target-wide `-TP` flag. Although such projects likely did not work with non-VS generators, we did support them before in Visual Studio generators. Add a special case to tolerate such flags again. Fixes: #21005 | 23 July 2020, 14:54:35 UTC |
| 4b1c6f9 | Brad King | 23 July 2020, 12:20:40 UTC | Merge topic 'cmake-gui-qt-5.14' into release-3.18 af6cf586f6 cmake-gui: Fix crash when built with Qt 5.14 or later Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5045 | 23 July 2020, 12:20:48 UTC |
| af6cf58 | Brad King | 22 July 2020, 19:16:12 UTC | cmake-gui: Fix crash when built with Qt 5.14 or later In commit d7679f6427 (QCMakeCacheView: use non-deprecated List and Set constructions, 2020-06-10, v3.18.0-rc2~13^2) the conversion of the `this->properties()` value to QSet is incorrect for Qt 5.14+. The problem is that `this->properties()` returns by value, so the range `this->properties().begin(), this->properties().end()` provides iterators to two different instances. Use an intermediate temporary copy of the value to get a consistent iterator range. Fixes: #20981 | 22 July 2020, 19:19:51 UTC |
| 24571e8 | Brad King | 22 July 2020, 12:45:55 UTC | Merge topic 'aux-install-dest' into release-3.18 83bc79e232 Auxiliary: Add options to control Vim and Emacs file installation Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5035 | 22 July 2020, 12:46:00 UTC |
| c8a6da0 | Brad King | 22 July 2020, 12:42:30 UTC | Merge topic 'graphviz-restore-per-target' into release-3.18 1829220310 Merge branch 'backport-3.17-graphviz-restore-per-target' f3a6b4a209 Tests: Cover Graphviz support for per-target dependency graph options 93549b9224 Graphviz: Restore support for per-target dependency graph options Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5039 | 22 July 2020, 12:42:36 UTC |
| e817818 | Brad King | 21 July 2020, 20:35:53 UTC | Merge branch 'backport-3.17-graphviz-restore-per-target' into release-3.17 Merge-request: !5039 | 21 July 2020, 20:35:53 UTC |
| 1829220 | Brad King | 21 July 2020, 19:00:28 UTC | Merge branch 'backport-3.17-graphviz-restore-per-target' | 21 July 2020, 19:00:52 UTC |
| f3a6b4a | Stephan Rohmen | 21 July 2020, 17:47:34 UTC | Tests: Cover Graphviz support for per-target dependency graph options Issue: #20928 | 21 July 2020, 18:55:44 UTC |
| 93549b9 | Stephan Rohmen | 21 July 2020, 17:45:45 UTC | Graphviz: Restore support for per-target dependency graph options The behaviors controlled by options `GRAPHVIZ_GENERATE_PER_TARGET` and `GRAPHVIZ_GENERATE_DEPENDERS` were broken by commit 553658393c (Graphviz: added test suite, fixes, enhancements, 2019-10-08, v3.17.0-rc1~615^2). It had not been covered in the test suite previously, and those changes left out checks for these features from the `default_options` case. Implement the previously-existing behavior in the new graphviz generation engine added by the above-mentioned commit. Fixes: #20928 | 21 July 2020, 18:55:44 UTC |
| 83bc79e | Brad King | 21 July 2020, 12:27:02 UTC | Auxiliary: Add options to control Vim and Emacs file installation Since commit 2642f432ef (Aux: Install editor and bash files to more natural locations, 2020-03-30, v3.18.0-rc1~429^2) these files are installed by default into locations that are not CMake-specific but may be distro-specific. Add options for packagers to control these locations. Also rename the `CMAKE_BASH_COMP_DIR` option to follow our conventions. Fixes: #20993 | 21 July 2020, 12:34:30 UTC |
| 19a0b5c | Brad King | 21 July 2020, 11:26:28 UTC | Merge topic 'ghs-crash' into release-3.18 5da2c71165 GHS: Fix crash when GHS_NO_SOURCE_GROUP_FILE property is not defined Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5033 | 21 July 2020, 11:26:41 UTC |
| dae9fd0 | Brad King | 21 July 2020, 11:25:34 UTC | Merge topic 'bootstrap-system-http2' into release-3.18 64bc82bb4d bootstrap: Add options to control use of system nghttp2 Acked-by: Kitware Robot <kwrobot@kitware.com> Acked-by: Christoph Grüninger <foss@grueninger.de> Merge-request: !5031 | 21 July 2020, 11:25:54 UTC |
| 21bebd2 | Brad King | 21 July 2020, 11:24:55 UTC | Merge topic 'strdup' into release-3.18 eea0337c7d centos5: Fix FTBFS with strdup Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5026 | 21 July 2020, 11:25:02 UTC |
| 70dca18 | Craig Scott | 21 July 2020, 11:18:50 UTC | Merge topic 'xcode-native-arch' into release-3.18 26673bf480 Xcode: Explicitly specify default native architecture on macOS ce624cfbd4 cmGlobalXCodeGenerator: Save CMAKE_SYSTEM_NAME in member Acked-by: Kitware Robot <kwrobot@kitware.com> Merge-request: !5023 | 21 July 2020, 11:19:02 UTC |
| 5da2c71 | Brad King | 20 July 2020, 14:39:16 UTC | GHS: Fix crash when GHS_NO_SOURCE_GROUP_FILE property is not defined Refactoring in commit 36aba01223 (cmGeneratorTarget::GetProperty: return cmProp, 2020-04-29, v3.18.0-rc1~246^2) left out a `nullptr` check. Fixes: #20985 | 20 July 2020, 14:41:41 UTC |
