| db45529 | Łukasz Langa | 23 September 2020, 12:36:32 UTC | Python 3.8.6 | 23 September 2020, 12:36:32 UTC |
| 5acc1b5 | Miss Islington (bot) | 23 September 2020, 03:57:48 UTC | bpo-37062: Enum: add extended AutoNumber example (GH-22349) (GH-22369) (cherry picked from commit 62e40d8450b9c78346ec3617de7fe3f0ad381510) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 23 September 2020, 03:57:48 UTC |
| 2466a7a | Miss Islington (bot) | 22 September 2020, 18:36:02 UTC | bpo-35764: Rewrite the IDLE Calltips doc section (GH-22363) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 22 September 2020, 18:36:02 UTC |
| 6d372ef | Miss Islington (bot) | 22 September 2020, 18:30:47 UTC | fix `EventType` bases `StrEnum` does not exist in 3.8, so use original `(str, enum.Enum)` bases. | 22 September 2020, 18:30:47 UTC |
| 7bcbb53 | Miss Islington (bot) | 22 September 2020, 06:02:45 UTC | bpo-40181: Remove '/' reminder in IDLE calltips. (GH-22350) The marker was added to the language in 3.8 and 3.7 only gets security patches. (cherry picked from commit 40a0625792e795cd41c4ba20475e3b770b53817a) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 22 September 2020, 06:02:45 UTC |
| ca2d99d | Miss Islington (bot) | 21 September 2020, 22:00:34 UTC | bpo-41815: SQLite: segfault if backup called on closed database (GH-22322) GH- [bpo-41815](): SQLite: fix segfault if backup called on closed database Attempting to backup a closed database will trigger segfault: ```python import sqlite3 target = sqlite3.connect(':memory:') source = sqlite3.connect(':memory:') source.close() source.backup(target) ``` (cherry picked from commit bfee9fad84531a471fd7864e88947320669f68e2) Co-authored-by: Peter McCormick <peter@pdmccormick.com> | 21 September 2020, 22:00:34 UTC |
| 488e3eb | Miss Islington (bot) | 19 September 2020, 19:56:30 UTC | bpo-41811: create SortKey members using first given value (GH-22316) (GH-22326) (cherry picked from commit ae0d2a33ec05aece939a959d36fcf1df1e210a08) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 19 September 2020, 19:56:30 UTC |
| 3acc403 | Victor Stinner | 18 September 2020, 15:21:24 UTC | bpo-35293: Travis CI uses "make venv" for the doc (GH-22307) (GH-22309) (GH-22310) Doc/requirements.txt becomes the reference for packages and package versions needed to build the Python documentation. * Doc/Makefile now uses Doc/requirements.txt * .travis.yml now uses "make env" of Doc/Makefile * Update Sphinx to version 2.4.4 (cherry picked from commit 8394500cca56490cc347604d39ca40abcdce46c3) (cherry picked from commit 9e73cac173e5e9010bd18c8334fffeee1cade3a4) | 18 September 2020, 15:21:24 UTC |
| b7cdea8 | Miss Islington (bot) | 18 September 2020, 09:31:30 UTC | bpo-35293: Remove RemovedInSphinx40Warning (GH-22198) * bpo-35293: Remove RemovedInSphinx40Warning * Update Misc/NEWS.d/next/Documentation/2020-09-12-17-37-13.bpo-35293._cOwPD.rst Co-authored-by: Victor Stinner <vstinner@python.org> * bpo-35293: Apply Victor's review Co-authored-by: Victor Stinner <vstinner@python.org> (cherry picked from commit 6595cb0af4c51c0381c233b97884fe916a4ddd35) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> | 18 September 2020, 09:31:30 UTC |
| c5cddc1 | Miss Islington (bot) | 18 September 2020, 08:31:28 UTC | bpo-41762: Fix usage of productionlist markup in the doc (GH-22281) (GH-22300) Use an unique identifier for the different grammars documented using the Sphinx productionlist markup. productionlist markups of the same grammar, like "expressions" or "compound statements", use the same identifier "python-grammar". (cherry picked from commit 8af239eacfcf52e4e0e2b0223e7cea4672309483) Co-authored-by: Victor Stinner <vstinner@python.org> | 18 September 2020, 08:31:28 UTC |
| 038688a | Serhiy Storchaka | 18 September 2020, 06:37:04 UTC | [3.8] Remove duplicated words words (GH-20413). (GH-22297) (cherry picked from commit 1c5d1d7304a119040fd3118128bdb412f0cce6a6) | 18 September 2020, 06:37:04 UTC |
| 5efb1a7 | Ethan Furman | 17 September 2020, 00:38:14 UTC | [3.8] bpo-39728: Enum: fix duplicate `ValueError` (GH-22277) (GH-22283) fix default `_missing_` to return `None` instead of raising a `ValueError` Co-authored-by: Andrey Darascheka <andrei.daraschenka@leverx.com>. (cherry picked from commit c95ad7a91fbd7636f33a098d3b39964ab083bf49) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 17 September 2020, 00:38:14 UTC |
| 007edda | Miss Islington (bot) | 17 September 2020, 00:28:32 UTC | _auto_called cleanup (GH-22285) (cherry picked from commit fc23a9483ef0d7c98bea9f82392377d0b6ef7b18) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 17 September 2020, 00:28:32 UTC |
| 3f40121 | Miss Islington (bot) | 16 September 2020, 14:30:54 UTC | bpo-41517: do not allow Enums to be extended (GH-22271) fix bug that let Enums be extended via multiple inheritance (cherry picked from commit 3064dbf5df1021e85b507366a7ea448c8895efe7) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 16 September 2020, 14:30:54 UTC |
| 929112e | Miss Islington (bot) | 16 September 2020, 00:16:36 UTC | bpo-41789: honor object overrides in Enum classes (GH-22250) EnumMeta double-checks that `__repr__`, `__str__`, `__format__`, and `__reduce_ex__` are not the same as `object`'s, and replaces them if they are -- even if that replacement was intentionally done in the Enum being constructed. This patch fixes that. Automerge-Triggered-By: @ethanfurman (cherry picked from commit 22415ad62555d79bd583b4a7d6a96006624a8277) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 16 September 2020, 00:16:36 UTC |
| 8f8ebcc | Miss Islington (bot) | 15 September 2020, 23:23:57 UTC | bpo-39587: Enum - use correct mixed-in data type (GH-22263) (cherry picked from commit bff01f3a3aac0c15fe8fbe8b2f561f7927d117a1) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 15 September 2020, 23:23:57 UTC |
| 5fdc142 | Miss Islington (bot) | 15 September 2020, 19:45:29 UTC | Improve the description of difflib in the documentation (GH-22253) (GH-22260) From "can produce difference information in various formats ..." to " can produce information about file differences in various formats ..." Automerge-Triggered-By: @Mariatta (cherry picked from commit 5531269f698f789d1247123fd82681f7a455f66e) Co-authored-by: Mandeep <mandeep052@gmail.com> | 15 September 2020, 19:45:29 UTC |
| a0da907 | Miss Islington (bot) | 15 September 2020, 13:56:43 UTC | bpo-41776: Revise example of "continue" in the tutorial documentation (GH-22234) (GH-22256) Revise example of "continue" in the tutorial documentation (cherry picked from commit 7bcc6456ad4704da9b287c8045768fa53961adc5) Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com> Co-authored-by: Neeraj Samtani <neerajjsamtani@gmail.com> | 15 September 2020, 13:56:43 UTC |
| 624cc10 | Miss Islington (bot) | 14 September 2020, 20:42:38 UTC | bpo-40721: add note about enum member name case (GH-22231) * UPPER_CASE preferred as enum members are constants (cherry picked from commit 542e1df2b018ee7068dba8076f2d6e84efd6e144) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> | 14 September 2020, 20:42:38 UTC |
| b007a9b | Miss Islington (bot) | 14 September 2020, 19:47:40 UTC | bpo-41744: Package python.props with correct name in NuGet package (GH-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility. (cherry picked from commit 7c11a9accabe3720940f334eb1226bb7bb9179c7) Co-authored-by: Václav Slavík <vaclav@slavik.io> | 14 September 2020, 19:47:40 UTC |
| 3c618d0 | Miss Islington (bot) | 14 September 2020, 05:38:20 UTC | bpo-39883: Update macOS installer copy of LICENSE. (GH-22235) (cherry picked from commit 7dbbea75cec27a48b68cc07c23f3f317cacf4a16) Co-authored-by: Ned Deily <nad@python.org> | 14 September 2020, 05:38:20 UTC |
| d09bead | Miss Islington (bot) | 13 September 2020, 21:21:49 UTC | bpo-41778: Change a punctuation on documentation. (GH-22229) (GH-22230) On this paragrapah the clarification about IIS7 seems there's not connection beacuase is in other sentence. Move the punctuation to connect both the last sentence with the information in the parenthesis. I think the NEWS is not necessary here. Automerge-Triggered-By: @ericvsmith (cherry picked from commit 94bfdee25db31941b187591ae5ae9bf3ed431090) Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com> | 13 September 2020, 21:21:49 UTC |
| 38c8d39 | Ethan Furman | 13 September 2020, 20:47:43 UTC | [3.8] bpo-37479: Enum - use correct __format__ (GH-14545) * bpo-37479: on Enum subclasses with mixins, __format__ uses overridden __str__. (cherry picked from commit 2f19e82fbe98ce86bcd98a176328af2808b678e8) Co-authored-by: thatneat <thatneat@users.noreply.github.com> | 13 September 2020, 20:47:43 UTC |
| bf50b0e | Miss Islington (bot) | 13 September 2020, 18:16:39 UTC | bpo-33239: Fix default value of 'buffering' parameter in docs of tempfile.* functions (GH-21763) (GH-22226) (cherry picked from commit b48389d95093c3f912549add8da339edc164bf0d) | 13 September 2020, 18:16:39 UTC |
| 3a150c7 | Miss Islington (bot) | 12 September 2020, 11:04:50 UTC | bpo-41672: Fix type mismatches in imaplib docs (GH-22207) (#22218) (cherry picked from commit c75330605d4795850ec74fdc4d69aa5d92f76c00) Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com> Co-authored-by: Norbert Cyran <cyran.norbert97@gmail.com> | 12 September 2020, 11:04:50 UTC |
| 530d110 | Miss Islington (bot) | 12 September 2020, 07:09:54 UTC | bpo-39651: Fix asyncio proactor _write_to_self() (GH-22197) Fix a race condition in the call_soon_threadsafe() method of asyncio.ProactorEventLoop: do nothing if the self-pipe socket has been closed. (cherry picked from commit 1b0f0e3d7d03155da1cf9769a847874d559e57e3) Co-authored-by: Victor Stinner <vstinner@python.org> | 12 September 2020, 07:09:54 UTC |
| 77901dc | Miss Islington (bot) | 12 September 2020, 06:43:27 UTC | bpo-41731: Make test_cmd_line_script pass with -vv (GH-22206) Argument script_exec_args is usually an absolute file name, but twice has form ['-m', 'module_name']. (cherry picked from commit 7e711ead26fea6465e0ef2e3b8880b57ba8fc129) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 12 September 2020, 06:43:27 UTC |
| bbab340 | Miss Islington (bot) | 12 September 2020, 06:09:08 UTC | bpo-41729: Fix test_winconsole failures (3) and hang (GH-22146) The problems occured with a repository build on machine with freshly updated Windows 10 Pro. (cherry picked from commit 31c9828ec026e5d9b9122d55bf0aa7cb45bfecc5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 12 September 2020, 06:09:08 UTC |
| e4c6947 | Miss Islington (bot) | 11 September 2020, 15:29:04 UTC | [doc] struct: update note about network byte order form to be more helpful (GH-22201) Update the sentence to provide some context on why network byte order is defined as big endian. (cherry picked from commit fb2718720346c8c7a0ad2d7477f20e9a5524ea0c) Co-authored-by: Stargirl Flowers <theaflowers@google.com> | 11 September 2020, 15:29:04 UTC |
| 8a30bdd | Miss Islington (bot) | 10 September 2020, 20:21:35 UTC | bpo-37149: Change Shipman tkinter link from archive.org to TkDocs (GH-22188) (#22193) The new link responds much faster and begins with a short explanation of the status of the doc. (cherry picked from commit 06d0b8b67e8aebd8fe4c34e97d6915c11f4afa30) Co-authored-by: Mark Roseman <mark@markroseman.com> | 10 September 2020, 20:21:35 UTC |
| e3d0e9b | Miss Islington (bot) | 10 September 2020, 06:41:13 UTC | [doc] Remove superfluous comment about equal in f-strings (GH-22006) Automerge-Triggered-By: @kushaldas (cherry picked from commit 788b79fa7b6184221e68d4f1a3fbe0b3270693f6) Co-authored-by: Andre Delfino <adelfino@gmail.com> | 10 September 2020, 06:41:13 UTC |
| 9133b01 | Miss Islington (bot) | 09 September 2020, 23:10:09 UTC | Update idlelib/help.html to current IDLE doc (GH-22181) (cherry picked from commit 471247150e9707e583297ac6b4edff978efd8941) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 09 September 2020, 23:10:09 UTC |
| d423aa8 | Miss Islington (bot) | 09 September 2020, 22:34:20 UTC | Add missing colon to IDLE doc markup (GH-22007) (cherry picked from commit 7a797a3967fdfedbaf49fd1f140ee670d7db40ad) Co-authored-by: Andre Delfino <adelfino@gmail.com> Co-authored-by: Andre Delfino <adelfino@gmail.com> | 09 September 2020, 22:34:20 UTC |
| 4c4c354 | Miss Islington (bot) | 09 September 2020, 18:15:49 UTC | [3.8] [3.9] bpo-41688: Document bug in **= dispatching in the language data… (GH-22172) (GH-22175) (cherry picked from commit 46bc21e1780016aaacd34e472f838dc792fb674c) Co-authored-by: Ammar Askar <ammar@ammaraskar.com> Automerge-Triggered-By: @brettcannon | 09 September 2020, 18:15:49 UTC |
| 778a9b2 | Miss Islington (bot) | 09 September 2020, 13:40:41 UTC | Fixes dead links to Django's logging config docs (GH-20823) (GH-22171) (cherry picked from commit 714217f9561507bbc7218a02089d0e1da0239372) | 09 September 2020, 13:40:41 UTC |
| 23d3681 | Miss Islington (bot) | 09 September 2020, 10:26:32 UTC | Fix compiler warnings in init_dump_ascii_wstr() (GH-22150) Fix GCC 9.3 (using -O3) warnings on x86: initconfig.c: In function ‘init_dump_ascii_wstr’: initconfig.c:2679:34: warning: format ‘%lc’ expects argument of type ‘wint_t’, but argument 2 has type ‘wchar_t’ {aka ‘long int’} 2679 | PySys_WriteStderr("%lc", ch); initconfig.c:2682:38: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’} 2682 | PySys_WriteStderr("\\x%02x", ch); initconfig.c:2686:38: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’} 2686 | PySys_WriteStderr("\\U%08x", ch); initconfig.c:2690:38: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 2 has type ‘wchar_t’ {aka ‘long int’} 2690 | PySys_WriteStderr("\\u%04x", ch); (cherry picked from commit 640e8e1d5f61d5868453d992da04bf4741327748) Co-authored-by: Victor Stinner <vstinner@python.org> | 09 September 2020, 10:26:32 UTC |
| 9171dc2 | Miss Islington (bot) | 09 September 2020, 00:46:41 UTC | bpo-41525: Make the Python program help ASCII-only (GH-21836) (cherry picked from commit 58de1dd6a8677bd213802c19204b827cb7134695) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> | 09 September 2020, 00:46:41 UTC |
| 68bc679 | Miss Islington (bot) | 08 September 2020, 23:57:11 UTC | [3.8] [doc] Fix padding in timeit (GH-22152) (GH-22159) Compare -p and -u options help in rendered output to see the difference. (cherry picked from commit 594f0ce73be807c0fecf958dc0644fa37983f5fe) Co-authored-by: Andre Delfino <adelfino@gmail.com> | 08 September 2020, 23:57:11 UTC |
| 7799dd3 | Mariatta | 08 September 2020, 23:28:02 UTC | [3.8] Fix typo in typing.py (GH-22121) (GH-22158) This is a trivial PR to fix a typo in a docstring in typing.py. From reverences -> references. (cherry picked from commit 84ef33c5117acd9867781135a9aeb62052432e8a) Co-authored-by: Graham Bleaney <gbleaney@gmail.com> Automerge-Triggered-By: @Mariatta | 08 September 2020, 23:28:02 UTC |
| 3cb5073 | Łukasz Langa | 08 September 2020, 09:39:14 UTC | Post 3.8.6rc1 | 08 September 2020, 09:39:14 UTC |
| 7c6dc85 | Łukasz Langa | 08 September 2020, 09:38:51 UTC | Merge tag 'v3.8.6rc1' into 3.8 Python 3.8.6rc1 | 08 September 2020, 09:38:51 UTC |
| ebef6c0 | Miss Islington (bot) | 07 September 2020, 16:28:04 UTC | bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (GH-22092) (cherry picked from commit fd4cafd4700dc03cb05fc2e5263c2666d785d6e3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> | 07 September 2020, 16:28:04 UTC |
| 08bd63d | Łukasz Langa | 07 September 2020, 15:52:19 UTC | Python 3.8.6rc1 | 07 September 2020, 15:52:19 UTC |
| 84105cb | Victor Stinner | 07 September 2020, 15:27:03 UTC | bpo-41401: Fix test_fspath_support in test_io. (GH-21640) (GH-22133) (GH-22135) The error is exposed on non-UTF-8 locales. (cherry picked from commit 67987acd5dc9776f55f4e139e2b3d9e7a6434d9f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit c73ee5acc96b4bbd6885156883b224b8cc3e470c) | 07 September 2020, 15:27:03 UTC |
| 4e581d6 | Miss Islington (bot) | 06 September 2020, 03:47:17 UTC | closes bpo-41723: Fix an error in the py_compile documentation. (GH-22110) (cherry picked from commit 5371a464ce88ffc88f3bb95cfd86f355b7d02953) Co-authored-by: Zackery Spytz <zspytz@gmail.com> | 06 September 2020, 03:47:17 UTC |
| 6ae6195 | Pablo Galindo | 05 September 2020, 16:07:54 UTC | bpo-41654: Explicitly cast PyExc_MemoryError to PyTypeObject to avoid warning (GH-22102) | 05 September 2020, 16:07:54 UTC |
| 4ddb2d7 | Miss Islington (bot) | 04 September 2020, 22:30:21 UTC | [3.8] Improve asyncio-dev 'Concurrency and Multithreading' docs (GH-20882) (GH-22010) I added some information to the `Concurrency and Multithreading` section of the `Developing with asyncio` guide. This is all information that would have helped me when I started using asyncio. I incorrectly assumed that `loop.call_soon_threadsafe()` and `run_coroutine_threadsafe()` could be called from a thread in a process separate from the one that the event loop is running in. Explicitly stating that this will not work will probably help some people starting out with asyncio in the future. I also added references to some other functions that can be used for inter-process communication without blocking the event loop. The section already mentions running blocking code in a ThreadPoolExecutor, but I think listing these other options in this section will also be helpful. (cherry picked from commit c68c5af2dc5ada8875a662f2beaac6234eae2a5a) Co-authored-by: Roger Iyengar <ri@rogeriyengar.com> | 04 September 2020, 22:30:21 UTC |
| e77547b | Miss Islington (bot) | 04 September 2020, 22:26:21 UTC | [3.8] Fix error in argparse documentation example (GH-17399) (GH-21990) Automerge-Triggered-By: @rhettinger (cherry picked from commit 8784d3300ec4ffc58bc0e9ab3cff9a24187dbe4c) Co-authored-by: SarahPythonista <4283226+SarahPythonista@users.noreply.github.com> | 04 September 2020, 22:26:21 UTC |
| 66e9c2a | Miss Islington (bot) | 04 September 2020, 22:26:05 UTC | [3.8] closes bpo-41533: Fix a potential memory leak when allocating a stack (GH-21847) (GH-22015) Free the stack allocated in va_build_stack if do_mkstack fails and the stack is not a small_stack (cherry picked from commit 75c80b0bda89debf312f075716b8c467d411f90e) Co-authored-by: Tony Solomonik <tony.solomonik@gmail.com> | 04 September 2020, 22:26:05 UTC |
| e52f5bc | Miss Islington (bot) | 04 September 2020, 22:25:51 UTC | [3.8] bpo-40486: Specify what happens if directory content change diring iteration (GH-22025) (GH-22094) (cherry picked from commit 306cfb3a37e1438f6ba9f0a9f3af3c00aae4ec64) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> | 04 September 2020, 22:25:51 UTC |
| 1470c91 | Miss Islington (bot) | 04 September 2020, 22:25:04 UTC | bpo-38585: Remove references to defusedexpat (GH-22095) defusedexpat is not maintained. (cherry picked from commit 51b84f8e96a441c498210f827c1297ee4973525f) Co-authored-by: Zackery Spytz <zspytz@gmail.com> | 04 September 2020, 22:25:04 UTC |
| 4bcff52 | Miss Islington (bot) | 04 September 2020, 09:55:44 UTC | bpo-41700: Skip test if the locale is not supported (GH-22081) (GH-22086) (cherry picked from commit 54a66ade2067c373d31003ad260e1b7d14c81564) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> | 04 September 2020, 09:55:44 UTC |
| 40e2444 | Miss Islington (bot) | 03 September 2020, 20:54:36 UTC | bpo-39010: Improve test shutdown (GH-22066) (#22083) Simply closing the event loop isn't enough to avoid warnings. If we don't also shut down the event loop's default executor, it sometimes logs a "dangling thread" warning. Follow-up to GH-22017 (cherry picked from commit be435ae2b064dc64f04475bec632862e1dbf605f) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com> | 03 September 2020, 20:54:36 UTC |
| 1f5f127 | Miss Islington (bot) | 03 September 2020, 20:54:06 UTC | bpo-41696: Fix handling of debug mode in asyncio.run (GH-22069) (#22072) * bpo-41696: Fix handling of debug mode in asyncio.run This allows PYTHONASYNCIODEBUG or -X dev to enable asyncio debug mode when using asyncio.run * 📜🤖 Added by blurb_it. Co-authored-by: hauntsaninja <> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 0770ad948cb6d9f7f6c4002efd83e27c27069808) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> | 03 September 2020, 20:54:06 UTC |
| a986b06 | Miss Islington (bot) | 03 September 2020, 19:38:34 UTC | bpo-39010: Fix errors logged on proactor loop restart (GH-22017) (#22035) Stopping and restarting a proactor event loop on windows can lead to spurious errors logged (ConnectionResetError while reading from the self pipe). This fixes the issue by ensuring that we don't attempt to start multiple copies of the self-pipe reading loop. (cherry picked from commit ea5a6363c3f8cc90b7c0cc573922b10f296073b6) Co-authored-by: Ben Darnell <ben@bendarnell.com> Co-authored-by: Ben Darnell <ben@bendarnell.com> | 03 September 2020, 19:38:34 UTC |
| 9fef7c5 | Miss Islington (bot) | 03 September 2020, 14:41:09 UTC | bpo-39883: Use BSD0 license for code in docs (GH-17635) (GH-22074) The PSF board approved this use. (cherry picked from commit e223d06a8b2067c68e9f97c4628c2b0f056dcae6) Co-authored-by: Todd <toddrjen@gmail.com> | 03 September 2020, 14:41:09 UTC |
| 5d663ed | Miss Islington (bot) | 02 September 2020, 13:29:46 UTC | [doc] Remove references to PyChecker. (GH-22055) (cherry picked from commit dea82b67315a6b873f7d4e558dd00a851137dcbb) Co-authored-by: Andre Delfino <adelfino@gmail.com> | 02 September 2020, 13:29:46 UTC |
| a8b05c4 | Miss Islington (bot) | 02 September 2020, 13:28:59 UTC | Remove reference to Boa Constructor. (GH-22057) (cherry picked from commit 1d25f5bf7b795b47e753aca56d7579d4ad7ee468) Co-authored-by: Andre Delfino <adelfino@gmail.com> | 02 September 2020, 13:28:59 UTC |
| 77f4000 | Pablo Galindo | 01 September 2020, 20:40:48 UTC | [3.8] [3.9] bpo-41654: Fix deallocator of MemoryError to account for subclasses (GH-22020) (GH-22046) When allocating MemoryError classes, there is some logic to use pre-allocated instances in a freelist only if the type that is being allocated is not a subclass of MemoryError. Unfortunately in the destructor this logic is not present so the freelist is altered even with subclasses of MemoryError.. (cherry picked from commit 9b648a95ccb4c3b14f1e87158f5c9f5dbb2f62c0) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>. (cherry picked from commit 87e91ae2e5f81e096c32839f211c68a749a4435a) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com> | 01 September 2020, 20:40:48 UTC |
| 38e3287 | Miss Islington (bot) | 30 August 2020, 19:42:27 UTC | bpo-41344: Raise ValueError when creating shared memory of size 0 (GH-21556) (GH-22019) (cherry picked from commit 475a5fbb5644ea200c990d85d8c264e78ab6c7ea) Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com> Co-authored-by: Vinay Sharma <vinay04sharma@icloud.com> | 30 August 2020, 19:42:27 UTC |
| 85ca9c0 | Miss Islington (bot) | 30 August 2020, 07:20:40 UTC | bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) (GH-22016) | 30 August 2020, 07:20:40 UTC |
| a1473d2 | Miss Islington (bot) | 29 August 2020, 22:33:26 UTC | bpo-41634: Fix a typo in the curses documentation (GH-21958) (cherry picked from commit 398575c210f79627830c5c470184f54ace950ac6) Co-authored-by: Zackery Spytz <zspytz@gmail.com> | 29 August 2020, 22:33:26 UTC |
| 838316d | Karthikeyan Singaravelan | 28 August 2020, 15:03:40 UTC | [3.8] bpo-41624: fix documentation of typing.Coroutine (GH-21952). (#21983) (cherry picked from commit 8c58d2a216ca2b5965361df9b8d8944bc7d4854d) Co-authored-by: MingZhe Hu <humingzhework@163.com> Co-authored-by: MingZhe Hu <humingzhework@163.com> | 28 August 2020, 15:03:40 UTC |
| 641279e | Miss Islington (bot) | 27 August 2020, 01:17:05 UTC | bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) (#21976) (cherry picked from commit 022bc7572f061e1d1132a4db9d085b29707701e7) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com> | 27 August 2020, 01:17:05 UTC |
| 7475aa2 | Miss Islington (bot) | 27 August 2020, 00:47:10 UTC | bpo-33660: Fix PosixPath to resolve a relative path on root (GH-21975) (cherry picked from commit 94ad6c674f7687ef22853cb8d42b440d6b42ddc8) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com> | 27 August 2020, 00:47:10 UTC |
| 57b6988 | Elvis Pranskevichus | 26 August 2020, 20:59:17 UTC | [3.8] bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 (GH-21895) (#21967) When I was fixing bpo-32751 back in GH-7216 I missed the case when *timeout* is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency.. (cherry picked from commit c517fc712105c8e5930cb42baaebdbe37fc3e15f) | 26 August 2020, 20:59:17 UTC |
| 6e1954c | Miss Islington (bot) | 26 August 2020, 18:26:28 UTC | bpo-37658: Fix asyncio.wait_for() to respect waited task status (GH-21894) (#21965) Currently, if `asyncio.wait_for()` itself is cancelled it will always raise `CancelledError` regardless if the underlying task is still running. This is similar to a race with the timeout, which is handled already. (cherry picked from commit a2118a14627256197bddcf4fcecad4c264c1e39d) Co-authored-by: Elvis Pranskevichus <elvis@magic.io> | 26 August 2020, 18:26:28 UTC |
| 0804539 | Miss Islington (bot) | 22 August 2020, 19:15:29 UTC | Document vars behavior when __dict__ is missing (GH-21466) (GH-21941) (cherry picked from commit 802726acf6048338394a6a4750835c2cdd6a947b) Co-authored-by: Andre Delfino <adelfino@gmail.com> | 22 August 2020, 19:15:29 UTC |
| e94d5db | Miss Islington (bot) | 22 August 2020, 09:07:43 UTC | Fix grammar in Doc/tutorial/controlflow.rst (GH-21885) (#21923) Automerge-Triggered-By: @csabella (cherry picked from commit 0be7c216e16f0d459f1c8f6209734c9b2b82fbd4) Co-authored-by: Denis Ovsienko <denis@ovsienko.info> | 22 August 2020, 09:07:43 UTC |
| 0694b82 | Miss Islington (bot) | 22 August 2020, 09:06:14 UTC | bpo-40994: Ungroup items in collections.abc documentation for improved clarity (GH-21880) (#21927) Use a less surprising document structure. Automerge-Triggered-By: @csabella (cherry picked from commit 2ce39631f679e14132a54dc90ce764259d26e166) Co-authored-by: Sydney Pemberton <46042811+sydneypemberton1986@users.noreply.github.com> | 22 August 2020, 09:06:14 UTC |
| 1370d9d | Miss Islington (bot) | 21 August 2020, 12:19:58 UTC | bpo-41572: Fix grammar in BaseTransport.close docstring (GH-21914) (GH-21930) Fix grammar in BaseTransport.close docstring. https://bugs.python.org/issue41572 Signed-off-by: Cleber Rosa <crosa@redhat.com> (cherry picked from commit 1afb42cfa82dad0ddd726f59c6c5fcb3962314db) Co-authored-by: Cleber Rosa <cleber.gnu@gmail.com> | 21 August 2020, 12:19:58 UTC |
| 7d0fef5 | Victor Stinner | 20 August 2020, 11:28:49 UTC | bpo-40204: Allow pre-Sphinx 3 syntax in the doc (GH-21844) (GH-21901) (GH-21928) * bpo-40204: Allow pre-Sphinx 3 syntax in the doc (GH-21844) Enable Sphinx 3.2 "c_allow_pre_v3" option and disable the c_warn_on_allowed_pre_v3 option to make the documentation compatible with Sphinx 2 and Sphinx 3. (cherry picked from commit 423e77d6de497931585d1883805a9e3fa4096b0b) * bpo-40204: Fix Sphinx sytanx in howto/instrumentation.rst (GH-21858) Use generic '.. object::' to declare markers, rather than abusing '.. c:function::' which fails on Sphinx 3. (cherry picked from commit 43577c01a2ab49122db696e9eaec6cb31d11cc81) * bpo-40204: Fix duplicates in the documentation (GH-21857) Fix two Sphinx 3 issues: Doc/c-api/buffer.rst:304: WARNING: Duplicate C declaration, also defined in 'c-api/buffer'. Declaration is 'PyBUF_ND'. Doc/c-api/unicode.rst:1603: WARNING: Duplicate C declaration, also defined in 'c-api/unicode'. Declaration is 'PyObject* PyUnicode_Translate(PyObject *str, PyObject *table, const char *errors)'. (cherry picked from commit 46d10b1237c67ff8347f533eda6a5468d098f7eb) * bpo-40204: Add :noindex: in the documentation (GH-21859) Add :noindex: to duplicated documentation to fix "duplicate object description" errors. For example, fix this Sphinx 3 issue: Doc/library/configparser.rst:1146: WARNING: duplicate object description of configparser.ConfigParser.optionxform, other instance in library/configparser, use :noindex: for one of them (cherry picked from commit d3ded080482beae578faa704b13534a62d066f9f) * bpo-40204, doc: Fix syntax of C variables (GH-21846) For example, fix the following Sphinx 3 errors: Doc/c-api/buffer.rst:102: WARNING: Error in declarator or parameters Invalid C declaration: Expected identifier in nested name. [error at 5] void \*obj -----^ Doc/c-api/arg.rst:130: WARNING: Unparseable C cross-reference: 'PyObject*' Invalid C declaration: Expected end of definition. [error at 8] PyObject* --------^ The modified documentation is compatible with Sphinx 2 and Sphinx 3. (cherry picked from commit 474652fe9346382dbf793f20b671eb74668bebde) * bpo-40204: Fix reference to terms in the doc (GH-21865) Sphinx 3 requires to refer to terms with the exact case. For example, fix the Sphinx 3 warning: Doc/library/pkgutil.rst:71: WARNING: term Loader not found in case sensitive match.made a reference to loader instead. (cherry picked from commit bb0b08540cc93e56f3f1bde1b39ce086d9e35fe1) * bpo-40204: Fix duplicated productionlist names in the doc (GH-21900) Sphinx 3 disallows having more than one productionlist markup with the same name. Simply remove names in this case, since names are not shown anyway. For example, fix the Sphinx 3 warning: Doc/reference/introduction.rst:96: duplicate token description of *:name, other instance in reference/expressions (cherry picked from commit 1abeda80f760134b4233608e2c288790f955b95a) (cherry picked from commit 8f88190af529543c84d5dc78f19abbfd73335cf4) | 20 August 2020, 11:28:49 UTC |
| 34889a5 | Frank Dana | 19 August 2020, 19:34:50 UTC | [3.8] venv: Update Aspen URL in 'activate' script comment (GH-21797) A comment in the venv `activate` script (as well as `activate.csh` and `activate.fish`) referencing Aspen magic directories lists a "further information" URL for Aspen at the zetadev.com website. zetadev.com changed ownership in 2019, and now redirects to a server in China with an expired security certificate. Out of an abundance of caution, while not changing the _code_ for the activate scripts, this PR updates the URL in those comments to reference Aspen's new documentation home at https://aspen.io/. No issue created, as I suspect this falls within the definition of a "trivial" change. Please let me know if I'm wrong about that, and I'll open the necessary issue(s). While filed against the 3.8 branch, strictly speaking this is not a backported PR. The comment in question was entirely removed from the script between Python 3.8 and 3.9. (IMHO this _should_ probably be backported to 3.7 and 3.6, as well. I'll happily file those PRs if needed.) Automerge-Triggered-By: @vsajip | 19 August 2020, 19:34:50 UTC |
| 2bcd0fe | Miss Islington (bot) | 17 August 2020, 15:32:11 UTC | Fix typo in message from assert statement (GH-21283) The error message was missing space between the action "acquire" and "_wait_semaphore" which is an attribute for instances of Condition. (cherry picked from commit 99c0ee3c893bb99fd98a97084fc386ce2911eb64) Co-authored-by: Allen <64019758+aboddie@users.noreply.github.com> | 17 August 2020, 15:32:11 UTC |
| 1baa8b1 | Miss Islington (bot) | 17 August 2020, 14:37:12 UTC | bpo-40782: Change asyncio.AbstractEventLoop.run_in_executor to be a method not a coroutine (GH-21852) asyncio.AbstractEventLoop.run_in_executor should be a method that returns an asyncio Future, not an async method. This matches the concrete implementations, and the documentation better. (cherry picked from commit 29f84294d88ec493c2de9d6e8dbc12fae3778771) Co-authored-by: James Weaver <james.barrett@bbc.co.uk> | 17 August 2020, 14:37:12 UTC |
| 08f0a21 | Miss Islington (bot) | 16 August 2020, 16:27:01 UTC | [3.8] bpo-41503: Fix race between setTarget and flush in logging.handlers.MemoryHandler (GH-21765) (GH-21898) (cherry picked from commit 2353d77fad7ed9d11d8a4d66b5dd1306cdb94125) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com> Automerge-Triggered-By: @vsajip | 16 August 2020, 16:27:01 UTC |
| 2434581 | Miss Islington (bot) | 15 August 2020, 17:42:36 UTC | bpo-31122: ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation (GH-18772) [bpo-31122](): ssl.wrap_socket() now raises ssl.SSLEOFError rather than OSError when peer closes connection during TLS negotiation Reproducer: http://tiny.cc/f4ztnz (tiny url because some bot keeps renaming b.p.o.-nnn as bpo links) (cherry picked from commit 495bd035662fda29639f9d52bb6baebea31d72fa) Co-authored-by: Dima Tisnek <dimaqq@gmail.com> | 15 August 2020, 17:42:36 UTC |
| 0a5b30d | Miss Islington (bot) | 14 August 2020, 23:09:58 UTC | Fix typo in typing doc (GH-21879) Automerge-Triggered-By: @gvanrossum (cherry picked from commit fa5d7251987c70a9c5d58b59a0b36ac9287eaafa) Co-authored-by: Irit Katriel <iritkatriel@yahoo.com> | 14 August 2020, 23:09:58 UTC |
| 2a9f709 | Miss Islington (bot) | 14 August 2020, 01:51:21 UTC | bpo-41410: Fix outdated info in mkstemp docs (GH-21701) Automerge-Triggered-By: @ericvsmith (cherry picked from commit e55de68be3e5b977a17d3c0ac9805b0feff8fedc) Co-authored-by: Rishav Kundu <rk@rishav.io> | 14 August 2020, 01:51:21 UTC |
| e05f20b | Miss Islington (bot) | 13 August 2020, 20:43:47 UTC | Fixed comment about pathlib.link_to: it was added in 3.8, not changed. (GH-21851) (#21866) (cherry picked from commit a3eae43aeedb6e6a31adeab3c0c90961d05ab113) Co-authored-by: Facundo Batista <facundo@taniquetil.com.ar> | 13 August 2020, 20:43:47 UTC |
| 43b3e4c | Antoine Pitrou | 13 August 2020, 20:03:18 UTC | [3.8] bpo-41066: Update the comparison section for os vs pathlib (GH-21261) (GH-21864) (cherry picked from commit 0eb9deb4a62e6d9daa82bc2f67d1075864ca8ece) Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com> Automerge-Triggered-By: @pitrou | 13 August 2020, 20:03:18 UTC |
| a3416c1 | Miss Islington (bot) | 13 August 2020, 18:38:55 UTC | [3.9] bpo-41520: Fix second codeop regression (GH-21848) Fix the repression introduced by the initial regression fix. (cherry picked from commit c818b15fa59039de67022c29085d439fa5d3ef95) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit f24430f1542ea2768793b48704ae2d4e241892ae) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 13 August 2020, 18:38:55 UTC |
| afff51f | Miss Islington (bot) | 12 August 2020, 13:12:05 UTC | bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838) (cherry picked from commit 369a1cbdee14d9f27356fb3a8bb21e4fde289d25) Co-authored-by: Victor Stinner <vstinner@python.org> | 12 August 2020, 13:12:05 UTC |
| 622d90f | Miss Islington (bot) | 12 August 2020, 10:38:37 UTC | bpo-41475: Fix note in "What's new in 3.7" (GH-21733) (GH-21833) (cherry picked from commit 76643c10ede2813ca921464fe839e81caee21a84) Co-authored-by: Ram Rachum <ram@rachum.com> | 12 August 2020, 10:38:37 UTC |
| 7b3ceaa | Miss Islington (bot) | 11 August 2020, 14:45:25 UTC | [3.8] bpo-41504: Add links to asttokens, leoAst, LibCST and parso to ast docs (GH-21773) (GH-21829) (cherry picked from commit e3c971ccfa58afcb2656b71b95e10b9703f2ad32) Co-authored-by: Edward K. Ream <edreamleo@gmail.com> https://bugs.python.org/issue41504 | 11 August 2020, 14:45:25 UTC |
| 09d8260 | Miss Islington (bot) | 10 August 2020, 17:06:11 UTC | bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806) On Git 2.28, "git diff master..." (3 dots) no longer works when "fetch --depth=1" is used, whereas it works on Git 2.26. Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command computing the list of modified files between the base branch and the PR branch. (cherry picked from commit eaa551702d80fd67219c48ee6a13ffb571ca360b) Co-authored-by: Victor Stinner <vstinner@python.org> | 10 August 2020, 17:06:11 UTC |
| 860bc0e | Miss Islington (bot) | 10 August 2020, 14:01:14 UTC | bpo-41514: Fix buggy IDLE test (GH-21808) test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot. (cherry picked from commit 416f0b71ba84fe83ee2ba4399b8a28712702980b) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 10 August 2020, 14:01:14 UTC |
| 61f23cb | Miss Islington (bot) | 09 August 2020, 20:26:37 UTC | bpo-41468: Improve and test IDLE run error exit (GH-21798) A message box pops up when an unexpected error stops the run process. Tell users it is likely a random glitch, but report it if not. (cherry picked from commit f2e161c27964a59bc5ab20d96f87ba5862c6222d) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 09 August 2020, 20:26:37 UTC |
| f421865 | Miss Islington (bot) | 09 August 2020, 18:54:33 UTC | [3.8] Doc: Add output to example code in programming FAQ (GH-21346) (GH-21791) Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.htmlGH-how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block. (cherry picked from commit 67acf74c4eaf64a860cc1bcda6efe6e9cb01f89b) Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com> Automerge-Triggered-By: @merwok | 09 August 2020, 18:54:33 UTC |
| 6925523 | Miss Islington (bot) | 09 August 2020, 17:35:59 UTC | Improve renamed test_run.RecursionLimitTest (GH-21794) PEP 8 style and new comments. (cherry picked from commit 8b67bf907c51846853127176cbb2982d102a2c2d) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> | 09 August 2020, 17:35:59 UTC |
| 105cfb5 | Miss Islington (bot) | 08 August 2020, 18:55:45 UTC | bpo-41455: Provide a link to how the third generation is collected in the GC docs (GH-21703) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com> (cherry picked from commit 82ca8fada15b121866530f2cdac1b7055be4a244) Co-authored-by: Yaroslav Pankovych <31005942+P-Alban@users.noreply.github.com> | 08 August 2020, 18:55:45 UTC |
| 66c8996 | Miss Islington (bot) | 08 August 2020, 03:21:33 UTC | bpo-41497: Fix potential UnicodeDecodeError in dis CLI (GH-21757) (cherry picked from commit a4084b9d1e40c1c9259372263d1fe8c8a562b093) Co-authored-by: Konge <zkonge@outlook.com> | 08 August 2020, 03:21:33 UTC |
| de5de41 | Miss Islington (bot) | 08 August 2020, 03:05:04 UTC | Doc: Add a link to tutorial page from `open()` doc (GH-21737) Adds a link to the "Reading and Writing Files" page so users can more easily discover how file handles are handled with the `with` context manager vs without it. (cherry picked from commit 705f14556545699ab615ec98f707b438f9603767) Co-authored-by: Benjamin Kane <bbkane@users.noreply.github.com> | 08 August 2020, 03:05:04 UTC |
| 398dabb | Miss Islington (bot) | 07 August 2020, 23:01:37 UTC | Update Azure Pipelines build to use Ubuntu 18.04 and move triggers into YAML files (GH-21776) (cherry picked from commit 102b4988b1a10d5a61034381aea15521d17c210c) Co-authored-by: Steve Dower <steve.dower@python.org> | 07 August 2020, 23:01:37 UTC |
| 135de08 | Steve Dower | 07 August 2020, 22:10:32 UTC | bpo-41490: Update ensurepip to install pip 20.2.1 and setuptools 49.2.1 (GH-21775) | 07 August 2020, 22:10:32 UTC |
| 87bc220 | Miss Islington (bot) | 07 August 2020, 16:15:37 UTC | bpo-41473: Skip test_gdb with gdb 9.2 to work around gdb bug (GH-21768) gdb 9.2 on Fedora Rawhide is not reliable, see: * https://bugs.python.org/issue41473 * https://bugzilla.redhat.com/show_bug.cgi?id=1866884 (cherry picked from commit e27a51c11e10d5df79b3e48dc3e7bfedfad5a794) Co-authored-by: Victor Stinner <vstinner@python.org> | 07 August 2020, 16:15:37 UTC |
| dc98a54 | Miss Islington (bot) | 07 August 2020, 07:49:46 UTC | bpo-41098: Doc: Add missing deprecated directives (GH-21162) PyUnicodeEncodeError_Create has been deprecated with `Py_DEPRECATED` macro. But it was not documented. (cherry picked from commit 46e19b61d31ba99f049258efa4ff1334856a3643) Co-authored-by: Inada Naoki <songofacandy@gmail.com> | 07 August 2020, 07:49:46 UTC |
| 713ba03 | Miss Islington (bot) | 06 August 2020, 16:52:57 UTC | bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754) (cherry picked from commit 777b611c8c5676b80898a429f71d28e59bddc49d) Co-authored-by: Steve Dower <steve.dower@python.org> | 06 August 2020, 16:52:57 UTC |
| b5789a7 | Miss Islington (bot) | 05 August 2020, 21:43:16 UTC | bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736) (cherry picked from commit 52f98424a55e14f05dfa7483cc0faf634a61c9ff) Co-authored-by: Eric L. Frederich <eric.frederich@gmail.com> | 05 August 2020, 21:43:16 UTC |
| b24c9d2 | Batuhan Taskaya | 05 August 2020, 18:37:19 UTC | [3.8] bpo-40726: handle uninitalized end_lineno on ast.increment_lineno (GH-21745) …no (GH-20312). (cherry picked from commit 8f4380d2f5839a321475104765221a7394a9d649) Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com> Automerge-Triggered-By: @pablogsal | 05 August 2020, 18:37:19 UTC |
