https://github.com/torvalds/linux
Revision 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC, committed by David S. Miller on 07 May 2020, 00:31:54 UTC
When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.
With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.
Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6572215
Tip revision: 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC
net: dsa: Do not leave DSA master with NULL netdev_ops
net: dsa: Do not leave DSA master with NULL netdev_ops
Tip revision: 050569f
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 551 bytes |
| Makefile | -rw-r--r-- | 365 bytes |
| attributes.c | -rw-r--r-- | 8.7 KB |
| bfind.c | -rw-r--r-- | 6.1 KB |
| bitmap.c | -rw-r--r-- | 5.0 KB |
| bnode.c | -rw-r--r-- | 15.3 KB |
| brec.c | -rw-r--r-- | 13.6 KB |
| btree.c | -rw-r--r-- | 12.2 KB |
| catalog.c | -rw-r--r-- | 14.1 KB |
| dir.c | -rw-r--r-- | 13.8 KB |
| extents.c | -rw-r--r-- | 15.5 KB |
| hfsplus_fs.h | -rw-r--r-- | 16.8 KB |
| hfsplus_raw.h | -rw-r--r-- | 9.5 KB |
| inode.c | -rw-r--r-- | 17.1 KB |
| ioctl.c | -rw-r--r-- | 3.7 KB |
| options.c | -rw-r--r-- | 5.3 KB |
| part_tbl.c | -rw-r--r-- | 4.2 KB |
| super.c | -rw-r--r-- | 17.9 KB |
| tables.c | -rw-r--r-- | 119.1 KB |
| unicode.c | -rw-r--r-- | 10.5 KB |
| wrapper.c | -rw-r--r-- | 7.0 KB |
| xattr.c | -rw-r--r-- | 23.3 KB |
| xattr.h | -rw-r--r-- | 1.2 KB |
| xattr_security.c | -rw-r--r-- | 2.0 KB |
| xattr_trusted.c | -rw-r--r-- | 1017 bytes |
| xattr_user.c | -rw-r--r-- | 963 bytes |
Computing file changes ...
