https://github.com/torvalds/linux
Revision 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC, committed by David S. Miller on 07 May 2020, 00:31:54 UTC
When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.
With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.
Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6572215
Tip revision: 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC
net: dsa: Do not leave DSA master with NULL netdev_ops
net: dsa: Do not leave DSA master with NULL netdev_ops
Tip revision: 050569f
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| crypto | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efivarfs | ||
| efs | ||
| erofs | ||
| exfat | ||
| exportfs | ||
| ext2 | ||
| ext4 | ||
| f2fs | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hugetlbfs | ||
| iomap | ||
| isofs | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| kernfs | ||
| lockd | ||
| minix | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| orangefs | ||
| overlayfs | ||
| proc | ||
| pstore | ||
| qnx4 | ||
| qnx6 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| tracefs | ||
| ubifs | ||
| udf | ||
| ufs | ||
| unicode | ||
| vboxsf | ||
| verity | ||
| xfs | ||
| zonefs | ||
| Kconfig | -rw-r--r-- | 7.7 KB |
| Kconfig.binfmt | -rw-r--r-- | 7.6 KB |
| Makefile | -rw-r--r-- | 4.5 KB |
| aio.c | -rw-r--r-- | 56.4 KB |
| anon_inodes.c | -rw-r--r-- | 4.6 KB |
| attr.c | -rw-r--r-- | 9.7 KB |
| bad_inode.c | -rw-r--r-- | 5.3 KB |
| binfmt_aout.c | -rw-r--r-- | 8.3 KB |
| binfmt_elf.c | -rw-r--r-- | 62.8 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.2 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 28.0 KB |
| binfmt_misc.c | -rw-r--r-- | 18.5 KB |
| binfmt_script.c | -rw-r--r-- | 4.4 KB |
| block_dev.c | -rw-r--r-- | 57.4 KB |
| buffer.c | -rw-r--r-- | 89.6 KB |
| char_dev.c | -rw-r--r-- | 16.5 KB |
| compat.c | -rw-r--r-- | 3.2 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.3 KB |
| coredump.c | -rw-r--r-- | 22.1 KB |
| d_path.c | -rw-r--r-- | 11.3 KB |
| dax.c | -rw-r--r-- | 45.7 KB |
| dcache.c | -rw-r--r-- | 84.0 KB |
| dcookies.c | -rw-r--r-- | 7.1 KB |
| direct-io.c | -rw-r--r-- | 40.1 KB |
| drop_caches.c | -rw-r--r-- | 1.8 KB |
| eventfd.c | -rw-r--r-- | 11.6 KB |
| eventpoll.c | -rw-r--r-- | 65.3 KB |
| exec.c | -rw-r--r-- | 48.2 KB |
| fcntl.c | -rw-r--r-- | 23.3 KB |
| fhandle.c | -rw-r--r-- | 6.8 KB |
| file.c | -rw-r--r-- | 24.7 KB |
| file_table.c | -rw-r--r-- | 10.2 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 74.6 KB |
| fs_context.c | -rw-r--r-- | 17.7 KB |
| fs_parser.c | -rw-r--r-- | 10.1 KB |
| fs_pin.c | -rw-r--r-- | 1.9 KB |
| fs_struct.c | -rw-r--r-- | 3.3 KB |
| fs_types.c | -rw-r--r-- | 2.5 KB |
| fsopen.c | -rw-r--r-- | 11.0 KB |
| inode.c | -rw-r--r-- | 60.4 KB |
| internal.h | -rw-r--r-- | 5.0 KB |
| io-wq.c | -rw-r--r-- | 26.9 KB |
| io-wq.h | -rw-r--r-- | 3.7 KB |
| io_uring.c | -rw-r--r-- | 190.7 KB |
| ioctl.c | -rw-r--r-- | 21.3 KB |
| libfs.c | -rw-r--r-- | 34.7 KB |
| locks.c | -rw-r--r-- | 79.7 KB |
| mbcache.c | -rw-r--r-- | 12.0 KB |
| mount.h | -rw-r--r-- | 4.0 KB |
| mpage.c | -rw-r--r-- | 21.1 KB |
| namei.c | -rw-r--r-- | 119.6 KB |
| namespace.c | -rw-r--r-- | 96.8 KB |
| no-block.c | -rw-r--r-- | 478 bytes |
| nsfs.c | -rw-r--r-- | 6.5 KB |
| open.c | -rw-r--r-- | 32.2 KB |
| pipe.c | -rw-r--r-- | 32.6 KB |
| pnode.c | -rw-r--r-- | 15.1 KB |
| pnode.h | -rw-r--r-- | 1.9 KB |
| posix_acl.c | -rw-r--r-- | 21.5 KB |
| proc_namespace.c | -rw-r--r-- | 7.8 KB |
| read_write.c | -rw-r--r-- | 52.7 KB |
| readdir.c | -rw-r--r-- | 13.6 KB |
| select.c | -rw-r--r-- | 34.3 KB |
| seq_file.c | -rw-r--r-- | 23.9 KB |
| signalfd.c | -rw-r--r-- | 9.0 KB |
| splice.c | -rw-r--r-- | 41.1 KB |
| stack.c | -rw-r--r-- | 2.5 KB |
| stat.c | -rw-r--r-- | 19.6 KB |
| statfs.c | -rw-r--r-- | 9.6 KB |
| super.c | -rw-r--r-- | 48.0 KB |
| sync.c | -rw-r--r-- | 10.4 KB |
| timerfd.c | -rw-r--r-- | 13.6 KB |
| userfaultfd.c | -rw-r--r-- | 52.7 KB |
| utimes.c | -rw-r--r-- | 7.3 KB |
| xattr.c | -rw-r--r-- | 23.7 KB |
Computing file changes ...
