Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC, committed by David S. Miller on 07 May 2020, 00:31:54 UTC 
net: dsa: Do not leave DSA master with NULL netdev_ops
 
When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.

With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.

Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6572215
History
Tip revision: 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC
net: dsa: Do not leave DSA master with NULL netdev_ops
Tip revision: 050569f
File Mode Size
Kconfig -rw-r--r-- 1.7 KB
Makefile -rw-r--r-- 307 bytes
compress.c -rw-r--r-- 9.9 KB
dir.c -rw-r--r-- 6.5 KB
export.c -rw-r--r-- 5.2 KB
inode.c -rw-r--r-- 40.8 KB
isofs.h -rw-r--r-- 6.4 KB
joliet.c -rw-r--r-- 1.4 KB
namei.c -rw-r--r-- 4.2 KB
rock.c -rw-r--r-- 18.5 KB
rock.h -rw-r--r-- 2.3 KB
util.c -rw-r--r-- 2.2 KB
zisofs.h -rw-r--r-- 508 bytes
back to top