https://github.com/torvalds/linux
Revision 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC, committed by David S. Miller on 07 May 2020, 00:31:54 UTC
When ndo_get_phys_port_name() for the CPU port was added we introduced
an early check for when the DSA master network device in
dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When
we perform the teardown operation in dsa_master_ndo_teardown() we would
not be checking that cpu_dp->orig_ndo_ops was successfully allocated and
non-NULL initialized.
With network device drivers such as virtio_net, this leads to a NPD as
soon as the DSA switch hanging off of it gets torn down because we are
now assigning the virtio_net device's netdev_ops a NULL pointer.
Fixes: da7b9e9b00d4 ("net: dsa: Add ndo_get_phys_port_name() for CPU port")
Reported-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Allen Pais <allen.pais@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6572215
Tip revision: 050569fc8384c8056bacefcc246bcb2dfe574936 authored by Florian Fainelli on 04 May 2020, 20:18:06 UTC
net: dsa: Do not leave DSA master with NULL netdev_ops
net: dsa: Do not leave DSA master with NULL netdev_ops
Tip revision: 050569f
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 5.5 KB |
| LICENCE | -rw-r--r-- | 1.4 KB |
| Makefile | -rw-r--r-- | 786 bytes |
| README.Locking | -rw-r--r-- | 6.9 KB |
| TODO | -rw-r--r-- | 1.9 KB |
| acl.c | -rw-r--r-- | 6.7 KB |
| acl.h | -rw-r--r-- | 966 bytes |
| background.c | -rw-r--r-- | 4.2 KB |
| build.c | -rw-r--r-- | 12.6 KB |
| compr.c | -rw-r--r-- | 11.6 KB |
| compr.h | -rw-r--r-- | 3.1 KB |
| compr_lzo.c | -rw-r--r-- | 2.2 KB |
| compr_rtime.c | -rw-r--r-- | 2.8 KB |
| compr_rubin.c | -rw-r--r-- | 8.7 KB |
| compr_zlib.c | -rw-r--r-- | 5.5 KB |
| debug.c | -rw-r--r-- | 25.6 KB |
| debug.h | -rw-r--r-- | 7.9 KB |
| dir.c | -rw-r--r-- | 22.6 KB |
| erase.c | -rw-r--r-- | 13.4 KB |
| file.c | -rw-r--r-- | 9.1 KB |
| fs.c | -rw-r--r-- | 19.3 KB |
| gc.c | -rw-r--r-- | 44.0 KB |
| ioctl.c | -rw-r--r-- | 557 bytes |
| jffs2_fs_i.h | -rw-r--r-- | 1.6 KB |
| jffs2_fs_sb.h | -rw-r--r-- | 5.7 KB |
| malloc.c | -rw-r--r-- | 7.3 KB |
| nodelist.c | -rw-r--r-- | 21.3 KB |
| nodelist.h | -rw-r--r-- | 17.9 KB |
| nodemgmt.c | -rw-r--r-- | 28.4 KB |
| os-linux.h | -rw-r--r-- | 7.4 KB |
| read.c | -rw-r--r-- | 6.7 KB |
| readinode.c | -rw-r--r-- | 42.8 KB |
| scan.c | -rw-r--r-- | 35.3 KB |
| security.c | -rw-r--r-- | 1.9 KB |
| summary.c | -rw-r--r-- | 23.6 KB |
| summary.h | -rw-r--r-- | 6.3 KB |
| super.c | -rw-r--r-- | 10.0 KB |
| symlink.c | -rw-r--r-- | 417 bytes |
| wbuf.c | -rw-r--r-- | 36.9 KB |
| write.c | -rw-r--r-- | 21.0 KB |
| writev.c | -rw-r--r-- | 1.1 KB |
| xattr.c | -rw-r--r-- | 38.3 KB |
| xattr.h | -rw-r--r-- | 4.1 KB |
| xattr_trusted.c | -rw-r--r-- | 1.2 KB |
| xattr_user.c | -rw-r--r-- | 1.1 KB |
Computing file changes ...
