Revision 093b0b3d5d041c16ef342790acaf3e9c1b5e01e6 authored by Hayato Ito on 28 March 2018, 12:08:08 UTC, committed by Chromium WPT Sync on 28 March 2018, 12:08:08 UTC
For the purpose of rendering, Blink must calculate all pending slot assignments
before UpdateStyle phase. Unless that, a recursive RecalcStyle() may not
traverse a node which should be re-attached.

e.g. Suppose the following tree, where #d1 is assigned to a slot.

host
├──/shadow-root
│   └── slot name=s1
└── div id=d1 slot=s1

Then, we change #d1's slot attribute to s2, like:

> document.querySelector('#d1').setAttribute('slot', 's2');

host
├──/shadow-root
│   └── slot name=s1
└── div id=d1 slot=s2

In this case, #d1 should be removed from a LayoutTree. In other words, Blink
has to reattach #d1 somehow. However, if we don't recalc a slot assignment for
the shadow tree before UpdateStyle, a recursive RecalcStyle never traverses the
sub-tree because child-needs-style-recalc flag is not set for the node (and its
ancestor nodes). A flag should be set as a result of slot assignment recalc.

Thanks to the Incremental Shadow DOM, a slot assignemt recalc now becomes a
local operatoin on each shadow tree, rather than one global operation for every
shadow trees. We don't need to traverse a composed tree to recalc all. We can
recalc a slot assignment for each shadow tree directly, without traversing a
composed tree.

For a shadow tree which is not connected, we don't need to recalc its slot
assignment before UpdateStyle because such a shadow tree shouldn't have any
effect on rendering. Lazy slot assignment recalc is enough for such a shadow
tree.

This CL doesn't introduce any optimization to minimize the number of
to-be-reattached nodes. I'll optimize that as a next task. I'll use a sort of
dynamic programming there, as I did at
https://chromium-review.googlesource.com/c/chromium/src/+/535493 for
non-Incremental Shadow DOM.

Except for the performance, this CL should be the last part of Incremental
Shadow DOM from the external behavior's perspective. Style and Layout should
work correctly after this CL, even with Incremental Shadow DOM.

BUG=776656

Change-Id: Id18e87ff59d92863c68c571e7db09253c08aa91f
Reviewed-on: https://chromium-review.googlesource.com/964062
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546458}
1 parent 6fca0b2
History
File Mode Size
resources
OWNERS -rw-r--r-- 65 bytes
README.md -rw-r--r-- 171 bytes
document-domain.html -rw-r--r-- 508 bytes
eventTestHarness.js -rw-r--r-- 1.7 KB
event_basic.html -rw-r--r-- 373 bytes
event_basic.js -rw-r--r-- 3.5 KB
event_body_attribute.html -rw-r--r-- 397 bytes
event_body_attribute.js -rw-r--r-- 3.9 KB
event_case_sensitive.html -rw-r--r-- 391 bytes
event_case_sensitive.js -rw-r--r-- 1.3 KB
event_constructor.html -rw-r--r-- 1.1 KB
event_constructor_eventinit.html -rw-r--r-- 1.2 KB
event_local_key.html -rw-r--r-- 1.2 KB
event_local_newvalue.html -rw-r--r-- 1.3 KB
event_local_oldvalue.html -rw-r--r-- 1.3 KB
event_local_removeitem.html -rw-r--r-- 1.7 KB
event_local_storagearea.html -rw-r--r-- 1.3 KB
event_local_storageeventinit.html -rw-r--r-- 1.2 KB
event_local_url.html -rw-r--r-- 1.4 KB
event_no_duplicates.html -rw-r--r-- 3.6 KB
event_session_key.html -rw-r--r-- 1.2 KB
event_session_newvalue.html -rw-r--r-- 1.3 KB
event_session_oldvalue.html -rw-r--r-- 1.3 KB
event_session_removeitem.html -rw-r--r-- 1.7 KB
event_session_storagearea.html -rw-r--r-- 1.4 KB
event_session_storageeventinit.html -rw-r--r-- 1.2 KB
event_session_url.html -rw-r--r-- 1.4 KB
event_setattribute.html -rw-r--r-- 385 bytes
event_setattribute.js -rw-r--r-- 3.9 KB
idlharness.html -rw-r--r-- 1.9 KB
missing_arguments.html -rw-r--r-- 1.1 KB
storage_builtins.html -rw-r--r-- 1.0 KB
storage_clear.html -rw-r--r-- 827 bytes
storage_enumerate.html -rw-r--r-- 2.4 KB
storage_functions_not_overwritten.html -rw-r--r-- 1.7 KB
storage_getitem.html -rw-r--r-- 2.0 KB
storage_in.html -rw-r--r-- 950 bytes
storage_indexing.html -rw-r--r-- 1.3 KB
storage_key.html -rw-r--r-- 1.9 KB
storage_key_empty_string.html -rw-r--r-- 604 bytes
storage_length.html -rw-r--r-- 934 bytes
storage_local-manual.html -rw-r--r-- 1.2 KB
storage_local_setitem_quotaexceedederr.html -rw-r--r-- 904 bytes
storage_local_window_open.html -rw-r--r-- 889 bytes
storage_removeitem.html -rw-r--r-- 1.6 KB
storage_session-manual.html -rw-r--r-- 1.2 KB
storage_session_setitem_quotaexceedederr.html -rw-r--r-- 914 bytes
storage_session_window_noopener.html -rw-r--r-- 1.1 KB
storage_session_window_open.html -rw-r--r-- 890 bytes
storage_set_value_enumerate.html -rw-r--r-- 887 bytes
storage_setitem.html -rw-r--r-- 7.5 KB
storage_string_conversion.html -rw-r--r-- 1.2 KB
storage_supported_property_names.html -rw-r--r-- 848 bytes

README.md

back to top