Revision 0b06af91463d5b6068ad794ac7307075440f8e4b authored by Peter Dillinger on 01 December 2020, 18:15:36 UTC, committed by Facebook GitHub Bot on 01 December 2020, 18:17:56 UTC
Summary: TSAN reports that our stack trace handler makes unsafe calls during a signal handler. I just tried fixing some of them and I don't think it's fixable unless we can get away from using FILE stdio. Even if we can use lower level functions only, I'm not sure it's fixed. I also tried suppressing the reports with function and file level TSAN suppression, but that doesn't seem to work, perhaps because the violation is reported on the callee, not the caller. So I added a warning to be printed whenever these violations would be reported that they are practically ignorable. Internal ref: T77844138 Pull Request resolved: https://github.com/facebook/rocksdb/pull/7723 Test Plan: run external_sst_file_test with seeded abort(), with TSAN (TSAN warnings + new warning) and without TSAN (no warning, just stack trace). Reviewed By: akankshamahajan15 Differential Revision: D25228011 Pulled By: pdillinger fbshipit-source-id: 3eda1d6e7ca3cdc64076cf99ae954168837d2818
1 parent eb65d67
| File | Mode | Size |
|---|---|---|
| delete_scheduler.cc | -rw-r--r-- | 13.0 KB |
| delete_scheduler.h | -rw-r--r-- | 5.1 KB |
| delete_scheduler_test.cc | -rw-r--r-- | 26.6 KB |
| file_prefetch_buffer.cc | -rw-r--r-- | 5.7 KB |
| file_prefetch_buffer.h | -rw-r--r-- | 4.2 KB |
| file_util.cc | -rw-r--r-- | 8.5 KB |
| file_util.h | -rw-r--r-- | 2.6 KB |
| filename.cc | -rw-r--r-- | 14.3 KB |
| filename.h | -rw-r--r-- | 7.3 KB |
| prefetch_test.cc | -rw-r--r-- | 5.9 KB |
| random_access_file_reader.cc | -rw-r--r-- | 10.7 KB |
| random_access_file_reader.h | -rw-r--r-- | 5.1 KB |
| random_access_file_reader_test.cc | -rw-r--r-- | 11.7 KB |
| read_write_util.cc | -rw-r--r-- | 2.2 KB |
| read_write_util.h | -rw-r--r-- | 1.3 KB |
| readahead_raf.cc | -rw-r--r-- | 6.0 KB |
| readahead_raf.h | -rw-r--r-- | 1.2 KB |
| sequence_file_reader.cc | -rw-r--r-- | 8.5 KB |
| sequence_file_reader.h | -rw-r--r-- | 2.3 KB |
| sst_file_manager_impl.cc | -rw-r--r-- | 19.4 KB |
| sst_file_manager_impl.h | -rw-r--r-- | 7.8 KB |
| writable_file_writer.cc | -rw-r--r-- | 15.6 KB |
| writable_file_writer.h | -rw-r--r-- | 8.3 KB |
Computing file changes ...
