https://github.com/torvalds/linux
Revision 0c36b390a546055b6815d4b93a2c9fed4d980ffb authored by Sebastian Ott on 04 June 2014, 13:58:24 UTC, committed by Tejun Heo on 04 June 2014, 16:12:29 UTC
The percpu-refcount infrastructure uses the underscore variants of this_cpu_ops in order to modify percpu reference counters. (e.g. __this_cpu_inc()). However the underscore variants do not atomically update the percpu variable, instead they may be implemented using read-modify-write semantics (more than one instruction). Therefore it is only safe to use the underscore variant if the context is always the same (process, softirq, or hardirq). Otherwise it is possible to lose updates. This problem is something that Sebastian has seen within the aio subsystem which uses percpu refcounters both in process and softirq context leading to reference counts that never dropped to zeroes; even though the number of "get" and "put" calls matched. Fix this by using the non-underscore this_cpu_ops variant which provides correct per cpu atomic semantics and fixes the corrupted reference counts. Cc: Kent Overstreet <kmo@daterainc.com> Cc: <stable@vger.kernel.org> # v3.11+ Reported-by: Sebastian Ott <sebott@linux.vnet.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Tejun Heo <tj@kernel.org> References: http://lkml.kernel.org/g/alpine.LFD.2.11.1406041540520.21183@denkbrett
1 parent 5a838c3
Tip revision: 0c36b390a546055b6815d4b93a2c9fed4d980ffb authored by Sebastian Ott on 04 June 2014, 13:58:24 UTC
percpu-refcount: fix usage of this_cpu_ops
percpu-refcount: fix usage of this_cpu_ops
Tip revision: 0c36b39
File | Mode | Size |
---|---|---|
basic | ||
coccinelle | ||
dtc | ||
genksyms | ||
kconfig | ||
ksymoops | ||
mod | ||
package | ||
rt-tester | ||
selinux | ||
tracing | ||
.gitignore | -rw-r--r-- | 122 bytes |
Kbuild.include | -rw-r--r-- | 10.4 KB |
Lindent | -rwxr-xr-x | 460 bytes |
Makefile | -rw-r--r-- | 1.4 KB |
Makefile.asm-generic | -rw-r--r-- | 684 bytes |
Makefile.build | -rw-r--r-- | 15.6 KB |
Makefile.clean | -rw-r--r-- | 3.2 KB |
Makefile.fwinst | -rw-r--r-- | 2.0 KB |
Makefile.headersinst | -rw-r--r-- | 4.7 KB |
Makefile.help | -rw-r--r-- | 68 bytes |
Makefile.host | -rw-r--r-- | 6.5 KB |
Makefile.lib | -rw-r--r-- | 13.8 KB |
Makefile.modbuiltin | -rw-r--r-- | 1.8 KB |
Makefile.modinst | -rw-r--r-- | 1.2 KB |
Makefile.modpost | -rw-r--r-- | 5.2 KB |
Makefile.modsign | -rw-r--r-- | 1003 bytes |
analyze_suspend.py | -rwxr-xr-x | 47.9 KB |
asn1_compiler.c | -rw-r--r-- | 33.8 KB |
bin2c.c | -rw-r--r-- | 702 bytes |
bloat-o-meter | -rwxr-xr-x | 1.8 KB |
bootgraph.pl | -rw-r--r-- | 6.3 KB |
checkincludes.pl | -rwxr-xr-x | 1.8 KB |
checkkconfigsymbols.sh | -rwxr-xr-x | 1.8 KB |
checkpatch.pl | -rwxr-xr-x | 130.3 KB |
checkstack.pl | -rwxr-xr-x | 5.3 KB |
checksyscalls.sh | -rwxr-xr-x | 5.5 KB |
checkversion.pl | -rwxr-xr-x | 1.9 KB |
cleanfile | -rwxr-xr-x | 3.4 KB |
cleanpatch | -rwxr-xr-x | 5.0 KB |
coccicheck | -rwxr-xr-x | 4.6 KB |
config | -rwxr-xr-x | 4.5 KB |
conmakehash.c | -rw-r--r-- | 6.0 KB |
decodecode | -rwxr-xr-x | 2.1 KB |
depmod.sh | -rwxr-xr-x | 1.7 KB |
diffconfig | -rwxr-xr-x | 3.7 KB |
docproc.c | -rw-r--r-- | 14.2 KB |
export_report.pl | -rw-r--r-- | 4.5 KB |
extract-ikconfig | -rwxr-xr-x | 1.6 KB |
extract-vmlinux | -rwxr-xr-x | 1.6 KB |
gcc-goto.sh | -rw-r--r-- | 495 bytes |
gcc-ld | -rw-r--r-- | 676 bytes |
gcc-version.sh | -rw-r--r-- | 822 bytes |
gcc-x86_32-has-stack-protector.sh | -rw-r--r-- | 184 bytes |
gcc-x86_64-has-stack-protector.sh | -rw-r--r-- | 200 bytes |
gen_initramfs_list.sh | -rw-r--r-- | 7.9 KB |
get_maintainer.pl | -rwxr-xr-x | 56.8 KB |
gfp-translate | -rwxr-xr-x | 1.7 KB |
headerdep.pl | -rwxr-xr-x | 3.5 KB |
headers.sh | -rwxr-xr-x | 530 bytes |
headers_check.pl | -rw-r--r-- | 3.6 KB |
headers_install.sh | -rw-r--r-- | 1.3 KB |
kallsyms.c | -rw-r--r-- | 16.5 KB |
kernel-doc | -rwxr-xr-x | 71.6 KB |
ld-version.sh | -rwxr-xr-x | 205 bytes |
link-vmlinux.sh | -rw-r--r-- | 5.7 KB |
makelst | -rwxr-xr-x | 773 bytes |
markup_oops.pl | -rw-r--r-- | 8.1 KB |
mkcompile_h | -rwxr-xr-x | 2.5 KB |
mkmakefile | -rw-r--r-- | 1.2 KB |
mksysmap | -rw-r--r-- | 1.3 KB |
mkuboot.sh | -rwxr-xr-x | 379 bytes |
mkversion | -rw-r--r-- | 74 bytes |
module-common.lds | -rw-r--r-- | 737 bytes |
namespace.pl | -rwxr-xr-x | 13.0 KB |
objdiff | -rwxr-xr-x | 2.5 KB |
patch-kernel | -rwxr-xr-x | 9.9 KB |
pnmtologo.c | -rw-r--r-- | 11.9 KB |
profile2linkerlist.pl | -rw-r--r-- | 375 bytes |
recordmcount.c | -rw-r--r-- | 12.4 KB |
recordmcount.h | -rw-r--r-- | 16.3 KB |
recordmcount.pl | -rwxr-xr-x | 17.7 KB |
setlocalversion | -rwxr-xr-x | 3.9 KB |
show_delta | -rwxr-xr-x | 3.0 KB |
sign-file | -rwxr-xr-x | 12.2 KB |
sortextable.c | -rw-r--r-- | 7.5 KB |
sortextable.h | -rw-r--r-- | 5.5 KB |
tags.sh | -rwxr-xr-x | 9.5 KB |
unifdef.c | -rw-r--r-- | 34.8 KB |
ver_linux | -rwxr-xr-x | 3.1 KB |
xz_wrap.sh | -rw-r--r-- | 562 bytes |
Computing file changes ...