Revision 0d4a2b733070a1bd52f981313f9e17f126701407 authored by Yi Wu on 04 August 2017, 20:09:56 UTC, committed by Facebook Github Bot on 04 August 2017, 20:12:07 UTC
Summary: The FsyncFiles background job call Fsync() periodically for blob files. However it can access WritableFileWriter concurrently with a Put() or Write(). And WritableFileWriter does not support concurrent access. It will lead to WritableFileWriter buffer being flush with same content twice, and blob file end up corrupted. Fixing by simply let FsyncFiles hold write_mutex_. Closes https://github.com/facebook/rocksdb/pull/2685 Differential Revision: D5561908 Pulled By: yiwu-arbug fbshipit-source-id: f0bb5bcab0e05694e053b8c49eab43640721e872
1 parent 627c9f1
| File | Mode | Size |
|---|---|---|
| aligned_buffer.h | -rw-r--r-- | 4.6 KB |
| allocator.h | -rw-r--r-- | 1.6 KB |
| arena.cc | -rw-r--r-- | 6.8 KB |
| arena.h | -rw-r--r-- | 5.1 KB |
| arena_test.cc | -rw-r--r-- | 6.5 KB |
| auto_roll_logger.cc | -rw-r--r-- | 5.4 KB |
| auto_roll_logger.h | -rw-r--r-- | 4.0 KB |
| auto_roll_logger_test.cc | -rw-r--r-- | 16.7 KB |
| autovector.h | -rw-r--r-- | 8.7 KB |
| autovector_test.cc | -rw-r--r-- | 9.4 KB |
| bloom.cc | -rw-r--r-- | 11.2 KB |
| bloom_test.cc | -rw-r--r-- | 7.8 KB |
| build_version.cc.in | -rw-r--r-- | 232 bytes |
| build_version.h | -rw-r--r-- | 600 bytes |
| cast_util.h | -rw-r--r-- | 849 bytes |
| channel.h | -rw-r--r-- | 1.5 KB |
| coding.cc | -rw-r--r-- | 2.3 KB |
| coding.h | -rw-r--r-- | 12.5 KB |
| coding_test.cc | -rw-r--r-- | 5.8 KB |
| compaction_job_stats_impl.cc | -rw-r--r-- | 2.3 KB |
| comparator.cc | -rw-r--r-- | 3.7 KB |
| compression.h | -rw-r--r-- | 25.0 KB |
| concurrent_arena.cc | -rw-r--r-- | 1.3 KB |
| concurrent_arena.h | -rw-r--r-- | 7.4 KB |
| core_local.h | -rw-r--r-- | 2.4 KB |
| crc32c.cc | -rw-r--r-- | 16.5 KB |
| crc32c.h | -rw-r--r-- | 1.6 KB |
| crc32c_test.cc | -rw-r--r-- | 2.0 KB |
| delete_scheduler.cc | -rw-r--r-- | 6.7 KB |
| delete_scheduler.h | -rw-r--r-- | 3.7 KB |
| delete_scheduler_test.cc | -rw-r--r-- | 20.2 KB |
| dynamic_bloom.cc | -rw-r--r-- | 2.6 KB |
| dynamic_bloom.h | -rw-r--r-- | 6.4 KB |
| dynamic_bloom_test.cc | -rw-r--r-- | 9.8 KB |
| event_logger.cc | -rw-r--r-- | 1.7 KB |
| event_logger.h | -rw-r--r-- | 4.5 KB |
| event_logger_test.cc | -rw-r--r-- | 1.2 KB |
| fault_injection_test_env.cc | -rw-r--r-- | 9.2 KB |
| fault_injection_test_env.h | -rw-r--r-- | 4.9 KB |
| file_reader_writer.cc | -rw-r--r-- | 19.4 KB |
| file_reader_writer.h | -rw-r--r-- | 6.4 KB |
| file_reader_writer_test.cc | -rw-r--r-- | 10.8 KB |
| file_util.cc | -rw-r--r-- | 2.9 KB |
| file_util.h | -rw-r--r-- | 995 bytes |
| filelock_test.cc | -rw-r--r-- | 1.3 KB |
| filename.cc | -rw-r--r-- | 12.4 KB |
| filename.h | -rw-r--r-- | 6.5 KB |
| filter_policy.cc | -rw-r--r-- | 598 bytes |
| hash.cc | -rw-r--r-- | 1.9 KB |
| hash.h | -rw-r--r-- | 1.0 KB |
| hash_map.h | -rw-r--r-- | 1.9 KB |
| hash_test.cc | -rw-r--r-- | 3.6 KB |
| heap.h | -rw-r--r-- | 4.9 KB |
| heap_test.cc | -rw-r--r-- | 3.8 KB |
| kv_map.h | -rw-r--r-- | 909 bytes |
| log_buffer.cc | -rw-r--r-- | 2.4 KB |
| log_buffer.h | -rw-r--r-- | 1.7 KB |
| log_write_bench.cc | -rw-r--r-- | 2.5 KB |
| logging.h | -rw-r--r-- | 2.1 KB |
| memory_usage.h | -rw-r--r-- | 844 bytes |
| mpsc.h | -rw-r--r-- | 5.7 KB |
| murmurhash.cc | -rw-r--r-- | 4.0 KB |
| murmurhash.h | -rw-r--r-- | 1.3 KB |
| mutexlock.h | -rw-r--r-- | 3.3 KB |
| random.cc | -rw-r--r-- | 975 bytes |
| random.h | -rw-r--r-- | 3.5 KB |
| rate_limiter.cc | -rw-r--r-- | 9.3 KB |
| rate_limiter.h | -rw-r--r-- | 3.1 KB |
| rate_limiter_test.cc | -rw-r--r-- | 6.5 KB |
| slice.cc | -rw-r--r-- | 5.5 KB |
| slice_transform_test.cc | -rw-r--r-- | 4.4 KB |
| sst_file_manager_impl.cc | -rw-r--r-- | 5.3 KB |
| sst_file_manager_impl.h | -rw-r--r-- | 3.6 KB |
| status.cc | -rw-r--r-- | 2.8 KB |
| status_message.cc | -rw-r--r-- | 946 bytes |
| stderr_logger.h | -rw-r--r-- | 850 bytes |
| stop_watch.h | -rw-r--r-- | 2.3 KB |
| string_util.cc | -rw-r--r-- | 9.1 KB |
| string_util.h | -rw-r--r-- | 4.2 KB |
| sync_point.cc | -rw-r--r-- | 4.6 KB |
| sync_point.h | -rw-r--r-- | 5.1 KB |
| testharness.cc | -rw-r--r-- | 1.2 KB |
| testharness.h | -rw-r--r-- | 1.3 KB |
| testutil.cc | -rw-r--r-- | 13.0 KB |
| testutil.h | -rw-r--r-- | 22.8 KB |
| thread_list_test.cc | -rw-r--r-- | 11.7 KB |
| thread_local.cc | -rw-r--r-- | 18.5 KB |
| thread_local.h | -rw-r--r-- | 3.1 KB |
| thread_local_test.cc | -rw-r--r-- | 14.4 KB |
| thread_operation.h | -rw-r--r-- | 3.9 KB |
| threadpool_imp.cc | -rw-r--r-- | 12.0 KB |
| threadpool_imp.h | -rw-r--r-- | 3.5 KB |
| timer_queue.h | -rw-r--r-- | 6.9 KB |
| timer_queue_test.cc | -rw-r--r-- | 2.1 KB |
| transaction_test_util.cc | -rw-r--r-- | 7.0 KB |
| transaction_test_util.h | -rw-r--r-- | 4.0 KB |
| xxhash.cc | -rw-r--r-- | 15.2 KB |
| xxhash.h | -rw-r--r-- | 6.2 KB |
Computing file changes ...
