Revision 0e2209629fec427ba75a6351486153a9feddd36b authored by Hannes Reinecke on 16 January 2020, 10:20:53 UTC, committed by Martin K. Petersen on 21 January 2020, 04:58:14 UTC
When a link is going down the driver will be calling fnic_cleanup_io(),
which will traverse all commands and calling 'done' for each found command.
While the traversal is handled under the host_lock, calling 'done' happens
after the host_lock is being dropped.

As fnic_queuecommand_lck() is being called with the host_lock held, it
might well be that it will pick the command being selected for abortion
from the above routine and enqueue it for sending, but then 'done' is being
called on that very command from the above routine.

Which of course confuses the hell out of the scsi midlayer.

So fix this by not queueing commands when fnic_cleanup_io is active.

Link: https://lore.kernel.org/r/20200116102053.62755-1-hare@suse.de
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 28d76df
History
File Mode Size
.gitignore -rw-r--r-- 44 bytes
Kconfig -rw-r--r-- 3.4 KB
Makefile -rw-r--r-- 4.1 KB
blacklist.c -rw-r--r-- 4.0 KB
blacklist.h -rw-r--r-- 84 bytes
blacklist_hashes.c -rw-r--r-- 166 bytes
blacklist_nohashes.c -rw-r--r-- 122 bytes
system_certificates.S -rw-r--r-- 828 bytes
system_keyring.c -rw-r--r-- 8.7 KB

back to top