Skip to main content

Browse the archive

https://github.com/GPflow/GPflow
21 September 2021, 22:50:56 UTC
Revision 1164235071397edf4dc0e227992d6fae4bb3a5ed authored by Eric Hammy on 11 February 2020, 14:27:49 UTC, committed by GitHub on 11 February 2020, 14:27:49 UTC 
Inconisistency on whether q_sqrt is triangular fixed. (#1223)
 
* Inconisistency on whether q_sqrt is triangular fixed.

Problem:
* KL divergence calculations only take lower triangle parts of q_sqrt in
their calculation (implying a lower triangular parameterisation of
covariance)
* Conditional calculations perform calculations using the whole of
q_sqrt.
* The end result is if you forgot to add the triangular transform
to the q_sqrt, your forward pass may be the same (if you initialise with
a triangular matrix), but your gradients will immediately stop q_sqrt
being triangular.

Fix:
* Conditional calulcations now only take the lower triangle parts of
q_sqrt in their calculation
1 parent 7275533
Raw File
Tip revision: 1164235071397edf4dc0e227992d6fae4bb3a5ed authored by Eric Hammy on 11 February 2020, 14:27:49 UTC
Inconisistency on whether q_sqrt is triangular fixed. (#1223)
Tip revision: 1164235
.gitignore 
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]

# C extensions
*.so

# Distribution / packaging
.Python
env/
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
*.egg-info/
.installed.cfg
*.egg

# PyInstaller
#  Usually these files are written by a python script from a template
#  before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
htmlcov/
.tox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*,cover

# Translations
*.mo
*.pot

# Django stuff:
*.log

# Sphinx documentation
docs/_build/

# PyBuilder
target/

# Emacs backups
*~

# Pycharm IDE directory
.idea

# IPython Notebooks
.ipynb_checkpoints

# VSCode
.vscode

# OSX
.DS_Store
back to top