https://github.com/GPflow/GPflow
Revision 1164235071397edf4dc0e227992d6fae4bb3a5ed authored by Eric Hammy on 11 February 2020, 14:27:49 UTC, committed by GitHub on 11 February 2020, 14:27:49 UTC
* Inconisistency on whether q_sqrt is triangular fixed. Problem: * KL divergence calculations only take lower triangle parts of q_sqrt in their calculation (implying a lower triangular parameterisation of covariance) * Conditional calculations perform calculations using the whole of q_sqrt. * The end result is if you forgot to add the triangular transform to the q_sqrt, your forward pass may be the same (if you initialise with a triangular matrix), but your gradients will immediately stop q_sqrt being triangular. Fix: * Conditional calulcations now only take the lower triangle parts of q_sqrt in their calculation
1 parent 7275533
Tip revision: 1164235071397edf4dc0e227992d6fae4bb3a5ed authored by Eric Hammy on 11 February 2020, 14:27:49 UTC
Inconisistency on whether q_sqrt is triangular fixed. (#1223)
Inconisistency on whether q_sqrt is triangular fixed. (#1223)
Tip revision: 1164235
Makefile
.PHONY: help clean dev docs package test
help:
@echo "The following make targets are available:"
@echo " dev-install install all dependencies for dev environment and sets a egg link to the project sources"
@echo " install install all dependencies and the project in the current environment"
@echo " package build pip package"
@echo " test run all tests in parallel"
@echo " clean removes package, build files and egg info"
clean:
rm -rf dist *.egg-info build
dev-install:
pip install -e .
install:
pip install .
package:
python setup.py bdist
test:
pytest -n auto tests/
Computing file changes ...
