Revision 12d48739d0b5d96efe6b7d26107f5572c6215f4a authored by Yoshinori Sato on 13 March 2008, 19:32:37 UTC, committed by Linus Torvalds on 13 March 2008, 20:11:43 UTC
Al Viro wrote:
>
> 	After that commit in asm-h8300/uaccess.h we have
>
> #define get_user(x, ptr)                                        \
> ({                                                              \
>     int __gu_err = 0;                                           \
>     uint32_t __gu_val = 0;                              \
>     ^^^^^^^^^^^^^^^^^
>     switch (sizeof(*(ptr))) {                                   \
>     case 1:                                                     \
>     case 2:                                                     \
>     case 4:                                                     \
>         __gu_val = *(ptr);                                      \
>         break;                                                  \
>     case 8:                                                     \
>         memcpy(&__gu_val, ptr, sizeof (*(ptr)));                \
>                                ^^^^^^^^^^^^^^^^
>
> which, of course, is FUBAR whenever we actually hit that case - memcpy of
> 8 bytes into uint32_t is obviously wrong.  Why don't we simply do

Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent fb39380
History
File Mode Size
basic
genksyms
kconfig
ksymoops
mod
package
rt-tester
.gitignore -rw-r--r-- 77 bytes
Kbuild.include -rw-r--r-- 9.1 KB
Lindent -rwxr-xr-x 65 bytes
Makefile -rw-r--r-- 893 bytes
Makefile.build -rw-r--r-- 11.1 KB
Makefile.clean -rw-r--r-- 3.2 KB
Makefile.headersinst -rw-r--r-- 6.9 KB
Makefile.host -rw-r--r-- 6.5 KB
Makefile.lib -rw-r--r-- 6.7 KB
Makefile.modinst -rw-r--r-- 1.0 KB
Makefile.modpost -rw-r--r-- 4.9 KB
bin2c.c -rw-r--r-- 702 bytes
binoffset.c -rw-r--r-- 3.9 KB
bloat-o-meter -rwxr-xr-x 1.7 KB
checkincludes.pl -rwxr-xr-x 529 bytes
checkkconfigsymbols.sh -rwxr-xr-x 1.8 KB
checkpatch.pl -rwxr-xr-x 50.2 KB
checkstack.pl -rwxr-xr-x 4.2 KB
checksyscalls.sh -rwxr-xr-x 3.1 KB
checkversion.pl -rwxr-xr-x 1.8 KB
cleanfile -rwxr-xr-x 3.4 KB
cleanpatch -rwxr-xr-x 5.0 KB
conmakehash.c -rw-r--r-- 6.0 KB
decodecode -rw-r--r-- 1.1 KB
export_report.pl -rw-r--r-- 4.2 KB
extract-ikconfig -rwxr-xr-x 1.7 KB
gcc-version.sh -rw-r--r-- 818 bytes
gcc-x86_64-has-stack-protector.sh -rw-r--r-- 187 bytes
gen_initramfs_list.sh -rw-r--r-- 6.6 KB
hdrcheck.sh -rwxr-xr-x 281 bytes
kallsyms.c -rw-r--r-- 13.3 KB
kernel-doc -rwxr-xr-x 55.2 KB
makelst -rwxr-xr-x 773 bytes
mkcompile_h -rwxr-xr-x 2.5 KB
mkmakefile -rw-r--r-- 1.0 KB
mksysmap -rw-r--r-- 1.3 KB
mkuboot.sh -rwxr-xr-x 379 bytes
mkversion -rw-r--r-- 74 bytes
namespace.pl -rwxr-xr-x 13.1 KB
patch-kernel -rwxr-xr-x 9.7 KB
pnmtologo.c -rw-r--r-- 11.7 KB
profile2linkerlist.pl -rw-r--r-- 378 bytes
setlocalversion -rwxr-xr-x 1.5 KB
show_delta -rwxr-xr-x 3.0 KB
unifdef.c -rw-r--r-- 29.0 KB
ver_linux -rwxr-xr-x 3.2 KB

back to top