Revision 14571a699ae56859bc30a22946f563a8b48b80c4 authored by Manuel Rego Casasnovas on 21 March 2018, 13:42:37 UTC, committed by Chromium WPT Sync on 21 March 2018, 13:42:37 UTC
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.

The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.

Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
1 parent fc04bb5
History
File Mode Size
OWNERS -rw-r--r-- 28 bytes
anim-gr.gif -rw-r--r-- 241 bytes
anim-gr.png -rw-r--r-- 460 bytes
anim-poster-gr.png -rw-r--r-- 422 bytes
apng.png -rw-r--r-- 259 bytes
background.png -rw-r--r-- 86 bytes
black-rectangle.png -rw-r--r-- 307 bytes
blue-area.png -rw-r--r-- 1.4 KB
blue-border.png -rw-r--r-- 1.8 KB
blue-png-cachable.py -rw-r--r-- 507 bytes
blue.png -rw-r--r-- 485 bytes
blue96x96.png -rw-r--r-- 1010 bytes
broken.png -rw-r--r-- 87 bytes
canvas-line.png -rw-r--r-- 502 bytes
colors.svg -rw-r--r-- 411 bytes
fail.gif -rw-r--r-- 23.9 KB
ggrr-256x256.png -rw-r--r-- 120 bytes
green-100x50.png -rw-r--r-- 218 bytes
green-16x16.png -rw-r--r-- 92 bytes
green-1x1.png -rw-r--r-- 82 bytes
green-256x256.png -rw-r--r-- 103 bytes
green-2x2.png -rw-r--r-- 118 bytes
green.png -rw-r--r-- 87 bytes
green.svg -rw-r--r-- 118 bytes
grgr-256x256.png -rw-r--r-- 130 bytes
movie_300_frame_0.png -rw-r--r-- 11.2 KB
pattern.mp4 -rw-r--r-- 1.5 KB
pattern.ogv -rw-r--r-- 6.5 KB
pattern.png -rw-r--r-- 123 bytes
pattern.svg -rw-r--r-- 319 bytes
red-16x16.png -rw-r--r-- 130 bytes
red-zeroheight.svg -rw-r--r-- 117 bytes
red-zerosize.svg -rw-r--r-- 115 bytes
red-zerowidth.svg -rw-r--r-- 117 bytes
red.png -rw-r--r-- 87 bytes
redtransparent.png -rw-r--r-- 109 bytes
rgrg-256x256.png -rw-r--r-- 131 bytes
rrgg-256x256.png -rw-r--r-- 120 bytes
smiley.png -rw-r--r-- 1.8 KB
smiley.png.headers -rw-r--r-- 23 bytes
threecolors.png -rw-r--r-- 242 bytes
transparent.png -rw-r--r-- 100 bytes
transparent50.png -rw-r--r-- 155 bytes
yellow.png -rw-r--r-- 95 bytes
yellow75.png -rw-r--r-- 150 bytes

back to top