Revision 14571a699ae56859bc30a22946f563a8b48b80c4 authored by Manuel Rego Casasnovas on 21 March 2018, 13:42:37 UTC, committed by Chromium WPT Sync on 21 March 2018, 13:42:37 UTC
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.
The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.
Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
1 parent fc04bb5
| File | Mode | Size |
|---|---|---|
| resources | ||
| OWNERS | -rw-r--r-- | 36 bytes |
| case-sensitivity.any.js | -rw-r--r-- | 1.5 KB |
| idlharness.html | -rw-r--r-- | 2.8 KB |
| performanceentry-tojson.html | -rw-r--r-- | 818 bytes |
| performanceobservers.js | -rw-r--r-- | 1.5 KB |
| po-callback-mutate.any.js | -rw-r--r-- | 2.6 KB |
| po-disconnect.any.js | -rw-r--r-- | 1.2 KB |
| po-entries-sort.any.js | -rw-r--r-- | 2.6 KB |
| po-getentries.any.js | -rw-r--r-- | 1.8 KB |
| po-mark-measure.any.js | -rw-r--r-- | 2.1 KB |
| po-observe.any.js | -rw-r--r-- | 2.8 KB |
| po-observe.html | -rw-r--r-- | 2.7 KB |
| po-resource.html | -rw-r--r-- | 1.8 KB |
| po-takeRecords.html | -rw-r--r-- | 1.4 KB |
| worker-with-performance-observer.html | -rw-r--r-- | 460 bytes |
Computing file changes ...
