https://github.com/Kitware/CMake
Revision 15b3f6f0f187ab12c29e437f737356bed13d977b authored by Ben Boeckel on 27 June 2016, 15:44:10 UTC, committed by Brad King on 27 June 2016, 18:34:06 UTC
In commit v3.6.0-rc1~174^2 (Ninja: Honor CMAKE_NINJA_FORCE_RESPONSE_FILE
for compile rules, 2016-04-06), Ninja learned to look for
`CMAKE_NINJA_FORCE_RESPONSE_FILE` in the current scope or the
environment in order to force response file usage for all compilation
rules.

However, on Windows, the RC compiler goes through cmcldeps which does a
`replace(output, output + ".dep.obj")` on the command line. However,
with a response file (which we name `output + ".rsp"`), the response
file path is replaced instead causing the compiler to (correctly)
complain that the response file `output + ".dep.obj.rsp"` does not
exist.

What needs to happen is for cmcldeps to look through the response file,
replace *its* contents and place it in the `output + ".dep.obj.rsp"`
file.

Also add a test which actually compiles an RC file into a library and
executable for all generators on Windows and additionally test
`CMAKE_NINJA_FORCE_RESPONSE_FILE` for Ninja generators.

Fixes #16167.
1 parent d152ae1
History
Tip revision: 15b3f6f0f187ab12c29e437f737356bed13d977b authored by Ben Boeckel on 27 June 2016, 15:44:10 UTC
ninja, rc: ignore CMAKE_NINJA_FORCE_RESPONSE_FILE for RC files
Tip revision: 15b3f6f
File Mode Size
Doxygen
Git
GitSetup
KWIML
KWStyle
Release
Scripts
Sphinx
cmbzip2
cmcompress
cmcurl
cmexpat
cmjsoncpp
cmlibarchive
cmliblzma
cmzlib
.NoDartCoverage -rw-r--r-- 39 bytes
.gitattributes -rw-r--r-- 76 bytes
CMakeLists.txt -rw-r--r-- 1.4 KB
SetupForDevelopment.sh -rwxr-xr-x 392 bytes
cmThirdParty.h.in -rw-r--r-- 1.0 KB
cm_bzlib.h -rw-r--r-- 784 bytes
cm_curl.h -rw-r--r-- 795 bytes
cm_expat.h -rw-r--r-- 788 bytes
cm_jsoncpp_reader.h -rw-r--r-- 828 bytes
cm_jsoncpp_value.h -rw-r--r-- 824 bytes
cm_jsoncpp_writer.h -rw-r--r-- 828 bytes
cm_kwiml.h -rw-r--r-- 858 bytes
cm_libarchive.h -rw-r--r-- 894 bytes
cm_lzma.h -rw-r--r-- 785 bytes
cm_xmlrpc.h -rw-r--r-- 776 bytes
cm_zlib.h -rw-r--r-- 777 bytes

back to top