Revision 15bff9162530113b426664eb0c1deb7ea9e3a90d authored by Tim Foley on 13 April 2018, 20:36:26 UTC, committed by GitHub on 13 April 2018, 20:36:26 UTC
A previous fix avoided crashes when an `import`ed module has errors by making the "failed to import" error a fatal one. Unfortunately, the code path that handles fatal errors was failing to copy diagnostic output from the sink over to the member variable on the `CompileRequest` that exposes the output through the API. This meant that API users lost all context on error messages in `import`ed code. This change fixes the immediate issue by plumbing through the error output, but doesn't fix the more fundamental issue: the front-end should not crash when an `import` fails, by any means.
1 parent 021a492
| File | Mode | Size |
|---|---|---|
| build | ||
| docs | ||
| examples | ||
| external | ||
| source | ||
| tests | ||
| tools | ||
| .editorconfig | -rw-r--r-- | 937 bytes |
| .gitattributes | -rw-r--r-- | 95 bytes |
| .gitignore | -rw-r--r-- | 398 bytes |
| .gitmodules | -rw-r--r-- | 107 bytes |
| .travis.yml | -rw-r--r-- | 1.6 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.1 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| Makefile | -rw-r--r-- | 6.3 KB |
| README.md | -rw-r--r-- | 4.9 KB |
| appveyor.yml | -rw-r--r-- | 3.5 KB |
| slang.h | -rw-r--r-- | 42.9 KB |
| slang.sln | -rw-r--r-- | 9.1 KB |
| test.bat | -rw-r--r-- | 1.4 KB |
Computing file changes ...
