Revision 15cf17d26e08ee95c2e392a3a71f55d32e99e971 authored by Konstantin Khlebnikov on 08 March 2013, 20:43:36 UTC, committed by Linus Torvalds on 08 March 2013, 23:05:34 UTC
Fix a warning from lockdep caused by calling cancel_work_sync() for uninitialized struct work. This path has been triggered by destructon kmem-cache hierarchy via destroying its root kmem-cache. cache ffff88003c072d80 obj ffff88003b410000 cache ffff88003c072d80 obj ffff88003b924000 cache ffff88003c20bd40 INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. Pid: 2825, comm: insmod Tainted: G O 3.9.0-rc1-next-20130307+ #611 Call Trace: __lock_acquire+0x16a2/0x1cb0 lock_acquire+0x8a/0x120 flush_work+0x38/0x2a0 __cancel_work_timer+0x89/0xf0 cancel_work_sync+0xb/0x10 kmem_cache_destroy_memcg_children+0x81/0xb0 kmem_cache_destroy+0xf/0xe0 init_module+0xcb/0x1000 [kmem_test] do_one_initcall+0x11a/0x170 load_module+0x19b0/0x2320 SyS_init_module+0xc6/0xf0 system_call_fastpath+0x16/0x1b Example module to demonstrate: #include <linux/module.h> #include <linux/slab.h> #include <linux/mm.h> #include <linux/workqueue.h> int __init mod_init(void) { int size = 256; struct kmem_cache *cache; void *obj; struct page *page; cache = kmem_cache_create("kmem_cache_test", size, size, 0, NULL); if (!cache) return -ENOMEM; printk("cache %p\n", cache); obj = kmem_cache_alloc(cache, GFP_KERNEL); if (obj) { page = virt_to_head_page(obj); printk("obj %p cache %p\n", obj, page->slab_cache); kmem_cache_free(cache, obj); } flush_scheduled_work(); obj = kmem_cache_alloc(cache, GFP_KERNEL); if (obj) { page = virt_to_head_page(obj); printk("obj %p cache %p\n", obj, page->slab_cache); kmem_cache_free(cache, obj); } kmem_cache_destroy(cache); return -EBUSY; } module_init(mod_init); MODULE_LICENSE("GPL"); Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> Cc: Glauber Costa <glommer@parallels.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 755727b
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 15.8 KB |
Kconfig.debug | -rw-r--r-- | 1015 bytes |
Makefile | -rw-r--r-- | 2.0 KB |
backing-dev.c | -rw-r--r-- | 21.5 KB |
balloon_compaction.c | -rw-r--r-- | 9.6 KB |
bootmem.c | -rw-r--r-- | 21.3 KB |
bounce.c | -rw-r--r-- | 7.5 KB |
cleancache.c | -rw-r--r-- | 6.5 KB |
compaction.c | -rw-r--r-- | 32.3 KB |
debug-pagealloc.c | -rw-r--r-- | 2.1 KB |
dmapool.c | -rw-r--r-- | 13.1 KB |
fadvise.c | -rw-r--r-- | 4.0 KB |
failslab.c | -rw-r--r-- | 1.3 KB |
filemap.c | -rw-r--r-- | 67.3 KB |
filemap_xip.c | -rw-r--r-- | 11.3 KB |
fremap.c | -rw-r--r-- | 6.8 KB |
frontswap.c | -rw-r--r-- | 10.3 KB |
highmem.c | -rw-r--r-- | 9.9 KB |
huge_memory.c | -rw-r--r-- | 72.9 KB |
hugetlb.c | -rw-r--r-- | 82.3 KB |
hugetlb_cgroup.c | -rw-r--r-- | 10.7 KB |
hwpoison-inject.c | -rw-r--r-- | 3.3 KB |
init-mm.c | -rw-r--r-- | 619 bytes |
internal.h | -rw-r--r-- | 11.1 KB |
interval_tree.c | -rw-r--r-- | 3.2 KB |
kmemcheck.c | -rw-r--r-- | 2.8 KB |
kmemleak-test.c | -rw-r--r-- | 3.3 KB |
kmemleak.c | -rw-r--r-- | 52.4 KB |
ksm.c | -rw-r--r-- | 65.9 KB |
maccess.c | -rw-r--r-- | 1.6 KB |
madvise.c | -rw-r--r-- | 14.1 KB |
memblock.c | -rw-r--r-- | 29.6 KB |
memcontrol.c | -rw-r--r-- | 180.4 KB |
memory-failure.c | -rw-r--r-- | 44.3 KB |
memory.c | -rw-r--r-- | 114.4 KB |
memory_hotplug.c | -rw-r--r-- | 46.6 KB |
mempolicy.c | -rw-r--r-- | 71.3 KB |
mempool.c | -rw-r--r-- | 10.5 KB |
migrate.c | -rw-r--r-- | 43.7 KB |
mincore.c | -rw-r--r-- | 7.8 KB |
mlock.c | -rw-r--r-- | 14.9 KB |
mm_init.c | -rw-r--r-- | 4.0 KB |
mmap.c | -rw-r--r-- | 81.8 KB |
mmu_context.c | -rw-r--r-- | 1.4 KB |
mmu_notifier.c | -rw-r--r-- | 9.3 KB |
mmzone.c | -rw-r--r-- | 2.4 KB |
mprotect.c | -rw-r--r-- | 10.2 KB |
mremap.c | -rw-r--r-- | 14.4 KB |
msync.c | -rw-r--r-- | 2.4 KB |
nobootmem.c | -rw-r--r-- | 11.0 KB |
nommu.c | -rw-r--r-- | 51.5 KB |
oom_kill.c | -rw-r--r-- | 19.5 KB |
page-writeback.c | -rw-r--r-- | 70.0 KB |
page_alloc.c | -rw-r--r-- | 170.6 KB |
page_cgroup.c | -rw-r--r-- | 11.9 KB |
page_io.c | -rw-r--r-- | 6.8 KB |
page_isolation.c | -rw-r--r-- | 7.0 KB |
pagewalk.c | -rw-r--r-- | 5.7 KB |
percpu-km.c | -rw-r--r-- | 2.8 KB |
percpu-vm.c | -rw-r--r-- | 12.9 KB |
percpu.c | -rw-r--r-- | 57.1 KB |
pgtable-generic.c | -rw-r--r-- | 4.6 KB |
process_vm_access.c | -rw-r--r-- | 13.3 KB |
quicklist.c | -rw-r--r-- | 2.4 KB |
readahead.c | -rw-r--r-- | 16.1 KB |
rmap.c | -rw-r--r-- | 50.4 KB |
shmem.c | -rw-r--r-- | 77.2 KB |
slab.c | -rw-r--r-- | 117.7 KB |
slab.h | -rw-r--r-- | 6.2 KB |
slab_common.c | -rw-r--r-- | 11.1 KB |
slob.c | -rw-r--r-- | 15.3 KB |
slub.c | -rw-r--r-- | 129.0 KB |
sparse-vmemmap.c | -rw-r--r-- | 5.9 KB |
sparse.c | -rw-r--r-- | 20.9 KB |
swap.c | -rw-r--r-- | 23.3 KB |
swap_state.c | -rw-r--r-- | 10.7 KB |
swapfile.c | -rw-r--r-- | 65.6 KB |
truncate.c | -rw-r--r-- | 18.3 KB |
util.c | -rw-r--r-- | 9.6 KB |
vmalloc.c | -rw-r--r-- | 66.1 KB |
vmscan.c | -rw-r--r-- | 100.2 KB |
vmstat.c | -rw-r--r-- | 33.9 KB |
Computing file changes ...