Revision 15de9cb5c9c83a23be92b8f7a1178cead1486587 authored by Chris Wilson on 11 February 2020, 12:01:31 UTC, committed by Jani Nikula on 18 February 2020, 07:53:18 UTC
We manipulate ring->head while active in i915_request_retire underneath
the timeline manipulation. We cannot rely on a stable ring->head outside
of the timeline->mutex, in particular while setting up the context for
resume and reset.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/1126
Fixes: 0881954965e3 ("drm/i915: Introduce intel_context.pin_mutex for pin management")
Fixes: e5dadff4b093 ("drm/i915: Protect request retirement with timeline->mutex")
References: f3c0efc9fe7a ("drm/i915/execlists: Leave resetting ring to intel_ring")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200211120131.958949-1-chris@chris-wilson.co.uk
(cherry picked from commit 42827350f75c56d0fe9f15d8425a1390528958b6)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent b1339ec
| File | Mode | Size |
|---|---|---|
| bpf | ||
| cgroup | ||
| configs | ||
| debug | ||
| dma | ||
| events | ||
| gcov | ||
| irq | ||
| livepatch | ||
| locking | ||
| power | ||
| printk | ||
| rcu | ||
| sched | ||
| time | ||
| trace | ||
| .gitignore | -rw-r--r-- | 53 bytes |
| Kconfig.freezer | -rw-r--r-- | 92 bytes |
| Kconfig.hz | -rw-r--r-- | 1.7 KB |
| Kconfig.locks | -rw-r--r-- | 4.9 KB |
| Kconfig.preempt | -rw-r--r-- | 3.0 KB |
| Makefile | -rw-r--r-- | 4.4 KB |
| acct.c | -rw-r--r-- | 15.5 KB |
| async.c | -rw-r--r-- | 10.2 KB |
| audit.c | -rw-r--r-- | 61.4 KB |
| audit.h | -rw-r--r-- | 10.4 KB |
| audit_fsnotify.c | -rw-r--r-- | 5.6 KB |
| audit_tree.c | -rw-r--r-- | 25.7 KB |
| audit_watch.c | -rw-r--r-- | 14.1 KB |
| auditfilter.c | -rw-r--r-- | 34.0 KB |
| auditsc.c | -rw-r--r-- | 69.7 KB |
| backtracetest.c | -rw-r--r-- | 1.9 KB |
| bounds.c | -rw-r--r-- | 751 bytes |
| capability.c | -rw-r--r-- | 14.6 KB |
| compat.c | -rw-r--r-- | 9.2 KB |
| configs.c | -rw-r--r-- | 2.0 KB |
| context_tracking.c | -rw-r--r-- | 6.3 KB |
| cpu.c | -rw-r--r-- | 58.0 KB |
| cpu_pm.c | -rw-r--r-- | 5.6 KB |
| crash_core.c | -rw-r--r-- | 11.4 KB |
| crash_dump.c | -rw-r--r-- | 1.3 KB |
| cred.c | -rw-r--r-- | 23.3 KB |
| delayacct.c | -rw-r--r-- | 4.7 KB |
| dma.c | -rw-r--r-- | 3.3 KB |
| elfcore.c | -rw-r--r-- | 459 bytes |
| exec_domain.c | -rw-r--r-- | 1.1 KB |
| exit.c | -rw-r--r-- | 42.1 KB |
| extable.c | -rw-r--r-- | 4.4 KB |
| fail_function.c | -rw-r--r-- | 6.9 KB |
| fork.c | -rw-r--r-- | 73.8 KB |
| freezer.c | -rw-r--r-- | 4.4 KB |
| futex.c | -rw-r--r-- | 112.2 KB |
| gen_kheaders.sh | -rwxr-xr-x | 3.2 KB |
| groups.c | -rw-r--r-- | 4.9 KB |
| hung_task.c | -rw-r--r-- | 7.3 KB |
| iomem.c | -rw-r--r-- | 4.7 KB |
| irq_work.c | -rw-r--r-- | 4.7 KB |
| jump_label.c | -rw-r--r-- | 20.8 KB |
| kallsyms.c | -rw-r--r-- | 17.7 KB |
| kcmp.c | -rw-r--r-- | 5.7 KB |
| kcov.c | -rw-r--r-- | 24.8 KB |
| kexec.c | -rw-r--r-- | 8.0 KB |
| kexec_core.c | -rw-r--r-- | 31.2 KB |
| kexec_elf.c | -rw-r--r-- | 11.4 KB |
| kexec_file.c | -rw-r--r-- | 33.0 KB |
| kexec_internal.h | -rw-r--r-- | 976 bytes |
| kheaders.c | -rw-r--r-- | 1.6 KB |
| kmod.c | -rw-r--r-- | 5.0 KB |
| kprobes.c | -rw-r--r-- | 63.8 KB |
| ksysfs.c | -rw-r--r-- | 6.3 KB |
| kthread.c | -rw-r--r-- | 34.1 KB |
| latencytop.c | -rw-r--r-- | 7.2 KB |
| module-internal.h | -rw-r--r-- | 782 bytes |
| module.c | -rw-r--r-- | 114.7 KB |
| module_signature.c | -rw-r--r-- | 1.1 KB |
| module_signing.c | -rw-r--r-- | 1.1 KB |
| notifier.c | -rw-r--r-- | 15.5 KB |
| nsproxy.c | -rw-r--r-- | 7.1 KB |
| padata.c | -rw-r--r-- | 26.1 KB |
| panic.c | -rw-r--r-- | 17.2 KB |
| params.c | -rw-r--r-- | 22.7 KB |
| pid.c | -rw-r--r-- | 15.9 KB |
| pid_namespace.c | -rw-r--r-- | 11.4 KB |
| profile.c | -rw-r--r-- | 14.8 KB |
| ptrace.c | -rw-r--r-- | 36.5 KB |
| range.c | -rw-r--r-- | 3.0 KB |
| reboot.c | -rw-r--r-- | 14.1 KB |
| relay.c | -rw-r--r-- | 32.1 KB |
| resource.c | -rw-r--r-- | 42.8 KB |
| rseq.c | -rw-r--r-- | 9.8 KB |
| seccomp.c | -rw-r--r-- | 46.2 KB |
| signal.c | -rw-r--r-- | 117.9 KB |
| smp.c | -rw-r--r-- | 21.7 KB |
| smpboot.c | -rw-r--r-- | 11.7 KB |
| smpboot.h | -rw-r--r-- | 640 bytes |
| softirq.c | -rw-r--r-- | 17.1 KB |
| stackleak.c | -rw-r--r-- | 3.9 KB |
| stacktrace.c | -rw-r--r-- | 9.7 KB |
| stop_machine.c | -rw-r--r-- | 17.2 KB |
| sys.c | -rw-r--r-- | 62.5 KB |
| sys_ni.c | -rw-r--r-- | 10.0 KB |
| sysctl-test.c | -rw-r--r-- | 10.8 KB |
| sysctl.c | -rw-r--r-- | 80.4 KB |
| sysctl_binary.c | -rw-r--r-- | 3.8 KB |
| task_work.c | -rw-r--r-- | 3.1 KB |
| taskstats.c | -rw-r--r-- | 15.8 KB |
| test_kprobes.c | -rw-r--r-- | 5.9 KB |
| torture.c | -rw-r--r-- | 21.0 KB |
| tracepoint.c | -rw-r--r-- | 14.9 KB |
| tsacct.c | -rw-r--r-- | 4.7 KB |
| ucount.c | -rw-r--r-- | 5.5 KB |
| uid16.c | -rw-r--r-- | 5.1 KB |
| uid16.h | -rw-r--r-- | 442 bytes |
| umh.c | -rw-r--r-- | 19.0 KB |
| up.c | -rw-r--r-- | 2.3 KB |
| user-return-notifier.c | -rw-r--r-- | 1.3 KB |
| user.c | -rw-r--r-- | 5.5 KB |
| user_namespace.c | -rw-r--r-- | 33.2 KB |
| utsname.c | -rw-r--r-- | 3.8 KB |
| utsname_sysctl.c | -rw-r--r-- | 3.2 KB |
| watchdog.c | -rw-r--r-- | 20.8 KB |
| watchdog_hld.c | -rw-r--r-- | 7.7 KB |
| workqueue.c | -rw-r--r-- | 164.8 KB |
| workqueue_internal.h | -rw-r--r-- | 2.4 KB |
Computing file changes ...
