Revision 15de9cb5c9c83a23be92b8f7a1178cead1486587 authored by Chris Wilson on 11 February 2020, 12:01:31 UTC, committed by Jani Nikula on 18 February 2020, 07:53:18 UTC
We manipulate ring->head while active in i915_request_retire underneath
the timeline manipulation. We cannot rely on a stable ring->head outside
of the timeline->mutex, in particular while setting up the context for
resume and reset.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/1126
Fixes: 0881954965e3 ("drm/i915: Introduce intel_context.pin_mutex for pin management")
Fixes: e5dadff4b093 ("drm/i915: Protect request retirement with timeline->mutex")
References: f3c0efc9fe7a ("drm/i915/execlists: Leave resetting ring to intel_ring")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200211120131.958949-1-chris@chris-wilson.co.uk
(cherry picked from commit 42827350f75c56d0fe9f15d8425a1390528958b6)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent b1339ec
History
File Mode Size
Makefile -rw-r--r-- 289 bytes
cgroup-internal.h -rw-r--r-- 8.6 KB
cgroup-v1.c -rw-r--r-- 33.0 KB
cgroup.c -rw-r--r-- 166.9 KB
cpuset.c -rw-r--r-- 100.0 KB
debug.c -rw-r--r-- 8.2 KB
freezer.c -rw-r--r-- 7.8 KB
legacy_freezer.c -rw-r--r-- 12.4 KB
namespace.c -rw-r--r-- 3.3 KB
pids.c -rw-r--r-- 8.8 KB
rdma.c -rw-r--r-- 14.7 KB
rstat.c -rw-r--r-- 10.9 KB

back to top