Revision 177c53d943368fc97644ebc0a250dc8e2d124250 authored by Peter Zijlstra on 28 February 2014, 12:39:05 UTC, committed by Ingo Molnar on 11 March 2014, 10:33:47 UTC
We must use smp_call_function_single(.wait=1) for the
irq_cpu_stop_queue_work() to ensure the queueing is actually done under
stop_cpus_lock. Without this we could have dropped the lock by the time
we do the queueing and get the race we tried to fix.

Fixes: 7053ea1a34fa ("stop_machine: Fix race between stop_two_cpus() and stop_cpus()")

Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140228123905.GK3104@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent d44753b
History
File Mode Size
Makefile -rw-r--r-- 394 bytes
compat.c -rw-r--r-- 19.2 KB
compat_mq.c -rw-r--r-- 4.1 KB
ipc_sysctl.c -rw-r--r-- 7.0 KB
ipcns_notifier.c -rw-r--r-- 2.2 KB
mq_sysctl.c -rw-r--r-- 2.9 KB
mqueue.c -rw-r--r-- 35.3 KB
msg.c -rw-r--r-- 24.0 KB
msgutil.c -rw-r--r-- 3.6 KB
namespace.c -rw-r--r-- 4.7 KB
sem.c -rw-r--r-- 54.8 KB
shm.c -rw-r--r-- 31.9 KB
syscall.c -rw-r--r-- 2.3 KB
util.c -rw-r--r-- 22.3 KB
util.h -rw-r--r-- 6.4 KB

back to top