Skip to main content

Browse the archive

Revision 17af09fcce881e2773a20086eea5c8117ad67204 authored by Siying Dong on 18 May 2018, 01:24:20 UTC, committed by Facebook Github Bot on 18 May 2018, 01:27:16 UTC 
Implement key shortening functions in ReverseBytewiseComparator
 
Summary:
Right now ReverseBytewiseComparator::FindShortestSeparator() doesn't really shorten key, and ReverseBytewiseComparator::FindShortestSuccessor() seems to return wrong results. The code is confusing too as it uses BytewiseComparatorImpl::FindShortestSeparator() but the function actually won't do anything if the the first key is larger than the second.

Implement ReverseBytewiseComparator::FindShortestSeparator() and override ReverseBytewiseComparator::FindShortestSuccessor() to be empty.
Closes https://github.com/facebook/rocksdb/pull/3836

Differential Revision: D7959762

Pulled By: siying

fbshipit-source-id: 93acb621c16ce6f23e087ae4e19f7d84d1254683
1 parent 1d7ca20
History
File Mode Size
coverage_test.sh -rwxr-xr-x 2.2 KB
parse_gcov_output.py -rw-r--r-- 4.1 KB
back to top