Revision 17af09fcce881e2773a20086eea5c8117ad67204 authored by Siying Dong on 18 May 2018, 01:24:20 UTC, committed by Facebook Github Bot on 18 May 2018, 01:27:16 UTC
Summary: Right now ReverseBytewiseComparator::FindShortestSeparator() doesn't really shorten key, and ReverseBytewiseComparator::FindShortestSuccessor() seems to return wrong results. The code is confusing too as it uses BytewiseComparatorImpl::FindShortestSeparator() but the function actually won't do anything if the the first key is larger than the second. Implement ReverseBytewiseComparator::FindShortestSeparator() and override ReverseBytewiseComparator::FindShortestSuccessor() to be empty. Closes https://github.com/facebook/rocksdb/pull/3836 Differential Revision: D7959762 Pulled By: siying fbshipit-source-id: 93acb621c16ce6f23e087ae4e19f7d84d1254683
1 parent 1d7ca20
| File | Mode | Size |
|---|---|---|
| file_read_sample.h | -rw-r--r-- | 801 bytes |
| histogram.cc | -rw-r--r-- | 9.2 KB |
| histogram.h | -rw-r--r-- | 4.4 KB |
| histogram_test.cc | -rw-r--r-- | 7.1 KB |
| histogram_windowing.cc | -rw-r--r-- | 6.3 KB |
| histogram_windowing.h | -rw-r--r-- | 2.8 KB |
| instrumented_mutex.cc | -rw-r--r-- | 2.0 KB |
| instrumented_mutex.h | -rw-r--r-- | 2.3 KB |
| iostats_context.cc | -rw-r--r-- | 1.6 KB |
| iostats_context_imp.h | -rw-r--r-- | 1.7 KB |
| iostats_context_test.cc | -rw-r--r-- | 979 bytes |
| perf_context.cc | -rw-r--r-- | 6.4 KB |
| perf_context_imp.h | -rw-r--r-- | 2.1 KB |
| perf_level.cc | -rw-r--r-- | 683 bytes |
| perf_level_imp.h | -rw-r--r-- | 496 bytes |
| perf_step_timer.h | -rw-r--r-- | 1.8 KB |
| statistics.cc | -rw-r--r-- | 6.0 KB |
| statistics.h | -rw-r--r-- | 3.8 KB |
| statistics_test.cc | -rw-r--r-- | 1.0 KB |
| thread_status_impl.cc | -rw-r--r-- | 4.8 KB |
| thread_status_updater.cc | -rw-r--r-- | 11.0 KB |
| thread_status_updater.h | -rw-r--r-- | 8.5 KB |
| thread_status_updater_debug.cc | -rw-r--r-- | 1.3 KB |
| thread_status_util.cc | -rw-r--r-- | 7.1 KB |
| thread_status_util.h | -rw-r--r-- | 5.1 KB |
| thread_status_util_debug.cc | -rw-r--r-- | 966 bytes |
Computing file changes ...
