Revision 17af09fcce881e2773a20086eea5c8117ad67204 authored by Siying Dong on 18 May 2018, 01:24:20 UTC, committed by Facebook Github Bot on 18 May 2018, 01:27:16 UTC
Summary: Right now ReverseBytewiseComparator::FindShortestSeparator() doesn't really shorten key, and ReverseBytewiseComparator::FindShortestSuccessor() seems to return wrong results. The code is confusing too as it uses BytewiseComparatorImpl::FindShortestSeparator() but the function actually won't do anything if the the first key is larger than the second. Implement ReverseBytewiseComparator::FindShortestSeparator() and override ReverseBytewiseComparator::FindShortestSuccessor() to be empty. Closes https://github.com/facebook/rocksdb/pull/3836 Differential Revision: D7959762 Pulled By: siying fbshipit-source-id: 93acb621c16ce6f23e087ae4e19f7d84d1254683
1 parent 1d7ca20
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 8.3 KB |
| cf_options.h | -rw-r--r-- | 8.0 KB |
| db_options.cc | -rw-r--r-- | 13.5 KB |
| db_options.h | -rw-r--r-- | 3.1 KB |
| options.cc | -rw-r--r-- | 22.8 KB |
| options_helper.cc | -rw-r--r-- | 82.3 KB |
| options_helper.h | -rw-r--r-- | 8.2 KB |
| options_parser.cc | -rw-r--r-- | 29.9 KB |
| options_parser.h | -rw-r--r-- | 5.1 KB |
| options_sanity_check.cc | -rw-r--r-- | 1.1 KB |
| options_sanity_check.h | -rw-r--r-- | 1.7 KB |
| options_settable_test.cc | -rw-r--r-- | 20.5 KB |
| options_test.cc | -rw-r--r-- | 73.5 KB |
Computing file changes ...
