Revision 19cab8872692960535aa6d12e3a295ac51d1a648 authored by Florian Fainelli on 20 September 2017, 22:52:13 UTC, committed by David S. Miller on 21 September 2017, 22:20:40 UTC
Commit 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
deprecated the ethtool_cmd::transceiver field, which was fine in
premise, except that the PHY library was actually using it to report the
type of transceiver: internal or external.

Use the first word of the reserved field to put this __u8 transceiver
field back in. It is made read-only, and we don't expect the
ETHTOOL_xLINKSETTINGS API to be doing anything with this anyway, so this
is mostly for the legacy path where we do:

ethtool_get_settings()
-> dev->ethtool_ops->get_link_ksettings()
   -> convert_link_ksettings_to_legacy_settings()

to have no information loss compared to the legacy get_settings API.

Fixes: 3f1ac7a700d0 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4a7a386
History
File Mode Size
Makefile -rw-r--r-- 326 bytes
compat.c -rw-r--r-- 2.2 KB
ipc_sysctl.c -rw-r--r-- 5.4 KB
mq_sysctl.c -rw-r--r-- 2.9 KB
mqueue.c -rw-r--r-- 40.1 KB
msg.c -rw-r--r-- 27.4 KB
msgutil.c -rw-r--r-- 3.6 KB
namespace.c -rw-r--r-- 4.8 KB
sem.c -rw-r--r-- 58.0 KB
shm.c -rw-r--r-- 38.5 KB
syscall.c -rw-r--r-- 4.3 KB
util.c -rw-r--r-- 21.8 KB
util.h -rw-r--r-- 7.0 KB

back to top