Revision 1ffadbe9fcee94b8537bcf8cb7a1e2075d112bf7 authored by Andrew Kryczka on 06 September 2022, 19:59:02 UTC, committed by Facebook GitHub Bot on 06 September 2022, 19:59:02 UTC
Summary:
Example flake: https://app.circleci.com/pipelines/github/facebook/rocksdb/17660/workflows/7a891875-f07b-4a67-b204-eaa7ca9f9aa2/jobs/467496

The test could get stuck in out-of-space due to a callback executing `SetFilesystemActive(false /* active */)` after the test executed `SetFilesystemActive(true /* active */)`. This could happen because background info logging went through the SyncPoint callback "WritableFileWriter::Append:BeforePrepareWrite", probably unintentionally. The solution of this PR is to call `ClearAllCallBacks()` to wait for any such pending callbacks to drain before calling `SetFilesystemActive(true /* active */)`

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10642

Reviewed By: cbi42

Differential Revision: D39265381

Pulled By: ajkr

fbshipit-source-id: 9a2f4916ab19726c8fb4b3a3b590b1b9ed93de1b
1 parent 76de3c8
History
File Mode Size
_data
_docs
_includes
_layouts
_posts
_sass
_top-level
blog
css
doc-type-examples
docs
static
.gitignore -rw-r--r-- 56 bytes
CNAME -rw-r--r-- 11 bytes
CONTRIBUTING.md -rw-r--r-- 4.7 KB
Gemfile -rw-r--r-- 84 bytes
Gemfile.lock -rw-r--r-- 7.8 KB
LICENSE-DOCUMENTATION -rw-r--r-- 17.7 KB
README.md -rw-r--r-- 3.1 KB
TEMPLATE-INFORMATION.md -rw-r--r-- 2.5 KB
_config.yml -rw-r--r-- 2.8 KB
feed.xml -rw-r--r-- 1.2 KB
index.md -rw-r--r-- 174 bytes

README.md

back to top