Revision 1ffadbe9fcee94b8537bcf8cb7a1e2075d112bf7 authored by Andrew Kryczka on 06 September 2022, 19:59:02 UTC, committed by Facebook GitHub Bot on 06 September 2022, 19:59:02 UTC
Summary: Example flake: https://app.circleci.com/pipelines/github/facebook/rocksdb/17660/workflows/7a891875-f07b-4a67-b204-eaa7ca9f9aa2/jobs/467496 The test could get stuck in out-of-space due to a callback executing `SetFilesystemActive(false /* active */)` after the test executed `SetFilesystemActive(true /* active */)`. This could happen because background info logging went through the SyncPoint callback "WritableFileWriter::Append:BeforePrepareWrite", probably unintentionally. The solution of this PR is to call `ClearAllCallBacks()` to wait for any such pending callbacks to drain before calling `SetFilesystemActive(true /* active */)` Pull Request resolved: https://github.com/facebook/rocksdb/pull/10642 Reviewed By: cbi42 Differential Revision: D39265381 Pulled By: ajkr fbshipit-source-id: 9a2f4916ab19726c8fb4b3a3b590b1b9ed93de1b
1 parent 76de3c8
| File | Mode | Size |
|---|---|---|
| delete_scheduler.cc | -rw-r--r-- | 13.4 KB |
| delete_scheduler.h | -rw-r--r-- | 5.1 KB |
| delete_scheduler_test.cc | -rw-r--r-- | 27.0 KB |
| file_prefetch_buffer.cc | -rw-r--r-- | 24.2 KB |
| file_prefetch_buffer.h | -rw-r--r-- | 15.1 KB |
| file_util.cc | -rw-r--r-- | 9.6 KB |
| file_util.h | -rw-r--r-- | 3.8 KB |
| filename.cc | -rw-r--r-- | 16.2 KB |
| filename.h | -rw-r--r-- | 7.7 KB |
| line_file_reader.cc | -rw-r--r-- | 2.3 KB |
| line_file_reader.h | -rw-r--r-- | 2.4 KB |
| prefetch_test.cc | -rw-r--r-- | 57.8 KB |
| random_access_file_reader.cc | -rw-r--r-- | 21.5 KB |
| random_access_file_reader.h | -rw-r--r-- | 8.0 KB |
| random_access_file_reader_test.cc | -rw-r--r-- | 13.2 KB |
| read_write_util.cc | -rw-r--r-- | 1.2 KB |
| read_write_util.h | -rw-r--r-- | 1.1 KB |
| readahead_file_info.h | -rw-r--r-- | 1.0 KB |
| readahead_raf.cc | -rw-r--r-- | 6.3 KB |
| readahead_raf.h | -rw-r--r-- | 1.3 KB |
| sequence_file_reader.cc | -rw-r--r-- | 11.8 KB |
| sequence_file_reader.h | -rw-r--r-- | 4.8 KB |
| sst_file_manager_impl.cc | -rw-r--r-- | 18.0 KB |
| sst_file_manager_impl.h | -rw-r--r-- | 7.6 KB |
| writable_file_writer.cc | -rw-r--r-- | 34.8 KB |
| writable_file_writer.h | -rw-r--r-- | 12.2 KB |
Computing file changes ...
