Revision 1ffadbe9fcee94b8537bcf8cb7a1e2075d112bf7 authored by Andrew Kryczka on 06 September 2022, 19:59:02 UTC, committed by Facebook GitHub Bot on 06 September 2022, 19:59:02 UTC
Summary: Example flake: https://app.circleci.com/pipelines/github/facebook/rocksdb/17660/workflows/7a891875-f07b-4a67-b204-eaa7ca9f9aa2/jobs/467496 The test could get stuck in out-of-space due to a callback executing `SetFilesystemActive(false /* active */)` after the test executed `SetFilesystemActive(true /* active */)`. This could happen because background info logging went through the SyncPoint callback "WritableFileWriter::Append:BeforePrepareWrite", probably unintentionally. The solution of this PR is to call `ClearAllCallBacks()` to wait for any such pending callbacks to drain before calling `SetFilesystemActive(true /* active */)` Pull Request resolved: https://github.com/facebook/rocksdb/pull/10642 Reviewed By: cbi42 Differential Revision: D39265381 Pulled By: ajkr fbshipit-source-id: 9a2f4916ab19726c8fb4b3a3b590b1b9ed93de1b
1 parent 76de3c8
| File | Mode | Size |
|---|---|---|
| adaptive | ||
| block_based | ||
| cuckoo | ||
| plain | ||
| block_fetcher.cc | -rw-r--r-- | 14.7 KB |
| block_fetcher.h | -rw-r--r-- | 5.5 KB |
| block_fetcher_test.cc | -rw-r--r-- | 20.3 KB |
| cleanable_test.cc | -rw-r--r-- | 9.2 KB |
| format.cc | -rw-r--r-- | 20.3 KB |
| format.h | -rw-r--r-- | 13.6 KB |
| get_context.cc | -rw-r--r-- | 17.7 KB |
| get_context.h | -rw-r--r-- | 8.9 KB |
| internal_iterator.h | -rw-r--r-- | 8.8 KB |
| iter_heap.h | -rw-r--r-- | 1.3 KB |
| iterator.cc | -rw-r--r-- | 4.2 KB |
| iterator_wrapper.h | -rw-r--r-- | 4.6 KB |
| merger_test.cc | -rw-r--r-- | 4.6 KB |
| merging_iterator.cc | -rw-r--r-- | 51.2 KB |
| merging_iterator.h | -rw-r--r-- | 3.2 KB |
| meta_blocks.cc | -rw-r--r-- | 22.4 KB |
| meta_blocks.h | -rw-r--r-- | 6.9 KB |
| mock_table.cc | -rw-r--r-- | 10.4 KB |
| mock_table.h | -rw-r--r-- | 3.0 KB |
| multiget_context.h | -rw-r--r-- | 13.1 KB |
| persistent_cache_helper.cc | -rw-r--r-- | 3.4 KB |
| persistent_cache_helper.h | -rw-r--r-- | 1.5 KB |
| persistent_cache_options.h | -rw-r--r-- | 1.1 KB |
| scoped_arena_iterator.h | -rw-r--r-- | 1.6 KB |
| sst_file_dumper.cc | -rw-r--r-- | 18.9 KB |
| sst_file_dumper.h | -rw-r--r-- | 3.7 KB |
| sst_file_reader.cc | -rw-r--r-- | 3.4 KB |
| sst_file_reader_test.cc | -rw-r--r-- | 14.0 KB |
| sst_file_writer.cc | -rw-r--r-- | 14.3 KB |
| sst_file_writer_collectors.h | -rw-r--r-- | 3.2 KB |
| table_builder.h | -rw-r--r-- | 8.9 KB |
| table_factory.cc | -rw-r--r-- | 2.4 KB |
| table_properties.cc | -rw-r--r-- | 14.1 KB |
| table_properties_internal.h | -rw-r--r-- | 462 bytes |
| table_reader.h | -rw-r--r-- | 7.8 KB |
| table_reader_bench.cc | -rw-r--r-- | 12.8 KB |
| table_reader_caller.h | -rw-r--r-- | 1.5 KB |
| table_test.cc | -rw-r--r-- | 210.3 KB |
| two_level_iterator.cc | -rw-r--r-- | 6.6 KB |
| two_level_iterator.h | -rw-r--r-- | 1.7 KB |
| unique_id.cc | -rw-r--r-- | 7.3 KB |
| unique_id_impl.h | -rw-r--r-- | 3.8 KB |
Computing file changes ...
